From 8eccf15964e09c2e024710512e671c6b1b88e885 Mon Sep 17 00:00:00 2001 From: Akshay Date: Wed, 27 Oct 2021 19:50:52 +0530 Subject: add 3 new lints, bump to v0.2.3 - empty_pattern - redundant_pattern_bind - unquoted_splice --- lib/src/lints/empty_pattern.rs | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 lib/src/lints/empty_pattern.rs (limited to 'lib/src/lints/empty_pattern.rs') diff --git a/lib/src/lints/empty_pattern.rs b/lib/src/lints/empty_pattern.rs new file mode 100644 index 0000000..6fb7558 --- /dev/null +++ b/lib/src/lints/empty_pattern.rs @@ -0,0 +1,37 @@ +use crate::{make, Lint, Metadata, Report, Rule, Suggestion}; + +use if_chain::if_chain; +use macros::lint; +use rnix::{ + types::{Pattern, TypedNode}, + NodeOrToken, SyntaxElement, SyntaxKind, +}; + +#[lint( + name = "empty pattern", + note = "Found empty pattern in function argument", + code = 10, + match_with = SyntaxKind::NODE_PATTERN +)] +struct EmptyPattern; + +impl Rule for EmptyPattern { + fn validate(&self, node: &SyntaxElement) -> Option { + if_chain! { + if let NodeOrToken::Node(node) = node; + if let Some(pattern) = Pattern::cast(node.clone()); + // no patterns within `{ }` + if pattern.entries().count() == 0; + // pattern is not bound + if pattern.at().is_none(); + then { + let at = node.text_range(); + let message = "This pattern is empty, use `_` instead"; + let replacement = make::ident("_").node().clone(); + Some(Self::report().suggest(at, message, Suggestion::new(at, replacement))) + } else { + None + } + } + } +} -- cgit v1.2.3