1 files changed, 12 insertions, 9 deletions

diff --git a/crates/hir_ty/src/builder.rs b/crates/hir_ty/src/builder.rs
index 9b2c6975a..e25ef866d 100644
--- a/crates/hir_ty/src/builder.rs
+++ b/crates/hir_ty/src/builder.rs
@@ -4,6 +4,7 @@ use std::iter;
 
 use chalk_ir::{
     cast::{Cast, CastTo, Caster},
+    fold::Fold,
     interner::HasInterner,
     AdtId, BoundVar, DebruijnIndex, Safety, Scalar,
 };
@@ -12,8 +13,8 @@ use smallvec::SmallVec;
 
 use crate::{
     db::HirDatabase, primitive, to_assoc_type_id, to_chalk_trait_id, utils::generics, Binders,
-    CallableSig, FnPointer, FnSig, GenericArg, Interner, ProjectionTy, Substitution, TraitRef, Ty,
-    TyDefId, TyKind, TypeWalk, ValueTyDefId,
+    CallableSig, FnPointer, FnSig, FnSubst, GenericArg, Interner, ProjectionTy, Substitution,
+    TraitRef, Ty, TyDefId, TyExt, TyKind, ValueTyDefId,
 };
 
 /// This is a builder for `Ty` or anything that needs a `Substitution`.
@@ -32,8 +33,7 @@ impl<D> TyBuilder<D> {
 
     fn build_internal(self) -> (D, Substitution) {
         assert_eq!(self.vec.len(), self.param_count);
-        // FIXME: would be good to have a way to construct a chalk_ir::Substitution from the interned form
-        let subst = Substitution::intern(self.vec);
+        let subst = Substitution::from_iter(&Interner, self.vec);
         (self.data, subst)
     }
 
@@ -78,9 +78,12 @@ impl TyBuilder<()> {
 
     pub fn fn_ptr(sig: CallableSig) -> Ty {
         TyKind::Function(FnPointer {
-            num_args: sig.params().len(),
+            num_binders: 0,
             sig: FnSig { abi: (), safety: Safety::Safe, variadic: sig.is_varargs },
-            substs: Substitution::from_iter(&Interner, sig.params_and_return.iter().cloned()),
+            substitution: FnSubst(Substitution::from_iter(
+                &Interner,
+                sig.params_and_return.iter().cloned(),
+            )),
         })
         .intern(&Interner)
     }
@@ -138,7 +141,7 @@ impl TyBuilder<hir_def::AdtId> {
                 self.vec.push(fallback().cast(&Interner));
             } else {
                 // each default can depend on the previous parameters
-                let subst_so_far = Substitution::intern(self.vec.clone());
+                let subst_so_far = Substitution::from_iter(&Interner, self.vec.clone());
                 self.vec
                     .push(default_ty.clone().substitute(&Interner, &subst_so_far).cast(&Interner));
             }
@@ -193,13 +196,13 @@ impl TyBuilder<TypeAliasId> {
     }
 }
 
-impl<T: TypeWalk + HasInterner<Interner = Interner>> TyBuilder<Binders<T>> {
+impl<T: HasInterner<Interner = Interner> + Fold<Interner>> TyBuilder<Binders<T>> {
     fn subst_binders(b: Binders<T>) -> Self {
         let param_count = b.binders.len(&Interner);
         TyBuilder::new(b, param_count)
     }
 
-    pub fn build(self) -> T {
+    pub fn build(self) -> <T as Fold<Interner>>::Result {
         let (b, subst) = self.build_internal();
         b.substitute(&Interner, &subst)
     }