diff options
Diffstat (limited to 'crates/hir_ty/src/infer/pat.rs')
-rw-r--r-- | crates/hir_ty/src/infer/pat.rs | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/crates/hir_ty/src/infer/pat.rs b/crates/hir_ty/src/infer/pat.rs index b15f4977d..9c8e3b6ae 100644 --- a/crates/hir_ty/src/infer/pat.rs +++ b/crates/hir_ty/src/infer/pat.rs | |||
@@ -94,14 +94,15 @@ impl<'a> InferenceContext<'a> { | |||
94 | pub(super) fn infer_pat( | 94 | pub(super) fn infer_pat( |
95 | &mut self, | 95 | &mut self, |
96 | pat: PatId, | 96 | pat: PatId, |
97 | mut expected: &Ty, | 97 | expected: &Ty, |
98 | mut default_bm: BindingMode, | 98 | mut default_bm: BindingMode, |
99 | ) -> Ty { | 99 | ) -> Ty { |
100 | let body = Arc::clone(&self.body); // avoid borrow checker problem | 100 | let body = Arc::clone(&self.body); // avoid borrow checker problem |
101 | let mut expected = self.resolve_ty_shallow(expected); | ||
101 | 102 | ||
102 | if is_non_ref_pat(&body, pat) { | 103 | if is_non_ref_pat(&body, pat) { |
103 | while let Some((inner, _lifetime, mutability)) = expected.as_reference() { | 104 | while let Some((inner, _lifetime, mutability)) = expected.as_reference() { |
104 | expected = inner; | 105 | expected = self.resolve_ty_shallow(inner); |
105 | default_bm = match default_bm { | 106 | default_bm = match default_bm { |
106 | BindingMode::Move => BindingMode::Ref(mutability), | 107 | BindingMode::Move => BindingMode::Ref(mutability), |
107 | BindingMode::Ref(Mutability::Not) => BindingMode::Ref(Mutability::Not), | 108 | BindingMode::Ref(Mutability::Not) => BindingMode::Ref(Mutability::Not), |
@@ -147,9 +148,9 @@ impl<'a> InferenceContext<'a> { | |||
147 | } | 148 | } |
148 | Pat::Or(ref pats) => { | 149 | Pat::Or(ref pats) => { |
149 | if let Some((first_pat, rest)) = pats.split_first() { | 150 | if let Some((first_pat, rest)) = pats.split_first() { |
150 | let ty = self.infer_pat(*first_pat, expected, default_bm); | 151 | let ty = self.infer_pat(*first_pat, &expected, default_bm); |
151 | for pat in rest { | 152 | for pat in rest { |
152 | self.infer_pat(*pat, expected, default_bm); | 153 | self.infer_pat(*pat, &expected, default_bm); |
153 | } | 154 | } |
154 | ty | 155 | ty |
155 | } else { | 156 | } else { |
@@ -173,13 +174,13 @@ impl<'a> InferenceContext<'a> { | |||
173 | Pat::TupleStruct { path: p, args: subpats, ellipsis } => self.infer_tuple_struct_pat( | 174 | Pat::TupleStruct { path: p, args: subpats, ellipsis } => self.infer_tuple_struct_pat( |
174 | p.as_deref(), | 175 | p.as_deref(), |
175 | subpats, | 176 | subpats, |
176 | expected, | 177 | &expected, |
177 | default_bm, | 178 | default_bm, |
178 | pat, | 179 | pat, |
179 | *ellipsis, | 180 | *ellipsis, |
180 | ), | 181 | ), |
181 | Pat::Record { path: p, args: fields, ellipsis: _ } => { | 182 | Pat::Record { path: p, args: fields, ellipsis: _ } => { |
182 | self.infer_record_pat(p.as_deref(), fields, expected, default_bm, pat) | 183 | self.infer_record_pat(p.as_deref(), fields, &expected, default_bm, pat) |
183 | } | 184 | } |
184 | Pat::Path(path) => { | 185 | Pat::Path(path) => { |
185 | // FIXME use correct resolver for the surrounding expression | 186 | // FIXME use correct resolver for the surrounding expression |
@@ -193,7 +194,7 @@ impl<'a> InferenceContext<'a> { | |||
193 | BindingMode::convert(*mode) | 194 | BindingMode::convert(*mode) |
194 | }; | 195 | }; |
195 | let inner_ty = if let Some(subpat) = subpat { | 196 | let inner_ty = if let Some(subpat) = subpat { |
196 | self.infer_pat(*subpat, expected, default_bm) | 197 | self.infer_pat(*subpat, &expected, default_bm) |
197 | } else { | 198 | } else { |
198 | expected.clone() | 199 | expected.clone() |
199 | }; | 200 | }; |
@@ -206,7 +207,6 @@ impl<'a> InferenceContext<'a> { | |||
206 | } | 207 | } |
207 | BindingMode::Move => inner_ty.clone(), | 208 | BindingMode::Move => inner_ty.clone(), |
208 | }; | 209 | }; |
209 | let bound_ty = self.resolve_ty_as_possible(bound_ty); | ||
210 | self.write_pat_ty(pat, bound_ty); | 210 | self.write_pat_ty(pat, bound_ty); |
211 | return inner_ty; | 211 | return inner_ty; |
212 | } | 212 | } |
@@ -265,13 +265,12 @@ impl<'a> InferenceContext<'a> { | |||
265 | }; | 265 | }; |
266 | // use a new type variable if we got error type here | 266 | // use a new type variable if we got error type here |
267 | let ty = self.insert_type_vars_shallow(ty); | 267 | let ty = self.insert_type_vars_shallow(ty); |
268 | if !self.unify(&ty, expected) { | 268 | if !self.unify(&ty, &expected) { |
269 | self.result.type_mismatches.insert( | 269 | self.result.type_mismatches.insert( |
270 | pat.into(), | 270 | pat.into(), |
271 | TypeMismatch { expected: expected.clone(), actual: ty.clone() }, | 271 | TypeMismatch { expected: expected.clone(), actual: ty.clone() }, |
272 | ); | 272 | ); |
273 | } | 273 | } |
274 | let ty = self.resolve_ty_as_possible(ty); | ||
275 | self.write_pat_ty(pat, ty.clone()); | 274 | self.write_pat_ty(pat, ty.clone()); |
276 | ty | 275 | ty |
277 | } | 276 | } |