1 files changed, 25 insertions, 20 deletions

diff --git a/crates/ide_completion/src/render.rs b/crates/ide_completion/src/render.rs
index eddaaa6f3..0a6ac8804 100644
--- a/crates/ide_completion/src/render.rs
+++ b/crates/ide_completion/src/render.rs
@@ -13,9 +13,11 @@ mod builder_ext;
 use hir::{
     AsAssocItem, Documentation, HasAttrs, HirDisplay, ModuleDef, Mutability, ScopeDef, Type,
 };
-use ide_db::{helpers::SnippetCap, RootDatabase, SymbolKind};
+use ide_db::{
+    helpers::{item_name, SnippetCap},
+    RootDatabase, SymbolKind,
+};
 use syntax::TextRange;
-use test_utils::mark;
 
 use crate::{
     item::ImportEdit, CompletionContext, CompletionItem, CompletionItemKind, CompletionKind,
@@ -51,18 +53,20 @@ pub(crate) fn render_resolution<'a>(
 pub(crate) fn render_resolution_with_import<'a>(
     ctx: RenderContext<'a>,
     import_edit: ImportEdit,
-    resolution: &ScopeDef,
 ) -> Option<CompletionItem> {
+    let resolution = ScopeDef::from(import_edit.import.original_item);
     let local_name = match resolution {
         ScopeDef::ModuleDef(ModuleDef::Function(f)) => f.name(ctx.completion.db).to_string(),
         ScopeDef::ModuleDef(ModuleDef::Const(c)) => c.name(ctx.completion.db)?.to_string(),
         ScopeDef::ModuleDef(ModuleDef::TypeAlias(t)) => t.name(ctx.completion.db).to_string(),
-        _ => import_edit.import_path.segments().last()?.to_string(),
+        _ => item_name(ctx.db(), import_edit.import.original_item)?.to_string(),
     };
-    Render::new(ctx).render_resolution(local_name, Some(import_edit), resolution).map(|mut item| {
-        item.completion_kind = CompletionKind::Magic;
-        item
-    })
+    Render::new(ctx).render_resolution(local_name, Some(import_edit), &resolution).map(
+        |mut item| {
+            item.completion_kind = CompletionKind::Magic;
+            item
+        },
+    )
 }
 
 /// Interface for data and methods required for items rendering.
@@ -115,11 +119,11 @@ impl<'a> RenderContext<'a> {
 
     fn active_name_and_type(&self) -> Option<(String, Type)> {
         if let Some(record_field) = &self.completion.record_field_syntax {
-            mark::hit!(record_field_type_match);
+            cov_mark::hit!(record_field_type_match);
             let (struct_field, _local) = self.completion.sema.resolve_record_field(record_field)?;
             Some((struct_field.name(self.db()).to_string(), struct_field.signature_ty(self.db())))
         } else if let Some(active_parameter) = &self.completion.active_parameter {
-            mark::hit!(active_param_type_match);
+            cov_mark::hit!(active_param_type_match);
             Some((active_parameter.name.clone(), active_parameter.ty.clone()))
         } else {
             None
@@ -242,7 +246,6 @@ impl<'a> Render<'a> {
             }
         };
 
-        let mut ref_match = None;
         if let ScopeDef::Local(local) = resolution {
             if let Some((active_name, active_type)) = self.ctx.active_name_and_type() {
                 let ty = local.ty(self.ctx.db());
@@ -251,7 +254,11 @@ impl<'a> Render<'a> {
                 {
                     item = item.set_score(score);
                 }
-                ref_match = refed_type_matches(&active_type, &active_name, &ty, &local_name);
+                if let Some(ref_match) =
+                    refed_type_matches(&active_type, &active_name, &ty, &local_name)
+                {
+                    item = item.ref_match(ref_match);
+                }
             }
         }
 
@@ -269,7 +276,7 @@ impl<'a> Render<'a> {
                     _ => false,
                 };
                 if has_non_default_type_params {
-                    mark::hit!(inserts_angle_brackets_for_generics);
+                    cov_mark::hit!(inserts_angle_brackets_for_generics);
                     item = item
                         .lookup_by(local_name.clone())
                         .label(format!("{}<…>", local_name))
@@ -281,7 +288,6 @@ impl<'a> Render<'a> {
         Some(
             item.kind(kind)
                 .add_import(import_to_add)
-                .set_ref_match(ref_match)
                 .set_documentation(self.docs(resolution))
                 .set_deprecated(self.is_deprecated(resolution))
                 .build(),
@@ -358,7 +364,6 @@ mod tests {
     use std::cmp::Reverse;
 
     use expect_test::{expect, Expect};
-    use test_utils::mark;
 
     use crate::{
         test_utils::{check_edit, do_completion, get_all_items, TEST_CONFIG},
@@ -734,7 +739,7 @@ fn foo(s: S) { s.$0 }
 
     #[test]
     fn no_call_parens_if_fn_ptr_needed() {
-        mark::check!(no_call_parens_if_fn_ptr_needed);
+        cov_mark::check!(no_call_parens_if_fn_ptr_needed);
         check_edit(
             "foo",
             r#"
@@ -758,7 +763,7 @@ fn main() -> ManualVtable {
 
     #[test]
     fn no_parens_in_use_item() {
-        mark::check!(no_parens_in_use_item);
+        cov_mark::check!(no_parens_in_use_item);
         check_edit(
             "foo",
             r#"
@@ -802,7 +807,7 @@ fn f(foo: &Foo) { foo.foo(); }
 
     #[test]
     fn inserts_angle_brackets_for_generics() {
-        mark::check!(inserts_angle_brackets_for_generics);
+        cov_mark::check!(inserts_angle_brackets_for_generics);
         check_edit(
             "Vec",
             r#"
@@ -851,7 +856,7 @@ fn foo(xs: Vec<i128>)
 
     #[test]
     fn active_param_score() {
-        mark::check!(active_param_type_match);
+        cov_mark::check!(active_param_type_match);
         check_scores(
             r#"
 struct S { foo: i64, bar: u32, baz: u32 }
@@ -868,7 +873,7 @@ fn foo(s: S) { test(s.$0) }
 
     #[test]
     fn record_field_scores() {
-        mark::check!(record_field_type_match);
+        cov_mark::check!(record_field_type_match);
         check_scores(
             r#"
 struct A { foo: i64, bar: u32, baz: u32 }