11 files changed, 111 insertions, 91 deletions

diff --git a/crates/ra_hir/src/adt.rs b/crates/ra_hir/src/adt.rs
index 78ea8976b..e027eedd9 100644
--- a/crates/ra_hir/src/adt.rs
+++ b/crates/ra_hir/src/adt.rs
@@ -6,7 +6,7 @@ use std::sync::Arc;
 use ra_arena::{RawId, Arena, impl_arena_id};
 use ra_syntax::{
     TreeArc,
-    ast::{self, NameOwner, StructFlavor, TypeAscriptionOwner}
+    ast::{self, NameOwner, StructKind, TypeAscriptionOwner}
 };
 
 use crate::{
@@ -47,7 +47,7 @@ pub struct StructData {
 impl StructData {
     fn new(struct_def: &ast::StructDef) -> StructData {
         let name = struct_def.name().map(|n| n.as_name());
-        let variant_data = VariantData::new(struct_def.flavor());
+        let variant_data = VariantData::new(struct_def.kind());
         let variant_data = Arc::new(variant_data);
         StructData { name, variant_data }
     }
@@ -94,7 +94,7 @@ impl EnumData {
         let variants = variants(&*enum_def)
             .map(|var| EnumVariantData {
                 name: var.name().map(|it| it.as_name()),
-                variant_data: Arc::new(VariantData::new(var.flavor())),
+                variant_data: Arc::new(VariantData::new(var.kind())),
             })
             .collect();
         Arc::new(EnumData { name, variants })
@@ -143,9 +143,9 @@ impl VariantData {
 }
 
 impl VariantData {
-    fn new(flavor: StructFlavor) -> Self {
+    fn new(flavor: StructKind) -> Self {
         let inner = match flavor {
-            ast::StructFlavor::Tuple(fl) => {
+            ast::StructKind::Tuple(fl) => {
                 let fields = fl
                     .fields()
                     .enumerate()
@@ -156,7 +156,7 @@ impl VariantData {
                     .collect();
                 VariantDataInner::Tuple(fields)
             }
-            ast::StructFlavor::Named(fl) => {
+            ast::StructKind::Named(fl) => {
                 let fields = fl
                     .fields()
                     .map(|fd| StructFieldData {
@@ -166,7 +166,7 @@ impl VariantData {
                     .collect();
                 VariantDataInner::Struct(fields)
             }
-            ast::StructFlavor::Unit => VariantDataInner::Unit,
+            ast::StructKind::Unit => VariantDataInner::Unit,
         };
         VariantData(inner)
     }
@@ -200,27 +200,27 @@ impl StructField {
         let fields = var_data.fields().unwrap();
         let ss;
         let es;
-        let (file_id, struct_flavor) = match self.parent {
+        let (file_id, struct_kind) = match self.parent {
             VariantDef::Struct(s) => {
                 let (file_id, source) = s.source(db);
                 ss = source;
-                (file_id, ss.flavor())
+                (file_id, ss.kind())
             }
             VariantDef::EnumVariant(e) => {
                 let (file_id, source) = e.source(db);
                 es = source;
-                (file_id, es.flavor())
+                (file_id, es.kind())
             }
         };
 
-        let field_sources = match struct_flavor {
-            ast::StructFlavor::Tuple(fl) => {
+        let field_sources = match struct_kind {
+            ast::StructKind::Tuple(fl) => {
                 fl.fields().map(|it| FieldSource::Pos(it.to_owned())).collect()
             }
-            ast::StructFlavor::Named(fl) => {
+            ast::StructKind::Named(fl) => {
                 fl.fields().map(|it| FieldSource::Named(it.to_owned())).collect()
             }
-            ast::StructFlavor::Unit => Vec::new(),
+            ast::StructKind::Unit => Vec::new(),
         };
         let field = field_sources
             .into_iter()
diff --git a/crates/ra_hir/src/code_model_api.rs b/crates/ra_hir/src/code_model_api.rs
index c3e5e26c3..9e6170440 100644
--- a/crates/ra_hir/src/code_model_api.rs
+++ b/crates/ra_hir/src/code_model_api.rs
@@ -4,7 +4,7 @@ use ra_db::{CrateId, SourceRootId, Edition};
 use ra_syntax::{ast::self, TreeArc};
 
 use crate::{
-    Name, ScopesWithSourceMap, Ty, HirFileId,
+    Name, ScopesWithSourceMap, Ty, HirFileId, ImportSource,
     HirDatabase, DefDatabase,
     type_ref::TypeRef,
     nameres::{ModuleScope, Namespace, ImportId, CrateModuleId},
@@ -117,11 +117,7 @@ impl Module {
     }
 
     /// Returns the syntax of the last path segment corresponding to this import
-    pub fn import_source(
-        &self,
-        db: &impl HirDatabase,
-        import: ImportId,
-    ) -> TreeArc<ast::PathSegment> {
+    pub fn import_source(&self, db: &impl HirDatabase, import: ImportId) -> ImportSource {
         self.import_source_impl(db, import)
     }
 
diff --git a/crates/ra_hir/src/code_model_impl/function.rs b/crates/ra_hir/src/code_model_impl/function.rs
index 334cb302b..f8bd0f784 100644
--- a/crates/ra_hir/src/code_model_impl/function.rs
+++ b/crates/ra_hir/src/code_model_impl/function.rs
@@ -20,12 +20,12 @@ impl FnSignature {
                     TypeRef::from_ast(type_ref)
                 } else {
                     let self_type = TypeRef::Path(Name::self_type().into());
-                    match self_param.flavor() {
-                        ast::SelfParamFlavor::Owned => self_type,
-                        ast::SelfParamFlavor::Ref => {
+                    match self_param.kind() {
+                        ast::SelfParamKind::Owned => self_type,
+                        ast::SelfParamKind::Ref => {
                             TypeRef::Reference(Box::new(self_type), Mutability::Shared)
                         }
-                        ast::SelfParamFlavor::MutRef => {
+                        ast::SelfParamKind::MutRef => {
                             TypeRef::Reference(Box::new(self_type), Mutability::Mut)
                         }
                     }
diff --git a/crates/ra_hir/src/code_model_impl/module.rs b/crates/ra_hir/src/code_model_impl/module.rs
index 0edb8ade5..88dee3a69 100644
--- a/crates/ra_hir/src/code_model_impl/module.rs
+++ b/crates/ra_hir/src/code_model_impl/module.rs
@@ -5,7 +5,7 @@ use crate::{
     Module, ModuleSource, Name, AstId,
     nameres::{CrateModuleId, ImportId},
     HirDatabase, DefDatabase,
-    HirFileId,
+    HirFileId, ImportSource,
 };
 
 impl ModuleSource {
@@ -72,7 +72,7 @@ impl Module {
         &self,
         db: &impl HirDatabase,
         import: ImportId,
-    ) -> TreeArc<ast::PathSegment> {
+    ) -> ImportSource {
         let (file_id, source) = self.definition_source(db);
         let (_, source_map) = db.raw_items_with_source_map(file_id);
         source_map.get(&source, import)
diff --git a/crates/ra_hir/src/expr.rs b/crates/ra_hir/src/expr.rs
index 51366de0a..b2a237ece 100644
--- a/crates/ra_hir/src/expr.rs
+++ b/crates/ra_hir/src/expr.rs
@@ -6,7 +6,7 @@ use rustc_hash::FxHashMap;
 use ra_arena::{Arena, RawId, impl_arena_id, map::ArenaMap};
 use ra_syntax::{
     SyntaxNodePtr, AstPtr, AstNode,
-    ast::{self, LoopBodyOwner, ArgListOwner, NameOwner, LiteralFlavor, TypeAscriptionOwner}
+    ast::{self, LoopBodyOwner, ArgListOwner, NameOwner, LiteralKind, TypeAscriptionOwner}
 };
 
 use crate::{
@@ -515,8 +515,8 @@ impl ExprCollector {
                     let else_branch = e
                         .else_branch()
                         .map(|b| match b {
-                            ast::ElseBranchFlavor::Block(it) => self.collect_block(it),
-                            ast::ElseBranchFlavor::IfExpr(elif) => {
+                            ast::ElseBranch::Block(it) => self.collect_block(it),
+                            ast::ElseBranch::IfExpr(elif) => {
                                 let expr: &ast::Expr = ast::Expr::cast(elif.syntax()).unwrap();
                                 self.collect_expr(expr)
                             }
@@ -532,8 +532,8 @@ impl ExprCollector {
                     let condition = self.collect_expr_opt(e.condition().and_then(|c| c.expr()));
                     let then_branch = self.collect_block_opt(e.then_branch());
                     let else_branch = e.else_branch().map(|b| match b {
-                        ast::ElseBranchFlavor::Block(it) => self.collect_block(it),
-                        ast::ElseBranchFlavor::IfExpr(elif) => {
+                        ast::ElseBranch::Block(it) => self.collect_block(it),
+                        ast::ElseBranch::IfExpr(elif) => {
                             let expr: &ast::Expr = ast::Expr::cast(elif.syntax()).unwrap();
                             self.collect_expr(expr)
                         }
@@ -725,14 +725,8 @@ impl ExprCollector {
                 self.alloc_expr(Expr::Array { exprs }, syntax_ptr)
             }
             ast::ExprKind::Literal(e) => {
-                let child = if let Some(child) = e.literal_expr() {
-                    child
-                } else {
-                    return self.alloc_expr(Expr::Missing, syntax_ptr);
-                };
-
-                let lit = match child.flavor() {
-                    LiteralFlavor::IntNumber { suffix } => {
+                let lit = match e.kind() {
+                    LiteralKind::IntNumber { suffix } => {
                         let known_name = suffix
                             .and_then(|it| IntTy::from_suffix(&it).map(UncertainIntTy::Known));
 
@@ -741,7 +735,7 @@ impl ExprCollector {
                             known_name.unwrap_or(UncertainIntTy::Unknown),
                         )
                     }
-                    LiteralFlavor::FloatNumber { suffix } => {
+                    LiteralKind::FloatNumber { suffix } => {
                         let known_name = suffix
                             .and_then(|it| FloatTy::from_suffix(&it).map(UncertainFloatTy::Known));
 
@@ -750,13 +744,13 @@ impl ExprCollector {
                             known_name.unwrap_or(UncertainFloatTy::Unknown),
                         )
                     }
-                    LiteralFlavor::ByteString => Literal::ByteString(Default::default()),
-                    LiteralFlavor::String => Literal::String(Default::default()),
-                    LiteralFlavor::Byte => {
+                    LiteralKind::ByteString => Literal::ByteString(Default::default()),
+                    LiteralKind::String => Literal::String(Default::default()),
+                    LiteralKind::Byte => {
                         Literal::Int(Default::default(), UncertainIntTy::Known(IntTy::u8()))
                     }
-                    LiteralFlavor::Bool => Literal::Bool(Default::default()),
-                    LiteralFlavor::Char => Literal::Char(Default::default()),
+                    LiteralKind::Bool => Literal::Bool(Default::default()),
+                    LiteralKind::Char => Literal::Char(Default::default()),
                 };
                 self.alloc_expr(Expr::Literal(lit), syntax_ptr)
             }
@@ -765,6 +759,7 @@ impl ExprCollector {
             ast::ExprKind::Label(_e) => self.alloc_expr(Expr::Missing, syntax_ptr),
             ast::ExprKind::IndexExpr(_e) => self.alloc_expr(Expr::Missing, syntax_ptr),
             ast::ExprKind::RangeExpr(_e) => self.alloc_expr(Expr::Missing, syntax_ptr),
+            ast::ExprKind::MacroCall(_e) => self.alloc_expr(Expr::Missing, syntax_ptr),
         }
     }
 
@@ -883,9 +878,7 @@ impl ExprCollector {
     fn collect_fn_body(&mut self, node: &ast::FnDef) {
         if let Some(param_list) = node.param_list() {
             if let Some(self_param) = param_list.self_param() {
-                let self_param = SyntaxNodePtr::new(
-                    self_param.self_kw().expect("self param without self keyword").syntax(),
-                );
+                let self_param = SyntaxNodePtr::new(self_param.syntax());
                 let param_pat = self.alloc_pat(
                     Pat::Bind {
                         name: Name::self_param(),
diff --git a/crates/ra_hir/src/lib.rs b/crates/ra_hir/src/lib.rs
index 5b6abcf6d..c19450f39 100644
--- a/crates/ra_hir/src/lib.rs
+++ b/crates/ra_hir/src/lib.rs
@@ -56,7 +56,7 @@ pub use self::{
     name::Name,
     source_id::{AstIdMap, ErasedFileAstId},
     ids::{HirFileId, MacroDefId, MacroCallId, MacroCallLoc, HirInterner},
-    nameres::{PerNs, Namespace},
+    nameres::{PerNs, Namespace, ImportId, ImportSource},
     ty::{Ty, ApplicationTy, TypeCtor, Substs, display::HirDisplay},
     impl_block::{ImplBlock, ImplItem},
     docs::{Docs, Documentation},
diff --git a/crates/ra_hir/src/nameres.rs b/crates/ra_hir/src/nameres.rs
index 67b9d6986..6f049acfc 100644
--- a/crates/ra_hir/src/nameres.rs
+++ b/crates/ra_hir/src/nameres.rs
@@ -70,9 +70,12 @@ use crate::{
     AstId,
 };
 
-pub(crate) use self::raw::{RawItems, ImportId, ImportSourceMap};
+pub(crate) use self::raw::{RawItems, ImportSourceMap};
 
-pub use self::per_ns::{PerNs, Namespace};
+pub use self::{
+    per_ns::{PerNs, Namespace},
+    raw::{ImportId, ImportSource},
+};
 
 /// Contans all top-level defs from a macro-expanded crate
 #[derive(Debug, PartialEq, Eq)]
diff --git a/crates/ra_hir/src/nameres/raw.rs b/crates/ra_hir/src/nameres/raw.rs
index 0936229ac..b7416ede6 100644
--- a/crates/ra_hir/src/nameres/raw.rs
+++ b/crates/ra_hir/src/nameres/raw.rs
@@ -31,21 +31,43 @@ pub struct RawItems {
 
 #[derive(Debug, Default, PartialEq, Eq)]
 pub struct ImportSourceMap {
-    map: ArenaMap<ImportId, AstPtr<ast::PathSegment>>,
+    map: ArenaMap<ImportId, ImportSourcePtr>,
+}
+
+#[derive(Debug, PartialEq, Eq, Clone, Copy)]
+enum ImportSourcePtr {
+    UseTree(AstPtr<ast::UseTree>),
+    ExternCrate(AstPtr<ast::ExternCrateItem>),
+}
+
+impl ImportSourcePtr {
+    fn to_node(self, file: &SourceFile) -> ImportSource {
+        match self {
+            ImportSourcePtr::UseTree(ptr) => ImportSource::UseTree(ptr.to_node(file).to_owned()),
+            ImportSourcePtr::ExternCrate(ptr) => {
+                ImportSource::ExternCrate(ptr.to_node(file).to_owned())
+            }
+        }
+    }
+}
+
+pub enum ImportSource {
+    UseTree(TreeArc<ast::UseTree>),
+    ExternCrate(TreeArc<ast::ExternCrateItem>),
 }
 
 impl ImportSourceMap {
-    fn insert(&mut self, import: ImportId, segment: &ast::PathSegment) {
-        self.map.insert(import, AstPtr::new(segment))
+    fn insert(&mut self, import: ImportId, ptr: ImportSourcePtr) {
+        self.map.insert(import, ptr)
     }
 
-    pub(crate) fn get(&self, source: &ModuleSource, import: ImportId) -> TreeArc<ast::PathSegment> {
+    pub(crate) fn get(&self, source: &ModuleSource, import: ImportId) -> ImportSource {
         let file = match source {
             ModuleSource::SourceFile(file) => &*file,
             ModuleSource::Module(m) => m.syntax().ancestors().find_map(SourceFile::cast).unwrap(),
         };
 
-        self.map[import].to_node(file).to_owned()
+        self.map[import].to_node(file)
     }
 }
 
@@ -256,18 +278,14 @@ impl RawItemsCollector {
     fn add_use_item(&mut self, current_module: Option<Module>, use_item: &ast::UseItem) {
         let is_prelude = use_item.has_atom_attr("prelude_import");
 
-        Path::expand_use_item(use_item, |path, segment, alias| {
-            let import = self.raw_items.imports.alloc(ImportData {
-                path,
-                alias,
-                is_glob: segment.is_none(),
-                is_prelude,
-                is_extern_crate: false,
-            });
-            if let Some(segment) = segment {
-                self.source_map.insert(import, segment)
-            }
-            self.push_item(current_module, RawItem::Import(import))
+        Path::expand_use_item(use_item, |path, use_tree, is_glob, alias| {
+            let import_data =
+                ImportData { path, alias, is_glob, is_prelude, is_extern_crate: false };
+            self.push_import(
+                current_module,
+                import_data,
+                ImportSourcePtr::UseTree(AstPtr::new(use_tree)),
+            );
         })
     }
 
@@ -279,14 +297,18 @@ impl RawItemsCollector {
         if let Some(name_ref) = extern_crate.name_ref() {
             let path = Path::from_name_ref(name_ref);
             let alias = extern_crate.alias().and_then(|a| a.name()).map(AsName::as_name);
-            let import = self.raw_items.imports.alloc(ImportData {
+            let import_data = ImportData {
                 path,
                 alias,
                 is_glob: false,
                 is_prelude: false,
                 is_extern_crate: true,
-            });
-            self.push_item(current_module, RawItem::Import(import))
+            };
+            self.push_import(
+                current_module,
+                import_data,
+                ImportSourcePtr::ExternCrate(AstPtr::new(extern_crate)),
+            );
         }
     }
 
@@ -303,6 +325,17 @@ impl RawItemsCollector {
         self.push_item(current_module, RawItem::Macro(m));
     }
 
+    fn push_import(
+        &mut self,
+        current_module: Option<Module>,
+        data: ImportData,
+        source: ImportSourcePtr,
+    ) {
+        let import = self.raw_items.imports.alloc(data);
+        self.source_map.insert(import, source);
+        self.push_item(current_module, RawItem::Import(import))
+    }
+
     fn push_item(&mut self, current_module: Option<Module>, item: RawItem) {
         match current_module {
             Some(module) => match &mut self.raw_items.modules[module] {
diff --git a/crates/ra_hir/src/path.rs b/crates/ra_hir/src/path.rs
index 6cc8104f4..5449cddfd 100644
--- a/crates/ra_hir/src/path.rs
+++ b/crates/ra_hir/src/path.rs
@@ -46,7 +46,7 @@ impl Path {
     /// Calls `cb` with all paths, represented by this use item.
     pub fn expand_use_item<'a>(
         item: &'a ast::UseItem,
-        mut cb: impl FnMut(Path, Option<&'a ast::PathSegment>, Option<Name>),
+        mut cb: impl FnMut(Path, &'a ast::UseTree, bool, Option<Name>),
     ) {
         if let Some(tree) = item.use_tree() {
             expand_use_tree(None, tree, &mut cb);
@@ -156,7 +156,7 @@ impl From<Name> for Path {
 fn expand_use_tree<'a>(
     prefix: Option<Path>,
     tree: &'a ast::UseTree,
-    cb: &mut impl FnMut(Path, Option<&'a ast::PathSegment>, Option<Name>),
+    cb: &mut impl FnMut(Path, &'a ast::UseTree, bool, Option<Name>),
 ) {
     if let Some(use_tree_list) = tree.use_tree_list() {
         let prefix = match tree.path() {
@@ -181,18 +181,15 @@ fn expand_use_tree<'a>(
                 if let Some(segment) = ast_path.segment() {
                     if segment.kind() == Some(ast::PathSegmentKind::SelfKw) {
                         if let Some(prefix) = prefix {
-                            cb(prefix, Some(segment), alias);
+                            cb(prefix, tree, false, alias);
                             return;
                         }
                     }
                 }
             }
             if let Some(path) = convert_path(prefix, ast_path) {
-                if tree.has_star() {
-                    cb(path, None, alias)
-                } else if let Some(segment) = ast_path.segment() {
-                    cb(path, Some(segment), alias)
-                };
+                let is_glob = tree.has_star();
+                cb(path, tree, is_glob, alias)
             }
             // FIXME: report errors somewhere
             // We get here if we do
diff --git a/crates/ra_hir/src/source_binder.rs b/crates/ra_hir/src/source_binder.rs
index 430dbc522..182ed4c91 100644
--- a/crates/ra_hir/src/source_binder.rs
+++ b/crates/ra_hir/src/source_binder.rs
@@ -9,7 +9,7 @@ use ra_db::{FileId, FilePosition};
 use ra_syntax::{
     SyntaxNode,
     ast::{self, AstNode, NameOwner},
-    algo::{find_node_at_offset, find_leaf_at_offset},
+    algo::{find_node_at_offset, find_token_at_offset},
 };
 
 use crate::{
@@ -197,9 +197,9 @@ pub fn trait_from_module(
 pub fn resolver_for_position(db: &impl HirDatabase, position: FilePosition) -> Resolver {
     let file_id = position.file_id;
     let file = db.parse(file_id);
-    find_leaf_at_offset(file.syntax(), position.offset)
-        .find_map(|node| {
-            node.ancestors().find_map(|node| {
+    find_token_at_offset(file.syntax(), position.offset)
+        .find_map(|token| {
+            token.parent().ancestors().find_map(|node| {
                 if ast::Expr::cast(node).is_some() || ast::Block::cast(node).is_some() {
                     if let Some(func) = function_from_child_node(db, file_id, node) {
                         let scopes = func.scopes(db);
diff --git a/crates/ra_hir/src/ty/tests.rs b/crates/ra_hir/src/ty/tests.rs
index 1e84e2d06..0b7c841df 100644
--- a/crates/ra_hir/src/ty/tests.rs
+++ b/crates/ra_hir/src/ty/tests.rs
@@ -2282,14 +2282,12 @@ fn infer(content: &str) -> String {
         types.sort_by_key(|(ptr, _)| (ptr.range().start(), ptr.range().end()));
         for (syntax_ptr, ty) in &types {
             let node = syntax_ptr.to_node(&source_file);
-            write!(
-                acc,
-                "{} '{}': {}\n",
-                syntax_ptr.range(),
-                ellipsize(node.text().to_string().replace("\n", " "), 15),
-                ty.display(&db)
-            )
-            .unwrap();
+            let (range, text) = if let Some(self_param) = ast::SelfParam::cast(node) {
+                (self_param.self_kw_token().range(), "self".to_string())
+            } else {
+                (syntax_ptr.range(), node.text().to_string().replace("\n", " "))
+            };
+            write!(acc, "{} '{}': {}\n", range, ellipsize(text, 15), ty.display(&db)).unwrap();
         }
     };