1 files changed, 214 insertions, 15 deletions

diff --git a/crates/ra_ide/src/completion/complete_unqualified_path.rs b/crates/ra_ide/src/completion/complete_unqualified_path.rs
index ad5fdcc4e..638f86eda 100644
--- a/crates/ra_ide/src/completion/complete_unqualified_path.rs
+++ b/crates/ra_ide/src/completion/complete_unqualified_path.rs
@@ -4,20 +4,23 @@ use hir::ScopeDef;
 use test_utils::tested_by;
 
 use crate::completion::{CompletionContext, Completions};
+use hir::{Adt, ModuleDef};
 use ra_syntax::AstNode;
 
 pub(super) fn complete_unqualified_path(acc: &mut Completions, ctx: &CompletionContext) {
-    if !ctx.is_trivial_path {
-        return;
-    }
-
-    if ctx.is_pat_binding_or_const
+    if (!ctx.is_trivial_path && !ctx.is_pat_binding_or_const)
         || ctx.record_lit_syntax.is_some()
         || ctx.record_pat_syntax.is_some()
     {
         return;
     }
 
+    complete_enum_variants(acc, ctx);
+
+    if ctx.is_pat_binding_or_const {
+        return;
+    }
+
     ctx.scope().process_all_names(&mut |name, res| {
         if ctx.use_item_syntax.is_some() {
             if let (ScopeDef::Unknown, Some(name_ref)) = (&res, &ctx.name_ref_syntax) {
@@ -31,6 +34,24 @@ pub(super) fn complete_unqualified_path(acc: &mut Completions, ctx: &CompletionC
     });
 }
 
+fn complete_enum_variants(acc: &mut Completions, ctx: &CompletionContext) {
+    if let Some(ty) = ctx.expected_type_of(&ctx.token.parent()) {
+        if let Some(Adt::Enum(enum_data)) = ty.as_adt() {
+            let variants = enum_data.variants(ctx.db);
+            let module = enum_data.module(ctx.db);
+            for variant in variants {
+                if let Some(path) = module.find_use_path(ctx.db, ModuleDef::from(variant)) {
+                    // Variants with trivial paths are already added by the existing completion logic,
+                    // so we should avoid adding these twice
+                    if path.segments.len() > 1 {
+                        acc.add_enum_variant(ctx, variant, Some(path.to_string()));
+                    }
+                }
+            }
+        }
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use insta::assert_debug_snapshot;
@@ -82,7 +103,7 @@ mod tests {
                 }
                 "
             ),
-            @r###"[]"###
+            @"[]"
         );
     }
 
@@ -712,7 +733,7 @@ mod tests {
             @r###"
         [
             CompletionItem {
-                label: "bar!",
+                label: "bar!(…)",
                 source_range: [252; 252),
                 delete: [252; 252),
                 insert: "bar!($0)",
@@ -720,7 +741,7 @@ mod tests {
                 detail: "macro_rules! bar",
             },
             CompletionItem {
-                label: "baz!",
+                label: "baz!(…)",
                 source_range: [252; 252),
                 delete: [252; 252),
                 insert: "baz!($0)",
@@ -728,7 +749,7 @@ mod tests {
                 detail: "#[macro_export]\nmacro_rules! baz",
             },
             CompletionItem {
-                label: "foo!",
+                label: "foo!(…)",
                 source_range: [252; 252),
                 delete: [252; 252),
                 insert: "foo!($0)",
@@ -781,7 +802,7 @@ mod tests {
             @r###"
         [
             CompletionItem {
-                label: "foo!",
+                label: "foo!(…)",
                 source_range: [49; 49),
                 delete: [49; 49),
                 insert: "foo!($0)",
@@ -820,7 +841,7 @@ mod tests {
             @r###"
         [
             CompletionItem {
-                label: "foo!",
+                label: "foo!(…)",
                 source_range: [57; 57),
                 delete: [57; 57),
                 insert: "foo!($0)",
@@ -859,7 +880,7 @@ mod tests {
             @r###"
         [
             CompletionItem {
-                label: "foo!",
+                label: "foo!(…)",
                 source_range: [50; 50),
                 delete: [50; 50),
                 insert: "foo!($0)",
@@ -932,7 +953,7 @@ mod tests {
             @r###"
         [
             CompletionItem {
-                label: "m!",
+                label: "m!(…)",
                 source_range: [145; 145),
                 delete: [145; 145),
                 insert: "m!($0)",
@@ -985,7 +1006,7 @@ mod tests {
             @r###"
         [
             CompletionItem {
-                label: "m!",
+                label: "m!(…)",
                 source_range: [145; 146),
                 delete: [145; 146),
                 insert: "m!($0)",
@@ -1038,7 +1059,7 @@ mod tests {
                     @r###"
         [
             CompletionItem {
-                label: "m!",
+                label: "m!(…)",
                 source_range: [145; 146),
                 delete: [145; 146),
                 insert: "m!($0)",
@@ -1109,4 +1130,182 @@ mod tests {
         "###
         );
     }
+    #[test]
+    fn completes_enum_variant_matcharm() {
+        assert_debug_snapshot!(
+            do_reference_completion(
+                r"
+                enum Foo {
+                    Bar,
+                    Baz,
+                    Quux
+                }
+
+                fn main() {
+                    let foo = Foo::Quux;
+
+                    match foo {
+                        Qu<|>
+                    }
+                }
+                "
+            ),
+            @r###"
+        [
+            CompletionItem {
+                label: "Foo",
+                source_range: [248; 250),
+                delete: [248; 250),
+                insert: "Foo",
+                kind: Enum,
+            },
+            CompletionItem {
+                label: "Foo::Bar",
+                source_range: [248; 250),
+                delete: [248; 250),
+                insert: "Foo::Bar",
+                kind: EnumVariant,
+                detail: "()",
+            },
+            CompletionItem {
+                label: "Foo::Baz",
+                source_range: [248; 250),
+                delete: [248; 250),
+                insert: "Foo::Baz",
+                kind: EnumVariant,
+                detail: "()",
+            },
+            CompletionItem {
+                label: "Foo::Quux",
+                source_range: [248; 250),
+                delete: [248; 250),
+                insert: "Foo::Quux",
+                kind: EnumVariant,
+                detail: "()",
+            },
+        ]
+        "###
+        )
+    }
+
+    #[test]
+    fn completes_enum_variant_iflet() {
+        assert_debug_snapshot!(
+            do_reference_completion(
+                r"
+                enum Foo {
+                    Bar,
+                    Baz,
+                    Quux
+                }
+
+                fn main() {
+                    let foo = Foo::Quux;
+
+                    if let Qu<|> = foo {
+
+                    }
+                }
+                "
+            ),
+            @r###"
+        [
+            CompletionItem {
+                label: "Foo",
+                source_range: [219; 221),
+                delete: [219; 221),
+                insert: "Foo",
+                kind: Enum,
+            },
+            CompletionItem {
+                label: "Foo::Bar",
+                source_range: [219; 221),
+                delete: [219; 221),
+                insert: "Foo::Bar",
+                kind: EnumVariant,
+                detail: "()",
+            },
+            CompletionItem {
+                label: "Foo::Baz",
+                source_range: [219; 221),
+                delete: [219; 221),
+                insert: "Foo::Baz",
+                kind: EnumVariant,
+                detail: "()",
+            },
+            CompletionItem {
+                label: "Foo::Quux",
+                source_range: [219; 221),
+                delete: [219; 221),
+                insert: "Foo::Quux",
+                kind: EnumVariant,
+                detail: "()",
+            },
+        ]
+        "###
+        )
+    }
+
+    #[test]
+    fn completes_enum_variant_basic_expr() {
+        assert_debug_snapshot!(
+            do_reference_completion(
+                r"
+                enum Foo {
+                    Bar,
+                    Baz,
+                    Quux
+                }
+
+                fn main() {
+                    let foo: Foo = Q<|>
+                }
+                "
+            ),
+            @r###"
+        [
+            CompletionItem {
+                label: "Foo",
+                source_range: [185; 186),
+                delete: [185; 186),
+                insert: "Foo",
+                kind: Enum,
+            },
+            CompletionItem {
+                label: "Foo::Bar",
+                source_range: [185; 186),
+                delete: [185; 186),
+                insert: "Foo::Bar",
+                kind: EnumVariant,
+                detail: "()",
+            },
+            CompletionItem {
+                label: "Foo::Baz",
+                source_range: [185; 186),
+                delete: [185; 186),
+                insert: "Foo::Baz",
+                kind: EnumVariant,
+                detail: "()",
+            },
+            CompletionItem {
+                label: "Foo::Quux",
+                source_range: [185; 186),
+                delete: [185; 186),
+                insert: "Foo::Quux",
+                kind: EnumVariant,
+                detail: "()",
+            },
+            CompletionItem {
+                label: "main()",
+                source_range: [185; 186),
+                delete: [185; 186),
+                insert: "main()$0",
+                kind: Function,
+                lookup: "main",
+                detail: "fn main()",
+            },
+        ]
+        "###
+        )
+    }
 }