2 files changed, 19 insertions, 10 deletions

diff --git a/crates/ra_toolchain/Cargo.toml b/crates/ra_toolchain/Cargo.toml
index 1873fbe16..84b748c0a 100644
--- a/crates/ra_toolchain/Cargo.toml
+++ b/crates/ra_toolchain/Cargo.toml
@@ -3,6 +3,10 @@ edition = "2018"
 name = "ra_toolchain"
 version = "0.1.0"
 authors = ["rust-analyzer developers"]
+license = "MIT OR Apache-2.0"
+
+[lib]
+doctest = false
 
 [dependencies]
 home = "0.5.3"
diff --git a/crates/ra_toolchain/src/lib.rs b/crates/ra_toolchain/src/lib.rs
index 3d2865e09..9916e52c4 100644
--- a/crates/ra_toolchain/src/lib.rs
+++ b/crates/ra_toolchain/src/lib.rs
@@ -15,6 +15,10 @@ pub fn rustup() -> PathBuf {
     get_path_for_executable("rustup")
 }
 
+pub fn rustfmt() -> PathBuf {
+    get_path_for_executable("rustfmt")
+}
+
 /// Return a `PathBuf` to use for the given executable.
 ///
 /// E.g., `get_path_for_executable("cargo")` may return just `cargo` if that
@@ -42,22 +46,23 @@ fn get_path_for_executable(executable_name: &'static str) -> PathBuf {
         path.push(".cargo");
         path.push("bin");
         path.push(executable_name);
-        if path.is_file() {
+        if let Some(path) = probe(path) {
             return path;
         }
     }
+
     executable_name.into()
 }
 
 fn lookup_in_path(exec: &str) -> bool {
     let paths = env::var_os("PATH").unwrap_or_default();
-    let mut candidates = env::split_paths(&paths).flat_map(|path| {
-        let candidate = path.join(&exec);
-        let with_exe = match env::consts::EXE_EXTENSION {
-            "" => None,
-            it => Some(candidate.with_extension(it)),
-        };
-        iter::once(candidate).chain(with_exe)
-    });
-    candidates.any(|it| it.is_file())
+    env::split_paths(&paths).map(|path| path.join(exec)).find_map(probe).is_some()
+}
+
+fn probe(path: PathBuf) -> Option<PathBuf> {
+    let with_extension = match env::consts::EXE_EXTENSION {
+        "" => None,
+        it => Some(path.with_extension(it)),
+    };
+    iter::once(path).chain(with_extension).find(|it| it.is_file())
 }