3 files changed, 43 insertions, 14 deletions

diff --git a/crates/ra_lsp_server/src/main_loop/handlers.rs b/crates/ra_lsp_server/src/main_loop/handlers.rs
index c25adb8b9..4720a8843 100644
--- a/crates/ra_lsp_server/src/main_loop/handlers.rs
+++ b/crates/ra_lsp_server/src/main_loop/handlers.rs
@@ -599,9 +599,6 @@ pub fn handle_code_action(
         let title = source_edit.label.clone();
         let edit = source_edit.try_conv_with(&world)?;
 
-        // We cannot use the 'editor.action.showReferences' command directly
-        // because that command requires vscode types which we convert in the handler
-        // on the client side.
         let cmd = Command {
             title,
             command: "rust-analyzer.applySourceChange".to_string(),
@@ -713,17 +710,21 @@ pub fn handle_code_lens_resolve(world: ServerWorld, code_lens: CodeLens) -> Resu
                 format!("{} implementations", locations.len())
             };
 
+            // We cannot use the 'editor.action.showReferences' command directly
+            // because that command requires vscode types which we convert in the handler
+            // on the client side.
+            let cmd = Command {
+                title,
+                command: "rust-analyzer.showReferences".into(),
+                arguments: Some(vec![
+                    to_value(&Ser::new(&lens_params.text_document.uri)).unwrap(),
+                    to_value(code_lens.range.start).unwrap(),
+                    to_value(locations).unwrap(),
+                ]),
+            };
             return Ok(CodeLens {
                 range: code_lens.range,
-                command: Some(Command {
-                    title,
-                    command: "rust-analyzer.showReferences".into(),
-                    arguments: Some(vec![
-                        to_value(&Ser::new(&lens_params.text_document.uri)).unwrap(),
-                        to_value(code_lens.range.start).unwrap(),
-                        to_value(locations).unwrap(),
-                    ]),
-                }),
+                command: Some(cmd),
                 data: None,
             });
         }
diff --git a/crates/ra_mbe/src/lib.rs b/crates/ra_mbe/src/lib.rs
index 6f719acbf..2c8ad4429 100644
--- a/crates/ra_mbe/src/lib.rs
+++ b/crates/ra_mbe/src/lib.rs
@@ -256,4 +256,28 @@ impl_froms!(TokenTree: Leaf, Subtree);
         assert_expansion(&rules, "foo! { eggs Baz }", "struct Baz ;");
     }
 
+    #[test]
+    fn test_match_group_pattern_by_separator_token() {
+        let rules = create_rules(
+            r#"
+        macro_rules! foo {
+            ($ ($ i:ident),*) => ($ (
+                mod $ i {}
+            )*);
+            ($ ($ i:ident)#*) => ($ (
+                fn $ i() {}
+            )*);
+            ($ i:ident ,# $ j:ident) => (
+                struct $ i;
+                struct $ j;
+            )
+        }
+"#,
+        );
+
+        assert_expansion(&rules, "foo! { foo, bar }", "mod foo {} mod bar {}");
+        assert_expansion(&rules, "foo! { foo# bar }", "fn foo () {} fn bar () {}");
+        assert_expansion(&rules, "foo! { Foo,# Bar }", "struct Foo ; struct Bar ;");
+    }
+
 }
diff --git a/crates/ra_mbe/src/mbe_expander.rs b/crates/ra_mbe/src/mbe_expander.rs
index 212e2ea92..04b5a4035 100644
--- a/crates/ra_mbe/src/mbe_expander.rs
+++ b/crates/ra_mbe/src/mbe_expander.rs
@@ -140,8 +140,12 @@ fn match_lhs(pattern: &crate::Subtree, input: &mut TtCursor) -> Option<Bindings>
             }) => {
                 while let Some(nested) = match_lhs(subtree, input) {
                     res.push_nested(nested)?;
-                    if separator.is_some() && !input.is_eof() {
-                        input.eat_punct()?;
+                    if let Some(separator) = *separator {
+                        if !input.is_eof() {
+                            if input.eat_punct()?.char != separator {
+                                return None;
+                            }
+                        }
                     }
                 }
             }