7 files changed, 94 insertions, 6 deletions

diff --git a/crates/ra_ide_api/src/completion/complete_dot.rs b/crates/ra_ide_api/src/completion/complete_dot.rs
index 65bba6dc7..80d0b1663 100644
--- a/crates/ra_ide_api/src/completion/complete_dot.rs
+++ b/crates/ra_ide_api/src/completion/complete_dot.rs
@@ -16,7 +16,7 @@ pub(super) fn complete_dot(acc: &mut Completions, ctx: &CompletionContext) -> Ca
         None => return Ok(()),
     };
     let receiver_ty = infer_result[expr].clone();
-    if !ctx.is_method_call {
+    if !ctx.is_call {
         complete_fields(acc, ctx, receiver_ty)?;
     }
     Ok(())
diff --git a/crates/ra_ide_api/src/completion/complete_path.rs b/crates/ra_ide_api/src/completion/complete_path.rs
index 4723a65a6..2494d28ed 100644
--- a/crates/ra_ide_api/src/completion/complete_path.rs
+++ b/crates/ra_ide_api/src/completion/complete_path.rs
@@ -125,4 +125,18 @@ mod tests {
             "foo",
         )
     }
+
+    #[test]
+    fn dont_render_function_parens_if_already_call() {
+        check_reference_completion(
+            "
+            //- /lib.rs
+            fn frobnicate() {}
+            fn main() {
+                frob<|>();
+            }
+            ",
+            "main;frobnicate",
+        )
+    }
 }
diff --git a/crates/ra_ide_api/src/completion/completion_context.rs b/crates/ra_ide_api/src/completion/completion_context.rs
index 01786bb69..113f6c070 100644
--- a/crates/ra_ide_api/src/completion/completion_context.rs
+++ b/crates/ra_ide_api/src/completion/completion_context.rs
@@ -32,8 +32,8 @@ pub(super) struct CompletionContext<'a> {
     pub(super) is_new_item: bool,
     /// The receiver if this is a field or method access, i.e. writing something.<|>
     pub(super) dot_receiver: Option<&'a ast::Expr>,
-    /// If this is a method call in particular, i.e. the () are already there.
-    pub(super) is_method_call: bool,
+    /// If this is a call (method or function) in particular, i.e. the () are already there.
+    pub(super) is_call: bool,
 }
 
 impl<'a> CompletionContext<'a> {
@@ -60,7 +60,7 @@ impl<'a> CompletionContext<'a> {
             can_be_stmt: false,
             is_new_item: false,
             dot_receiver: None,
-            is_method_call: false,
+            is_call: false,
         };
         ctx.fill(original_file, position.offset);
         Ok(Some(ctx))
@@ -172,6 +172,12 @@ impl<'a> CompletionContext<'a> {
                     }
                 }
             }
+            self.is_call = path
+                .syntax()
+                .parent()
+                .and_then(ast::PathExpr::cast)
+                .and_then(|it| it.syntax().parent().and_then(ast::CallExpr::cast))
+                .is_some()
         }
         if let Some(field_expr) = ast::FieldExpr::cast(parent) {
             // The receiver comes before the point of insertion of the fake
@@ -187,7 +193,7 @@ impl<'a> CompletionContext<'a> {
                 .expr()
                 .map(|e| e.syntax().range())
                 .and_then(|r| find_node_with_range(original_file.syntax(), r));
-            self.is_method_call = true;
+            self.is_call = true;
         }
     }
 }
diff --git a/crates/ra_ide_api/src/completion/completion_item.rs b/crates/ra_ide_api/src/completion/completion_item.rs
index 334449fae..6a9770429 100644
--- a/crates/ra_ide_api/src/completion/completion_item.rs
+++ b/crates/ra_ide_api/src/completion/completion_item.rs
@@ -165,7 +165,7 @@ impl Builder {
 
     fn from_function(mut self, ctx: &CompletionContext, function: hir::Function) -> Builder {
         // If not an import, add parenthesis automatically.
-        if ctx.use_item_syntax.is_none() {
+        if ctx.use_item_syntax.is_none() && !ctx.is_call {
             if function.signature(ctx.db).args().is_empty() {
                 self.snippet = Some(format!("{}()$0", self.label));
             } else {
diff --git a/crates/ra_syntax/src/grammar/items/nominal.rs b/crates/ra_syntax/src/grammar/items/nominal.rs
index 8d02ad555..495462ca7 100644
--- a/crates/ra_syntax/src/grammar/items/nominal.rs
+++ b/crates/ra_syntax/src/grammar/items/nominal.rs
@@ -29,6 +29,10 @@ pub(super) fn struct_def(p: &mut Parser, kind: SyntaxKind) {
         L_CURLY => named_field_def_list(p),
         L_PAREN if kind == STRUCT_KW => {
             pos_field_list(p);
+            // test tuple_struct_where
+            // struct Test<T>(T) where T: Clone;
+            // struct Test<T>(T);
+            type_params::opt_where_clause(p);
             p.expect(SEMI);
         }
         _ if kind == STRUCT_KW => {
diff --git a/crates/ra_syntax/tests/data/parser/inline/ok/0114_tuple_struct_where.rs b/crates/ra_syntax/tests/data/parser/inline/ok/0114_tuple_struct_where.rs
new file mode 100644
index 000000000..ddd59016d
--- /dev/null
+++ b/crates/ra_syntax/tests/data/parser/inline/ok/0114_tuple_struct_where.rs
@@ -0,0 +1,2 @@
+struct Test<T>(T) where T: Clone;
+struct Test<T>(T);
diff --git a/crates/ra_syntax/tests/data/parser/inline/ok/0114_tuple_struct_where.txt b/crates/ra_syntax/tests/data/parser/inline/ok/0114_tuple_struct_where.txt
new file mode 100644
index 000000000..b7de83072
--- /dev/null
+++ b/crates/ra_syntax/tests/data/parser/inline/ok/0114_tuple_struct_where.txt
@@ -0,0 +1,62 @@
+SOURCE_FILE@[0; 53)
+  STRUCT_DEF@[0; 33)
+    STRUCT_KW@[0; 6)
+    WHITESPACE@[6; 7)
+    NAME@[7; 11)
+      IDENT@[7; 11) "Test"
+    TYPE_PARAM_LIST@[11; 14)
+      L_ANGLE@[11; 12)
+      TYPE_PARAM@[12; 13)
+        NAME@[12; 13)
+          IDENT@[12; 13) "T"
+      R_ANGLE@[13; 14)
+    POS_FIELD_LIST@[14; 17)
+      L_PAREN@[14; 15)
+      POS_FIELD@[15; 16)
+        PATH_TYPE@[15; 16)
+          PATH@[15; 16)
+            PATH_SEGMENT@[15; 16)
+              NAME_REF@[15; 16)
+                IDENT@[15; 16) "T"
+      R_PAREN@[16; 17)
+    WHITESPACE@[17; 18)
+    WHERE_CLAUSE@[18; 32)
+      WHERE_KW@[18; 23)
+      WHITESPACE@[23; 24)
+      WHERE_PRED@[24; 32)
+        PATH_TYPE@[24; 25)
+          PATH@[24; 25)
+            PATH_SEGMENT@[24; 25)
+              NAME_REF@[24; 25)
+                IDENT@[24; 25) "T"
+        COLON@[25; 26)
+        WHITESPACE@[26; 27)
+        PATH_TYPE@[27; 32)
+          PATH@[27; 32)
+            PATH_SEGMENT@[27; 32)
+              NAME_REF@[27; 32)
+                IDENT@[27; 32) "Clone"
+    SEMI@[32; 33)
+  WHITESPACE@[33; 34)
+  STRUCT_DEF@[34; 52)
+    STRUCT_KW@[34; 40)
+    WHITESPACE@[40; 41)
+    NAME@[41; 45)
+      IDENT@[41; 45) "Test"
+    TYPE_PARAM_LIST@[45; 48)
+      L_ANGLE@[45; 46)
+      TYPE_PARAM@[46; 47)
+        NAME@[46; 47)
+          IDENT@[46; 47) "T"
+      R_ANGLE@[47; 48)
+    POS_FIELD_LIST@[48; 51)
+      L_PAREN@[48; 49)
+      POS_FIELD@[49; 50)
+        PATH_TYPE@[49; 50)
+          PATH@[49; 50)
+            PATH_SEGMENT@[49; 50)
+              NAME_REF@[49; 50)
+                IDENT@[49; 50) "T"
+      R_PAREN@[50; 51)
+    SEMI@[51; 52)
+  WHITESPACE@[52; 53)