diff options
Diffstat (limited to 'docs/dev')
-rw-r--r-- | docs/dev/README.md | 6 | ||||
-rw-r--r-- | docs/dev/style.md | 7 |
2 files changed, 9 insertions, 4 deletions
diff --git a/docs/dev/README.md b/docs/dev/README.md index 24197b332..6bce38e56 100644 --- a/docs/dev/README.md +++ b/docs/dev/README.md | |||
@@ -43,6 +43,10 @@ https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0 | |||
43 | while unactionable ones are effectively wont-fix. Each triaged issue should have one of these labels. | 43 | while unactionable ones are effectively wont-fix. Each triaged issue should have one of these labels. |
44 | * [fun](https://github.com/rust-analyzer/rust-analyzer/issues?q=is%3Aopen+is%3Aissue+label%3Afun) | 44 | * [fun](https://github.com/rust-analyzer/rust-analyzer/issues?q=is%3Aopen+is%3Aissue+label%3Afun) |
45 | is for cool, but probably hard stuff. | 45 | is for cool, but probably hard stuff. |
46 | * [Design](https://github.com/rust-analyzer/rust-analyzer/issues?q=is%3Aopen+is%3Aissue+label%Design) | ||
47 | is for moderate/large scale architecture discussion. | ||
48 | Also a kind of fun. | ||
49 | These issues should generally include a link to a Zulip discussion thread. | ||
46 | 50 | ||
47 | # CI | 51 | # CI |
48 | 52 | ||
@@ -212,7 +216,7 @@ To log all communication between the server and the client, there are two choice | |||
212 | 216 | ||
213 | * you can log on the server side, by running something like | 217 | * you can log on the server side, by running something like |
214 | ``` | 218 | ``` |
215 | env RA_LOG=gen_lsp_server=trace code . | 219 | env RA_LOG=lsp_server=debug code . |
216 | ``` | 220 | ``` |
217 | 221 | ||
218 | * you can log on the client side, by enabling `"rust-analyzer.trace.server": | 222 | * you can log on the client side, by enabling `"rust-analyzer.trace.server": |
diff --git a/docs/dev/style.md b/docs/dev/style.md index 428cee3ad..6dc6868c2 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md | |||
@@ -294,8 +294,9 @@ Prefer `Default` even it has to be implemented manually. | |||
294 | 294 | ||
295 | **Rationale:** less typing in the common case, uniformity. | 295 | **Rationale:** less typing in the common case, uniformity. |
296 | 296 | ||
297 | Use `Vec::new` rather than `vec![]`. **Rationale:** uniformity, strength | 297 | Use `Vec::new` rather than `vec![]`. |
298 | reduction. | 298 | |
299 | **Rationale:** uniformity, strength reduction. | ||
299 | 300 | ||
300 | ## Functions Over Objects | 301 | ## Functions Over Objects |
301 | 302 | ||
@@ -479,7 +480,7 @@ pub fn reachable_nodes(node: Node) -> FxHashSet<Node> { | |||
479 | } | 480 | } |
480 | ``` | 481 | ``` |
481 | 482 | ||
482 | **Rational:** re-use allocations, accumulator style is more concise for complex cases. | 483 | **Rationale:** re-use allocations, accumulator style is more concise for complex cases. |
483 | 484 | ||
484 | # Style | 485 | # Style |
485 | 486 | ||