diff options
Diffstat (limited to 'docs/dev')
-rw-r--r-- | docs/dev/README.md | 6 | ||||
-rw-r--r-- | docs/dev/lsp-extensions.md | 7 | ||||
-rw-r--r-- | docs/dev/style.md | 2 |
3 files changed, 8 insertions, 7 deletions
diff --git a/docs/dev/README.md b/docs/dev/README.md index f74f7d8eb..d0e6d29d8 100644 --- a/docs/dev/README.md +++ b/docs/dev/README.md | |||
@@ -235,14 +235,14 @@ We don't do "patch" releases, unless something truly egregious comes up. | |||
235 | 235 | ||
236 | There are three sets of people with extra permissions: | 236 | There are three sets of people with extra permissions: |
237 | 237 | ||
238 | * rust-analyzer GitHub organization (**admins**)[https://github.com/orgs/rust-analyzer/people?query=role:owner] (which include current t-compiler leads). | 238 | * rust-analyzer GitHub organization [**admins**](https://github.com/orgs/rust-analyzer/people?query=role:owner) (which include current t-compiler leads). |
239 | Admins have full access to the org. | 239 | Admins have full access to the org. |
240 | * (**review**)[https://github.com/orgs/rust-analyzer/teams/review] team in the organization. | 240 | * [**review**](https://github.com/orgs/rust-analyzer/teams/review) team in the organization. |
241 | Reviewers have `r+` access to all of organization's repositories and publish rights on crates.io. | 241 | Reviewers have `r+` access to all of organization's repositories and publish rights on crates.io. |
242 | They also have direct commit access, but all changes should via bors queue. | 242 | They also have direct commit access, but all changes should via bors queue. |
243 | It's ok to self-approve if you think you know what you are doing! | 243 | It's ok to self-approve if you think you know what you are doing! |
244 | bors should automatically sync the permissions. | 244 | bors should automatically sync the permissions. |
245 | * (**triage**)[https://github.com/orgs/rust-analyzer/teams/triage] team in the organization. | 245 | * [**triage**](https://github.com/orgs/rust-analyzer/teams/triage) team in the organization. |
246 | This team can label and close issues. | 246 | This team can label and close issues. |
247 | 247 | ||
248 | Note that at the time being you need to be a member of the org yourself to view the links. | 248 | Note that at the time being you need to be a member of the org yourself to view the links. |
diff --git a/docs/dev/lsp-extensions.md b/docs/dev/lsp-extensions.md index a46121bb2..a112477de 100644 --- a/docs/dev/lsp-extensions.md +++ b/docs/dev/lsp-extensions.md | |||
@@ -1,8 +1,8 @@ | |||
1 | <!--- | 1 | <!--- |
2 | lsp_ext.rs hash: faae991334a151d0 | 2 | lsp_ext.rs hash: 28a9d5a24b7ca396 |
3 | 3 | ||
4 | If you need to change the above hash to make the test pass, please check if you | 4 | If you need to change the above hash to make the test pass, please check if you |
5 | need to adjust this doc as well and ping this issue: | 5 | need to adjust this doc as well and ping this issue: |
6 | 6 | ||
7 | https://github.com/rust-analyzer/rust-analyzer/issues/4604 | 7 | https://github.com/rust-analyzer/rust-analyzer/issues/4604 |
8 | 8 | ||
@@ -46,6 +46,7 @@ If this capability is set, `WorkspaceEdit`s returned from `codeAction` requests | |||
46 | ```typescript | 46 | ```typescript |
47 | interface SnippetTextEdit extends TextEdit { | 47 | interface SnippetTextEdit extends TextEdit { |
48 | insertTextFormat?: InsertTextFormat; | 48 | insertTextFormat?: InsertTextFormat; |
49 | annotationId?: ChangeAnnotationIdentifier; | ||
49 | } | 50 | } |
50 | ``` | 51 | ``` |
51 | 52 | ||
@@ -620,7 +621,7 @@ This request is sent from client to server to move item under cursor or selectio | |||
620 | 621 | ||
621 | **Request:** `MoveItemParams` | 622 | **Request:** `MoveItemParams` |
622 | 623 | ||
623 | **Response:** `TextDocumentEdit | null` | 624 | **Response:** `SnippetTextEdit[]` |
624 | 625 | ||
625 | ```typescript | 626 | ```typescript |
626 | export interface MoveItemParams { | 627 | export interface MoveItemParams { |
diff --git a/docs/dev/style.md b/docs/dev/style.md index 7c47c26b2..078c478d4 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md | |||
@@ -159,7 +159,7 @@ More than one mark per test / code branch doesn't add significantly to understan | |||
159 | Do not use `#[should_panic]` tests. | 159 | Do not use `#[should_panic]` tests. |
160 | Instead, explicitly check for `None`, `Err`, etc. | 160 | Instead, explicitly check for `None`, `Err`, etc. |
161 | 161 | ||
162 | **Rationale:**a `#[should_panic]` is a tool for library authors, to makes sure that API does not fail silently, when misused. | 162 | **Rationale:** `#[should_panic]` is a tool for library authors, to makes sure that API does not fail silently, when misused. |
163 | `rust-analyzer` is not a library, we don't need to test for API misuse, and we have to handle any user input without panics. | 163 | `rust-analyzer` is not a library, we don't need to test for API misuse, and we have to handle any user input without panics. |
164 | Panic messages in the logs from the `#[should_panic]` tests are confusing. | 164 | Panic messages in the logs from the `#[should_panic]` tests are confusing. |
165 | 165 | ||