Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge #2673 | bors[bot] | 2019-12-29 | 4 | -25/+96 |
|\ | | | | | | | | | | | | | | | 2673: Don't add non-impl/trait containers to scope r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | Don't add non-impl/trait containers to scope | Aleksey Kladov | 2019-12-29 | 4 | -25/+96 |
|/ | |||||
* | Merge #2668 | bors[bot] | 2019-12-29 | 41 | -2209/+1933 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2668: In-server cargo check watching r=matklad a=kiljacken Opening a draft now so people can follow the progress, and comment if they spot something stupid. Things that need doing: - [x] Running cargo check on save - [x] Pipe through configuration options from client - [x] Tests for parsing behavior - [x] Remove existing cargo watch support from VSCode extension - [x] Progress notification in VSCode extension using LSP 3.15 `$/progress` notification - [ ] ~~Rework ra-ide diagnostics to support secondary messages~~ - [ ] ~~Make cargo-check watcher use ra-ide diagnostics~~ ~~I'd love some input on whether to try to keep the status bar progress thingy for VSCode? It will require some plumbing, and maintaining yet another rust-analyzer specific LSP notification, which I'm not sure we want to.~~ Fixes #1894 Co-authored-by: Emil Lauridsen <[email protected]> | ||||
| * | Fix busy-waiting issue in main cargo watch thread | Emil Lauridsen | 2019-12-27 | 1 | -3/+5 |
| | | |||||
| * | Don't finish main cargo watch thread when subprocess finishes. | Emil Lauridsen | 2019-12-27 | 2 | -3/+5 |
| | | |||||
| * | Fix shutdown behavoir of main cargo-watch thread. | Emil Lauridsen | 2019-12-27 | 1 | -7/+8 |
| | | | | | | | | | | Even though this didn't error, it became clear to me that it was closing the wrong channel, resulting in the child thread never finishing. | ||||
| * | Add doc comment to module | Emil Lauridsen | 2019-12-27 | 1 | -0/+2 |
| | | |||||
| * | Cargo fmt run | Emil Lauridsen | 2019-12-27 | 1 | -7/+1 |
| | | |||||
| * | Shutdown/cancelation story for main cargo watch thread | Emil Lauridsen | 2019-12-27 | 1 | -15/+32 |
| | | |||||
| * | Consistent, hopefully robust, shutdown/cancelation story for cargo check ↵ | Emil Lauridsen | 2019-12-27 | 1 | -16/+50 |
| | | | | | | | | subprocess | ||||
| * | Move cargo watch functionality to separate crate | Emil Lauridsen | 2019-12-27 | 16 | -1338/+1373 |
| | | |||||
| * | Keep VSCode config mostly backwards compatible | Emil Lauridsen | 2019-12-25 | 8 | -84/+71 |
| | | |||||
| * | Some documentatioN | Emil Lauridsen | 2019-12-25 | 1 | -0/+13 |
| | | |||||
| * | Actually respect disabling cargo check functionality | Emil Lauridsen | 2019-12-25 | 1 | -3/+19 |
| | | |||||
| * | Re-format ra_lsp_server changes | Emil Lauridsen | 2019-12-25 | 3 | -7/+7 |
| | | |||||
| * | Re-format VSCode extension changes | Emil Lauridsen | 2019-12-25 | 2 | -19/+20 |
| | | |||||
| * | Re-implement status display using LSP 3.15 progress event | Emil Lauridsen | 2019-12-25 | 4 | -9/+103 |
| | | |||||
| * | Remove cargo watch supporting code and tests from vscode extension | Emil Lauridsen | 2019-12-25 | 14 | -1684/+0 |
| | | |||||
| * | Migrate tests from extension to rust | Emil Lauridsen | 2019-12-25 | 9 | -0/+1069 |
| | | |||||
| * | Fix use of wrong message in diagnostic | Emil Lauridsen | 2019-12-25 | 1 | -1/+1 |
| | | |||||
| * | Configuration plumbing for cargo watcher | Emil Lauridsen | 2019-12-25 | 7 | -84/+83 |
| | | |||||
| * | Remove cargo-watch from vscode extension. | Emil Lauridsen | 2019-12-25 | 6 | -454/+1 |
| | | | | | | | | Still keeps tests around for reference when porting them to rust | ||||
| * | Initial implementation of cargo check watching | Emil Lauridsen | 2019-12-25 | 8 | -4/+599 |
| | | |||||
* | | Merge #2667 | bors[bot] | 2019-12-29 | 21 | -114/+609 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | 2667: Visibility r=matklad a=flodiebold This adds the infrastructure for handling visibility (for fields and methods, not in name resolution) in the HIR and code model, and as a first application hides struct fields from completions if they're not visible from the current module. (We might want to relax this again later, but I think it's ok for now?) Co-authored-by: Florian Diebold <[email protected]> | ||||
| * | | visible_from -> is_visible_from | Florian Diebold | 2019-12-27 | 4 | -10/+10 |
| | | | |||||
| * | | Remove Arc from RawVisibility | Florian Diebold | 2019-12-26 | 1 | -11/+6 |
| | | | | | | | | | | | | | | | Now that it's not used as a direct query return value anymore, it doesn't need to be cheaply cloneable anymore. | ||||
| * | | Fix cross-crate glob privacy handling | Florian Diebold | 2019-12-26 | 3 | -6/+28 |
| | | | |||||
| * | | Remove visibility query, instead add struct field visibility to data | Florian Diebold | 2019-12-26 | 5 | -102/+35 |
| | | | | | | | | | | | | | | | Methods should be handled the same, and for items the visibility will be in the def map. | ||||
| * | | Rename ResolvedVisibility -> Visibility | Florian Diebold | 2019-12-26 | 8 | -67/+54 |
| | | | |||||
| * | | Rename Visibility -> RawVisibility | Florian Diebold | 2019-12-26 | 6 | -40/+40 |
| | | | |||||
| * | | Handle privacy for modules | Florian Diebold | 2019-12-26 | 3 | -11/+36 |
| | | | |||||
| * | | Check for `todo!` macros in no_todo | Florian Diebold | 2019-12-26 | 1 | -1/+1 |
| | | | |||||
| * | | Take visibility into account for glob imports | Florian Diebold | 2019-12-26 | 7 | -43/+165 |
| | | | |||||
| * | | Keep track of visibility during def collection | Florian Diebold | 2019-12-26 | 6 | -54/+120 |
| | | | |||||
| * | | Collect visibility of items during nameres | Florian Diebold | 2019-12-26 | 6 | -19/+63 |
| | | | |||||
| * | | Add doc comment | Florian Diebold | 2019-12-26 | 1 | -0/+2 |
| | | | |||||
| * | | Make enum variant fields public | Florian Diebold | 2019-12-26 | 1 | -2/+9 |
| | | | |||||
| * | | Hide completions for private struct fields | Florian Diebold | 2019-12-26 | 1 | -1/+56 |
| | | | |||||
| * | | Add visibility in code model for fields | Florian Diebold | 2019-12-26 | 2 | -3/+20 |
| | | | |||||
| * | | Add logic for resolving and checking visibility | Florian Diebold | 2019-12-26 | 2 | -1/+60 |
| | | | |||||
| * | | Add infrastructure for visibility on syntax and hir_def level | Florian Diebold | 2019-12-26 | 5 | -2/+163 |
| | | | |||||
* | | | Merge #2671 | bors[bot] | 2019-12-27 | 1 | -7/+8 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2671: anyhow and crossbeam-queue r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]> | ||||
| * | | | anyhow and crossbeam-queue | Jeremy Kolb | 2019-12-27 | 1 | -7/+8 |
|/ / / | |||||
* | | | Merge #2657 | bors[bot] | 2019-12-27 | 3 | -18/+62 |
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | 2657: Omit closure parameters in closure type display strings r=flodiebold a=SomeoneToIgnore Part of https://github.com/rust-analyzer/rust-analyzer/issues/1946 I wonder, should we display the the closure trait (Fn/FnMut/FnOnce) in inlay hints instead of `|...|` at all? Co-authored-by: Kirill Bulatov <[email protected]> | ||||
| * | | Omit closure parameters | Kirill Bulatov | 2019-12-23 | 3 | -18/+62 |
| | | | |||||
* | | | Merge #2658 | bors[bot] | 2019-12-25 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2658: Only add features flags if non-empty r=matklad a=edwin0cheng This prevent error when disabled `all-features` in a cargo workspace, because of `--features is not allowed in the root of a virtual workspace` when running `cargo metadata`. Co-authored-by: Edwin Cheng <[email protected]> | ||||
| * | | | Only add features flags if non-empty | Edwin Cheng | 2019-12-23 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge #2663 | bors[bot] | 2019-12-25 | 5 | -37/+151 |
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | 2663: Fill in type params in 'add missing impl members' assist r=flodiebold a=flodiebold Co-authored-by: Florian Diebold <[email protected]> | ||||
| * | | | Fill in type params in 'add missing impl members' assist | Florian Diebold | 2019-12-24 | 5 | -37/+151 |
| | | | | |||||
* | | | | Merge #2662 | bors[bot] | 2019-12-25 | 1 | -1/+1 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2662: Notify that latest version of VS Code is required r=matklad a=spebern Suggested in #2660. Co-authored-by: bold <[email protected]> |