aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #2673bors[bot]2019-12-294-25/+96
|\ | | | | | | | | | | | | | | 2673: Don't add non-impl/trait containers to scope r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Don't add non-impl/trait containers to scopeAleksey Kladov2019-12-294-25/+96
|/
* Merge #2668bors[bot]2019-12-2941-2209/+1933
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2668: In-server cargo check watching r=matklad a=kiljacken Opening a draft now so people can follow the progress, and comment if they spot something stupid. Things that need doing: - [x] Running cargo check on save - [x] Pipe through configuration options from client - [x] Tests for parsing behavior - [x] Remove existing cargo watch support from VSCode extension - [x] Progress notification in VSCode extension using LSP 3.15 `$/progress` notification - [ ] ~~Rework ra-ide diagnostics to support secondary messages~~ - [ ] ~~Make cargo-check watcher use ra-ide diagnostics~~ ~~I'd love some input on whether to try to keep the status bar progress thingy for VSCode? It will require some plumbing, and maintaining yet another rust-analyzer specific LSP notification, which I'm not sure we want to.~~ Fixes #1894 Co-authored-by: Emil Lauridsen <[email protected]>
| * Fix busy-waiting issue in main cargo watch threadEmil Lauridsen2019-12-271-3/+5
| |
| * Don't finish main cargo watch thread when subprocess finishes.Emil Lauridsen2019-12-272-3/+5
| |
| * Fix shutdown behavoir of main cargo-watch thread.Emil Lauridsen2019-12-271-7/+8
| | | | | | | | | | Even though this didn't error, it became clear to me that it was closing the wrong channel, resulting in the child thread never finishing.
| * Add doc comment to moduleEmil Lauridsen2019-12-271-0/+2
| |
| * Cargo fmt runEmil Lauridsen2019-12-271-7/+1
| |
| * Shutdown/cancelation story for main cargo watch threadEmil Lauridsen2019-12-271-15/+32
| |
| * Consistent, hopefully robust, shutdown/cancelation story for cargo check ↵Emil Lauridsen2019-12-271-16/+50
| | | | | | | | subprocess
| * Move cargo watch functionality to separate crateEmil Lauridsen2019-12-2716-1338/+1373
| |
| * Keep VSCode config mostly backwards compatibleEmil Lauridsen2019-12-258-84/+71
| |
| * Some documentatioNEmil Lauridsen2019-12-251-0/+13
| |
| * Actually respect disabling cargo check functionalityEmil Lauridsen2019-12-251-3/+19
| |
| * Re-format ra_lsp_server changesEmil Lauridsen2019-12-253-7/+7
| |
| * Re-format VSCode extension changesEmil Lauridsen2019-12-252-19/+20
| |
| * Re-implement status display using LSP 3.15 progress eventEmil Lauridsen2019-12-254-9/+103
| |
| * Remove cargo watch supporting code and tests from vscode extensionEmil Lauridsen2019-12-2514-1684/+0
| |
| * Migrate tests from extension to rustEmil Lauridsen2019-12-259-0/+1069
| |
| * Fix use of wrong message in diagnosticEmil Lauridsen2019-12-251-1/+1
| |
| * Configuration plumbing for cargo watcherEmil Lauridsen2019-12-257-84/+83
| |
| * Remove cargo-watch from vscode extension.Emil Lauridsen2019-12-256-454/+1
| | | | | | | | Still keeps tests around for reference when porting them to rust
| * Initial implementation of cargo check watchingEmil Lauridsen2019-12-258-4/+599
| |
* | Merge #2667bors[bot]2019-12-2921-114/+609
|\ \ | | | | | | | | | | | | | | | | | | | | | 2667: Visibility r=matklad a=flodiebold This adds the infrastructure for handling visibility (for fields and methods, not in name resolution) in the HIR and code model, and as a first application hides struct fields from completions if they're not visible from the current module. (We might want to relax this again later, but I think it's ok for now?) Co-authored-by: Florian Diebold <[email protected]>
| * | visible_from -> is_visible_fromFlorian Diebold2019-12-274-10/+10
| | |
| * | Remove Arc from RawVisibilityFlorian Diebold2019-12-261-11/+6
| | | | | | | | | | | | | | | Now that it's not used as a direct query return value anymore, it doesn't need to be cheaply cloneable anymore.
| * | Fix cross-crate glob privacy handlingFlorian Diebold2019-12-263-6/+28
| | |
| * | Remove visibility query, instead add struct field visibility to dataFlorian Diebold2019-12-265-102/+35
| | | | | | | | | | | | | | | Methods should be handled the same, and for items the visibility will be in the def map.
| * | Rename ResolvedVisibility -> VisibilityFlorian Diebold2019-12-268-67/+54
| | |
| * | Rename Visibility -> RawVisibilityFlorian Diebold2019-12-266-40/+40
| | |
| * | Handle privacy for modulesFlorian Diebold2019-12-263-11/+36
| | |
| * | Check for `todo!` macros in no_todoFlorian Diebold2019-12-261-1/+1
| | |
| * | Take visibility into account for glob importsFlorian Diebold2019-12-267-43/+165
| | |
| * | Keep track of visibility during def collectionFlorian Diebold2019-12-266-54/+120
| | |
| * | Collect visibility of items during nameresFlorian Diebold2019-12-266-19/+63
| | |
| * | Add doc commentFlorian Diebold2019-12-261-0/+2
| | |
| * | Make enum variant fields publicFlorian Diebold2019-12-261-2/+9
| | |
| * | Hide completions for private struct fieldsFlorian Diebold2019-12-261-1/+56
| | |
| * | Add visibility in code model for fieldsFlorian Diebold2019-12-262-3/+20
| | |
| * | Add logic for resolving and checking visibilityFlorian Diebold2019-12-262-1/+60
| | |
| * | Add infrastructure for visibility on syntax and hir_def levelFlorian Diebold2019-12-265-2/+163
| | |
* | | Merge #2671bors[bot]2019-12-271-7/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2671: anyhow and crossbeam-queue r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | | anyhow and crossbeam-queueJeremy Kolb2019-12-271-7/+8
|/ / /
* | | Merge #2657bors[bot]2019-12-273-18/+62
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 2657: Omit closure parameters in closure type display strings r=flodiebold a=SomeoneToIgnore Part of https://github.com/rust-analyzer/rust-analyzer/issues/1946 I wonder, should we display the the closure trait (Fn/FnMut/FnOnce) in inlay hints instead of `|...|` at all? Co-authored-by: Kirill Bulatov <[email protected]>
| * | Omit closure parametersKirill Bulatov2019-12-233-18/+62
| | |
* | | Merge #2658bors[bot]2019-12-251-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2658: Only add features flags if non-empty r=matklad a=edwin0cheng This prevent error when disabled `all-features` in a cargo workspace, because of `--features is not allowed in the root of a virtual workspace` when running `cargo metadata`. Co-authored-by: Edwin Cheng <[email protected]>
| * | | Only add features flags if non-emptyEdwin Cheng2019-12-231-1/+1
| | | |
* | | | Merge #2663bors[bot]2019-12-255-37/+151
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 2663: Fill in type params in 'add missing impl members' assist r=flodiebold a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * | | Fill in type params in 'add missing impl members' assistFlorian Diebold2019-12-245-37/+151
| | | |
* | | | Merge #2662bors[bot]2019-12-251-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2662: Notify that latest version of VS Code is required r=matklad a=spebern Suggested in #2660. Co-authored-by: bold <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 00:41:05 +0000