aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #5565bors[bot]2020-07-292-1/+62
|\ | | | | | | | | | | | | | | 5565: SSR: Don't mix non-path-based rules with path-based r=matklad a=davidlattimore If any rules contain paths, then we reject any rules that don't contain paths. Allowing a mix leads to strange semantics, since the path-based rules only match things where the path refers to semantically the same thing, whereas the non-path-based rules could match anything. Specifically, if we have a rule like `foo ==>> bar` we only want to match the `foo` that is in the current scope, not any `foo`. However "foo" can be parsed as a pattern (BIND_PAT -> NAME -> IDENT). Allowing such a rule through would result in renaming everything called `foo` to `bar`. It'd also be slow, since without a path, we'd have to use the slow-scan search mechanism. Co-authored-by: David Lattimore <[email protected]>
| * SSR: Don't mix non-path-based rules with path-basedDavid Lattimore2020-07-292-1/+62
| | | | | | | | If any rules contain paths, then we reject any rules that don't contain paths. Allowing a mix leads to strange semantics, since the path-based rules only match things where the path refers to semantically the same thing, whereas the non-path-based rules could match anything. Specifically, if we have a rule like `foo ==>> bar` we only want to match the `foo` that is in the current scope, not any `foo`. However "foo" can be parsed as a pattern (BIND_PAT -> NAME -> IDENT). Allowing such a rule through would result in renaming everything called `foo` to `bar`. It'd also be slow, since without a path, we'd have to use the slow-scan search mechanism.
* | Merge #5561bors[bot]2020-07-291-54/+110
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5561: Allow running more tests at once via the module runners r=matklad a=SomeoneToIgnore Sometimes I group tests into submodules located in the root `#[cfg(test)]` crate and want to (re)run them all at once. This PR adds more test runnables to allow running all tests in the file via a module runner. Not all possible module runners are added, to avoid displaying too many code lens. before: <img width="306" alt="before" src="https://user-images.githubusercontent.com/2690773/88724886-e4c6ea00-d133-11ea-9d80-082bb610d422.png"> after (`nested_tests_0` got the runnable, `root_tests` had not): <img width="300" alt="after" src="https://user-images.githubusercontent.com/2690773/88724896-e85a7100-d133-11ea-99ee-689126679cbc.png"> Co-authored-by: Kirill Bulatov <[email protected]>
| * Allow running more tests at onceKirill Bulatov2020-07-281-54/+110
|/
* Merge #5560bors[bot]2020-07-283-7/+8
|\ | | | | | | | | | | | | | | | | | | | | 5560: Fix nameref parsing r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix nameref parsingAleksey Kladov2020-07-283-7/+8
|/
* Merge #5555bors[bot]2020-07-281-1/+2
|\ | | | | | | | | | | | | | | | | | | | | 5555: Bump test timeout for macs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Bump test timeout for macsAleksey Kladov2020-07-281-1/+2
|/
* Merge #5547bors[bot]2020-07-271-1/+13
|\ | | | | | | | | | | | | | | | | | | | | 5547: Fold multiline fn parameters r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fold multiline fn parametersAleksey Kladov2020-07-271-1/+13
| |
* | Merge #5532bors[bot]2020-07-272-23/+31
|\ \ | | | | | | | | | | | | | | | | | | | | | 5532: Restore line index optimization for edits r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Restore line index micro-optimizationLaurențiu Nicola2020-07-252-23/+31
| | |
* | | Merge #5528bors[bot]2020-07-271-0/+10
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 5528: README: Add some instructions for running typescript tests and linter. r=matklad a=davidlattimore Co-authored-by: David Lattimore <[email protected]>
| * | README: Add some instructions for running typescript tests and linter.David Lattimore2020-07-251-0/+10
| | |
* | | Merge #5539bors[bot]2020-07-273-27/+103
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5539: SSR: Fix path resolution of locals in current scope r=matklad a=davidlattimore Co-authored-by: David Lattimore <[email protected]>
| * | | SSR: Fix for path resolution of localsDavid Lattimore2020-07-262-0/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It seems that Semantics::scope, if given a statement node, won't resolve locals that were defined in the current scope, only in parent scopes. Not sure if this is intended / expected behavior, but we work around it for now by finding another nearby node to use as the scope (e.g. the expression inside the EXPR_STMT).
| * | | SSR: Move more resolution-related code into the resolving moduleDavid Lattimore2020-07-262-27/+38
| | | |
* | | | Merge #5541bors[bot]2020-07-271-4/+278
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5541: add completion for rustc lints r=matklad a=Emilgardis This is a very naive approach to provide completions for lints. Preferably, this would pull from current `rustup which rustc` via `rustc -W help <crate>`, but currently `rustc` only provides human output for lints. ![image](https://user-images.githubusercontent.com/1502855/88492913-90dec880-cfae-11ea-89d8-2b494951b20c.png) also, clippy would be really nice but I feel like for that ra should really pull from clippy Co-authored-by: Emil Gardström <[email protected]>
| * | | | add completion for rustc lintsEmil Gardström2020-07-271-4/+278
| |/ / /
* | | | Merge #5543bors[bot]2020-07-271-12/+12
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5543: :arrow_up: deps r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | :arrow_up: depsAleksey Kladov2020-07-271-12/+12
|/ / /
* | | Merge #5538bors[bot]2020-07-261-0/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5538: Report type errors in metrics r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Report type errors in metricsAleksey Kladov2020-07-261-0/+4
|/ / /
* | | Merge #5537bors[bot]2020-07-261-21/+50
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | 5537: Add one more test r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add one more testAleksey Kladov2020-07-261-21/+50
|/ /
* | Merge #5531bors[bot]2020-07-256-30/+102
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 5531: Add rustc-perf to metrics r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Add rustc-perf to metricsAleksey Kladov2020-07-256-30/+102
|/
* Merge #5527bors[bot]2020-07-243-33/+52
|\ | | | | | | | | | | | | | | | | | | | | 5527: Link metrics r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Link metricsAleksey Kladov2020-07-241-8/+6
| |
| * Add self-analysis-stats to metricsAleksey Kladov2020-07-242-25/+46
|/
* Merge #5520bors[bot]2020-07-244-7/+26
|\ | | | | | | | | | | | | | | 5520: Add DocumentData to represent in-memory document with LSP info r=matklad a=kjeremy At the moment this only holds document version information but in the near-future it will hold other things like semantic token delta info. Co-authored-by: kjeremy <[email protected]>
| * Add DocumentData to represent in-memory document with LSP infokjeremy2020-07-244-7/+26
| |
* | Merge #5525bors[bot]2020-07-241-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5525: minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | minorAleksey Kladov2020-07-241-1/+1
| | |
* | | Merge #5524bors[bot]2020-07-2410-103/+159
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 5524: Allow opting out of experimental diagnostics like MismatchedArgCount r=matklad a=jonas-schievink Closes https://github.com/rust-analyzer/rust-analyzer/issues/5448 Closes https://github.com/rust-analyzer/rust-analyzer/issues/5419 Co-authored-by: Jonas Schievink <[email protected]>
| * | Only display experimental diagnostics when enabledJonas Schievink2020-07-245-11/+22
| | |
| * | Add toggle for experimental diagnosticsJonas Schievink2020-07-242-5/+14
| | |
| * | Mark MismatchedArgCount as experimentalJonas Schievink2020-07-241-0/+3
| | |
| * | Allow filtering diagnosticsJonas Schievink2020-07-241-3/+22
| | |
| * | Add a builder for DiagnosticSinkJonas Schievink2020-07-244-88/+102
| | |
* | | Real metricsAleksey Kladov2020-07-241-3/+3
| | |
* | | Fix metricsAleksey Kladov2020-07-241-10/+20
| | |
* | | Fix metricsAleksey Kladov2020-07-242-14/+8
| | |
* | | Fix emailAleksey Kladov2020-07-241-1/+1
| | |
* | | fix syntaxAleksey Kladov2020-07-241-1/+1
| | |
* | | Fix another nameAleksey Kladov2020-07-242-3/+4
| | |
* | | fix nameAleksey Kladov2020-07-242-2/+2
| | |
* | | Add metricsAleksey Kladov2020-07-244-0/+255
| | |
* | | Revert "Merge #5516"Aleksey Kladov2020-07-242-43/+32
| | | | | | | | | | | | | | | This reverts commit 5b13c2411f025a16495f5828afe2def6e9220102, reversing changes made to c3defe2532ba6ffd12a13bcbc8fdeda037665efc.
* | | Merge #5523bors[bot]2020-07-242-13/+21
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5523: Minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>