aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | handle the case of conflicting lifetime param nameJess Balint2020-05-221-7/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - and clean/format code
| * | | | | | Assist: replace anonymous lifetime with a named oneJess Balint2020-05-223-0/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (fixes #4523)
* | | | | | | Merge #4653bors[bot]2020-05-302-5/+61
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4653: Fix match ergonomics in closure parameters r=matklad a=flodiebold Fixes #4476. Co-authored-by: Florian Diebold <[email protected]>
| * | | | | | Fix match ergonomics in closure parametersFlorian Diebold2020-05-292-5/+61
| | |/ / / / | |/| | | | | | | | | | | | | | | | Fixes #4476.
* | | | | | Merge #4655bors[bot]2020-05-301-1/+1
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4655: Fix typo in docs/dev/lsp-extensions.md: automagiacally -> automagically r=kjeremy a=theHamsta This may be a typo... Co-authored-by: Stephan Seitz <[email protected]>
| * | | | | Fix typo in docs/dev/lsp-extensions.md: automagiacally -> automagicallyStephan Seitz2020-05-291-1/+1
| | | | | |
* | | | | | Merge #4651bors[bot]2020-05-292-4/+2
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4651: Use first match branch in case of type mismatch, not last r=kjeremy a=flodiebold The comment says this was intentional, but I do agree with #4304 that it makes more sense the other way around (for if/else as well). Fixes #4304. Co-authored-by: Florian Diebold <[email protected]>
| * | | | | Use first match branch in case of type mismatch, not lastFlorian Diebold2020-05-292-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The comment says this was intentional, but I do agree with #4304 that it makes more sense the other way around (for if/else as well). Fixes #4304.
* | | | | | Merge #4652bors[bot]2020-05-293-22/+56
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4652: Upgrade Chalk r=kjeremy a=flodiebold Fixes #4072. Co-authored-by: Florian Diebold <[email protected]>
| * | | | | Upgrade ChalkFlorian Diebold2020-05-293-22/+56
| |/ / / / | | | | | | | | | | | | | | | Fixes #4072.
* | | | | Merge #4648bors[bot]2020-05-2912-72/+259
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4648: Support raw_ref_op's raw reference operator r=matklad a=robojumper Fixes #4642. This syntax (and its semantics) are implemented in rustc behind the `raw_ref_op` feature. It is not entirely clear whether this is the syntax that will become stable, but [it seems like](https://github.com/rust-lang/rust/pull/72279) rust-analyzer must still support this unstable syntax to support future stable rust. Also fixes a random inference failure involving a direct coercion from `&[T, _]` to `*const [T]`. Co-authored-by: robojumper <[email protected]>
| * | | | Support raw_ref_op's raw reference operatorrobojumper2020-05-2812-72/+259
|/ / / /
* | | | Merge #4640bors[bot]2020-05-284-1/+86
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4640: Add `inRustProject` when-clause for commands in vscode r=vsrs a=vsrs At the moment all rust-analyzer commands always visible in the command palette, even if there is no rust project opened. This PR adds special [when-clause](https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts) context. This context also might be used in key bindings. Co-authored-by: vsrs <[email protected]> Co-authored-by: vsrs <[email protected]>
| * | | | Add `inRustProject` context documentation.vsrs2020-05-281-0/+10
| | | | |
| * | | | Add `inRustProject` when-clause for commands.vsrs2020-05-273-1/+76
| | | | |
* | | | | Merge #4641bors[bot]2020-05-286-86/+71
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4641: Upgrade Chalk r=matklad a=flodiebold Chalk newly added TypeName::Never and Array; I implemented the conversion for Never, but not Array since that expects a const argument. Co-authored-by: Florian Diebold <[email protected]>
| * | | | | Upgrade ChalkFlorian Diebold2020-05-276-86/+71
| |/ / / / | | | | | | | | | | | | | | | | | | | | Chalk newly added TypeName::Never and Array; I implemented the conversion for Never, but not Array since that expects a const argument.
* | | | | Merge #4646bors[bot]2020-05-282-4/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4646: Link forum topic r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Link forum topicAleksey Kladov2020-05-282-4/+8
|/ / / / /
* | | | | Merge #4639bors[bot]2020-05-272-3/+3
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4639: Fixed missing newline on each field on "Missing structure fields". r=flodiebold a=flipbit03 Co-authored-by: Cadu <[email protected]>
| * | | | Fixed missing newline on each field on "Missing structure fields".Cadu2020-05-272-3/+3
|/ / / /
* | | | Merge #4592bors[bot]2020-05-273-1/+49
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4592: fix textedit range returned for completion when left token is a keyword r=bnjjj a=bnjjj close #4545 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | fix textedit range returned for completion when left token is a keywordBenjamin Coenen2020-05-272-0/+3
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | fix textedit range returned for completion when left token is a keyword #4545Benjamin Coenen2020-05-243-1/+46
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | Merge #4596bors[bot]2020-05-271-1/+59
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4596: Strip leading underscores of argument names in function/method r=matklad a=kuy Closes #4510 ### Goal When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names. ### Solution - Option 1: All signatures don't contain underscores - Option 2: Keep same signature, but inserted snippet doesn't contain underscores I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE. ### Other impls. rls: Complete argument names with underscores (same as actual ra) IntelliJ Rust: Doesn't complete argument names VSCode (TypeScript): Doesn't complete argument names ### Working example ![Screen Shot 2020-05-25 at 0 03 21](https://user-images.githubusercontent.com/151614/82757771-a05e5b80-9e1d-11ea-9dbc-1263c960e2ae.png) Co-authored-by: Yuki Kodama <[email protected]>
| * | | | | Trim at presentation layerYuki Kodama2020-05-252-4/+2
| | | | | |
| * | | | | Fix test to consider multiple underscoresYuki Kodama2020-05-251-7/+7
| | | | | |
| * | | | | Use built-in methodYuki Kodama2020-05-251-11/+5
| | | | | |
| * | | | | Separate assertionsYuki Kodama2020-05-251-7/+65
| | | | | |
| * | | | | Reflect test caseYuki Kodama2020-05-251-7/+7
| | | | | |
| * | | | | Strip leading underscoreYuki Kodama2020-05-251-2/+10
| | | | | |
| | | | | |
| \ \ \ \ \
*-. \ \ \ \ \ Merge #4625 #4629bors[bot]2020-05-272-7/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4625: Partially fix displaying inlay hints in Github PR diff views r=matklad a=Veetaha See the comment in https://github.com/rust-analyzer/rust-analyzer/issues/4608#issuecomment-63424257 It partially fixes the left side of diff view (the one where old code is displayed), but the diff editor with new code changes still has `file` scheme and will proceed displaying inlay hints... 4629: Fix the `should_panic` snippet r=matklad a=eminence Closes #4628 Co-authored-by: veetaha <[email protected]> Co-authored-by: Andrew Chin <[email protected]>
| | * | | | | | Fix the `should_panic` snippetAndrew Chin2020-05-261-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #4628
| * | | | | | | Partially fix displaying inlay hints in Github PR diff viewsveetaha2020-05-261-4/+5
| | | | | | | |
* | | | | | | | Merge #4633bors[bot]2020-05-271-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4633: typo r=matklad a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * | | | | | | | typoVeetaha2020-05-271-1/+1
|/ / / / / / / /
* | | | | | | | Merge #4632bors[bot]2020-05-271-0/+63
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4632: Document inlay hints and runnables r=matklad a=matklad We want to change those, but let's document what we have in meantime bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | | Document inlay hints and runnablesAleksey Kladov2020-05-271-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to change those, but let's document what we have in meantime
* | | | | | | | | Merge #4622bors[bot]2020-05-274-43/+40
|\ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4622: Pass trivially copy types as copy r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | | | | | Pass trivially copy types as copykjeremy2020-05-264-43/+40
| | |/ / / / / / | |/| | | | | |
* | | | | | | | Merge #4623bors[bot]2020-05-262-13/+13
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4623: Update deps r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | | | | | Update lexerkjeremy2020-05-262-3/+3
| | | | | | | | |
| * | | | | | | | Update crateskjeremy2020-05-261-10/+10
|/ / / / / / / /
* | | | | | | | Merge #4621bors[bot]2020-05-261-1/+1
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4621: Highlight question mark operator r=matklad a=kuy Fixes #4597 Co-authored-by: Yuki Kodama <[email protected]>
| * | | | | | | Add question mark operatorYuki Kodama2020-05-251-1/+1
| | |/ / / / / | |/| | | | |
* | | | | | | Merge #4534bors[bot]2020-05-261-0/+59
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4534: Add call postfix completion r=matklad a=vain0x To make it easier to wrap an expression with Ok/Some/Rc::new etc. Note I agree with conclusion of the discussion in #1431 that adding many completions is not the way to go. However, this PR still could be justified due to versatility of use. Co-authored-by: vain0x <[email protected]>
| * | | | | | Add call postfix completionvain0x2020-05-201-0/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | To make it easier to wrap an expression with Ok/Some/Rc::new etc.
* | | | | | | Merge #4617bors[bot]2020-05-263-9/+12
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4617: Hover tooltip module name is monospace once again r=matklad a=aloucks The line separator is also moved below the function signature to split regions between the docs. This is very similar to how IntelliJ displays tooltips. Adding an additional separator between the module name and function signature currently has rendering issues. Fixes #4594 Alternative to #4615 @kjeremy @Veetaha Note that I have semantic coloring disabled so ignore any differences due to that. ![image](https://user-images.githubusercontent.com/221559/82857507-30180e80-9edf-11ea-903a-f25c60055a93.png) ![image](https://user-images.githubusercontent.com/221559/82857407-e6c7bf00-9ede-11ea-9ae0-d348279552e7.png) Co-authored-by: Aaron Loucks <[email protected]>
| * | | | | | | Hover tooltip module name is monospace once againAaron Loucks2020-05-263-9/+12
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The line separator is moved below the function signature to split regions between the docs. This is very similar to how IntelliJ displays tooltips. Adding an additional separator between the module name and function signature currently has rendering issues. Fixes #4594 Alternative to #4615
* | | | | | | Merge #4614bors[bot]2020-05-254-9/+8
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4614: Fix some clippy perf warnings r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-25 02:27:06 +0000