aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #3376bors[bot]2020-02-294-18/+86
|\ | | | | | | | | | | | | | | | | | | | | | | | | 3376: Fix a common false-positive type mismatch r=matklad a=flodiebold E.g. for `&{ some_string() }` in a context where a `&str` is expected, we reported a mismatch inside the block. The problem is that we're passing an expectation of `str` down, but the expectation is more of a hint in this case. There's a long comment in rustc about this, which I just copied. Also, fix reported location for type mismatches in macros. Co-authored-by: Florian Diebold <[email protected]>
| * Fix a common false-positive type mismatchFlorian Diebold2020-02-294-18/+86
|/ | | | | | | | | E.g. for `&{ some_string() }` in a context where a `&str` is expected, we reported a mismatch inside the block. The problem is that we're passing an expectation of `str` down, but the expectation is more of a hint in this case. There's a long comment in rustc about this, which I just copied. Also, fix reported location for type mismatches in macros.
* Merge #3375bors[bot]2020-02-298-15/+39
|\ | | | | | | | | | | | | | | | | 3375: Cleanup editing API a bit r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix typoAleksey Kladov2020-02-293-3/+3
| |
| * Cleanup editing APIAleksey Kladov2020-02-295-12/+36
|/
* Merge #3374bors[bot]2020-02-293-15/+25
|\ | | | | | | | | | | | | | | | | | | | | 3374: More orthogonal API for building paths r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * More orthogonal API for building pathsAleksey Kladov2020-02-293-15/+25
|/
* Merge #3372bors[bot]2020-02-284-13/+19
|\ | | | | | | | | | | | | | | 3372: vscode: migrate to more type-safe assert impl r=matklad a=Veetaha https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#assertion-functions Co-authored-by: Veetaha <[email protected]>
| * vscode: simplify assert.eq() to assert() as per matkladVeetaha2020-02-282-15/+4
| |
| * vscode: add dat semicolonVeetaha2020-02-281-1/+1
| |
| * vscode: add equality assertionVeetaha2020-02-282-2/+12
| |
| * vscode: rename nodeAssert -> nativeAssertVeetaha2020-02-281-2/+2
| |
| * vscode: add error loging on failed assertionVeetaha2020-02-281-1/+6
| |
| * vscode: migrate to more type-safe assert implVeetaha2020-02-283-8/+10
| |
* | Merge #3371bors[bot]2020-02-283-23/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3371: Simplify r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | SimplifyAleksey Kladov2020-02-283-23/+3
|/ /
* | Merge #3370bors[bot]2020-02-285-533/+538
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 3370: Move insert_use util to utils r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Move insert_use util to utilsAleksey Kladov2020-02-285-533/+538
|/
* Merge #3369bors[bot]2020-02-282-3/+3
|\ | | | | | | | | | | | | | | | | | | | | 3369: Reduce visibility r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Reduce visibilityAleksey Kladov2020-02-282-3/+3
|/
* Merge #3367bors[bot]2020-02-2813-71/+144
|\ | | | | | | | | | | | | | | | | | | | | 3367: Fix highlighting of const patterns r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Correctly flag 'lifetime definitions as definitionsAleksey Kladov2020-02-286-40/+47
| |
| * Fix highlighting of const patternsAleksey Kladov2020-02-285-16/+61
| |
| * Classify name takes const patterns into accountAleksey Kladov2020-02-286-23/+44
| |
* | Merge #3366bors[bot]2020-02-282-38/+51
|\ \ | |/ |/| | | | | | | | | | | | | | | 3366: Simpilfy original_range logic r=matklad a=edwin0cheng This PR fixed another [bug](https://github.com/rust-analyzer/rust-analyzer/issues/3000#issuecomment-592474844) which incorrectly map the wrong range of `punct` in macro_call and simplify the logic a little bit by introducing an `ascend_call_token` function. Co-authored-by: Edwin Cheng <[email protected]>
| * Simpilfy origin_range logicEdwin Cheng2020-02-282-38/+51
| |
* | Merge #3364bors[bot]2020-02-283-3/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3364: Fix union classification r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fix union classificationAleksey Kladov2020-02-283-3/+5
|/ /
* | Merge #3363bors[bot]2020-02-289-156/+231
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3363: Cleanup highlighting tags r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fix highlighting testAleksey Kladov2020-02-285-49/+55
| | |
| * | Cleanup highlighting tagsAleksey Kladov2020-02-285-102/+169
| | |
| * | add more tagsAleksey Kladov2020-02-285-30/+32
| | |
* | | Merge #3362bors[bot]2020-02-281-5/+0
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 3362: removing ctrl+r key binding fixes #2733 r=matklad a=jasonwilliams @matklad i didn't see this mentioned anywhere else in the features.md Co-authored-by: Jason Williams <[email protected]>
| * | removing ctrl+r key binding fixes #2733Jason Williams2020-02-281-5/+0
|/ /
* | Merge #3361bors[bot]2020-02-281-0/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3361: Reset fontStyle for inlay hints r=matklad a=matklad Otherwise, we get bold hints on `true` and `false` bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Reset fontStyle for inlay hintsAleksey Kladov2020-02-281-0/+2
| |/ | | | | | | Otherwise, we get bold hints on `true` and `false`
* | Merge #3355bors[bot]2020-02-281-1/+23
|\ \ | | | | | | | | | | | | | | | | | | | | | 3355: vscode: added feature flags for better short-term ux r=matklad a=Veetaha See [this zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Feature.20flags) for more details. Co-authored-by: Veetaha <[email protected]>
| * | vscode: added feature flags for better short-term uxVeetaha2020-02-271-1/+23
| | |
* | | Merge #3360bors[bot]2020-02-283-8/+37
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 3360: Parse attribues in RHS of let statments r=matklad a=edwin0cheng Fixed #3315 Co-authored-by: Edwin Cheng <[email protected]>
| * | Parse attr in rhs of let stmtsEdwin Cheng2020-02-283-8/+37
| |/
* | Merge #3359bors[bot]2020-02-282-79/+24
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 3359: Remove AnalysisHost::type_of r=matklad a=edwin0cheng This PR remove ` AnalysisHost::type_of` (It is subsume by hover now) and use `Semantics::type_of_x` to infer the type inside `hover` directly. And this also solved a bug : Right now hovering on a string literal inside a macro will show up a `&str` popup correctly. (Except if that involved builtin macro, e.g. `println`) Co-authored-by: Edwin Cheng <[email protected]>
| * | Fix typoEdwin Cheng2020-02-281-1/+1
| | |
| * | Remove hover::type_ofEdwin Cheng2020-02-282-79/+24
| |/
* | Merge #3357bors[bot]2020-02-281-4/+9
|\ \ | |/ |/| | | | | | | | | | | 3357: introduce const visibility assist r=matklad a=qmx this adds the same change visibility assist to `const` declarations too - as suggested by @matklad Co-authored-by: Douglas Campos <[email protected]>
| * introduce const visibility assistDouglas Campos2020-02-281-4/+9
|/
* Merge #3354bors[bot]2020-02-271-0/+6
|\ | | | | | | | | | | | | | | | | | | | | 3354: Map builtin r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Map builtinAleksey Kladov2020-02-271-0/+6
| |
* | Merge #3353bors[bot]2020-02-271-0/+6
|\| | | | | | | | | | | | | | | | | | | | | 3353: Set attr scope r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Set attr scopeAleksey Kladov2020-02-271-0/+6
|/
* Merge #3352bors[bot]2020-02-271-0/+6
|\ | | | | | | | | | | | | | | | | | | | | 3352: Map unsafe keyword r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 22:28:50 +0000