aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #7018bors[bot]2020-12-231-61/+58
|\ | | | | | | | | | | | | | | | | 7018: Cleanup handle_code_action r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Make code more directAleksey Kladov2020-12-231-27/+20
| | | | | | | | | | | | | | * Push control flow outwards, as per https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/dev/style.md#preconditions * Don't re-do the work, pass-in the arguments
| * Make code more understandableAleksey Kladov2020-12-231-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid mutation of snapshot's config -- that's spooky action at a distance. Instead, copy it over to a local variable. This points out a minor architecture problem, which we won't fix right away. Various `ide`-level config structs, like `AssistConfig`, are geared towards one-shot use when calling a specific methods. On the other hand, the large `Config` struct in `rust-analyzer` is a long-term config store. The fact that `Config` stores `AssistConfig` is accidental -- a better design would probably be to just store `ConfigData` inside `Config` and create various `Config`s on the fly out of it.
| * Rename for clarityAleksey Kladov2020-12-231-46/+46
| |
* | Merge #7010bors[bot]2020-12-2313-7/+172
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7010: Update ungrammar for const block patterns r=matklad a=Veykril Fixes #6848 Adds const blocks and const block patterns to the AST and parses them. Blocked on https://github.com/rust-analyzer/ungrammar/pull/17/, will merge that PR there once this one gets the OK so I can remove the local ungrammar dependency path and fix the Cargo.lock. Co-authored-by: Lukas Wirth <[email protected]>
| * | Remove local ungrammar dependencyLukas Wirth2020-12-233-4/+4
| | |
| * | Parse const effect blockLukas Wirth2020-12-234-2/+38
| | |
| * | Parse ConstBlockPatLukas Wirth2020-12-233-0/+96
| | |
| * | Update ungrammar for const block patternsLukas Wirth2020-12-237-7/+40
| | |
* | | Merge #7017bors[bot]2020-12-231-1/+7
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7017: Document `make` module design r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Document `make` module designAleksey Kladov2020-12-231-1/+7
| | |/ | |/|
* | | Merge #6960bors[bot]2020-12-232-1/+55
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 6960: Show enum variant on Self qualified paths r=matklad a=Veykril Fixes first part of #6549 Fixes #6550 Co-authored-by: Lukas Wirth <[email protected]>
| * | Show enum variant completions for ref scrutineeLukas Wirth2020-12-201-1/+26
| | |
| * | Show enum variant on Self qualified pathsLukas Wirth2020-12-201-0/+29
| | |
* | | Merge #7015bors[bot]2020-12-231-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7015: Disable the unaligned feature of the object crate r=lnicola a=lnicola We `mmap` the files so they should be reasonably aligned. Let's see what https://github.com/rust-analyzer/rust-analyzer/pull/6817#issuecomment-744866239 is about. Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Disable unaligned feature for the object crateLaurențiu Nicola2020-12-231-1/+1
| | | |
* | | | Merge #7014bors[bot]2020-12-231-11/+9
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 7014: Set RA_TARGET at job level r=lnicola a=lnicola bors r+ Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Set RA_TARGET at job levelLaurențiu Nicola2020-12-231-11/+9
| | | |
* | | | Merge #7013bors[bot]2020-12-232-5/+5
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 7013: Don't think that /submod.rs is /mod.rs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Don't think that /submod.rs is /mod.rsAleksey Kladov2020-12-232-5/+5
|/ / /
* | | Merge #7012bors[bot]2020-12-232-2/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7012: Document, how to view config in effect r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Document, how to view config in effectAleksey Kladov2020-12-232-2/+5
|/ / /
* | | Merge #7011bors[bot]2020-12-232-2/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7011: Don't release uncompressed binaries under the new naming scheme r=lnicola a=lnicola bors r+ Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Don't release uncompressed binaries under the new naming schemeLaurențiu Nicola2020-12-232-2/+1
|/ / /
* | | Merge #7000bors[bot]2020-12-235-28/+52
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7000: Store invocation site for eager macros r=edwin0cheng a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6992 r? @edwin0cheng I'm not sure if this is totally correct, it looks like we create **two** `EagerCallLoc`s per macro invocation, one for the arguments (?), and one for the actual macro call. I gave both the same `AstId`, hopefully that's correct. Co-authored-by: Jonas Schievink <[email protected]>
| * | Store invocation site for eager macrosJonas Schievink2020-12-225-28/+52
| | |
* | | Merge #6964bors[bot]2020-12-228-74/+363
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6964: Add full pattern completions for Struct and Variant patterns r=matklad a=Veykril Just gonna call it full pattern completion as pattern completion is already implemented in a sense by showing idents in pattern position. What this does is basically complete struct and variant patterns where applicable(function params, let statements and refutable pattern locations). This does not replace just completing the corresponding idents of the structs and variants, instead two completions are shown for these, a completion for the ident itself and a completion for the pattern(if the pattern make sense to be used that is). I figured in some cases one would rather type out the pattern manually if it has a lot of fields but you only care about one since this completion would cause one more work in the end since you would have to delete all the extra matched fields again. These completions are tagged as `CompletionKind::Snippet`, not sure if that is the right one here. <details> <summary>some gifs</summary> ![dx2lxgzhj3](https://user-images.githubusercontent.com/3757771/102719967-6987ef80-42f1-11eb-8ae0-8aff53777860.gif) ![EP2E7sJLkB](https://user-images.githubusercontent.com/3757771/102785777-c7264580-439e-11eb-8a64-f142e19fb65b.gif) ![JMNHHWknr9](https://user-images.githubusercontent.com/3757771/102785796-d1e0da80-439e-11eb-934b-218ada31b51c.gif) </details> Co-authored-by: Lukas Wirth <[email protected]>
| * | | Reduce some more code duplicationLukas Wirth2020-12-225-94/+76
| | | |
| * | | Insert snippet positions after fields names in record patternsLukas Wirth2020-12-212-6/+6
| | | |
| * | | Create non-exhaustive patterns for non_exhaustive attributed itemsLukas Wirth2020-12-201-3/+5
| | | |
| * | | Reduce code duplication in pattern completionLukas Wirth2020-12-201-34/+29
| | | |
| * | | Emit snippets for struct pattern completion if enabledLukas Wirth2020-12-202-15/+36
| | | |
| * | | Add completions for patternsLukas Wirth2020-12-206-26/+315
| | |/ | |/|
* | | Merge #7001bors[bot]2020-12-221-6/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7001: Add support for downloading aarch64-apple-darwin binaries r=matklad a=lnicola There's also a slight behavior change here: we no longer download our 64-binaries on 32-bit Darwin and Linux. We still do that on Windows, as I don't know how to detect 32-bit Node on 64 Windows. But some people install the 32-bit Code by mistake, I doubt 32-bit Windows is that popular in the Rust crowd. Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Add support for downloading aarch64-apple-darwin binaries, change naming ↵Laurențiu Nicola2020-12-221-6/+8
| | | | | | | | | | | | | | | | convention
* | | | Merge #7005bors[bot]2020-12-221-103/+66
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7005: Improve extract_module_to_file assist r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Improve extract_module_to_file assistAleksey Kladov2020-12-221-103/+66
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | * simplify code * correctly handle crate roots and mod.rs files (nested inline modules are still mishandled) * make sure that new text contains a trailing newline
* | | | Merge #7002bors[bot]2020-12-221-5/+15
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7002: Extension conflict check detects more combinations r=extremegf a=extremegf This will also detect conflicts with kalitaalexey.vscode-rust and work correctly after RA is integrated with rust-lang.rust extension. Co-authored-by: Przemyslaw Horban <[email protected]> Co-authored-by: P. Horban <[email protected]>
| * | | | Fix grammar nitP. Horban2020-12-221-1/+1
| | | | | | | | | | | | | | | Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | | Extension conflict check detests more combinationsPrzemyslaw Horban2020-12-221-5/+15
| | |/ / | |/| |
* | | | Merge #6993bors[bot]2020-12-223-55/+55
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6993: Clean up descriptions for settings r=matklad a=rherrmann Use two consecutive newlines (`\n\n`) to actually continue text on a new line. Use proper markup to reference related settings. Consistently format references to files, command line arguments, etc. as `code`. Format mentions of UI elements in _italic_. Fix typos, add missing full-stops, add missing default values. Co-authored-by: RĂĽdiger Herrmann <[email protected]>
| * | | Clean up descriptions for settingsRĂĽdiger Herrmann2020-12-223-55/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use two consecutive newlines (`\n\n`) to actually continue text on a new line. Use proper markup to reference related settings. Consistently format references to files, editor commands, command line arguments, files, etc. as `code`. Fix typos, add missing full-stops, add missing default values.
* | | | Merge #6999bors[bot]2020-12-220-0/+0
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6999: Build aarch64-apple-darwin binaries on CI (take 2) r=matklad a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | | Build aarch64-apple-darwin binaries on CILaurențiu Nicola2020-12-222-32/+154
| | |/ / | |/| |
* | | | Merge #6989bors[bot]2020-12-222-32/+154
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6989: Build aarch64-apple-darwin binaries on CI r=matklad a=lnicola This splits the `dist` matrix job into four and tries to make `xtask dist` more principled about target and artifact naming. Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Build aarch64-apple-darwin binaries on CILaurențiu Nicola2020-12-222-32/+154
| | | |
* | | | Merge #6746bors[bot]2020-12-2210-19/+252
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6746: Feature/add assist extract module to file r=matklad a=sasurau4 Fix #6522 ## Screenshot <img src="https://user-images.githubusercontent.com/13580199/102748269-33a44300-43a5-11eb-9e37-f5fcb8e62f73.gif" width=600 /> ## TODO - [x] Remove all TODO comment - [x] Pass the doc test Co-authored-by: Daiki Ihara <[email protected]>
| * | | | Use workspace applyEdit instead of snippetWorkspaceEditDaiki Ihara2020-12-211-1/+1
| | | | |
| * | | | Fix assist test logicDaiki Ihara2020-12-211-2/+6
| | | | |
| * | | | Update test diagnostics in ideDaiki Ihara2020-12-211-0/+1
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-26 10:40:19 +0000