aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6033bors[bot]2020-09-284-29/+201
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 6033: Make name resolution resolve proc macros instead of relying purely on the build system r=matklad a=jonas-schievink This makes name resolution look at proc-macro declaration attributes like `#[proc_macro_derive]` and defines the right proc macro in the macro namespace, fixing unresolved custom derives like `thiserror::Error` (which can cause false positives, now that we emit diagnostics for unresolved imports). This works even when proc-macro support is turned off, in which case we fall back to a dummy expander that always returns an error. IMO this is the right way to handle at least the name resolution part of proc. macros, while the *expansion* itself should rely on the build system to build and provide the macro DLL. It does mean that they may go out of sync, but we can provide diagnostics if that happens (something like "could not find macro X in crate Y – ensure that all files of crate Y are saved"). I think it is valuable to be able to reason about proc macros even when we can't expand them, since proc macro expansion can break between Rust releases or users might not want to turn it on for performance reasons. It allows us to provide better diagnostics on any proc macro invocation we're not expanding (like a weak warning that informs the user that proc macro support is turned off, or that it has been disabled because the server crashed). Fixes https://github.com/rust-analyzer/rust-analyzer/issues/5763 Co-authored-by: Jonas Schievink <[email protected]>
| * Add more comments about proc macro resolutionJonas Schievink2020-09-281-0/+20
| |
| * Simplify iterator chainJonas Schievink2020-09-281-5/+2
| |
| * Remove incorrect docsJonas Schievink2020-09-181-6/+0
| |
| * Reduce visibility of non-proc-macrosJonas Schievink2020-09-183-0/+85
| | | | | | | | | | proc-macro crates only export proc-macros, but currently other items are also considered public (and show up in completion)
| * Remove obsolete proc macro collection codeJonas Schievink2020-09-181-19/+0
| | | | | | | | The new attribute-based resolution takes care of this
| * Use hir_def to resolve proc macrosJonas Schievink2020-09-183-16/+79
| |
| * Add testJonas Schievink2020-09-181-0/+32
| |
* | Merge #6085bors[bot]2020-09-281-0/+7
|\ \ | | | | | | | | | | | | | | | | | | | | | 6085: Mark unresolved imports diagnostic as experimental r=jonas-schievink a=jonas-schievink It causes a lot of false positives for people. We collected all of the known ones during the last week. Co-authored-by: Jonas Schievink <[email protected]>
| * | Mark unresolved imports diagnostic as experimentalJonas Schievink2020-09-281-0/+7
| | |
* | | Merge #6084bors[bot]2020-09-271-20/+25
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6084: Update deps r=kjeremy a=kjeremy cargo update Co-authored-by: Jeremy Kolb <[email protected]>
| * | | Update depsJeremy Kolb2020-09-271-20/+25
|/ / /
* | | Merge #6027bors[bot]2020-09-274-21/+46
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6027: Spawn a flycheck instance per workspace r=matklad a=jonas-schievink Limitations: - All instances are restarted on every file change - There's only one configuration used for all of them Co-authored-by: Jonas Schievink <[email protected]>
| * | | Spawn a flycheck instance per workspaceJonas Schievink2020-09-274-21/+46
|/ / /
* | | Merge #6073bors[bot]2020-09-255-55/+203
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6073: Dont unnecessarily unnest imports r=matklad a=Veykril Fixes #6071 This has the side effect that paths that refer to items inside of the current module get prefixed with `self`. Changing this behavior is unfortunately not straightforward should it be unwanted, though I don't see a problem with this as prefixing imports like this with `self` is what I do personally anyways 😅. You can see what I mean with this in one of the tests which had to be changed in `crates/ssr/src/tests.rs`. There is one test that i still have to look at though, ~~which I by accident pushed with `#[ignore]` on it~~, which is `different_crate_renamed`, for some reason this now doesn't use the crate alias. This also makes me believe that aliases in general will break with this. So maybe this is not as straight forwards as I'd hoped for, but I don't really know how aliases work here. Edit: The failing test should work now Co-authored-by: Lukas Wirth <[email protected]>
| * | | Remove partial import test in insert_useLukas Wirth2020-09-251-10/+0
| | | |
| * | | Don't unnecessarily unnest imports for import insertionLukas Wirth2020-09-254-45/+203
| | | |
* | | | Merge #6076bors[bot]2020-09-253-13/+19
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6076: Update chalk to 0.28.0 r=matklad a=vandenheuvel Co-authored-by: Bram van den Heuvel <[email protected]>
| * | | | Update chalk to 0.28.0Bram van den Heuvel2020-09-253-13/+19
| | | | |
* | | | | Merge #6055bors[bot]2020-09-251-0/+5
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6055: Add ok postfix completion r=matklad a=mullr Wrapping values in `Ok(...)` is so pervasive that it seems reasonable for it to have its own postfix completion. Co-authored-by: Russell Mull <[email protected]>
| * | | | Cargo fmtRussell Mull2020-09-221-9/+2
| | | | |
| * | | | Add ok postfix completionRussell Mull2020-09-221-0/+12
| | | | |
* | | | | Merge #6072bors[bot]2020-09-252-6/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6072: Cleanup unintended unresolved reference in syntax higlighting test r=matklad a=Nashenas88 Fixes the issue brought up here https://github.com/rust-analyzer/rust-analyzer/pull/5957#discussion_r486625707 cc @jonas-schievink Co-authored-by: Paul Daniel Faria <[email protected]>
| * | | | | Cleanup unintended unresolved reference in syntax higlighting testPaul Daniel Faria2020-09-242-6/+6
| | |/ / / | |/| | |
* | | | | Merge #6062bors[bot]2020-09-244-9/+12
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6062: Bump smol_str from 0.1.16 to 0.1.17 r=matklad a=woshilapin When I built `rust-analyzer` today, I noticed the following warnings. ``` warning: use of deprecated item 'syntax::SmolStr::new_inline_from_ascii': Use `new_inline` instead --> crates/mbe/src/syntax_bridge.rs:639:30 | 639 | ... (SmolStr::new_inline_from_ascii(1, &[punct.char as u8]), punct.id) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default warning: 1 warning emitted ``` So I thought it would be a nice small PR. Co-authored-by: Jean SIMARD <[email protected]>
| * | | | | Bump smol_str from 0.1.16 to 0.1.17Jean SIMARD2020-09-244-9/+12
| | | | | |
* | | | | | Merge #6050bors[bot]2020-09-241-0/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6050: VS Code + WSL: describe binary location r=matklad a=qnighy It looks like VS Code server chooses a different location for `globalStorage`. Co-authored-by: Masaki Hara <[email protected]>
| * | | | | VS Code + WSL: describe binary locationMasaki Hara2020-09-211-0/+1
| | |/ / / | |/| | | | | | | | It looks like VS Code server chooses a different location for `globalStorage`.
* | | | | Merge #6056bors[bot]2020-09-241-0/+12
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6056: Add dbgr postfix completion r=matklad a=lnicola Expanding to `dbg!(&e)`. Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | | | Add dbgr postfix completionLaurențiu Nicola2020-09-221-0/+12
| | | | | |
* | | | | | Merge #6061bors[bot]2020-09-244-19/+117
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6061: Allow to use a Github Auth token for fetching releases r=matklad a=Matthias247 This change allows to use a authorization token provided by Github in order to fetch metadata for a RA release. Using an authorization token prevents to get rate-limited in environments where lots of RA users use a shared client IP (e.g. behind a company NAT). The auth token is stored in `ExtensionContext.globalState`. As far as I could observe through testing with a local WSL2 environment that state is synced between an extension installed locally and a remote version. The change provides no explicit command to query for an auth token. However in case a download fails it will provide a retry option as well as an option to enter the auth token. This should be more discoverable for most users. Closes #3688 Co-authored-by: Matthias Einwag <[email protected]>
| * | | | | Fix lintMatthias Einwag2020-09-231-1/+1
| | | | | |
| * | | | | Move unlink on download into download functionMatthias Einwag2020-09-232-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since this is required by all callsites its easier to have it in the function itself.
| * | | | | Remane functionMatthias Einwag2020-09-231-5/+5
| | | | | |
| * | | | | Use closure in trailing position and strongly type header mapMatthias Einwag2020-09-232-18/+21
| | | | | |
| * | | | | Apply suggestions from code reviewMatthias Einwag2020-09-231-1/+1
| | | | | | | | | | | | | | | | | | Co-authored-by: Veetaha <[email protected]>
| * | | | | Remove stray newlineMatthias Einwag2020-09-231-1/+0
| | | | | |
| * | | | | Fix clearing the tokenMatthias Einwag2020-09-231-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous version would have interpreted an empty token as an abort of the dialog and would have not properly cleared the token. This is now fixed by checking for `undefined` for a an abort and by setting the token to `undefined` in order to clear it.
| * | | | | Add a command for updating the Github API tokenMatthias Einwag2020-09-232-0/+13
| | | | | |
| * | | | | Use retry dialog also for downloadsMatthias Einwag2020-09-231-20/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the change already implements a retry dialog for network operations, let's also use it for allowing to retry the actual file.
| * | | | | Fix tslintMatthias Einwag2020-09-231-2/+2
| | | | | |
| * | | | | Allow to use a Github Auth token for fetching releasesMatthias Einwag2020-09-233-4/+72
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change allows to use a authorization token provided by Github in order to fetch metadata for a RA release. Using an authorization token prevents to get rate-limited in environments where lots of RA users use a shared client IP (e.g. behind a company NAT). The auth token is stored in `ExtensionContext.globalState`. As far as I could observe through testing with a local WSL2 environment that state is synced between an extension installed locally and a remote version. The change provides no explicit command to query for an auth token. However in case a download fails it will provide a retry option as well as an option to enter the auth token. This should be more discoverable for most users. Closes #3688
* | | | | Merge #5846bors[bot]2020-09-243-8/+161
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5846: Add references to fn args during completion r=matklad a=adamrk When completing a function call, if there is an argument taken as a ref or mut ref which matches the name and type of a variable in scope, we will insert a `&` or `&mut` when filling in the function arguments. This addresses https://github.com/rust-analyzer/rust-analyzer/issues/5449. E.g. ```rust fn foo(x: &i32) {} fn main() { let x = 5; foo # completing foo here generates `foo(&x)` now instead of `foo(x)` } ``` Co-authored-by: adamrk <[email protected]>
| * | | | | Make unify private againadamrk2020-09-022-2/+2
| | | | | |
| * | | | | Trim mut keyword in fn completionadamrk2020-09-021-1/+22
| | | | | |
| * | | | | Remove exposing unificationadamrk2020-09-024-23/+1
| | | | | |
| * | | | | Collect locals in contextadamrk2020-09-022-12/+15
| | | | | |
| * | | | | Add back Param structadamrk2020-09-012-3/+13
| | | | | |
| * | | | | Add references to fn args during completionadamrk2020-08-305-10/+151
| | | | | |
* | | | | | Merge #6068bors[bot]2020-09-233-10/+10
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6068: More compliant lsp-types 0.82 r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 09:36:03 +0000