aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #4743bors[bot]2020-08-127-32/+284
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 4743: Add tracking of packed repr, use it to highlight unsafe refs r=matklad a=Nashenas88 Taking a reference to a misaligned field on a packed struct is an unsafe operation. Highlight that behavior. Currently, the misaligned part isn't tracked, so this highlight is a bit too aggressive. Fixes #4600 Co-authored-by: Paul Daniel Faria <[email protected]> Co-authored-by: Paul Daniel Faria <[email protected]> Co-authored-by: Paul Daniel Faria <[email protected]>
| * Remove unused import left behind after rebasingPaul Daniel Faria2020-08-101-1/+1
| |
| * Fix type names broken by rebase, redo expected test because of rebasePaul Daniel Faria2020-08-103-14/+44
| |
| * Move unsafe semantics methods into `SemanticsImpl` and reference them in ↵Paul Daniel Faria2020-08-101-71/+83
| | | | | | | | `Semantics`
| * Return bool from is_unsafe_method_call and cleanup usagesPaul Daniel Faria2020-08-102-24/+25
| |
| * Move semantic logic into Semantics, fix missing tag for safe amp operator, ↵Paul Daniel Faria2020-08-106-105/+112
| | | | | | | | using functional methods rather than clunky inline closure
| * Remove merge backupPaul Daniel Faria2020-08-101-769/+0
| |
| * Fix rebase errorsPaul Daniel Faria2020-08-104-9/+10
| |
| * Move unsafe packed ref logic to Semantics, use `Attrs::by_key` to simplify ↵Paul Daniel Faria2020-08-104-54/+815
| | | | | | | | repr attr lookup
| * Revert function structs back to using bool to track self param, use first ↵Paul Daniel Faria2020-08-1010-27/+22
| | | | | | | | param for self information in syntax highlighting instead
| * Deduplicate unsafe method call into a single functionPaul Daniel Faria2020-08-101-41/+31
| |
| * Unsafe borrow of packed fields: account for borrow through ref binding, auto ↵Paul Daniel Faria2020-08-1010-48/+156
| | | | | | | | ref function calls
| * Cleanup repr check, fix packed repr check and testPaul Daniel Faria2020-08-103-14/+15
| |
| * Update FIXME comment to be more usefulPaul Daniel Faria2020-08-101-1/+2
| |
| * Limit scope of unsafe to & instead of all ref exprs, add test showing ↵Paul Daniel Faria2020-08-102-1/+20
| | | | | | | | missing support for autoref behavior
| * Remove token tree from ReprKind::Other variant, expose ReprKind higher, ↵Paul Daniel Faria2020-08-102-10/+4
| | | | | | | | remove debug println.
| * Add tracking of packed repr, use it to highlight unsafe refsPaul Daniel Faria2020-08-104-4/+105
| | | | | | | | | | | | Taking a reference to a misaligned field on a packed struct is an unsafe operation. Highlight that behavior. Currently, the misaligned part isn't tracked, so this highlight is a bit too aggressive.
* | Merge #5722bors[bot]2020-08-127-94/+30
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5722: Replace SepBy with Itertools r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Replace SepBy with ItertoolsAleksey Kladov2020-08-127-94/+30
| | |
* | | Merge #5721bors[bot]2020-08-1261-669/+618
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 5721: Cleanup parser modifiers tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Cleanup parser modifiers testsAleksey Kladov2020-08-1241-362/+292
| | |
| * | Allow default everywhereAleksey Kladov2020-08-1221-307/+326
| | | | | | | | | | | | closes #5681
* | | Merge #5720bors[bot]2020-08-121-1/+1
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 5720: Fix docs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fix docsAleksey Kladov2020-08-121-1/+1
| | |
* | | Merge #5699bors[bot]2020-08-126-10/+15
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 5699: Fix clippy warnings r=matklad a=popzxc Currently clippy spawns a bunch of warnings on the `rust-analyzer` project. Nothing critical, but easy to fix, so I guess it won't harm. Co-authored-by: Igor Aleksanov <[email protected]>
| * | Revert style preference-related fixesIgor Aleksanov2020-08-125-21/+21
| | |
| * | Revert boxing for large enum variantIgor Aleksanov2020-08-101-3/+4
| | |
| * | Fix clippy warningsIgor Aleksanov2020-08-1011-34/+38
| |/
* | Merge #5719bors[bot]2020-08-121-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5719: Minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | MinorAleksey Kladov2020-08-121-0/+1
| | |
* | | Merge #5718bors[bot]2020-08-122-1/+14
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5718: Deny clippy r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Deny clippyAleksey Kladov2020-08-122-1/+14
| | |
* | | Merge #5717bors[bot]2020-08-121-4/+3
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 5717: Minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | MinorAleksey Kladov2020-08-121-4/+3
| | |
* | | Merge pull request #5716 from jonas-schievink/muslJonas Schievink2020-08-123-8/+16
|\ \ \ | | | | | | | | Fix build on musl and test it in CI
| * | | Fix build on musl and test it in CIJonas Schievink2020-08-123-8/+16
| |/ /
* | | Merge #5711bors[bot]2020-08-121-4/+4
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5711: Display snippet in the completion label r=matklad a=SomeoneToIgnore Before, the completion did not show the actual snippet and it was hard to understand what to input to get the right snippet: <img width="467" alt="image" src="https://user-images.githubusercontent.com/2690773/89941040-21f6a600-dc23-11ea-94b8-61f77f88feaf.png"> <img width="367" alt="image" src="https://user-images.githubusercontent.com/2690773/89941046-23c06980-dc23-11ea-8034-6c4e14357c94.png"> Now it's more clear: <img width="315" alt="image" src="https://user-images.githubusercontent.com/2690773/89941124-42befb80-dc23-11ea-9fcc-5fd49cc92b74.png"> <img width="210" alt="image" src="https://user-images.githubusercontent.com/2690773/89941132-4488bf00-dc23-11ea-99c2-12ec66e0a044.png"> Co-authored-by: Kirill Bulatov <[email protected]>
| * | Display snippet in the completion labelKirill Bulatov2020-08-111-4/+4
| | |
* | | Merge #5715bors[bot]2020-08-121-8/+8
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 5715: Simplify r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | SimplifyAleksey Kladov2020-08-121-8/+8
|/ /
* | Merge #5708bors[bot]2020-08-111-5/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | 5708: Use Hygiene in completion r=jonas-schievink a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Use Hygiene in completionLaurențiu Nicola2020-08-111-5/+5
| | |
* | | Merge #5707bors[bot]2020-08-117-14/+30
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5707: Address some FIXMEs for ra_assists r=jonas-schievink a=JmPotato Signed-off-by: JmPotato <[email protected]> Co-authored-by: JmPotato <[email protected]>
| * | | Revert some FIXMEsJmPotato2020-08-112-4/+9
| | | | | | | | | | | | | | | | Signed-off-by: JmPotato <[email protected]>
| * | | Typo fixJmPotato2020-08-112-2/+2
| | | | | | | | | | | | | | | | Signed-off-by: JmPotato <[email protected]>
| * | | Remove redundant dependenciesJmPotato2020-08-113-5/+2
| | | | | | | | | | | | | | | | Signed-off-by: JmPotato <[email protected]>
| * | | Typo fixJmPotato2020-08-111-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: JmPotato <[email protected]>
| * | | Address some FIXMEsJmPotato2020-08-116-18/+32
| |/ / | | | | | | | | | Signed-off-by: JmPotato <[email protected]>
* | | Merge #5705bors[bot]2020-08-111-2/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5705: Log the command flycheck runs to debug misconfigurations r=jonas-schievink a=Veetaha Without this users have no clue why flycheck fails to run. This is what is printed to the output channel: ``` [ERROR rust_analyzer::main_loop] cargo check failed: Cargo watcher failed,the command produced no valid metadata (exit code: ExitStatus(ExitStatus(25856))) ``` I stumbled with this figuring out that rust-analyzer adds `--all-features` which is not intended for some crates in the workspace (i.e. they have mutually-exclusive features). Having the command rust-analyzer ran should help a lot Co-authored-by: Veetaha <[email protected]>
| * | | Log the command flycheck runs to debug misconfigurationsVeetaha2020-08-111-2/+8
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this users have no clue why flycheck fails to run. This is what is printed to the output channel: ``` [ERROR rust_analyzer::main_loop] cargo check failed: Cargo watcher failed,the command produced no valid metadata (exit code: ExitStatus(ExitStatus(25856))) ``` I stumbled with this figuring out that rust-analyzer adds `--all-features` which is not intended for some crates in the workspace (e.g. they have mutually-exclusive features. Having the command rust-analyzer ran should help a lot