aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #5114bors[bot]2020-06-283-94/+128
|\ | | | | | | | | | | | | | | | | | | | | 5114: Cleanup cargo process handling in flycheck r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Cleanup cargo process handling in flycheckAleksey Kladov2020-06-282-61/+66
| |
| * More standard pattern for CargoAleksey Kladov2020-06-281-76/+83
| |
| * NamingAleksey Kladov2020-06-282-12/+11
| |
| * RenameAleksey Kladov2020-06-281-3/+3
| |
| * Make sure to join the childAleksey Kladov2020-06-281-2/+25
| |
* | Merge #5113bors[bot]2020-06-281-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | 5113: Update instant r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | Update instantJeremy Kolb2020-06-281-2/+2
|/ /
* | Merge #5112bors[bot]2020-06-282-10/+14
|\ \ | |/ |/| | | | | | | | | | | 5112: Update Chalk to released version r=flodiebold a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * Update Chalk to released versionFlorian Diebold2020-06-282-10/+14
|/
* Merge #5108bors[bot]2020-06-281-1/+2
|\ | | | | | | | | | | | | | | | | | | | | 5108: Don't show ra_fixture param hints r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Don't show ra_fixture param hintsAleksey Kladov2020-06-281-1/+2
|/
* Merge #5104bors[bot]2020-06-281-13/+1
|\ | | | | | | | | | | | | | | 5104: Simplify r=matklad a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * SimplifyVeetaha2020-06-271-13/+1
|/
* Merge #5102bors[bot]2020-06-272-0/+36
|\ | | | | | | | | | | | | | | 5102: Add support for include_bytes! r=edwin0cheng a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * Add support for include_bytesLaurențiu Nicola2020-06-272-0/+36
|/
* Merge #5100bors[bot]2020-06-273-19/+60
|\ | | | | | | | | | | | | | | 5100: Add support for include_str r=edwin0cheng a=lnicola r? @edwin0cheng Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * Add support for include_strLaurențiu Nicola2020-06-273-19/+60
| |
* | Merge #4587bors[bot]2020-06-2713-13/+328
|\ \ | | | | | | | | | | | | | | | | | | | | | 4587: Add "missing unsafe" diagnostics r=Nashenas88 a=Nashenas88 Addresses #190 Co-authored-by: Paul Daniel Faria <[email protected]>
| * | Remove html from gitignore so highlight snapshots are not ignoredPaul Daniel Faria2020-06-271-1/+0
| | |
| * | Simplify unsafe expr collection matchPaul Daniel Faria2020-06-271-4/+3
| | |
| * | Improve perf of finding unsafe exprsPaul Daniel Faria2020-06-271-49/+39
| | |
| * | Remove unneeded code, filename from tests, fix rebasing issuesPaul Daniel Faria2020-06-2712-34/+85
| | |
| * | Cleanup changes leftover from previous tracking attemptPaul Daniel Faria2020-06-271-14/+16
| | |
| * | Revert ide highlighting changes (addressing on another branch)Paul Daniel Faria2020-06-2710-104/+10
| | |
| * | Remove track_parent and parent_map, replace with simple walk in missign ↵Paul Daniel Faria2020-06-273-291/+121
| | | | | | | | | | | | unsafe validator
| * | Fix issues caused during rebasePaul Daniel Faria2020-06-271-45/+63
| | |
| * | unsafe: Clean up, improve tracking, add debug_assertPaul Daniel Faria2020-06-274-153/+232
| | | | | | | | | | | | | | | | | | Move unsafe_expressions to unsafe_validation.rs, replace vec tracking of child exprs with inline macro, add debug assert to ensure tracked children match walked children exactly
| * | Add HighlightTag::Operator, use it for unsafe deref. Move unsafe validation ↵Paul Daniel Faria2020-06-2711-58/+81
| | | | | | | | | | | | to its own file
| * | Account for deref token in syntax highlighting of unsafe, add test for that casePaul Daniel Faria2020-06-271-0/+1
| | |
| * | Track expr parents during lowering, use parent map when checking if unsafe ↵Paul Daniel Faria2020-06-274-100/+177
| | | | | | | | | | | | exprs are within unsafe blocks
| * | Address review comments, have MissingUnsafe diagnostic point to each unsafe ↵Paul Daniel Faria2020-06-273-25/+19
| | | | | | | | | | | | use, update tests
| * | Rename Expr::UnsafeBlock to Expr::UnsafePaul Daniel Faria2020-06-274-5/+5
| | |
| * | Track unsafe blocks, don't trigger missing unsafe diagnostic when unsafe ↵Paul Daniel Faria2020-06-277-19/+82
| | | | | | | | | | | | exprs within unsafe block
| * | Add missing self param to testPaul Daniel Faria2020-06-271-1/+1
| | |
| * | Fix typo in testPaul Daniel Faria2020-06-271-1/+1
| | |
| * | Remove UnnecessaryUnsafe diagnostic, Fix Expr::Call unsafe analysisPaul Daniel Faria2020-06-274-70/+22
| | |
| * | Add tests covering unsafe blocks, more attempts to get call expr tests passingPaul Daniel Faria2020-06-272-1/+86
| | |
| * | Move diagnostics back into expr, add tests for diagnostics, fix logic to ↵Paul Daniel Faria2020-06-277-73/+158
| | | | | | | | | | | | account for derefs of raw ptrs
| * | Add unsafe diagnostics and unsafe highlightingPaul Daniel Faria2020-06-275-2/+163
|/ /
* | Merge #5099bors[bot]2020-06-271-1/+1
|\ \ | |/ |/| | | | | | | | | | | 5099: Escape space in path for MacOS binary location r=matklad a=LeSeulArtichaut This makes it possible and easier to copy paste the path to the binary server, without needing to add quotes. Co-authored-by: LeSeulArtichaut <[email protected]>
| * Escape space in path for MacOS binary locationLeSeulArtichaut2020-06-271-1/+1
|/
* Merge #5090bors[bot]2020-06-274-54/+62
|\ | | | | | | | | | | | | | | 5090: Bump deps r=matklad a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * Bump rustc_lexerLaurențiu Nicola2020-06-273-15/+15
| |
| * Bump depsLaurențiu Nicola2020-06-272-45/+53
| |
* | Merge #5095bors[bot]2020-06-271-7/+7
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5095: Add `::` to label for `crate::` completion r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add `::` to label for `crate::` completionAleksey Kladov2020-06-271-7/+7
|/ /
* | Merge #5094bors[bot]2020-06-271-13/+10
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5094: cleanup r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | cleanupAleksey Kladov2020-06-271-13/+10
|/ /
* | Merge #4982bors[bot]2020-06-277-59/+281
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4982: Bump chalk r=matklad a=lnicola This passes the tests, but fails in a weird way on `analysis-stats`: ``` thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/me/.cargo/registry/src/github.com-1ecc6299db9ec823/chalk-solve-0.14.0/src/clauses/builtin_traits/fn_family.rs:96:20 stack backtrace: 0: backtrace::backtrace::libunwind::trace at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86 1: backtrace::backtrace::trace_unsynchronized at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66 2: std::sys_common::backtrace::_print_fmt at src/libstd/sys_common/backtrace.rs:78 3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt at src/libstd/sys_common/backtrace.rs:59 4: core::fmt::write at src/libcore/fmt/mod.rs:1076 5: std::io::Write::write_fmt at src/libstd/io/mod.rs:1537 6: std::sys_common::backtrace::_print at src/libstd/sys_common/backtrace.rs:62 7: std::sys_common::backtrace::print at src/libstd/sys_common/backtrace.rs:49 8: std::panicking::default_hook::{{closure}} at src/libstd/panicking.rs:198 9: std::panicking::default_hook at src/libstd/panicking.rs:218 10: std::panicking::rust_panic_with_hook at src/libstd/panicking.rs:477 11: rust_begin_unwind at src/libstd/panicking.rs:385 12: core::panicking::panic_fmt at src/libcore/panicking.rs:86 13: core::panicking::panic at src/libcore/panicking.rs:51 14: chalk_solve::clauses::builtin_traits::fn_family::add_fn_trait_program_clauses 15: chalk_solve::clauses::builder::ClauseBuilder<I>::push_binders 16: chalk_solve::clauses::program_clauses_that_could_match 17: chalk_solve::clauses::program_clauses_for_goal 18: chalk_solve::recursive::Solver<I>::solve_new_subgoal 19: <chalk_solve::recursive::Solver<I> as chalk_solve::recursive::solve::SolveDatabase<I>>::solve_goal 20: chalk_solve::recursive::Solver<I>::solve_root_goal 21: chalk_solve::solve::Solver<I>::solve_limited 22: ra_hir_ty::traits::trait_solve_query 23: salsa::runtime::Runtime<DB>::execute_query_implementation 24: salsa::derived::slot::Slot<DB,Q,MP>::read_upgrade 25: salsa::derived::slot::Slot<DB,Q,MP>::read 26: <salsa::derived::DerivedStorage<DB,Q,MP> as salsa::plumbing::QueryStorageOps<DB,Q>>::try_fetch 27: salsa::QueryTable<DB,Q>::get 28: <T as ra_hir_ty::db::HirDatabase>::trait_solve 29: ra_hir_ty::infer::InferenceContext::resolve_ty_as_possible 30: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_inner 31: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_coerce 32: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::check_call_arguments 33: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_method_call 34: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_inner 35: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr 36: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_method_call 37: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_inner 38: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_coerce 39: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_inner 40: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_inner 41: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_coerce 42: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_inner 43: ra_hir_ty::infer::expr::<impl ra_hir_ty::infer::InferenceContext>::infer_expr_coerce 44: ra_hir_ty::infer::infer_query 45: salsa::runtime::Runtime<DB>::execute_query_implementation 46: salsa::derived::slot::Slot<DB,Q,MP>::read_upgrade 47: salsa::derived::slot::Slot<DB,Q,MP>::read 48: <salsa::derived::DerivedStorage<DB,Q,MP> as salsa::plumbing::QueryStorageOps<DB,Q>>::try_fetch 49: ra_hir_ty::db::infer_wait 50: rust_analyzer::cli::analysis_stats::analysis_stats 51: rust_analyzer::main 52: std::rt::lang_start::{{closure}} 53: std::rt::lang_start_internal::{{closure}} at src/libstd/rt.rs:52 54: std::panicking::try::do_call at src/libstd/panicking.rs:297 55: std::panicking::try at src/libstd/panicking.rs:274 56: std::panic::catch_unwind at src/libstd/panic.rs:394 57: std::rt::lang_start_internal at src/libstd/rt.rs:51 58: main 59: __libc_start_main 60: _start note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. ``` It's as if we're returning `None` for a well-known trait that `chalk` asks about. That seems to happen for `Deref`, `CoerceUnsized` and `Try`. r? @flodiebold Co-authored-by: LaurenČ›iu Nicola <[email protected]>