| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
|/ |
|
|\
| |
| |
| |
| |
| | |
31: Parse enums r=matklad a=matklad
|
| | |
|
| | |
|
|/ |
|
|\
| |
| |
| |
| |
| | |
29: Structs r=matklad a=matklad
r? @CAD97
|
| | |
|
| | |
|
|/ |
|
|\
| |
| |
| |
| |
| | |
30: Skip over balanced parens r=matklad a=matklad
|
|/ |
|
|\
| |
| |
| |
| |
| | |
28: Don't return SyntaxKind from bump r=matklad a=matklad
|
|/ |
|
|\
| |
| |
| |
| |
| | |
25: Drop curly_block r=matklad a=matklad
closes #13
|
| | |
|
| | |
|
|/
|
|
| |
closes #13
|
|\
| |
| |
| |
| |
| | |
24: Block Comments r=matklad a=CAD97
closes #7
|
| | |
|
| |
| |
| |
| | |
closes #7
|
|\ \
| | |
| | |
| | |
| | |
| | | |
23: Simplify item parsing r=matklad a=matklad
|
| | | |
|
|/ / |
|
| | |
|
|\ \
| |/
|/|
| |
| |
| | |
22: Try to fix spurious download errors on appveyor r=matklad a=matklad
|
|/ |
|
|\
| |
| |
| |
| |
| | |
21: Apply #20 to generating code r=CAD97 a=CAD97
|
|/ |
|
|\
| |
| |
| |
| |
| |
| | |
20: Drop `repr(u32)` from SyntaxKind r=CAD97 a=matklad
Nomicon says it disables some optimizations:
https://doc.rust-lang.org/beta/nomicon/other-reprs.html#repru-repri
|
|/
|
|
|
| |
Nomicon says it disables some optimizations:
https://doc.rust-lang.org/beta/nomicon/other-reprs.html#repru-repri
|
|\
| |
| |
| |
| |
| | |
18: Comments r=matklad a=matklad
|
| | |
|
| | |
|
| | |
|
|\ \
| |/
|/|
| |
| |
| | |
17: Document the design of `FileBuilder` r=matklad a=matklad
|
| | |
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
16: Proof-of-concept SyntaxKind as enum r=matklad a=CAD97
This was the one bit about the original RFC I was most confused about. Why isn't `SyntaxKind` a normal `enum`?
If it's to signify that it's non-exhaustive [`#[non_exhaustive]`](https://github.com/rust-lang/rust/issues/44109) should be used. (Or `#[doc(hidden)] __Nonexhaustive` on stable.)
If it's so that more variants can be added externally, why? There's no need for that, that I can foresee.
If it's to expose the `SyntaxKind` type but not any of its instances, why? This is the only actual benefit I can see of this pseudo-enum style.
This diff is meant to be as non-invasive as possible, and as such reexports all symbols as they existed prior to this. It's diffed on top of the assumed-good-to-merge #15 to avoid the conflict between them.
Diff without #15: <https://github.com/matklad/libsyntax2/pull/16/commits/4244948c6b1a62bd0e1ef276d1f0cc22c36f6f66>
Just `src/syntax_kinds.rs`: <https://github.com/matklad/libsyntax2/pull/16/commits/4244948c6b1a62bd0e1ef276d1f0cc22c36f6f66#diff-8f0d69eb4fe0148851505f787b6fd3bb>
|
| | |
|
|\|
| |
| |
| |
| |
| |
| |
| | |
15: Add minimal docs to most public symbols r=matklad a=CAD97
Also sticks a safety on some warnings that rustc provides.
If you're just stubbing out a module and don't want rustc refusing to compile it because you haven't documented it yet, stick `#![allow(missing_docs)]` at the top.
|
|/ |
|
|\
| |
| |
| |
| |
| | |
14: Normalize test newlines r=matklad a=CAD97
Tests pass with CRLF newlines now
|
| |
| |
| |
| | |
Tests pass with CRLF newlines now
|
| | |
|
| | |
|
| | |
|
|/ |
|
|\
| |
| | |
Enforce rustfmt format
|
| | |
|
| | |
|