aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* handle the case of conflicting lifetime param nameJess Balint2020-05-221-7/+36
| | | | - and clean/format code
* Assist: replace anonymous lifetime with a named oneJess Balint2020-05-223-0/+149
| | | | (fixes #4523)
* Merge #4560bors[bot]2020-05-216-9/+43
|\ | | | | | | | | | | | | | | | | | | | | 4560: Use WorkspaceEdit for ssr r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Use WorkspaceEdit for ssrAleksey Kladov2020-05-216-9/+43
|/
* Merge #4557bors[bot]2020-05-219-47/+129
|\ | | | | | | | | | | | | | | | | | | | | 4557: Formalize JoinLines protocol extension r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Formalize JoinLines protocol extensionAleksey Kladov2020-05-219-47/+129
|/
* Merge #4553bors[bot]2020-05-217-50/+37
|\ | | | | | | | | | | | | | | | | | | | | 4553: Cleanup r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * CleanupAleksey Kladov2020-05-213-34/+18
| |
| * Cleanup TextEditAleksey Kladov2020-05-215-18/+21
|/
* Merge #4552bors[bot]2020-05-2116-478/+109
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4552: Transition OnEnter to WorkspaceSnippetEdit r=matklad a=matklad This also changes our handiling of snippet edits on the client side. `editor.insertSnippet` unfortunately forces indentation, which we really don't want to have to deal with. So, let's just implement our manual hacky way of dealing with a simple subset of snippets we actually use in rust-analyzer bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Remove dead code for handling cursor positionsAleksey Kladov2020-05-218-388/+12
| |
| * Transition OnEnter to WorkspaceSnippetEditAleksey Kladov2020-05-218-90/+97
| | | | | | | | | | | | | | | | This also changes our handiling of snippet edits on the client side. `editor.insertSnippet` unfortunately forces indentation, which we really don't want to have to deal with. So, let's just implement our manual hacky way of dealing with a simple subset of snippets we actually use in rust-analyzer
* | Merge #4550bors[bot]2020-05-211-4/+4
|\ \ | |/ |/| | | | | | | | | | | | | | | 4550: Fix phrasing in inlay hints settings r=matklad a=lnicola Part of #4549 r? @LucianoBestia Co-authored-by: Laurențiu Nicola <[email protected]>
| * Fix phrasing in inlay hints settingsLaurențiu Nicola2020-05-211-4/+4
|/
* Merge #4547bors[bot]2020-05-213-8/+3
|\ | | | | | | | | | | | | | | | | | | | | 4547: Remove unused cursor positions r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Remove unused cursor positionsAleksey Kladov2020-05-213-8/+3
|/
* Merge #4506bors[bot]2020-05-212-4/+7
|\ | | | | | | | | | | | | | | | | | | 4506: Make `find_path_inner` a query r=matklad a=jonas-schievink This eliminates the remaining performance problems in the "Implement default members" assist (at least those that I've found). Closes https://github.com/rust-analyzer/rust-analyzer/issues/4498 Co-authored-by: Jonas Schievink <[email protected]>
| * Make `find_path_inner` a queryJonas Schievink2020-05-202-4/+7
| | | | | | | | | | This eliminates any remaining performance problems in the "Implement default members" assist (at least that I've found).
* | Merge #4543bors[bot]2020-05-211-13/+7
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4543: Remove unused cursor positions r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Remove unused cursor positionsAleksey Kladov2020-05-201-13/+7
|/ /
* | Merge #4541bors[bot]2020-05-208-68/+61
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 4541: Remove set_cursor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Remove set_cursorAleksey Kladov2020-05-202-31/+13
| |
| * Snippetify unwrap -> matchAleksey Kladov2020-05-203-14/+31
| |
| * More snippetsAleksey Kladov2020-05-203-23/+17
|/
* Merge #4540bors[bot]2020-05-2010-172/+133
|\ | | | | | | | | | | | | | | | | 4540: More snippets r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * More snippetsAleksey Kladov2020-05-206-97/+45
| |
| * Snippetify introduce/inline varAleksey Kladov2020-05-204-75/+88
| |
* | Merge #4526bors[bot]2020-05-201-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4526: Use a flat play icon instead of the blue emoji with test code lens r=kjeremy a=aloucks @lnicola Restores this commit: https://github.com/rust-analyzer/rust-analyzer/commit/55e914a2a179aba63bd9948d6e0cf3e2a4bf5960 That was effectively wiped out by this code formatting commit: https://github.com/rust-analyzer/rust-analyzer/commit/dc217bdf90d555eaa1780041fc3a14e64173994d https://github.com/rust-analyzer/rust-analyzer/commit/3d445256fe56f4a7ead64514fb57b79079973d84 Co-authored-by: Aaron Loucks <[email protected]>
| * | Use a flat play icon instead of the blue emoji with test code lensAaron Loucks2020-05-201-2/+2
| | |
* | | Merge #4539bors[bot]2020-05-2014-117/+96
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4539: Relax cursor position tests in assists r=matklad a=matklad Those will be replaced with snippets anyway bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Relax cursor position tests in assistsAleksey Kladov2020-05-2014-117/+96
|/ / | | | | | | Those will be replaced with snippets anyway
* | Merge #4536bors[bot]2020-05-202-5/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | 4536: Fix names of launch configuration in dev docs r=kjeremy a=kuy Follows renaming of launch configurations in https://github.com/rust-analyzer/rust-analyzer/commit/80a42a0628f7655c3299fbf4c5a15e31990b35d3 Co-authored-by: Yuki Kodama <[email protected]>
| * | Fix names of launch configuration in dev docsYuki Kodama2020-05-202-5/+5
| | |
* | | Merge #4537bors[bot]2020-05-201-1/+1
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 4537: Fix GNOME spelling r=matklad a=afranke GNOME is a trademark. :-) Co-authored-by: Alexandre Franke <[email protected]>
| * | Fix GNOME spellingAlexandre Franke2020-05-201-1/+1
|/ / | | | | GNOME is a trademark. :-)
* | Merge #4533bors[bot]2020-05-206-160/+124
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 4533: More snippets r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Snippetify fix_visibilityAleksey Kladov2020-05-203-32/+36
| | |
| * | Snippetify fill_match_armsAleksey Kladov2020-05-203-118/+79
| | |
| * | Don't set cursor in change_visibilityAleksey Kladov2020-05-201-6/+3
| | |
| * | Cleanup importsAleksey Kladov2020-05-201-4/+6
|/ /
* | Merge #4532bors[bot]2020-05-205-506/+603
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4532: Split change_ and fix_ visibility assists r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Split change_ and fix_ visibility assistsAleksey Kladov2020-05-205-506/+603
|/ /
* | Merge #4520bors[bot]2020-05-2049-288/+179
|\ \ | | | | | | | | | | | | | | | | | | | | | 4520: Marks 2.0 r=matklad a=matklad The main benefit here is that we no longer need to declare marks. The main drawback is that this is ~~glorious~~ horrible. WDYT? Co-authored-by: Aleksey Kladov <[email protected]>
| * | Switch to new magic marksAleksey Kladov2020-05-2042-298/+152
| | |
| * | Remove cross-crate marksAleksey Kladov2020-05-207-45/+4
| | | | | | | | | | | | | | | They create quite a bit of friction. Really, we should just move the tests to the same crate, rather than paper over existing split.
| * | Significantly more glorious marksAleksey Kladov2020-05-204-8/+86
|/ /
* | Merge #4530bors[bot]2020-05-207-92/+85
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4530: Use snippets in change_return_type_to_result r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Use snippets in change_return_type_to_resultAleksey Kladov2020-05-203-48/+37
| | |
| * | wipAleksey Kladov2020-05-201-4/+8
| | |
| * | CleanupAleksey Kladov2020-05-201-12/+10
| | |