aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Add test for #6852Florian Diebold2020-12-131-0/+37
|/ / /
* | | Merge #6855bors[bot]2020-12-131-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6855: Change recommendation when source can't be loaded from sysroot r=matklad a=flodiebold Since we just tried running `rustup component add`, it doesn't make sense to me to recommend trying that again. If we're reaching this case, it's probably more likely that rustc was installed via package manager, in which case the source should be installed the same way (e.g. if you install the rust-src package on Ubuntu it will install a symlink in the right place to make our sysroot detection work, and IMO we should get other distributors to do the same if they aren't already). Co-authored-by: Florian Diebold <[email protected]>
| * | | Change recommendation when source can't be loaded from sysrootFlorian Diebold2020-12-131-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Since we just tried running `rustup component add`, it doesn't make sense to me to recommend trying that again. If we're reaching this case, it's probably more likely that rustc was installed via package manager, in which case the source should be installed the same way (e.g. if you install the rust-src package on Ubuntu it will install a symlink in the right place to make our sysroot detection work).
* | | Merge #6852bors[bot]2020-12-133-3/+17
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 6852: Ignore lifetime params in substitutions r=matklad a=Veykril [`hir_ty::utils::Generics`](https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/utils.rs#L153) currently only assumes type parameters but not lifetime parameters and therefor creates incorrect index and length calculations, this PR just makes the use sites ignore LifetimeGenerics for now. This fixes the panic at least locally for me for `analysis-stats`. Funnily enough this panic prevented me from using reference search for the `args` field to fix this problem. Co-authored-by: Lukas Wirth <[email protected]>
| * | Ignore lifetime params in substitutionsLukas Wirth2020-12-133-3/+17
| | |
* | | Merge #6845bors[bot]2020-12-122-1/+34
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6845: Don't HirDisplay unknown types when displaying for source r=Veykril a=Veykril Was wondering why the add missing impl assist didn't do anything here: ![Code_JCA1Qo0V9P](https://user-images.githubusercontent.com/3757771/101990300-7af44a80-3ca6-11eb-8431-e5eb4de4e78c.png) Turns out me forgetting to set the Index::Idx type in the trait causes RA to panic due to it trying to to create an unparsable type in the `make` module. Now we get this instead which imo is definitely better to have. ![Code_MUFPJUCULY](https://user-images.githubusercontent.com/3757771/101990347-c9094e00-3ca6-11eb-9c6a-146bddf64b7c.png) Co-authored-by: Lukas Wirth <[email protected]>
| * | Don't HirDisplay unknown types when displaying for sourceLukas Wirth2020-12-122-1/+34
| | |
* | | Merge #6846bors[bot]2020-12-1210-10/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6846: Remove some redundant allocations r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | | Remove some redundant allocationsJeremy Kolb2020-12-1210-10/+9
|/ / /
* | | Merge #6818bors[bot]2020-12-1216-96/+249
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6818: Add Lifetimes to the HIR r=matklad a=Veykril This doesn't handle resolve yet as I don't know yet how that will be used. I'll get to that once I start moving the lifetime reference PR to the hir. This also adds a new `hir` name type for lifetimes and labels, `hir::LifetimeName`. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Add Lifetimes to the HIRLukas Wirth2020-12-1116-96/+249
| | |/ | |/|
* | | Merge #6841bors[bot]2020-12-121-0/+10
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6841: Added "Remove this semicolon" test r=matklad a=ivan770 Closes https://github.com/rust-analyzer/rust-analyzer/pull/6769#discussion_r540150066 Co-authored-by: ivan770 <[email protected]>
| * | | Added remove this semicolon testivan7702020-12-121-0/+10
|/ / /
* | | Merge #6839bors[bot]2020-12-122-4/+74
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6839: Infer labeled blocks r=flodiebold a=Veykril The test should cover all the interesting cases I believe(main part of it is copied from the loop label break test above it). The test is indented to stay consistent with the rest of the tests in the file, I can dedent all the tests in the file in a follow up PR if desired. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Infer labeled blocksLukas Wirth2020-12-112-4/+74
| | |/ | |/|
* | | Merge #6813bors[bot]2020-12-112-6/+39
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6813: negative sign matching in mbe matching for literal r=edwin0cheng a=edwin0cheng Fix #6292 r @jonas-schievink Co-authored-by: Edwin Cheng <[email protected]>
| * | | Add missing arg for eat_charEdwin Cheng2020-12-111-3/+3
| | | |
| * | | negative sign matching in mbe matching for literalEdwin Cheng2020-12-112-6/+39
| | |/ | |/|
* | | Merge #6838bors[bot]2020-12-111-8/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6838: cargo update r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | cargo updatekjeremy2020-12-111-8/+8
|/ / /
* | | Merge #6836bors[bot]2020-12-112-25/+29
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 6836: Use Attrs::docs in NavigationTarget instead of DocCommentsOwner r=kjeremy a=Veykril That should be the last place where the AST comment machinery is referred to. Co-authored-by: Lukas Wirth <[email protected]>
| * | Use Attrs::docs in NavigationTarget instead of DocCommentsOwnerLukas Wirth2020-12-112-25/+29
|/ /
* | Merge #6834bors[bot]2020-12-112-12/+12
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6834: Use Attrs::docs in runnables instead of DocCommentsOwner r=kjeremy a=Veykril I figured that we should probably move as much of the doc usage to the HIR as possible hence this PR. If we should keep this AST-based feel free to close. This change does have the nice(but not really useful as I doubt anyones gonna write doc tests like these) side effect that these two doc string snippets allow being run now. ![image](https://user-images.githubusercontent.com/3757771/101945607-bf241400-3bee-11eb-96ce-ccae80028b1f.png) ![image](https://user-images.githubusercontent.com/3757771/101946375-2e9a0380-3bef-11eb-9950-e35168fdd048.png) Co-authored-by: Lukas Wirth <[email protected]>
| * | Use Attrs::docs in runnables instead of DocCommentsOwnerLukas Wirth2020-12-112-12/+12
| | |
* | | Merge #6832bors[bot]2020-12-111-0/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6832: Add upstream commit to builtin_attr.rs r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | Add upstream commit to builtin_attr.rsJonas Schievink2020-12-111-0/+2
|/ / /
* | | Merge #6819bors[bot]2020-12-112-0/+429
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6819: Add builtin attributes for use in nameres r=jonas-schievink a=jonas-schievink These are not yet used, but have to go through nameres later in order to support procedural macro attributes Co-authored-by: Jonas Schievink <[email protected]>
| * | | Add builtin attributes for use in nameresJonas Schievink2020-12-112-0/+429
| | | |
* | | | Merge #6830bors[bot]2020-12-115-37/+29
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6830: Avoid panic when collecting memory metrics r=jonas-schievink a=jonas-schievink This is getting hit during metrics collection. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | metrics: go back to `cmd!`Jonas Schievink2020-12-111-6/+3
| | | | |
| * | | | Move print_memory_usage to cli.rsJonas Schievink2020-12-114-32/+26
| | | | |
| * | | | Avoid panic when collecting memory metricsJonas Schievink2020-12-111-1/+2
| | | | |
* | | | | Merge #6829bors[bot]2020-12-111-1/+1
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6829: Fix typo leading to metrics loss r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Fix typo leading to metrics lossJonas Schievink2020-12-111-1/+1
| | | | |
* | | | | Merge #6828bors[bot]2020-12-111-1/+6
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6828: Metrics debugging r=jonas-schievink a=jonas-schievink Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Capture memory usage metricsJonas Schievink2020-12-111-1/+6
|/ / / /
* | | | Merge #6827bors[bot]2020-12-111-3/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6827: Revert "Fix memory usage metrics" r=jonas-schievink a=jonas-schievink Reverts rust-analyzer/rust-analyzer#6825 It broke metrics entirely. Will debug this later, unless someone else gets to it first. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Revert "Fix memory usage metrics"Jonas Schievink2020-12-111-3/+1
|/ / / /
* | | | Merge #6824bors[bot]2020-12-111-0/+16
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6824: Don't highlight parent nodes of comments on hover r=kjeremy a=Veykril Fixes #6815 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Don't highlight parent nodes of comments on hoverLukas Wirth2020-12-111-0/+16
| | |/ / | |/| |
* | | | Merge #6825bors[bot]2020-12-111-1/+3
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6825: Fix memory usage metrics r=jonas-schievink a=jonas-schievink Let's see if this fixes https://github.com/rust-analyzer/rust-analyzer/issues/6808 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | Fix memory usage metricsJonas Schievink2020-12-111-1/+3
| |/ /
* | | Merge #6821bors[bot]2020-12-112-25/+23
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 6821: Improve code structure r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Improve code structureAleksey Kladov2020-12-112-25/+23
|/ / | | | | | | | | Make sure that there's only one entry point, analyze, remove awkard analyzer2 name
* | Merge #6816bors[bot]2020-12-112-136/+18
|\ \ | |/ |/| | | | | | | | | | | | | 6816: Use natural trait ordering in derive completion r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Use natural trait ordering in derive completionAleksey Kladov2020-12-112-136/+18
|/ | | | | | | | derive(Clone, Copy) reads better than derive(Copy, Clone). However, we preserve the reverse ordering in the lookup text for sorting purposes. That way, it's convenient to type just `Ord` to derive everything.
* Merge #6807bors[bot]2020-12-103-0/+41
|\ | | | | | | | | | | | | | | | | | | 6807: Replicate Cargo environment variables r=jonas-schievink a=jonas-schievink These might be relied on by procedural macros, and can also be accessed via `env!`. Required for fixing https://github.com/rust-analyzer/rust-analyzer/issues/6696. We do not yet propagate these to any proc macros though. Co-authored-by: Jonas Schievink <[email protected]>
| * Use itertoolsJonas Schievink2020-12-103-3/+5
| |
| * Replicate Cargo environment variablesJonas Schievink2020-12-101-0/+39
| |
* | Merge #6804bors[bot]2020-12-101-3/+9
|\ \ | |/ |/| | | | | | | | | | | | | | | 6804: Bump the macro token limit r=jonas-schievink a=jonas-schievink Should fix https://github.com/rust-analyzer/rust-analyzer/issues/6504 Not entirely sure what the previous limit was based on, but it looks like it does get hit in practice. Co-authored-by: Jonas Schievink <[email protected]>