aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #5668bors[bot]2020-08-051-5/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5668: Fix relative path handling for custom rustfmt r=matklad a=matklad `current_dir` and relative paths to executables works differently on unix and windows (unix behavior does not make sense), see: https://github.com/oconnor663/duct.rs/blob/17e30e83a16b202551df4d70d0b2cc174cb53e5d/src/lib.rs#L295-L324 The original motivation to set cwd was to make rustfmt read the correct rustfmt.toml, but that was future proofing, rather than a bug fix. So, let's just remove this and see if breaks or fixes more use-cases. If support for per-file config is needed, we could use `--config-path` flag. bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix relative path handling for custom rustfmtAleksey Kladov2020-08-051-5/+0
|/ | | | | | | | | | | | | | | | `current_dir` and relative paths to executables works differently on unix and windows (unix behavior does not make sense), see: https://github.com/oconnor663/duct.rs/blob/17e30e83a16b202551df4d70d0b2cc174cb53e5d/src/lib.rs#L295-L324 The original motivation to set cwd was to make rustfmt read the correct rustfmt.toml, but that was future proofing, rather than a bug fix. So, let's just remove this and see if breaks or fixes more use-cases. If support for per-file config is needed, we could use `--config-path` flag.
* Merge #5658bors[bot]2020-08-042-1/+44
|\ | | | | | | | | | | | | | | | | | | 5658: do not add to `pub use` in assists that insert a use statement r=jonas-schievink a=jbr closes #5657 , see issue for rationale Initially I wrote a version of this that changed the signature of `insert_use_statement` to take an `Option<VisibilityKind>` and only add to use statements with the same visibility, but that didn't make sense for any of the current uses of `insert_use_statement` (they all expected private visibility). Co-authored-by: Jacob Rothstein <[email protected]>
| * do not add to `pub use` statementsJacob Rothstein2020-08-032-1/+44
| |
* | Merge #5659bors[bot]2020-08-042-31/+23
|\ \ | |/ |/| | | | | | | | | | | | | 5659: Revert LineIndex optimizations to fix #5656 r=matklad a=lazear This PR reverts the changes from https://github.com/rust-analyzer/rust-analyzer/pull/5532, which was causing issues as described in https://github.com/rust-analyzer/rust-analyzer/issues/5656 Co-authored-by: Michael Lazear <[email protected]>
| * Revert "Restore line index micro-optimization"Michael Lazear2020-08-032-31/+23
|/ | | | This reverts commit 83a87fcd11298d8de32801ac6496ddf8b4e9c0e1.
* Merge #5653bors[bot]2020-08-031-1/+22
|\ | | | | | | | | | | | | | | 5653: Fold trait declarations r=SomeoneToIgnore a=lnicola Fixes #5652 Co-authored-by: Laurențiu Nicola <[email protected]>
| * Fold trait declarationsLaurențiu Nicola2020-08-031-1/+22
| |
* | Merge #5628bors[bot]2020-08-032-2/+2
|\ \ | |/ |/| | | | | | | | | | | 5628: Rename test modules r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * Rename test modulesLaurențiu Nicola2020-07-312-2/+2
| |
* | Tweak style wordingAleksey Kladov2020-08-021-6/+7
| |
* | reorg docsAleksey Kladov2020-08-022-268/+263
| |
* | Merge #5638bors[bot]2020-08-012-24/+27
|\ \ | | | | | | | | | | | | | | | | | | | | | 5638: Simplify argument parsing r=matklad a=lnicola and use `Display` when printing errors. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Simplify argument parsingLaurențiu Nicola2020-08-012-24/+27
| | |
* | | Merge #5642bors[bot]2020-08-0137-151/+150
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5642: Grammar updates r=matklad a=matklad bors r+ Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Update grammarAleksey Kladov2020-08-0137-151/+150
|/ / /
* | | Merge #5635bors[bot]2020-08-013-118/+22
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5635: Better JSON serialization in metrics r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Better JSON serialization in metricsAleksey Kladov2020-08-013-118/+22
|/ /
* | Merge #5634bors[bot]2020-07-315-17/+37
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5634: Finish rename r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Finish renameAleksey Kladov2020-07-311-3/+3
| | |
| * | Unify naming of tuple fieldsAleksey Kladov2020-07-315-14/+14
| | |
| * | Section headersAleksey Kladov2020-07-311-0/+20
|/ /
* | Merge #5633bors[bot]2020-07-3114-55/+55
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5633: Rename DotDotPat -> RestPat r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Rename DotDotPat -> RestPatAleksey Kladov2020-07-3114-55/+55
|/ /
* | Merge #5632bors[bot]2020-07-3111-22/+19
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 5632: Cleanup impl gramamr r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | RenameAleksey Kladov2020-07-318-15/+12
| | |
| * | Simplify trait gramamrAleksey Kladov2020-07-313-7/+7
| | |
* | | Merge #5631bors[bot]2020-07-31121-837/+829
|\| | | | | | | | | | | | | | | | | | | | | | | | | | 5631: Finalize pattern grammar r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Rename BindPat -> IdentPatAleksey Kladov2020-07-3183-273/+277
| | |
| * | Rename PalceholderPat -> WildcardPatAleksey Kladov2020-07-3150-135/+132
| | |
| * | ReorderAleksey Kladov2020-07-313-19/+18
| | |
| * | Allign RecordPat with RecordExprAleksey Kladov2020-07-3122-85/+78
| | |
| * | Minor gramamr reorderAleksey Kladov2020-07-312-388/+387
|/ /
* | Merge #5630bors[bot]2020-07-312-27/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5630: Remove dead code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Remove dead codeAleksey Kladov2020-07-312-27/+0
| | |
* | | Merge #5629bors[bot]2020-07-3141-654/+716
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5629: Finalize Path grammar r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Fix leading colonAleksey Kladov2020-07-312-2/+3
| | | |
| * | | Fix const arguments grammarAleksey Kladov2020-07-314-263/+263
| | | |
| * | | Fix GenericArgs grammarAleksey Kladov2020-07-314-50/+107
| | | |
| * | | fixup! Finalize Path grammarAleksey Kladov2020-07-311-1/+1
| | | |
| * | | Rename TypeArgList -> GenericArgListAleksey Kladov2020-07-3141-70/+70
| | | |
| * | | Finalize Path grammarAleksey Kladov2020-07-312-473/+477
| | | |
* | | | Merge #5627bors[bot]2020-07-312-1/+8
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5627: Specify literal tokens r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Specify literal tokensAleksey Kladov2020-07-312-1/+8
| | | |
* | | | Merge #5626bors[bot]2020-07-314-79/+68
|\| | | | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 5626: Minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | MinorAleksey Kladov2020-07-314-79/+68
|/ /
* | Merge #5625bors[bot]2020-07-311-0/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5625: Document crates.io deps policy r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Document crates.io deps policyAleksey Kladov2020-07-311-0/+6
| | |
* | | Merge #5624bors[bot]2020-07-3119-848/+894
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 5624: Finalize expressions grammar r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Rename LambdaExpr -> ClosureExprAleksey Kladov2020-07-3119-54/+59
| | |