aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Also replace the associated types with iterKirill Bulatov2020-10-102-12/+19
|
* Add a testKirill Bulatov2020-10-101-23/+39
|
* Merge #5858bors[bot]2020-10-104-61/+138
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5858: Draft: Show reason for failed rename refactoring r=rherrmann a=rherrmann Return an error with a meaningful message for requests to `textDocument/rename` if the operation cannot be performed. Pass errors, raised by rename handling code to the LSP runtime. As a consequence, the VS Code client shows and logs the request as if a server-side programming error occured. Screenshot of a rename error showing in VS Code ![invalid-rename-ui](https://user-images.githubusercontent.com/607182/91059560-2c08a380-e62a-11ea-9297-f092db935a3b.png) I would kindly ask to get feedback from the maintainers if they can spare the time: * Is the general direction of the proposed changes acceptable? * I'm new to Rust. The code feels clumsy and redundant, please suggest improvements if you find the time for. E.g. is there a simple replacement for `RenameError`? * Should presenting the error with proper severity (i.e. not as a programming error) be part of this change or in a followup change? See https://github.com/rust-analyzer/rust-analyzer/issues/3981 Co-authored-by: Rüdiger Herrmann <[email protected]>
| * Show reason for failed rename refactoringRüdiger Herrmann2020-10-104-61/+138
|/ | | | | | | | | | | Return an error with a meaningful message for requests to `textDocument/rename` if the operation cannot be performed. Pass errors raised by rename handling code to the LSP runtime. As a consequence, the VS Code client shows and logs the request as if a server-side programming error occured. Resolves https://github.com/rust-analyzer/rust-analyzer/issues/3981
* Merge #6176bors[bot]2020-10-101-0/+2
|\ | | | | | | | | | | | | | | 6176: add eprintln in fmt-like postfix r=SomeoneToIgnore a=bnjjj Co-authored-by: Benjamin Coenen <[email protected]>
| * add eprintln in fmt-like postfixBenjamin Coenen2020-10-081-0/+2
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #6187bors[bot]2020-10-091-12/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | 6187: Remove release build overrides r=jonas-schievink a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Remove release build overridesLaurențiu Nicola2020-10-091-12/+0
| | |
* | | Merge #6189bors[bot]2020-10-093-15/+47
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6189: adt: correctly inherit field visibility from enum r=jonas-schievink a=jonas-schievink Previously, "find all references" on a variant field wouldn't find any references outside the defining module. This is because variant fields were incorrectly assumed to be private, like struct fields without explicit visibility, but they actually inherit the enum's visibility. bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | adt: correctly inherit field visibility from enumJonas Schievink2020-10-093-15/+47
|/ / / | | | | | | | | | | | | | | | | | | Previously, "find all references" on a variant field wouldn't find any references outside the defining module. This is because variant fields were incorrectly assumed to be private, like struct fields without explicit visibility, but they actually inherit the enum's visibility.
* | | Merge #6188bors[bot]2020-10-092-43/+119
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 6188: Treat `ast::Name` in field patterns as use r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | Treat `ast::Name` in field patterns as useJonas Schievink2020-10-092-43/+119
|/ /
* | Merge #6185bors[bot]2020-10-091-2/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | 6185: Add note if RUST_SRC_PATH is likely to be wrong r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | Update crates/project_model/src/sysroot.rsJonas Schievink2020-10-091-1/+1
| | | | | | | | | Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Add note if RUST_SRC_PATH is likely to be wrongJonas Schievink2020-10-091-2/+8
|/ /
* | Merge #6181bors[bot]2020-10-092-0/+21
|\ \ | |/ |/| | | | | | | | | | | 6181: Fix source_to_def for named enum variant fields r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * Fix source_to_def for named enum variant fieldsJonas Schievink2020-10-092-0/+21
|/
* Merge #6173bors[bot]2020-10-084-30/+38
|\ | | | | | | | | | | | | | | 6173: Bump rustc_lexer, cfg-if to 1.0 and add new license to check r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * Bump rustc_lexer, cfg-if to 1.0 and add new license to checkkjeremy2020-10-084-30/+38
|/
* Merge #5651bors[bot]2020-10-086-1/+40
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5651: Add track_env_var to the proc macro server r=kjeremy a=lnicola See https://github.com/rust-lang/rust/pull/74653. Fixes #6054. Fixes #5640, maybe. Should be merged when 1.47 is released. Proc macros still don't work for me, but it no longer crashes. Co-authored-by: Laurențiu Nicola <[email protected]>
| * Add track_env_var to the proc macro serverLaurențiu Nicola2020-10-086-1/+40
| |
* | Merge #6161bors[bot]2020-10-075-12/+28
|\ \ | | | | | | | | | | | | | | | | | | | | | 6161: Bump chalk to use latest git to get upstream fix r=jonas-schievink a=Ameobea * Chalk very recently (like an hour ago) merged a fix that prevents rust analyzer from panicking. This allows it to be usable again for code that hits those situations. See #6134, #6145, Probably #6120 Co-authored-by: Casey Primozic <[email protected]>
| * | Switch from git to latest tagged release of chalk depsCasey Primozic2020-10-072-11/+15
| | |
| * | Make unimplemented match variants explicitCasey Primozic2020-10-071-1/+2
| | |
| * | `todo!()` -> `unimplemented!() // FIXME` for CICasey Primozic2020-10-062-3/+5
| | |
| * | Bump chalk to use latest git to get fixCasey Primozic2020-10-065-16/+25
| | | | | | | | | | | | * Chalk very recently (like an hour ago) merged a fix that prevents rust analyzer from panicking. This allows it to be usable again for code that hits those situations. See #6134, #6145, Probably #6120
* | | Merge #6154bors[bot]2020-10-075-56/+295
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6154: Shorten type hints for std::iter Iterators r=SomeoneToIgnore a=Veykril Fixes #3750. This re-exports the `hir_expand::name::known` module to be able to fetch the `Iterator` and `iter` names. I'm not sure if there is anything to do with `Solution::Ambig` in `normalize_trait_assoc_type` or whether discarding those results is always wanted. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Clean up inlay_hintsLukas Wirth2020-10-072-19/+26
| | | |
| * | | Shorten iterator hints for std::iter iterators behind referencesLukas Wirth2020-10-072-3/+5
| | | |
| * | | Shorten iterator chain hintsLukas Wirth2020-10-072-43/+115
| | | |
| * | | Move IntoIterator into FamousDefsLukas Wirth2020-10-072-31/+20
| | | |
| * | | Use FamousDefs for shorten_iterator hintLukas Wirth2020-10-062-69/+85
| | | |
| * | | Shorten type hints for std::iter IteratorsLukas Wirth2020-10-064-9/+162
| | | |
* | | | minorAleksey Kladov2020-10-071-1/+1
| | | |
* | | | Merge #6167bors[bot]2020-10-071-178/+210
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6167: Add comparisons guideline to style r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | minorAleksey Kladov2020-10-071-11/+11
| | | | |
| * | | | Add comparisons guideline to styleAleksey Kladov2020-10-071-0/+27
| | | | |
| * | | | Reorg styleAleksey Kladov2020-10-071-176/+181
|/ / / /
* | | | Merge #6166bors[bot]2020-10-072-4/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6166: Better progress API r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Better progress APIAleksey Kladov2020-10-072-4/+9
|/ / / / | | | | | | | | | | | | | | | | | | | | Percentage is a UI concern, the physical fact here is fraction. It's sad that percentage bleeds into the protocol level, we even duplicated this bad API ourselves!
* | | | Merge #6165bors[bot]2020-10-072-22/+23
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6165: Cleanup r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | CleanupAleksey Kladov2020-10-072-22/+23
|/ / / /
* | | | Merge #6158bors[bot]2020-10-071-5/+33
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6158: Fix for negative literals in macros r=matklad a=cutsoy _This pull request fixes #6028._ When writing `-42.0f32` in Rust, it is usually parsed as two different tokens (a minus operator and a float literal). But a procedural macro can also generate new tokens, including negative [float literals](https://doc.rust-lang.org/stable/proc_macro/struct.Literal.html#method.f32_suffixed): ```rust #[proc_macro] fn example_verbose(input: TokenStream) -> TokenStream { let literal = Literal::f32_suffixed(-42.0); quote! { #literal } } ``` or even shorter ```rust #[proc_macro] fn example(input: TokenStream) -> TokenStream { let literal = -42.0f32; quote! { #literal } } ``` Unfortunately, these currently cause RA to crash: ``` thread '<unnamed>' panicked at 'Fail to convert given literal Literal { text: "-42.0f32", id: TokenId( 4294967295, ), }', crates/mbe/src/subtree_source.rs:161:28 ``` This pull request contains both a fix 8cf9362 and a unit test 27798ee. In addition, I installed the patched server with `cargo xtask install --server` and verified in VSCode that it no longer crashes when a procedural macro returns a negative number literal. Co-authored-by: Tim <[email protected]>
| * | | | Added unit test for negative number literals in macros.Tim2020-10-061-0/+21
| | | | |
| * | | | Fixed parsing of negative number literals in macros.Tim2020-10-061-5/+12
| | |/ / | |/| |
* | | | Merge #6160bors[bot]2020-10-075-1/+448
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6160: Add validation check for ambiguous trait objects r=matklad a=Veykril Fixes #285. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Add validation check for ambiguous trait objectsLukas Wirth2020-10-065-1/+448
| | | | |
* | | | | Merge #6159bors[bot]2020-10-071-0/+17
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6159: Document "*.mutable" trick in manual r=matklad a=stanciuadrian Closes #5803. Co-authored-by: Adrian Stanciu <[email protected]>
| * | | | Update manual.adocAdrian Stanciu2020-10-061-0/+17
|/ / / /
* | | | Merge #6128bors[bot]2020-10-061-4/+25
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6128: Trim all trailing whitespace in onEnter r=matklad a=repnop Fixes #5848 Co-authored-by: Wesley Norris <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 18:48:28 +0000