aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge #7812bors[bot]2021-02-285-40/+60
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7812: Use consistent naming for assist r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Use consistent naming for assistAleksey Kladov2021-02-284-39/+39
| | | | |
| * | | | Don't spam loop-rewriting assistAleksey Kladov2021-02-282-2/+22
|/ / / / | | | | | | | | | | | | The more focused the assist, the better!
* | | | Merge #7809bors[bot]2021-02-281-6/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7809: Delete old issues from GitHub's bug report template r=lnicola a=saruman9 Co-authored-by: saruman9 <[email protected]>
| * | | | Delete old issues from GitHub's bug report templatesaruman92021-02-281-6/+3
|/ / / /
* | | | Merge #7804bors[bot]2021-02-2813-419/+270
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7804: Introduce TypeCtor::Scalar r=lnicola a=Veykril `TypeCtor::Int(..) | TypeCtor::Float(..) | TypeCtor::Char | TypeCtor::Bool` => `TypeCtor::Scalar(..)`, in this case we can actually just straight up use `chalk_ir::Scalar` already since its just a POD without any IDs or anything. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Use chalk_ir::Scalar directlyLukas Wirth2021-02-286-197/+78
| | | |
| * | | Introduce TypeCtor::ScalarLukas Wirth2021-02-2813-380/+350
| | | |
* | | | Merge #7808bors[bot]2021-02-281-17/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7808: Fix assert split exprs on comma r=edwin0cheng a=edwin0cheng bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * | | | Fix assert split exprs on commaEdwin Cheng2021-02-281-17/+2
| | | | |
* | | | | Merge #7807bors[bot]2021-02-281-0/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7807: Directly link changelog from quick-links section in 'README.md' file r=matklad a=regexident Co-authored-by: Vincent Esche <[email protected]>
| * | | | | Directly link changelog from quick-links section in 'README.md' fileVincent Esche2021-02-281-0/+1
| | | | | |
* | | | | | Merge #7806bors[bot]2021-02-284-8/+8
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7806: Fixed remaining references to `AnalysisChange` (now: `Change`) r=matklad a=regexident (The type was renamed/moved in 8716c4cec3a05ba891b20b5f28df69d925b913ad) Co-authored-by: Vincent Esche <[email protected]>
| * | | | | Fixed remaining references to `AnalysisChange` (now: `Change`)Vincent Esche2021-02-284-8/+8
|/ / / / / | | | | | | | | | | | | | | | (The type was renamed/moved in 8716c4cec3a05ba891b20b5f28df69d925b913ad)
* | | | | Merge #7805bors[bot]2021-02-288-109/+209
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7805: For unresolved macros, hightlight only the last segment r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | For unresolved macros, hightlight only the last segmentAleksey Kladov2021-02-288-109/+209
|/ / / /
* | | | Merge #7803bors[bot]2021-02-282-1/+24
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7803: Fix non-latin characters doc comment in mbe expansion r=edwin0cheng a=edwin0cheng Fixes #7781 ![Peek 2021-02-28 13-47](https://user-images.githubusercontent.com/11014119/109409237-f58e5580-79cb-11eb-92ed-a6700bbe39b5.gif) Off-topic: This is a [beautiful poem](http://chinesepoetryinenglishverse.blogspot.com/2013/12/blog-post_4784.html) from by Li Shangyin. bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * | | | Fix non-latin characters doc comment for mbeEdwin Cheng2021-02-282-1/+24
|/ / / /
* | | | Merge #7802bors[bot]2021-02-285-89/+144
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7802: Fix builtin macros split exprs on comma r=edwin0cheng a=edwin0cheng Fixes #7640 bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * | | | Fix builtin macros split exprs on commaEdwin Cheng2021-02-285-89/+144
| | | | |
* | | | | Merge #7801bors[bot]2021-02-282-4/+46
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7801: Restrict visibilities to the containing DefMap r=jonas-schievink a=jonas-schievink Visibilities must always point into the DefMap where they are used, but in a block expression `self` resolves to the *containing* non-block module, which is in a different DefMap. Restrict visibilities accordingly, turning them into basically `pub(block)`, which Rust has no syntax for. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Restrict visibilities to the containing DefMapJonas Schievink2021-02-282-4/+46
|/ / / /
* | | | Merge #7797bors[bot]2021-02-273-82/+6411
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7797: Format generated lints and features manually r=matklad a=lnicola As `quote` and `rustfmt` leave them on a single line, which makes running `grep` in the repository quite annoying. Also removes a dead `gen_features.rs` file (`gen_lint_completions.rs` does the same thing). Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | | Remove dead gen_features codeLaurențiu Nicola2021-02-271-48/+0
| | | | |
| * | | | Format generated features manually instead of relying on rustfmtLaurențiu Nicola2021-02-272-34/+6411
| | | | |
* | | | | Merge #7566bors[bot]2021-02-276-0/+783
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7566: Add benchmark tests for mbe r=matklad a=edwin0cheng This PR add more real world tests dumped from `rust-analyzer analysis-stats .` to benchmark its performance. cc #7513 r? @matklad Co-authored-by: Edwin Cheng <[email protected]>
| * | | | | Add benchmark test for mbeEdwin Cheng2021-02-246-0/+783
| | | | | |
* | | | | | Merge #7677bors[bot]2021-02-275-64/+488
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7677: More enum matching r=yoshuawuyts a=jDomantas * Renamed existing `generate_enum_match_method` to `generate_enum_is_variant` * Added two similar assists to generate `into_` and `as_` methods. * Made all of them general enough to work on record and tuple variants too. For `as_` method generation there's room to improve: * Right now it always returns `Option<&Field>`, even though `Option<Field>` would be nicer when `Field: Copy`. I don't know how to check if the field type implements `Copy`. If given suggestions I could try to fix this in a follow-up pr. * `&String` could be replaced with `&str`, `&Box<_>` with `&_`, and probably some more. I don't know what would be a good way to do that. Closes #7604 Co-authored-by: Domantas Jadenkus <[email protected]>
| * | | | | generate try_into instead of intoDomantas Jadenkus2021-02-273-72/+96
| | | | | |
| * | | | | rename generate_enum_match_method file to match assist nameDomantas Jadenkus2021-02-272-2/+2
| | | | | |
| * | | | | move into_ and as_ generation to a separate fileDomantas Jadenkus2021-02-274-402/+340
| | | | | |
| * | | | | cargo fmtDomantas Jadenkus2021-02-271-35/+20
| | | | | |
| * | | | | add generate_enum_as_method assistDomantas Jadenkus2021-02-273-0/+154
| | | | | |
| * | | | | deduplicate someDomantas Jadenkus2021-02-271-37/+28
| | | | | |
| * | | | | add generate_enum_into_method assistDomantas Jadenkus2021-02-273-20/+275
| | | | | |
| * | | | | make generate_enum_is_method work on any variantsDomantas Jadenkus2021-02-271-18/+95
| | | | | |
| * | | | | rename existing assist to generate_enum_is_methodDomantas Jadenkus2021-02-273-11/+11
|/ / / / /
* | | | | Merge #7794bors[bot]2021-02-261-2/+24
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7794: Disable "Flip comma" assist inside a macro call r=Veykril a=greenhat Fix #7693 Disables "Flip comma" assist if called inside a macro call. Co-authored-by: Denys Zadorozhnyi <[email protected]>
| * | | | | Disable "Flip comma" assist inside a macro callDenys Zadorozhnyi2021-02-261-2/+24
|/ / / / /
* | | | | Merge #7792bors[bot]2021-02-261-3/+3
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7792: docs(ide_assists): Change remaining occurrences of importMergeBehaviour to importMergeBehavior r=lnicola a=SanchithHegde Co-authored-by: Sanchith Hegde <[email protected]>
| * | | | | docs(ide_assists): Change importMergeBehaviour to importMergeBehaviorSanchith Hegde2021-02-261-3/+3
|/ / / / /
* | | | | Merge #7786bors[bot]2021-02-252-7/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7786: bump crates r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | | bump crateskjeremy2021-02-252-7/+7
|/ / / / /
* | | | | Merge #7785bors[bot]2021-02-251-40/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7785: :arrow_up: crates r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | :arrow_up: cratesAleksey Kladov2021-02-251-40/+8
|/ / / / /
* | | | | Merge #7741bors[bot]2021-02-244-0/+327
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7741: Add convert_for_to_iter_for_each assist r=mattyhall a=mattyhall Implements one direction of #7681 I wonder if this tries to guess too much at the right thing here. A common pattern is: ```rust let col = vec![1, 2, 3]; for v in &mut col { *v *= 2; } // equivalent to: col.iter_mut().for_each(|v| *v *= 2); ``` I've tried to detect this case by checking if the expression after the `in` is a (mutable) reference and if not inserting iter()/iter_mut(). This is just a convention used in the stdlib however, so could sometimes be wrong. I'd be happy to make an improvement for this, but not sure what would be best. A few options spring to mind: 1. Only allow this for types that are known to have iter/iter_mut (ie stdlib types) 2. Try to check if iter/iter_mut exists and they return the right iterator type 3. Don't try to do this and just add `.into_iter()` to whatever is after `in` Co-authored-by: Matt Hall <[email protected]>
| * | | | Address further review commentsMatt Hall2021-02-242-51/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use known names for iter/iter_mut method (simplifies checking if the method exists * Extract code to check assist with fixtures to function
| * | | | Address review commentsMatt Hall2021-02-231-33/+125
| | | | | | | | | | | | | | | | | | | | | | | | | * Move code to build replacement into closure * Look for iter/iter_mut methods on types behind reference
| * | | | Add convert_for_to_iter_for_each assistMatt Hall2021-02-233-0/+250
| |/ / /
* | | | Merge #7719bors[bot]2021-02-248-21/+137
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7719: De Morgan's Law assist now correctly parenthesizes binary expressions. r=Veykril a=lbrande Closes #7694 by parenthesizing binary expressions that are negated. Co-authored-by: lbrande <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-25 05:37:55 +0000