aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #2772bors[bot]2020-01-092-15/+99
|\ | | | | | | | | | | | | | | | | 2772: Actually test references r=kjeremy a=kjeremy This will be a little more work when `ReferenceSearchResults` change but I think it's easier to maintain in the end. It also follows a similar pattern to navigation targets and call hierarchy. Co-authored-by: kjeremy <[email protected]> Co-authored-by: Jeremy Kolb <[email protected]>
| * visibility tweakJeremy Kolb2020-01-091-2/+2
| |
| * Actually test referenceskjeremy2020-01-082-15/+99
| |
* | Merge #2771bors[bot]2020-01-093-8/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2771: Remove the Default impl for SourceRoot r=matklad a=michalt Let's be always explicit whether we create a library (i.e., an immutable dependency) or a local `SourceRoot`, since it can have a large impact on the validation performance in salsa. (we found it the hard way recently, where the `Default` instance made it quite tricky to spot a bug) Signed-off-by: Michal Terepeta <[email protected]> Co-authored-by: Michal Terepeta <[email protected]>
| * | Remove the Default impl for SourceRootMichal Terepeta2020-01-083-8/+9
| |/ | | | | | | | | | | | | | | | | Let's be always explicit whether we create a library (i.e., an immutable dependency) or a local `SourceRoot`, since it can have a large impact on the validation performance in salsa. (we found it the hard way recently, where the `Default` instance made it quite tricky to spot a bug) Signed-off-by: Michal Terepeta <[email protected]>
* | Merge #2777bors[bot]2020-01-091-2/+3
|\ \ | |/ |/| | | | | | | | | | | 2777: Better error message r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Better error messageAleksey Kladov2020-01-091-2/+3
| | | | | | | | closes #2775
* | Merge #2769bors[bot]2020-01-081-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | 2769: Update lsp-features.md r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | Update lsp-features.mdJeremy Kolb2020-01-081-2/+2
| |/
* | Merge #2698bors[bot]2020-01-0811-15/+502
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 2698: Call Hierarchy r=kjeremy a=kjeremy Support experiment incoming and outgoing calls. Fixes #2546 Co-authored-by: Jeremy Kolb <[email protected]> Co-authored-by: kjeremy <[email protected]>
| * Move private API downkjeremy2020-01-081-15/+15
| |
| * Implement proposed CallHierarchy featureJeremy Kolb2020-01-0811-15/+502
|/ | | | See: https://github.com/microsoft/vscode-languageserver-node/blob/master/protocol/src/protocol.callHierarchy.proposed.ts
* Merge #2738bors[bot]2020-01-083-18/+100
|\ | | | | | | | | | | | | | | 2738: [Draft] Adds a way to limits reference search by StructLiteral r=matklad a=mikhail-m1 first draft for #2549 Co-authored-by: Mikhail Modin <[email protected]>
| * Adds a way to limits reference search by StructLiteralMikhail Modin2020-01-083-18/+100
|/
* Merge pull request #2762 from edwin0cheng/fix-2759Aleksey Kladov2020-01-081-11/+25
|\ | | | | Reject tuple index for missing fields assist
| * Proper emit diagnostic without fixEdwin Cheng2020-01-071-19/+25
| |
| * Reject tuple index for missing fields assistEdwin Cheng2020-01-071-0/+8
| |
* | Merge #2763bors[bot]2020-01-082-6/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | 2763: :arrow_up: pico-args r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | :arrow_up: pico-argsAleksey Kladov2020-01-082-6/+6
|/ /
* | Merge pull request #2760 from edwin0cheng/fix-descend-into-macrosAleksey Kladov2020-01-071-2/+3
|\ \ | | | | | | Use src node for analyze source in `descend_into_macros`
| * | Use src node for analyze sourceEdwin Cheng2020-01-071-2/+3
| |/
* | Merge pull request #2761 from matklad/cachingAleksey Kladov2020-01-071-1/+15
|\ \ | | | | | | Try to restore caching on CI
| * | More tenacious CI networkingAleksey Kladov2020-01-071-0/+2
| | |
| * | Try to restore caching on CIAleksey Kladov2020-01-071-1/+13
| | |
* | | Merge #2758bors[bot]2020-01-071-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2758: Add "code-oss" Visual Studio Code binary name r=matklad a=leo-lb When Visual Studio Code is manually compiled from the upstream source tree the binary is named "code-oss". Co-authored-by: leo-lb <[email protected]>
| * | | Add "code-oss" Visual Studio Code binary nameleo-lb2020-01-071-1/+1
| | | | | | | | | | | | | | | | When Visual Studio Code is manually compiled from the upstream source tree the binary is named "code-oss".
* | | | Merge pull request #2756 from matklad/retasksAleksey Kladov2020-01-075-44/+71
|\ \ \ \ | |/ / / |/| / / | |/ / :arrow_up: crates
| * | Fix back compatAleksey Kladov2020-01-071-0/+1
| | |
| * | :arrow_up: cratesAleksey Kladov2020-01-071-22/+21
| | |
| * | Share cache cleaning logic between OSesAleksey Kladov2020-01-073-22/+49
| | |
* | | Merge #2755bors[bot]2020-01-076-371/+344
|\| | | | | | | | | | | | | | | | | | | | | | | 2755: Cleanup r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | CleanupAleksey Kladov2020-01-073-7/+7
| | |
| * | Move cmd to a separate dirAleksey Kladov2020-01-072-53/+58
| | |
| * | Refactor xtasksAleksey Kladov2020-01-075-281/+290
| | |
| * | SimplifyAleksey Kladov2020-01-072-45/+4
| |/ | | | | | | help for internal tools does not worth the duplication
* | Merge #2754bors[bot]2020-01-071-1/+4
|\ \ | |/ |/| | | | | | | | | | | 2754: Fix panic in tuple fields r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix panic in tuple fieldsAleksey Kladov2020-01-071-1/+4
|/
* Merge pull request #2725 from kiljacken/actions-matrixAleksey Kladov2020-01-072-3/+35
|\ | | | | Run tests on ubuntu, windows and macos
| * Add missing comma and use double-quotes to bors.tomlEmil Lauridsen2020-01-051-3/+3
| |
| * Rename old toolchains on windows to speedup installationEmil Lauridsen2020-01-031-2/+6
| |
| * Remove rust-docs on Windows before updating to latest stableEmil Lauridsen2020-01-031-0/+4
| |
| * Update bors.tomlEmil Lauridsen2020-01-031-1/+6
| |
| * Blindfolded PowerShell codingEmil Lauridsen2020-01-031-1/+17
| |
| * Run tests on ubuntu, windows and macosEmil Lauridsen2020-01-031-1/+4
| |
* | Merge #2724bors[bot]2020-01-069-21/+123
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2724: Improve const generic parsing r=matklad a=mchesser Add support for generic arguments in: `impl` type parameters: ```rust impl<const N: u32> Bar<N> {} ``` type args: ```rust type A = B<1, { 2 }>; test::<10>(); ``` Co-authored-by: Michael Chesser <[email protected]>
| * | Improve const generics parsingMichael Chesser2020-01-069-21/+123
|/ / | | | | | | | | - Handle const generics type args - Fix issue with const generic as first parameter in trait impl
* | Merge #2753bors[bot]2020-01-061-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2753: Fix a problem with `Durability` of libraries r=matklad a=michalt When processing a change with added libraries, we used `Default::default` for `SourceRoot` which sets `is_library` to false. Since we use `is_library` to decide whether to use low or high durability, I believe that this caused us to mark many library dependencies as having low durability and thus increased the size of the graph that salsa needed to verify on every change. Based on my initial tests this speeds up the `CrateDefMapQuery` on rust-analyzer from about ~64ms to ~14ms and reduces the number of validations for the query from over 60k to about 7k. Signed-off-by: Michal Terepeta <[email protected]> Co-authored-by: Michal Terepeta <[email protected]>
| * | Fix a problem with `Durability` of librariesMichal Terepeta2020-01-061-1/+1
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | When processing a change with added libraries, we used `Default::default` for `SourceRoot` which sets `is_library` to false. Since we use `is_library` to decide whether to use low or high durability, I believe that this caused us to mark many library dependencies as having low durability and thus increased the size of the graph that salsa needed to verify on every change. Based on my initial tests this speeds up the `CrateDefMapQuery` on rust-analyzer from about ~64ms to ~14ms and reduces the number of validations for the query from over 60k to about 7k. Signed-off-by: Michal Terepeta <[email protected]>
* | Merge #2750bors[bot]2020-01-061-0/+4
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 2750: add note in vscode instructions for vim plugin users r=matklad a=guswynn Fixes #2746 As the issue mentions, this is already mentioned below in the setting docs. However, it ended up taking me a long time to figure this out, so a note in the instructions for Vscode specifically is helpful Co-authored-by: Gus Wynn <[email protected]>
| * | add note in vscode instructions for vim plugin usersGus Wynn2020-01-051-0/+4
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 14:13:08 +0000