Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Merge #2727 | bors[bot] | 2020-01-11 | 19 | -85/+995 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2727: Qualify paths in 'add impl members' r=flodiebold a=flodiebold This makes the 'add impl members' assist qualify paths, so that they should resolve to the same thing as in the definition. To do that, it adds an algorithm that finds a path to refer to any item from any module (if possible), which is actually probably the more important part of this PR :smile: It handles visibility, reexports, renamed crates, prelude etc.; I think the only thing that's missing is support for local items. I'm not sure about the performance, since it takes into account every location where the target item has been `pub use`d, and then recursively goes up the module tree; there's probably potential for optimization by memoizing more, but I think the general shape of the algorithm is necessary to handle every case in Rust's module system. ~The 'find path' part is actually pretty complete, I think; I'm still working on the assist (hence the failing tests).~ Fixes #1943. Co-authored-by: Florian Diebold <[email protected]> Co-authored-by: Florian Diebold <[email protected]> | |||||
| * | | Use FxHashMap | Florian Diebold | 2020-01-11 | 3 | -3/+5 | |
| | | | ||||||
| * | | Apply review suggestions | Florian Diebold | 2020-01-11 | 9 | -47/+35 | |
| | | | ||||||
| * | | Fix ordering problem between qualifying paths and substituting params | Florian Diebold | 2020-01-11 | 7 | -126/+206 | |
| | | | ||||||
| * | | Some more refactoring | Florian Diebold | 2020-01-11 | 2 | -8/+16 | |
| | | | ||||||
| * | | Fix file ID when qualifying paths; add another failing test | Florian Diebold | 2020-01-11 | 1 | -3/+31 | |
| | | | ||||||
| * | | Handle type args | Florian Diebold | 2020-01-11 | 2 | -9/+19 | |
| | | | ||||||
| * | | More failing tests | Florian Diebold | 2020-01-11 | 1 | -1/+126 | |
| | | | ||||||
| * | | Qualify some paths in 'add missing impl members' | Florian Diebold | 2020-01-11 | 6 | -3/+128 | |
| | | | ||||||
| * | | Use `self` | Florian Diebold | 2020-01-11 | 1 | -0/+20 | |
| | | | ||||||
| * | | Cleanup | Florian Diebold | 2020-01-11 | 1 | -13/+25 | |
| | | | ||||||
| * | | Handle cycles | Florian Diebold | 2020-01-11 | 1 | -5/+54 | |
| | | | ||||||
| * | | Use query for importable locations | Florian Diebold | 2020-01-11 | 4 | -34/+77 | |
| | | | ||||||
| * | | Use super, don't use private imports | Florian Diebold | 2020-01-11 | 1 | -2/+48 | |
| | | | ||||||
| * | | Use shortest path | Florian Diebold | 2020-01-11 | 1 | -4/+19 | |
| | | | ||||||
| * | | handle most cases | Florian Diebold | 2020-01-11 | 2 | -11/+67 | |
| | | | ||||||
| * | | basics working | Florian Diebold | 2020-01-11 | 2 | -5/+117 | |
| | | | ||||||
| * | | more WIP | Florian Diebold | 2020-01-11 | 2 | -12/+122 | |
| | | | ||||||
| * | | find_path WIP | Florian Diebold | 2020-01-11 | 3 | -0/+58 | |
| | | | ||||||
| * | | Add test | Florian Diebold | 2020-01-11 | 1 | -0/+23 | |
| |/ | ||||||
* | | Merge #2804 | bors[bot] | 2020-01-11 | 1 | -1/+1 | |
|\ \ | |/ |/| | | | | | | | | | | | 2804: Use lsp-seq-first in ra-emacs-lsp since that's more likely to exist r=flodiebold a=flodiebold Co-authored-by: Florian Diebold <[email protected]> | |||||
| * | Use lsp-seq-first in ra-emacs-lsp since that's more likely to exist | Florian Diebold | 2020-01-11 | 1 | -1/+1 | |
|/ | ||||||
* | Merge #2800 | bors[bot] | 2020-01-11 | 1 | -3/+1 | |
|\ | | | | | | | | | | | | | | | 2800: Stick to defaulter release profile r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]> | |||||
| * | Stick to defaulter release profile | Aleksey Kladov | 2020-01-11 | 1 | -3/+1 | |
|/ | ||||||
* | Merge pull request #2798 from matklad/release-process | Aleksey Kladov | 2020-01-11 | 2 | -45/+15 | |
|\ | | | | | Tweak release workflow | |||||
| * | Tweak release workflow | Aleksey Kladov | 2020-01-11 | 1 | -41/+13 | |
| | | ||||||
| * | Don't be overly generic | Aleksey Kladov | 2020-01-11 | 2 | -6/+4 | |
| | | ||||||
* | | Merge #2791 | bors[bot] | 2020-01-11 | 4 | -4/+26 | |
|\ \ | |/ |/| | | | | | | | | | | | | | | | 2791: Slightly more robust cargo watcher root search r=kiljacken a=kiljacken Fixes #2780 (hopefully). Use the already painstakingly found `workspaces` instead of naively using `folder_roots` from editor. Co-authored-by: Emil Lauridsen <[email protected]> | |||||
| * | Clean up straggling mut | Emil Lauridsen | 2020-01-11 | 1 | -1/+1 | |
| | | ||||||
| * | Disable cargo checking in workspaces with no cargo projects | Emil Lauridsen | 2020-01-11 | 2 | -14/+20 | |
| | | ||||||
| * | Address nit | Emil Lauridsen | 2020-01-10 | 3 | -3/+7 | |
| | | ||||||
| * | Slightly more robust cargo watcher root search | Emil Lauridsen | 2020-01-10 | 2 | -4/+16 | |
| | | ||||||
* | | Merge pull request #2766 from gilescope/windows-build | Aleksey Kladov | 2020-01-11 | 3 | -2/+128 | |
|\ \ | | | | | | | Upload PR | |||||
| * | | We only want this triggering for master. | Giles Cope | 2020-01-09 | 1 | -2/+0 | |
| | | | ||||||
| * | | Reducing binary size and optimising a bit more. | Giles Cope | 2020-01-09 | 2 | -1/+3 | |
| | | | ||||||
| * | | Still double compiling. Try this. | Giles Cope | 2020-01-09 | 1 | -9/+3 | |
| | | | ||||||
| * | | Was doing the compile twice. | Giles Cope | 2020-01-09 | 1 | -1/+2 | |
| | | | ||||||
| * | | Split out into a release build as bins were not getting generated as cargo ↵ | Giles Cope | 2020-01-09 | 2 | -32/+131 | |
| | | | | | | | | | | | | build wasn't run | |||||
| * | | second attempt | Giles Cope | 2020-01-09 | 1 | -1/+1 | |
| | | | ||||||
| * | | parameterised debug | Giles Cope | 2020-01-09 | 1 | -3/+4 | |
| | | | ||||||
| * | | Packaging server bins | Giles Cope | 2020-01-09 | 1 | -2/+13 | |
| | | | ||||||
| * | | create dir if not there as cp doesn't seem to have an option to create the ↵ | Giles Cope | 2020-01-09 | 1 | -1/+1 | |
| | | | | | | | | | | | | dest dir automatically. | |||||
| * | | put as debug for now while I get it working. | Giles Cope | 2020-01-09 | 1 | -3/+3 | |
| | | | ||||||
| * | | Getting to grips with github format... | Giles Cope | 2020-01-09 | 1 | -1/+5 | |
| | | | ||||||
| * | | Less output for typescript artifacts | Giles Cope | 2020-01-09 | 1 | -2/+7 | |
| | | | ||||||
| * | | Relative adderss | Giles Cope | 2020-01-08 | 1 | -1/+1 | |
| | | | ||||||
| * | | Upload | Giles Cope | 2020-01-08 | 1 | -3/+6 | |
| | | | ||||||
| * | | noop | Giles Cope | 2020-01-08 | 1 | -0/+1 | |
| | | | ||||||
| * | | Make artifacts accessible | Giles Cope | 2020-01-08 | 1 | -0/+7 | |
| | | | ||||||
* | | | Merge #2795 | bors[bot] | 2020-01-11 | 1 | -2/+10 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2795: Use dummy value for macro file in bulitin macros r=matklad a=edwin0cheng This PR skip the actual line and column computation for `MacroFile` and return a dummy value instead. Related to #2794 Co-authored-by: Edwin Cheng <[email protected]> |