aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge #2807bors[bot]2020-01-124-2/+55
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 2807: Use attr location for builtin derive in goto-implementation r=matklad a=edwin0cheng This PR is use attribute location for builtin derive in `ImplBlock`'s NavigationTarget such that the goto-implementation will goto to a correct position. Related to #2531 Co-authored-by: Edwin Cheng <[email protected]>
| * | Add testEdwin Cheng2020-01-121-0/+12
| | |
| * | Use attr location for builtin macro goto-impEdwin Cheng2020-01-123-2/+43
| |/
* | Merge #2809bors[bot]2020-01-123-19/+55
|\ \ | |/ |/| | | | | | | | | | | 2809: Qualify paths in 'fill match arms' assist r=matklad a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * Qualify paths in 'fill match arms' assistFlorian Diebold2020-01-123-19/+55
|/
* Merge #2803bors[bot]2020-01-113-1/+100
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2803: Fix various names, e.g. Iterator not resolving in core prelude r=matklad a=flodiebold Basically, `Iterator` is re-exported via several steps, which happened to not be resolved yet when we got to the prelude import, but since the name resolved to the reexport from `core::iter` (just to no actual items), we gave up trying to resolve it further. Maybe part of the problem is that we can have `PartialResolvedImport::Unresolved` or `PartialResolvedImport::Indeterminate` with `None` in all namespaces, and handle them differently. Fixes #2683. Co-authored-by: Florian Diebold <[email protected]>
| * Fix various names, e.g. Iterator not resolving in core preludeFlorian Diebold2020-01-113-1/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | Basically, `Iterator` is re-exported via several steps, which happened to not be resolved yet when we got to the prelude import, but since the name resolved to the reexport from `core::iter` (just to no actual items), we gave up trying to resolve it further. Maybe part of the problem is that we can have `PartialResolvedImport::Unresolved` or `PartialResolvedImport::Indeterminate` with `None` in all namespaces, and handle them differently. Fixes #2683.
* | Merge #2727bors[bot]2020-01-1119-85/+995
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2727: Qualify paths in 'add impl members' r=flodiebold a=flodiebold This makes the 'add impl members' assist qualify paths, so that they should resolve to the same thing as in the definition. To do that, it adds an algorithm that finds a path to refer to any item from any module (if possible), which is actually probably the more important part of this PR :smile: It handles visibility, reexports, renamed crates, prelude etc.; I think the only thing that's missing is support for local items. I'm not sure about the performance, since it takes into account every location where the target item has been `pub use`d, and then recursively goes up the module tree; there's probably potential for optimization by memoizing more, but I think the general shape of the algorithm is necessary to handle every case in Rust's module system. ~The 'find path' part is actually pretty complete, I think; I'm still working on the assist (hence the failing tests).~ Fixes #1943. Co-authored-by: Florian Diebold <[email protected]> Co-authored-by: Florian Diebold <[email protected]>
| * | Use FxHashMapFlorian Diebold2020-01-113-3/+5
| | |
| * | Apply review suggestionsFlorian Diebold2020-01-119-47/+35
| | |
| * | Fix ordering problem between qualifying paths and substituting paramsFlorian Diebold2020-01-117-126/+206
| | |
| * | Some more refactoringFlorian Diebold2020-01-112-8/+16
| | |
| * | Fix file ID when qualifying paths; add another failing testFlorian Diebold2020-01-111-3/+31
| | |
| * | Handle type argsFlorian Diebold2020-01-112-9/+19
| | |
| * | More failing testsFlorian Diebold2020-01-111-1/+126
| | |
| * | Qualify some paths in 'add missing impl members'Florian Diebold2020-01-116-3/+128
| | |
| * | Use `self`Florian Diebold2020-01-111-0/+20
| | |
| * | CleanupFlorian Diebold2020-01-111-13/+25
| | |
| * | Handle cyclesFlorian Diebold2020-01-111-5/+54
| | |
| * | Use query for importable locationsFlorian Diebold2020-01-114-34/+77
| | |
| * | Use super, don't use private importsFlorian Diebold2020-01-111-2/+48
| | |
| * | Use shortest pathFlorian Diebold2020-01-111-4/+19
| | |
| * | handle most casesFlorian Diebold2020-01-112-11/+67
| | |
| * | basics workingFlorian Diebold2020-01-112-5/+117
| | |
| * | more WIPFlorian Diebold2020-01-112-12/+122
| | |
| * | find_path WIPFlorian Diebold2020-01-113-0/+58
| | |
| * | Add testFlorian Diebold2020-01-111-0/+23
| |/
* | Merge #2804bors[bot]2020-01-111-1/+1
|\ \ | |/ |/| | | | | | | | | | | 2804: Use lsp-seq-first in ra-emacs-lsp since that's more likely to exist r=flodiebold a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * Use lsp-seq-first in ra-emacs-lsp since that's more likely to existFlorian Diebold2020-01-111-1/+1
|/
* Merge #2800bors[bot]2020-01-111-3/+1
|\ | | | | | | | | | | | | | | 2800: Stick to defaulter release profile r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Stick to defaulter release profileAleksey Kladov2020-01-111-3/+1
|/
* Merge pull request #2798 from matklad/release-processAleksey Kladov2020-01-112-45/+15
|\ | | | | Tweak release workflow
| * Tweak release workflowAleksey Kladov2020-01-111-41/+13
| |
| * Don't be overly genericAleksey Kladov2020-01-112-6/+4
| |
* | Merge #2791bors[bot]2020-01-114-4/+26
|\ \ | |/ |/| | | | | | | | | | | | | | | 2791: Slightly more robust cargo watcher root search r=kiljacken a=kiljacken Fixes #2780 (hopefully). Use the already painstakingly found `workspaces` instead of naively using `folder_roots` from editor. Co-authored-by: Emil Lauridsen <[email protected]>
| * Clean up straggling mutEmil Lauridsen2020-01-111-1/+1
| |
| * Disable cargo checking in workspaces with no cargo projectsEmil Lauridsen2020-01-112-14/+20
| |
| * Address nitEmil Lauridsen2020-01-103-3/+7
| |
| * Slightly more robust cargo watcher root searchEmil Lauridsen2020-01-102-4/+16
| |
* | Merge pull request #2766 from gilescope/windows-buildAleksey Kladov2020-01-113-2/+128
|\ \ | | | | | | Upload PR
| * | We only want this triggering for master.Giles Cope2020-01-091-2/+0
| | |
| * | Reducing binary size and optimising a bit more.Giles Cope2020-01-092-1/+3
| | |
| * | Still double compiling. Try this.Giles Cope2020-01-091-9/+3
| | |
| * | Was doing the compile twice.Giles Cope2020-01-091-1/+2
| | |
| * | Split out into a release build as bins were not getting generated as cargo ↵Giles Cope2020-01-092-32/+131
| | | | | | | | | | | | build wasn't run
| * | second attemptGiles Cope2020-01-091-1/+1
| | |
| * | parameterised debugGiles Cope2020-01-091-3/+4
| | |
| * | Packaging server binsGiles Cope2020-01-091-2/+13
| | |
| * | create dir if not there as cp doesn't seem to have an option to create the ↵Giles Cope2020-01-091-1/+1
| | | | | | | | | | | | dest dir automatically.
| * | put as debug for now while I get it working.Giles Cope2020-01-091-3/+3
| | |