aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #4576bors[bot]2020-06-084-0/+403
|\ | | | | | | | | | | | | | | | | | | 4576: Add implementation of extract struct from enum variant r=matklad a=mcrakhman Hi guys! I implemented the extraction functionality including modifying multiple files. The only thing I didn't change the cursor position. I've done it with a previous API, but now snippets have been introduced and I need to figure out how to do it. Please bear in mind that I am a newcomer in the rust-analyzer (and also Rust) world, so I tried to implement the feature to the best of my knowledge, but the API is very new to me, so I am very welcome to introducing changes etc. Co-authored-by: Mikhail Rakhmanov <[email protected]>
| * Fix review commentsMikhail Rakhmanov2020-06-052-33/+19
| |
| * Remove unnecessary returnMikhail Rakhmanov2020-06-051-2/+2
| |
| * Remove AsName importMikhail Rakhmanov2020-06-043-8/+21
| |
| * Fixed testsMikhail Rakhmanov2020-06-033-10/+28
| |
| * Merge branch 'master' into assists_extract_enumMikhail Rakhmanov2020-06-03172-3673/+6898
| |\
| * | Fix incorrect behaviour if not resolvedMikhail Rakhmanov2020-06-031-0/+1
| | |
| * | Further refactoring under review commentsMikhail Rakhmanov2020-05-241-7/+3
| | |
| * | Remove unnecessary set_file and change variable positions for better readabilityMikhail Rakhmanov2020-05-231-2/+1
| | |
| * | Remove unwraps where possibleMikhail Rakhmanov2020-05-231-22/+11
| | |
| * | Further review fixesMikhail Rakhmanov2020-05-234-15/+12
| | |
| * | Use default instead of new in AssistDirectorMikhail Rakhmanov2020-05-231-5/+7
| | |
| * | Better naming and fix some review commentsMikhail Rakhmanov2020-05-232-15/+14
| | |
| * | More formattingMikhail Rakhmanov2020-05-221-3/+1
| | |
| * | Refactor AssistDirectorMikhail Rakhmanov2020-05-221-6/+4
| | |
| * | Formatting and remove unused importsMikhail Rakhmanov2020-05-222-16/+21
| | |
| * | Add preliminary implementation of extract struct from enum variantMikhail Rakhmanov2020-05-225-1/+403
| | |
* | | Merge #4784bors[bot]2020-06-083-40/+20
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4784: Change management of test cfg to better support json projects r=Nashenas88 a=Nashenas88 This helps support json projects where they can decide whether to add the `test` cfg or not. One alternative is to add support for marking json project crates as a sysroot crate, and adding logic to remove the `test` cfg in those cases. In my opinion, that option gives less flexibility to json projects and leads to more functionality that needs to be maintained. Fixes #4508 cc @woody77 Co-authored-by: Paul Daniel Faria <[email protected]> Co-authored-by: Paul Daniel Faria <[email protected]>
| * | | Use Option<&str> for target instead of Option<&String>Paul Daniel Faria2020-06-082-4/+4
| | | |
| * | | Remove default_cfg_options, pass target instead so it can be used for ↵Paul Daniel Faria2020-06-083-38/+19
| | | | | | | | | | | | | | | | building cargo workspaces
| * | | Change management of test cfg to better support json projectsPaul Daniel Faria2020-06-073-8/+7
| | | |
* | | | Merge #4796bors[bot]2020-06-089-15/+18
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4796: Fix unsafe highlihgintngs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Better unsafe highlihgting testsAleksey Kladov2020-06-088-9/+16
| | | | |
| * | | | Highlight only the unsafe operator itselfAleksey Kladov2020-06-081-6/+2
|/ / / /
* | | | Merge #4775bors[bot]2020-06-083-24/+57
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4775: Add goto def for enum variant field r=matklad a=unexge Closes #4764. I'm not familiar with ra codebase, there might be better ways to do that :smile: Co-authored-by: unexge <[email protected]>
| * | | | Use explicit match for extracting def from `classify_name`unexge2020-06-081-2/+5
| | | | |
| * | | | Swap `into_definition` and `definition` semantics for `FieldShorthand` variantunexge2020-06-081-2/+2
| | | | |
| * | | | Add `FieldShorthand` variant to `NameClass`unexge2020-06-083-27/+32
| | | | |
| * | | | Add goto def for enum variant fieldunexge2020-06-062-0/+25
| | | | |
* | | | | Merge #4683bors[bot]2020-06-084-46/+368
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4683: Implement syntax highlighting for doctests r=ltentrup a=ltentrup The implementation is more complicated than the previous injection logic as the doctest comments consist of multiple ranges. The implementation extracts the doctests together with an offset-mapping, applies the syntax highlighting, and updates the text ranges. <img width="478" alt="Bildschirmfoto 2020-06-01 um 15 45 25" src="https://user-images.githubusercontent.com/201808/83415249-1f0b5800-a41f-11ea-8fa6-c282434d6ff7.png"> Part of #4170. Co-authored-by: Leander Tentrup <[email protected]>
| * | | | | Implement syntax highlighting for doctestsLeander Tentrup2020-06-084-46/+368
| | | | | |
* | | | | | Merge #4794bors[bot]2020-06-083-58/+73
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4794: Tweak release r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | RefactorAleksey Kladov2020-06-082-41/+49
| | | | | | |
| * | | | | | Move to a dedicated fileAleksey Kladov2020-06-083-57/+64
|/ / / / / /
* | | | | | Merge #4773bors[bot]2020-06-086-68/+312
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4773: Run|Debug hover actions. r=matklad a=vsrs ![hover_actions_run](https://user-images.githubusercontent.com/62505555/83335644-dfc1f780-a2b6-11ea-820b-ccaa82290e7d.gif) This hover actions work exactly like corresponding lenses. Co-authored-by: vsrs <[email protected]>
| * | | | | | Apply suggestions from code reviewvsrs2020-06-083-21/+21
| | | | | | |
| * | | | | | Add lib target filtering.vsrs2020-06-061-11/+18
| | | | | | |
| * | | | | | Disable runnables lookup in macro-generated code.vsrs2020-06-061-1/+10
| | | | | | |
| * | | | | | Add Run|Debug hover actionsvsrs2020-06-066-24/+184
| | | | | | |
| * | | | | | Preliminary runnables refactoringvsrs2020-06-063-54/+122
| | |/ / / / | |/| | | |
* | | | | | Merge #4793bors[bot]2020-06-081-0/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4793: Don't @ people in commit messages r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | Don't @ people in commit messagesAleksey Kladov2020-06-081-0/+8
|/ / / / / /
* | | | | | Merge #4792bors[bot]2020-06-081-0/+27
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4792: Document more knowledge r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Preconditions styleAleksey Kladov2020-06-081-0/+20
| | | | | |
| * | | | | IDE APIAleksey Kladov2020-06-081-0/+7
|/ / / / /
* | | | | Merge #4781bors[bot]2020-06-081-32/+27
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4781: Remove redundancy in syntax highlighting tests r=matklad a=ltentrup Follow up from #4683. Improves syntax highlighting testing by introducing a function that contains the boilerplate comparison code. Keeps the `ra_fixture` argument in the first position, thus, the editor syntax highlighting injection still works. Co-authored-by: Leander Tentrup <[email protected]>
| * | | | | Remove redundancy in syntax highlighting testsLeander Tentrup2020-06-071-32/+27
| | |/ / / | |/| | |
* | | | | Merge #4770bors[bot]2020-06-086-104/+33
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4770: Clean up handling of int/float literal types r=matklad a=flodiebold 'Unknown' int/float types actually never exist as such, they get replaced by type variables immediately. So the whole `Uncertain<IntTy>` thing was unnecessary and just led to a bunch of match branches that were never hit. Co-authored-by: Florian Diebold <[email protected]>
| * | | | | Clean up handling of int/float literal typesFlorian Diebold2020-06-066-104/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'Unknown' int/float types actually never exist as such, they get replaced by type variables immediately. So the whole `Uncertain<IntTy>` thing was unnecessary and just led to a bunch of match branches that were never hit.
* | | | | | Merge #4787bors[bot]2020-06-082-15/+24
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4787: Fix bug in lexer for format specifier r=matklad a=ltentrup The `type` and `width` were not correctly distinguished. Fixes #4696. Co-authored-by: Leander Tentrup <[email protected]>