aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Document doer object anti-patternAleksey Kladov2020-11-021-0/+54
|
* Merge #6436bors[bot]2020-11-021-0/+6
|\ | | | | | | | | | | | | | | 6436: Textmate grammar: allow comments in attributes r=dustypomerleau a=dustypomerleau Fixes #6419 Co-authored-by: Dusty Pomerleau <[email protected]>
| * fix: allow comments in attributesDusty Pomerleau2020-11-021-0/+6
|/
* Merge #6423bors[bot]2020-10-311-18/+18
|\ | | | | | | | | | | | | | | 6423: cargo update r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * cargo updateJeremy Kolb2020-10-311-18/+18
|/
* Merge #6420bors[bot]2020-10-311-1/+1
|\ | | | | | | | | | | | | | | 6420: Update Cargo.toml r=flodiebold a=pksunkara This was blocking the automated publishing. Co-authored-by: Pavan Kumar Sunkara <[email protected]>
| * Update Cargo.tomlPavan Kumar Sunkara2020-10-311-1/+1
|/
* Merge #6416bors[bot]2020-10-303-58/+62
|\ | | | | | | | | | | | | | | | | 6416: Respond with JSON-RPC error if we failed to deserialize request r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Respond with JSON-RPC error if we failed to deserialize requestAleksey Kladov2020-10-303-58/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Historically, we intentinally violated JSON-RPC spec here by hard crashing. The idea was to poke both the clients and servers to fix stuff. However, this is confusing for server implementors, and falls down in one important place -- protocol extension are not always backwards compatible, which causes crashes simply due to version mismatch. We had once such case with our own extension, and one for semantic tokens. So let's be less adventerous and just err on the err side!
* | Merge #6415bors[bot]2020-10-307-329/+188
|\ \ | |/ |/| | | | | | | | | | | 6415: Upgrade Chalk to 0.36 r=flodiebold a=flodiebold Quite a few changes, because Chalk got rid of the `ApplicationTy` nesting. Co-authored-by: Florian Diebold <[email protected]>
| * Upgrade Chalk to 0.36Florian Diebold2020-10-307-329/+188
|/ | | | Quite a few changes, because Chalk got rid of the `ApplicationTy` nesting.
* Merge #6411bors[bot]2020-10-301-6/+1
|\ | | | | | | | | | | | | | | 6411: remove FIXME after rust 1.47 comes out r=lnicola a=qy3u Remove 'FIXME' after rust 1.47 comes out. And for compatibility with versions before 1.47, did't remove 'src'. Co-authored-by: yuqing <[email protected]>
| * remove FIXME after rust 1.47 comes outyuqing2020-10-301-6/+1
|/
* Merge #6403bors[bot]2020-10-291-2/+2
|\ | | | | | | | | | | | | | | 6403: docs: Update Neovim nvim-lspconfig repository link r=lnicola a=rockerBOO `nvim-lsp` updated their repository to `nvim-lspconfig` to lessen confusion about what it does. Co-authored-by: Dave Lage <[email protected]>
| * docs: Update Neovim nvim-lspconfig repository linkDave Lage2020-10-291-2/+2
|/
* Merge #6398bors[bot]2020-10-281-7/+7
|\ | | | | | | | | | | | | | | 6398: cargo update r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * cargo updatekjeremy2020-10-281-7/+7
| |
* | Merge #6396bors[bot]2020-10-281-45/+68
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 6396: refactor(hir_ty): do not override DisplayTarget in hir_fmt r=flodiebold a=bnjjj Linked to bug discovery from #6387 The main goal is to not use `display()` method inside `hir_fmt` to not override any parameters (like `DisplayTarget`). cc @flodiebold Co-authored-by: Benjamin Coenen <[email protected]>
| * refactor(hir_ty): do not override DisplayTarget in hir_fmtBenjamin Coenen2020-10-281-45/+68
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #6394bors[bot]2020-10-281-1/+1
|\ \ | |/ |/| | | | | | | | | | | | | | | 6394: Smaller inlay hints r=SomeoneToIgnore a=kjeremy This makes things a lot more readable but isn't officially supported by vscode: https://github.com/Microsoft/vscode/issues/9078 Inspired by Visual Studio, IntelliJ and Resharper. Co-authored-by: kjeremy <[email protected]>
| * Smaller inlay hintskjeremy2020-10-281-1/+1
| | | | | | | | | | | | This makes things a lot more readable but isn't officially supported by vscode: https://github.com/Microsoft/vscode/issues/9078 Inspired by Visual Studio, IntelliJ and Resharper.
* | Merge #6387bors[bot]2020-10-283-13/+72
|\ \ | |/ |/| | | | | | | | | | | | | 6387: do not use associated types placeholder for inlay hint r=flodiebold a=bnjjj close #6191 Co-authored-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-284-8/+17
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-283-60/+44
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-286-155/+108
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-282-31/+102
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hint #6191Benjamin Coenen2020-10-273-19/+61
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #6384bors[bot]2020-10-281-3/+67
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 6384: add doctest runnables on struct r=lnicola a=bnjjj I will check for how to do the same on trait implementation on another PR. #6356 Co-authored-by: Benjamin Coenen <[email protected]>
| * | add doctest runnables on struct #6356Benjamin Coenen2020-10-271-1/+1
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | add doctest runnables on struct #6356Benjamin Coenen2020-10-271-3/+67
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | Merge #6392bors[bot]2020-10-281-0/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6392: Also set textDecoration: none on inlay hints r=SomeoneToIgnore a=lnicola Closes #6380 Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Also set textDecoration: none on inlay hintsLaurențiu Nicola2020-10-281-0/+1
|/ / /
* | | Merge #6379bors[bot]2020-10-273-0/+15
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6379: Highlight never type as BuiltinType r=matklad a=Veykril Fixes #6374 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Highlight never type as BuiltinTypeLukas Wirth2020-10-263-0/+15
| | | |
* | | | Merge #6382bors[bot]2020-10-271-0/+1
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 6382: Set font-wieght: normal on inlay hints r=SomeoneToIgnore a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Set font-wieght: normal on inlay hintsLaurențiu Nicola2020-10-271-0/+1
| | | |
* | | | Merge #6383bors[bot]2020-10-271-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6383: Update client install command in dev docs r=kjeremy a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | | Update client install command in dev docsLaurențiu Nicola2020-10-271-1/+1
| |/ / /
* | | | Merge #6376bors[bot]2020-10-274-1/+26
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6376: Avoid impls_fnonce to return true when the trait solving is ambiguous r=flodiebold a=GrayJack This PR should fix #6375 This adds a variation of `method_resolution::implements_trait` called `method_resolution::implements_trait_unique`, that only returns true when the trait solving is unique, and also change `impls_fnonce` to use the later instead. I also added a test just to be sure. Co-authored-by: GrayJack <[email protected]>
| * | | Fix testGrayJack2020-10-261-158/+158
| | | |
| * | | Add test to avoid regressionGrayJack2020-10-262-153/+165
| | | |
| * | | Fix case where non FnOnce variables is marked callableGrayJack2020-10-262-1/+14
| | |/ | |/|
* | | Merge #6257bors[bot]2020-10-261-11/+11
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 6257: Don't suggest extracting out 1-tuple enum variants r=matklad a=repnop Fixes #6241. Co-authored-by: Wesley Norris <[email protected]>
| * | Don't suggest extracting out 1-tuple enum variantsWesley Norris2020-10-261-11/+11
| | | | | | | | | | | | Fixes #6241.
* | | Merge #6378bors[bot]2020-10-261-2/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6378: Better ordering of assists r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Better ordering of assistsAleksey Kladov2020-10-261-2/+3
|/ / /
* | | Merge #6351bors[bot]2020-10-2622-185/+165
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6351: Organized completions r=popzxc a=popzxc This PR continues the work on refactoring of the `completions` crate. In this episode: - Actual completions methods are encapsulated into `completions` module, so they aren't mixed with the rest of the code. - Name duplication was removed (`complete_attribute` => `completions::attribute`, `completion_context` => `context`). - `Completions` structure was moved from `item` module to the `completions`. - `presentation` module was removed, as it was basically a module with `impl` for `Completions`. - Code approaches were a bit unified here and there. Co-authored-by: Igor Aleksanov <[email protected]>
| * | Reduce visibility of some methodsIgor Aleksanov2020-10-262-3/+3
| | |
| * | Add a module doc-comment for completions moduleIgor Aleksanov2020-10-251-0/+2
| | |
| * | Remove presentation moduleIgor Aleksanov2020-10-253-1421/+1409
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-26 23:06:56 +0000