aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Changes from reviewZac Pullar-Strecker2020-08-252-18/+23
|
* Renames, comments, and dead code removalZac Pullar-Strecker2020-08-244-23/+8
|
* Merge remote-tracking branch 'upstream/master' into 503-hover-doc-linksZac Pullar-Strecker2020-08-241623-128337/+130529
|\
| * Merge #5823bors[bot]2020-08-222-8/+2
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5823: Don't underline function definition if self is &mut r=Nashenas88 a=matklad The self is right there, and is already underlined, so it makes little sense to emit even more underlines. before: ![before](https://user-images.githubusercontent.com/1711539/90672843-0d379500-e257-11ea-840f-b0caed4410f1.png) after: ![after](https://user-images.githubusercontent.com/1711539/90672840-0c9efe80-e257-11ea-9739-23af433841c6.png) Co-authored-by: Aleksey Kladov <[email protected]>
| | * Don't underline function definition if self is &mutAleksey Kladov2020-08-192-8/+2
| | | | | | | | | | | | | | | The self is right there, and is already underlined, so it makes little sense to emit even more underlines.
| * | Merge #5839bors[bot]2020-08-211-1/+0
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5839: Dont ask me why... r=kjeremy a=Veetaha Co-authored-by: Veetaha <[email protected]>
| | * | Dont ask me why...Veetaha2020-08-211-1/+0
| |/ /
| * | Merge #5838bors[bot]2020-08-2111-19/+21
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5838: :arrow_up: autocfg r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * | :arrow_up: autocfgAleksey Kladov2020-08-211-2/+2
| | | |
| | * | :arrow_up: ungrammarAleksey Kladov2020-08-2111-17/+19
| |/ /
| * | Merge #5835bors[bot]2020-08-2147-425/+54
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5835: Switch to expect_test from crates.io r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * | Switch to expect_test from crates.ioAleksey Kladov2020-08-2145-54/+54
| | | |
| | * | Remove expect crateAleksey Kladov2020-08-212-371/+0
| | | |
| * | | Merge #5832bors[bot]2020-08-201-10/+10
| |\ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | 5832: Update crates r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| | * | Update crateskjeremy2020-08-201-10/+10
| |/ /
| * | Merge #5824bors[bot]2020-08-191-25/+38
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5824: Optimize reference search r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * | Optimize reference searchAleksey Kladov2020-08-191-25/+38
| |/ /
| * | Merge #5813bors[bot]2020-08-191-0/+3
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5813: Try lld r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| | * | Use lld on winsowsAleksey Kladov2020-08-191-0/+3
| | | |
| * | | Merge #5822bors[bot]2020-08-191-25/+15
| |\ \ \ | | | |/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5822: Remove dead code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * | Remove dead codeAleksey Kladov2020-08-191-25/+15
| | |/
| * | Merge #5821bors[bot]2020-08-197-7/+163
| |\ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | 5821: **Remove Unused Parameter** refactoring r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * **Remove Unused Parameter** refactoringAleksey Kladov2020-08-197-7/+163
| |/
| * Merge #5820bors[bot]2020-08-195-17/+41
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | 5820: Future proof find-usages API r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Future proof find-usages APIAleksey Kladov2020-08-195-17/+41
| |/ | | | | | | | | | | We might want to provide more efficient impls for check if usages exist, limiting the search, filtering and cancellation, so let's violate YAGNI a bit here.
| * Merge #5819bors[bot]2020-08-191-19/+16
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | 5819: Apply couple of rule of thumbs to simplify highlighting code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Apply couple of rule of thumbs to simplify highlighting codeAleksey Kladov2020-08-191-19/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Main one: instead of adding a parameter to function to handle special case, make the caller handle it. Second main one: make sure that function does a reasonable thing. `highlight_def` picks a color for def, *regardless* of the context the def is use. Feeding an info from the call-site muddies the responsibilities here. Minor smells, flagging the function as having space for improvement in the first place: * many parameters, some of which are set as constants on most call-sites (introduce severalfunction instad) * boolean param (add two functions instead)
| * | Merge #5818bors[bot]2020-08-191-19/+11
| |\| | | | | | | | | | | | | | | | | | | | | | | | | 5818: Some trivial local simiplifications r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Inline trivial functionAleksey Kladov2020-08-191-8/+6
| | |
| | * SimplifyAleksey Kladov2020-08-191-9/+4
| | |
| | * MinorAleksey Kladov2020-08-191-2/+1
| | |
| | * Minor cleanupsAleksey Kladov2020-08-191-1/+1
| | |
| | * Better nameAleksey Kladov2020-08-191-4/+4
| |/
| * Merge #5817bors[bot]2020-08-194-56/+30
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | 5817: Better API factoring around self access modes r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Better API factoring around self access modesAleksey Kladov2020-08-194-56/+30
| | |
| * | Merge #5816bors[bot]2020-08-191-2/+9
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | 5816: Better error if Cargo is not in Path r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Better error if Cargo is not in PathAleksey Kladov2020-08-191-2/+9
| | |
| * | Merge #5815bors[bot]2020-08-191-2/+11
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | 5815: Introduce hir::Param r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Introduce hir::ParamAleksey Kladov2020-08-191-2/+11
| |/ | | | | | | | | We generally shouldn't expose TypeRef out of hir. So, let's just use a placehoder here.
| * Merge #5814bors[bot]2020-08-199-43/+62
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | 5814: Add SelfParam to code_model r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Add SelfParam to code_modelAleksey Kladov2020-08-199-43/+62
| | |
| * | Merge #5812bors[bot]2020-08-191-7/+6
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | 5812: Minor cleanups r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Minor cleanupsAleksey Kladov2020-08-191-7/+6
| |/
| * Merge #5811bors[bot]2020-08-191-3/+3
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | 5811: Minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * MinorAleksey Kladov2020-08-191-3/+3
| | |
| * | Merge #5643bors[bot]2020-08-199-49/+220
| |\ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5643: Add new consuming modifier, apply consuming and mutable to methods r=matklad a=Nashenas88 This adds a new `consuming` semantic modifier for syntax highlighters. This also emits `mutable` and `consuming` in two cases: - When a method takes `&mut self`, then it now has `function.mutable` emitted. - When a method takes `self`, and the type of `Self` is not `Copy`, then `function.consuming` is emitted. CC @flodiebold Co-authored-by: Paul Daniel Faria <[email protected]>
| | * Add new method to Semantics, method_receiver_kind, which returns the kind of ↵Paul Daniel Faria2020-08-165-70/+181
| | | | | | | | | | | | | | | | | | | | | self The options are Shared, Mutable, Consuming, and Copied. Use this to add proper highlighting to methods based on usage.
| | * Mark mutating functions with `mutable` modifier, and owning functions with ↵Paul Daniel Faria2020-08-165-15/+70
| | | | | | | | | | | | `consuming`.
| | * Add new HighlightModifier variant, ConsumingPaul Daniel Faria2020-08-163-0/+5
| | |
| * | Merge #5809bors[bot]2020-08-181-6/+6
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5809: :arrow_up: crates r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-11 11:33:03 +0100