| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
7677: More enum matching r=yoshuawuyts a=jDomantas
* Renamed existing `generate_enum_match_method` to `generate_enum_is_variant`
* Added two similar assists to generate `into_` and `as_` methods.
* Made all of them general enough to work on record and tuple variants too.
For `as_` method generation there's room to improve:
* Right now it always returns `Option<&Field>`, even though `Option<Field>` would be nicer when `Field: Copy`. I don't know how to check if the field type implements `Copy`. If given suggestions I could try to fix this in a follow-up pr.
* `&String` could be replaced with `&str`, `&Box<_>` with `&_`, and probably some more. I don't know what would be a good way to do that.
Closes #7604
Co-authored-by: Domantas Jadenkus <[email protected]>
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
7794: Disable "Flip comma" assist inside a macro call r=Veykril a=greenhat
Fix #7693
Disables "Flip comma" assist if called inside a macro call.
Co-authored-by: Denys Zadorozhnyi <[email protected]>
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
7792: docs(ide_assists): Change remaining occurrences of importMergeBehaviour to importMergeBehavior r=lnicola a=SanchithHegde
Co-authored-by: Sanchith Hegde <[email protected]>
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
7786: bump crates r=kjeremy a=kjeremy
Co-authored-by: kjeremy <[email protected]>
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
7785: :arrow_up: crates r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <[email protected]>
|
| |/ / / |
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
7741: Add convert_for_to_iter_for_each assist r=mattyhall a=mattyhall
Implements one direction of #7681
I wonder if this tries to guess too much at the right thing here. A common pattern is:
```rust
let col = vec![1, 2, 3];
for v in &mut col {
*v *= 2;
}
// equivalent to:
col.iter_mut().for_each(|v| *v *= 2);
```
I've tried to detect this case by checking if the expression after the `in` is a (mutable) reference and if not inserting iter()/iter_mut(). This is just a convention used in the stdlib however, so could sometimes be wrong. I'd be happy to make an improvement for this, but not sure what would be best. A few options spring to mind:
1. Only allow this for types that are known to have iter/iter_mut (ie stdlib types)
2. Try to check if iter/iter_mut exists and they return the right iterator type
3. Don't try to do this and just add `.into_iter()` to whatever is after `in`
Co-authored-by: Matt Hall <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | | |
* Use known names for iter/iter_mut method (simplifies checking if the
method exists
* Extract code to check assist with fixtures to function
|
| | | |
| | |
| | |
| | |
| | | |
* Move code to build replacement into closure
* Look for iter/iter_mut methods on types behind reference
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
7719: De Morgan's Law assist now correctly parenthesizes binary expressions. r=Veykril a=lbrande
Closes #7694 by parenthesizing binary expressions that are negated.
Co-authored-by: lbrande <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | | |
7775: Fix typo. r=Veykril a=boxdot
Co-authored-by: boxdot <[email protected]>
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
7772: Pickup ConstReference patterns in FindUsages r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <[email protected]>
|
| |/ / |
|
| |\ \
| |/
|/|
| |
| |
| |
| |
| |
| | |
7770: reliable memory usage during benchmarking r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <[email protected]>
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
7769: Update mio r=kjeremy a=kjeremy
Co-authored-by: kjeremy <[email protected]>
|
| | | | |
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
7768: Fix visibility computation when inside a block expression r=jonas-schievink a=jonas-schievink
fixes https://github.com/rust-analyzer/rust-analyzer/issues/7728
bors r+
Co-authored-by: Jonas Schievink <[email protected]>
|
| | | | |
|
| | |/ |
|
| |\ \
| |/
|/|
| |
| |
| |
| |
| | |
7766: Update our vscode npm packages r=kjeremy a=kjeremy
Co-authored-by: kjeremy <[email protected]>
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
7759: 7526: Rename ide related crates r=Veykril a=chetankhilosiya
renamed assists -> ide_assists and ssr -> ide_ssr.
the completion crate is already renamed.
Co-authored-by: Chetan Khilosiya <[email protected]>
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| |
| | |
7756: update tracing-tree r=kjeremy a=kjeremy
Removes some dependencies
Co-authored-by: kjeremy <[email protected]>
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
7753: Add isize to the list of suffixed integers in typed_integer r=kjeremy a=jonasbb
The missing `isize` in `typed_integers` seems to just be an oversight.
Might fix: #7751
Co-authored-by: Jonas Bushart <[email protected]>
|
| | |
| |
| |
| |
| |
| | |
The missing `isize` in `typed_integers` seems to just be an oversight.
Might fix: #7751
|
| |\ \
| |/
|/|
| |
| |
| |
| |
| | |
7752: up once_cell r=kjeremy a=kjeremy
Co-authored-by: kjeremy <[email protected]>
|
| | | |
|
| |\ \
| |/
|/|
| |
| |
| |
| |
| |
| | |
7749: Make more common assist easier to ues r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <[email protected]>
|
