aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge #2898bors[bot]2020-01-235-18/+16
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2898: Remove RWLock from check watcher. r=matklad a=kiljacken @matklad mentioned this might be a good idea. So the general idea is that we don't really need the lock, as we can just clone the check watcher state when creating a snapshot. We can then use `Arc::get_mut` to get mutable access to the state from `WorldState` when needed. Running with this it seems to improve responsiveness a bit while cargo is running, but I have no hard numbers to prove it. In any case, a serialization point less is always better when we're trying to be responsive. Co-authored-by: Emil Lauridsen <[email protected]>
| * | Remove RWLock from check watcher.Emil Lauridsen2020-01-235-18/+16
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | @matklad mentioned this might be a good idea. So the general idea is that we don't really need the lock, as we can just clone the check watcher state when creating a snapshot. We can then use `Arc::get_mut` to get mutable access to the state from `WorldState` when needed. Running with this it seems to improve responsiveness a bit while cargo is running, but I have no hard numbers to prove it. In any case, a serialization point less is always better when we're trying to be responsive.
* | Merge #2896bors[bot]2020-01-223-41/+41
|\ \ | | | | | | | | | | | | | | | | | | | | | 2896: Update crates r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Update crateskjeremy2020-01-223-41/+41
|/ /
* | Merge #2894bors[bot]2020-01-223-3/+20
|\ \ | | | | | | | | | | | | | | | | | | | | | 2894: Omit default parameters for references r=matklad a=SomeoneToIgnore Co-authored-by: Kirill Bulatov <[email protected]>
| * | Omit default parameters for reference typesKirill Bulatov2020-01-223-3/+20
|/ /
* | Merge #2891bors[bot]2020-01-222-29/+24
|\ \ | | | | | | | | | | | | | | | | | | | | | 2891: ra_syntax: removed code duplication and token reevaluation r=Veetaha a=Veetaha Just a small refactoring along the way of reading the codebase Co-authored-by: Veetaha <[email protected]>
| * | Fixed a typoVeetaha2020-01-221-1/+1
| | |
| * | Fixed a typoVeetaha2020-01-221-1/+1
| | |
| * | Preserved a comment on the bug previously present in ast::Literal::kind()Veetaha2020-01-221-0/+5
| | |
| * | ra_syntax: remove code duplication and token reevaluation from ↵Veetaha2020-01-222-32/+22
|/ / | | | | | | ast::Literal::kind()
* | Don't fail fast on CIAleksey Kladov2020-01-221-0/+1
| |
* | Merge #2893bors[bot]2020-01-221-0/+535
|\ \ | | | | | | | | | | | | | | | | | | | | | 2893: Add syntax guide r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add syntax guideAleksey Kladov2020-01-221-0/+535
|/ /
* | Merge #2884bors[bot]2020-01-212-12/+12
|\ \ | | | | | | | | | | | | | | | | | | | | | 2884: vscode-languageclient 6.0.1 r=matklad a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | vscode-languageclient 6.0.1Jeremy Kolb2020-01-212-12/+12
|/ /
* | Merge #2877bors[bot]2020-01-204-27/+55
|\ \ | |/ |/| | | | | | | | | | | 2877: "Insert explicit type " assist fix #2869, fix typo r=matklad a=TomasKralCZ So this was quite straightforward. I basically looked at how the other assists work and tried doing something simillar. I also fixed a typo in the other assist. Co-authored-by: TomasKralCZ <[email protected]>
| * changed 'descendants()' to 'children()'TomasKralCZ2020-01-201-4/+1
| |
| * added eq_token() method to LetStmtTomasKralCZ2020-01-192-2/+8
| |
| * Merge branch 'master' of https://github.com/rust-analyzer/rust-analyzerTomasKralCZ2020-01-1915-86/+181
| |\
| * | fix 'add_explicit_type' assist rangeTomasKralCZ2020-01-191-1/+26
| | |
| * | fix typo in 'inline_local_variable'TomasKralCZ2020-01-192-26/+26
| | |
* | | Merge #2878bors[bot]2020-01-191-4/+52
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2878: Fix a corner case when printing unaccounted time r=matklad a=michalt Previously `ra_prof` wouldn't actually print the unaccounted time in some cases. We would print, for instance, this: ``` 5ms - foo 2ms - bar ``` instead of: ``` 5ms - foo 2ms - bar 3ms - ??? ``` The fix is to properly handle the case when an entry has 0 children instead of using the `last` variable. Signed-off-by: Michal Terepeta <[email protected]> Co-authored-by: Michal Terepeta <[email protected]>
| * | Fix a corner case when printing unaccounted timeMichal Terepeta2020-01-191-4/+52
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously `ra_prof` wouldn't actually print the unaccounted time in some cases. We would print, for instance, this: ``` 5ms - foo 2ms - bar ``` instead of: ``` 5ms - foo 2ms - bar 3ms - ??? ``` The fix is to properly handle the case when an entry has 0 children instead of using the `last` variable. Signed-off-by: Michal Terepeta <[email protected]>
* | Merge #2875bors[bot]2020-01-183-23/+38
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2875: Improve parameter hints a bit & add emacs support r=matklad a=flodiebold - just include the name, not e.g. `mut` - don't return empty hints (or `_`) CC @brotzeit for the Emacs change Co-authored-by: Florian Diebold <[email protected]>
| * | Improve parameter hints a bit & add emacs supportFlorian Diebold2020-01-183-23/+38
|/ / | | | | | | | | - just include the name, not e.g. `mut` - don't return empty hints (or `_`)
* | Merge #2870bors[bot]2020-01-173-5/+35
|\ \ | | | | | | | | | | | | | | | | | | | | | 2870: Fix inference for shift operators r=matklad a=flodiebold Fixes #2602. Co-authored-by: Florian Diebold <[email protected]>
| * | Fix inference for shift operatorsFlorian Diebold2020-01-173-5/+35
|/ / | | | | | | Fixes #2602.
* | Merge #2867bors[bot]2020-01-174-55/+59
|\ \ | | | | | | | | | | | | | | | | | | | | | 2867: Nest attrs into exprs in function args r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Nest attrs into exprs in function argsAleksey Kladov2020-01-173-32/+23
| | |
| * | Extract expr_with_attrsAleksey Kladov2020-01-173-23/+36
|/ /
* | Merge pull request #2813 from jyn514/arg_attributesAleksey Kladov2020-01-173-0/+45
|\ \ | | | | | | Allow attributes before function arguments
| * | move inline function closer to relevant codeJoshua Nelson2020-01-175-119/+44
| | | | | | | | | | | | also updates generated inline tests
| * | shrink inline tesJoshua Nelson2020-01-161-9/+3
| | |
| * | Allow attributes before function argumentsJoshua Nelson2020-01-123-0/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds support for function calls of the form: ```rust ( #[attr(...)] 1.2, #[attr_one(...)] #[attr_two(...)] 1.5, ... etc ... ) ``` Closes https://github.com/rust-analyzer/rust-analyzer/issues/2801
* | | Merge #2865bors[bot]2020-01-173-2/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2865: fix(mixed): fixed a couple of typos and added a todo r=kjeremy a=Veetaha Fixed a couple of typos and added a todo while studying the codebase. Co-authored-by: Veetaha <[email protected]>
| * | | todo(codegen): added todo to change the reference to removed ra_tools crateVeetaha2020-01-161-0/+1
| | | |
| * | | fix(xtask.gen_syntax.typo): add s to the verb that refers to the 3d personVeetaha2020-01-151-1/+1
| | | |
| * | | fix(ra_parser.typo): amend 'format language' to 'formal language'Veetaha2020-01-151-1/+1
| | | |
* | | | Merge #2864bors[bot]2020-01-161-12/+12
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 2864: Crates up r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | Crates upkjeremy2020-01-161-12/+12
|/ / /
* | | Merge #2863bors[bot]2020-01-169-190/+88
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2863: Minimize test r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Minimize testAleksey Kladov2020-01-167-129/+51
| | | |
| * | | Simplify array parsingAleksey Kladov2020-01-163-68/+44
|/ / /
* | | Merge #2862bors[bot]2020-01-1616-430/+306
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2862: Move from `from_source` to `SourceBinder` r=matklad a=matklad bors r+ Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Fix commentAleksey Kladov2020-01-161-3/+1
| | | |
| * | | Remove dead codeAleksey Kladov2020-01-161-34/+2
| | | |
| * | | Correctly discover module containersAleksey Kladov2020-01-161-11/+15
| | | |
| * | | Create modules via SourceBinderAleksey Kladov2020-01-1610-112/+65
| | | |
| * | | Move module to SourceBinderAleksey Kladov2020-01-165-55/+69
| | | |