aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge #6205bors[bot]2020-10-121-2/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6205: Fix iterator hint shortening heuristic r=SomeoneToIgnore a=Veykril Turns out I made a mistake with the heuristic check which is always true, so all iterators exposed from `core` were shortened, including things like ranges. 😅 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Fix iterator hint shortening heuristicLukas Wirth2020-10-121-2/+2
| | | |
* | | | Merge #6137bors[bot]2020-10-121-684/+1041
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6137: add a new TextMate grammar r=matklad a=dustypomerleau Thanks to everyone working hard on Rust Analyzer - my impression is that it's quickly becoming the community default. I think it would be helpful to have a more robust TextMate grammar to fall back on, for those who wish to disable semantic highlighting for any reason. It should allow theming of punctuation, and provide scopes for all tokens on the page. This can be done at zero cost to those who enable semantic highlighting, as the TextMate scopes will be invisible to those users. I can see a couple ways of accomplishing this: 1. Ship a new grammar by merging this PR. 1. Ship no TextMate grammar at all (like the [Rust](https://marketplace.visualstudio.com/items?itemName=rust-lang.rust) extension), and allow users to install a separate extension that provides the grammar of their choice (I have released this one as [Rust Syntax](https://marketplace.visualstudio.com/items?itemName=dustypomerleau.rust-syntax)). If no grammar were installed, they would simply fall back to the default grammar provided by their editor. In the case of VS Code, the default grammar already matches what is currently being shipped, so users who choose not to override it would see no difference. I have tried to choose sensible default scopes, in the hopes that a wider variety of themes would work out of the box with Rust, even if those themes do not yet supply scopes for semantic highlighting. There is definitely some interest in using this grammar with Rust Analyzer, as this was the very first issue after the syntax extension was shipped: https://github.com/dustypomerleau/rust-syntax/issues/1. I considered simply using an alternative grammar alongside Rust Analyzer, but this doesn't seem possible. When RA starts, any existing grammar/extension is overridden, and I haven't been able to find a workaround. Co-authored-by: Dusty Pomerleau <[email protected]>
| * | | | add new TextMate grammarDusty Pomerleau2020-10-111-684/+1041
| | | | |
* | | | | Merge #6153bors[bot]2020-10-125-13/+119
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6153: Improve prime_caches and display its progress r=matklad a=jonas-schievink It now computes the `CrateDefMap` of all crates, which is generally a reasonable approximation for "IDE features ready". There is still some delay after this finishes, I suspect mostly due to impl collection, which takes a while, but this should be an improvement already. For more accurate progress reports, this topologically sorts all crates before starting this operation. ~~Because that is also the ordering in which parallelization makes sense (which was previously attempted in https://github.com/rust-analyzer/rust-analyzer/pull/3529), I decided to throw that into the mix as well. It still doesn't provide *that* much of a performance boost, but it does scale beyond the current single-core architecture, and adding it was very easy.~~ ~~Unfortunately, as written, this will not tell the user which crate is actually causing slowdowns, since the displayed crate is the last one that was *started*, not the one we are currently *blocked* on, but that seems fairly difficult to implement unless I'm missing something.~~ (I have removed rayon for now since it does not work correctly with cancellation.) Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Improve prime_caches and display its progressJonas Schievink2020-10-125-13/+119
| | |/ / | |/| |
* | | | Merge #6195bors[bot]2020-10-122-30/+53
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6195: Shorten iterators in associated params r=matklad a=SomeoneToIgnore Applies the same iterator-shortening logic to the iterator associated types, recursively. Before: ![image](https://user-images.githubusercontent.com/2690773/95662735-e6ecf200-0b41-11eb-8e54-28493ad4e644.png) After: <img width="1192" alt="image" src="https://user-images.githubusercontent.com/2690773/95662894-e9038080-0b42-11eb-897d-527571ccac58.png"> Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | Also replace the associated types with iterKirill Bulatov2020-10-102-12/+19
| | | | |
| * | | | Add a testKirill Bulatov2020-10-101-23/+39
| | | | |
* | | | | Merge #6198bors[bot]2020-10-124-4/+124
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6198: Skip macro matcher fragment name semantic highlighting r=matklad a=Veykril Implements a small state-machine for macro_rules! highlighting to separate out the matcher part of its rules. This skips semantically highlighting names of metavariables in the matcher and expander. This might even allow for more fun macro highlighting things in the future. Fixes #4380. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | Skip macro matcher fragment name semantic highlightingLukas Wirth2020-10-104-4/+124
| | | | | |
* | | | | | Merge #6199bors[bot]2020-10-122-2/+5
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6199: Fix `mut self` not emitting mutable binding on `self` use r=matklad a=Veykril Prior to this, when `self` in a function is taken by value and bound mutably, its use inside of the method body won't be marked `mutably`. Fixes #5461 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | Fix `mut self` not emitting mutable binding on `self` useLukas Wirth2020-10-112-2/+5
| |/ / / /
* | | | | Merge #5917bors[bot]2020-10-1217-32/+403
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5917: Add a command to open docs for the symbol under the cursor r=matklad a=zacps #### Todo - [ ] Decide if there should be a default keybind or context menu entry - [x] Figure out how to get the documentation path for methods and other non-top-level defs - [x] Design the protocol extension. In future we'll probably want parameters for local/remote documentation URLs, so that should maybe be done in this PR? - [x] Code organisation - [x] Tests Co-authored-by: Zac Pullar-Strecker <[email protected]>
| * | | | | Remove methodowner & fix formattingZac Pullar-Strecker2020-10-084-53/+27
| | | | | |
| * | | | | Rebase fixesZac Pullar-Strecker2020-10-082-14/+6
| | | | | |
| * | | | | Changes from reviewZac Pullar-Strecker2020-10-081-3/+3
| | | | | |
| * | | | | Remove outdated part of doc_links module docsZac Pullar-Strecker2020-10-081-2/+0
| | | | | |
| * | | | | Add ignored test to demonstrate ImportMap bugZac Pullar-Strecker2020-10-081-1/+26
| | | | | |
| * | | | | Fix namespace detection & function testZac Pullar-Strecker2020-10-081-6/+2
| | | | | |
| * | | | | Add testsZac Pullar-Strecker2020-10-081-2/+94
| | | | | |
| * | | | | Update tests for new function fieldZac Pullar-Strecker2020-10-081-12/+12
| | | | | |
| * | | | | Fix send->sent typoZac Pullar-Strecker2020-10-081-7/+7
| | | | | |
| * | | | | Change Option::Some bug to a fixme noteZac Pullar-Strecker2020-10-082-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | IMO this is too much work to be worth fixing at the moment.
| * | | | | Differentiate method/tymethod by determining 'defaultness'Zac Pullar-Strecker2020-10-087-9/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently a method only has defaultness if it is a provided trait method, but this will change when specialisation is available and may need to become a concept known to hir. I opted to go for a 'fewest changes' approach given specialisation is still under development.
| * | | | | Document the protocol extensionZac Pullar-Strecker2020-10-081-1/+12
| | | | | |
| * | | | | Code reorganisation and field supportZac Pullar-Strecker2020-10-086-60/+105
| | | | | |
| * | | | | Changes from reviewZac Pullar-Strecker2020-10-086-47/+14
| | | | | |
| * | | | | Rename ide::link_rewrite -> ide::doc_links & tidy importsZac Pullar-Strecker2020-10-083-4/+4
| | | | | |
| * | | | | Add support for struct & trait methodsZac Pullar-Strecker2020-10-081-7/+83
| | | | | |
| * | | | | WIP: Command to open docs under cursorZac Pullar-Strecker2020-10-089-4/+176
| | | | | |
* | | | | | Merge #6200bors[bot]2020-10-122-30/+30
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6200: Update crates r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | | Update crateskjeremy2020-10-112-30/+30
|/ / / / /
* | | | | Merge #5858bors[bot]2020-10-104-61/+138
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5858: Draft: Show reason for failed rename refactoring r=rherrmann a=rherrmann Return an error with a meaningful message for requests to `textDocument/rename` if the operation cannot be performed. Pass errors, raised by rename handling code to the LSP runtime. As a consequence, the VS Code client shows and logs the request as if a server-side programming error occured. Screenshot of a rename error showing in VS Code ![invalid-rename-ui](https://user-images.githubusercontent.com/607182/91059560-2c08a380-e62a-11ea-9297-f092db935a3b.png) I would kindly ask to get feedback from the maintainers if they can spare the time: * Is the general direction of the proposed changes acceptable? * I'm new to Rust. The code feels clumsy and redundant, please suggest improvements if you find the time for. E.g. is there a simple replacement for `RenameError`? * Should presenting the error with proper severity (i.e. not as a programming error) be part of this change or in a followup change? See https://github.com/rust-analyzer/rust-analyzer/issues/3981 Co-authored-by: Rüdiger Herrmann <[email protected]>
| * | | | Show reason for failed rename refactoringRüdiger Herrmann2020-10-104-61/+138
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Return an error with a meaningful message for requests to `textDocument/rename` if the operation cannot be performed. Pass errors raised by rename handling code to the LSP runtime. As a consequence, the VS Code client shows and logs the request as if a server-side programming error occured. Resolves https://github.com/rust-analyzer/rust-analyzer/issues/3981
* | | | Merge #6176bors[bot]2020-10-101-0/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6176: add eprintln in fmt-like postfix r=SomeoneToIgnore a=bnjjj Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | add eprintln in fmt-like postfixBenjamin Coenen2020-10-081-0/+2
| | |_|/ | |/| | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | Merge #6187bors[bot]2020-10-091-12/+0
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6187: Remove release build overrides r=jonas-schievink a=lnicola Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | | Remove release build overridesLaurențiu Nicola2020-10-091-12/+0
| | | | |
* | | | | Merge #6189bors[bot]2020-10-093-15/+47
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6189: adt: correctly inherit field visibility from enum r=jonas-schievink a=jonas-schievink Previously, "find all references" on a variant field wouldn't find any references outside the defining module. This is because variant fields were incorrectly assumed to be private, like struct fields without explicit visibility, but they actually inherit the enum's visibility. bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | | adt: correctly inherit field visibility from enumJonas Schievink2020-10-093-15/+47
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | Previously, "find all references" on a variant field wouldn't find any references outside the defining module. This is because variant fields were incorrectly assumed to be private, like struct fields without explicit visibility, but they actually inherit the enum's visibility.
* | | | Merge #6188bors[bot]2020-10-092-43/+119
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6188: Treat `ast::Name` in field patterns as use r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | Treat `ast::Name` in field patterns as useJonas Schievink2020-10-092-43/+119
|/ / /
* | | Merge #6185bors[bot]2020-10-091-2/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6185: Add note if RUST_SRC_PATH is likely to be wrong r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | Update crates/project_model/src/sysroot.rsJonas Schievink2020-10-091-1/+1
| | | | | | | | | | | | Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | Add note if RUST_SRC_PATH is likely to be wrongJonas Schievink2020-10-091-2/+8
|/ / /
* | | Merge #6181bors[bot]2020-10-092-0/+21
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 6181: Fix source_to_def for named enum variant fields r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | Fix source_to_def for named enum variant fieldsJonas Schievink2020-10-092-0/+21
|/ /
* | Merge #6173bors[bot]2020-10-084-30/+38
|\ \ | | | | | | | | | | | | | | | | | | | | | 6173: Bump rustc_lexer, cfg-if to 1.0 and add new license to check r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Bump rustc_lexer, cfg-if to 1.0 and add new license to checkkjeremy2020-10-084-30/+38
|/ /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 14:32:46 +0000