aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | internal: add ranges to minicoreAleksey Kladov2021-06-152-28/+42
| | | | | | |
| * | | | | | internal: unindent some testsAleksey Kladov2021-06-151-255/+252
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-152-111/+102
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-153-62/+75
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-151-181/+129
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-152-118/+88
| | | | | | |
| * | | | | | internal: introduce minicore -- a subset of libcore for testingAleksey Kladov2021-06-156-42/+271
| | | | | | |
* | | | | | | Merge #9292bors[bot]2021-06-153-15/+23
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9292: fix: Code: clean-up #8951 r=wxb1ank a=wxb1ank #8951 was a major change in the VS Code extension and caused quite a few problems. This PR is a catch-all for bugs and improvements in the new code. This should fix: - #9284 - [this unreported bug](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) - ...and one or two uncaught exceptions I just found The original lack of testing was my own fault, but this area of the VS Code API is also tricky for a couple reasons: - The [FileSystem](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) API does not list or warn about any exceptions, but [FileSystemProvider](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) (which `FileSystem` is a wrapper of, AFAICT) does. - At first glance, [Uri.path](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) *looks* like it works for FS operations. It does not, at least, on Windows. You need to use `Uri.fsPath`. I only use Windows, so I need people on macOS, Linux, and (possibly) NixOS to test this. Co-authored-by: wxb1ank <[email protected]>
| * | | | | | | Use `.then()` for Thenablewxb1ank2021-06-151-3/+1
| | | | | | | |
| * | | | | | | fix: clean-up #8951wxb1ank2021-06-153-15/+25
| | | | | | | |
* | | | | | | | Merge #9295bors[bot]2021-06-1513-19/+60
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9295: fix: Highlight unsafe trait refs as unsafe only in impl blocks and definitions r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | | | Highlight unsafe trait refs as unsafe only in impl blocks and definitionsLukas Wirth2021-06-1513-19/+60
|/ / / / / / /
* | | | | | | Merge #9291bors[bot]2021-06-151-1/+1
|\ \ \ \ \ \ \ | | |/ / / / / | |/| | | / / | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9291: minor: fix typo r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | minor: fix typoAleksey Kladov2021-06-151-1/+1
| | | | | |
* | | | | | Merge #9290bors[bot]2021-06-157-85/+60
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9290: internal: enforce no #[ignore] and no #[should_panic] r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | internal: enforce no #[ignore] and no #[should_panic]Aleksey Kladov2021-06-153-2/+33
| | | | | |
| * | | | | internal: don't #[ignore] testsAleksey Kladov2021-06-154-83/+27
|/ / / / / | | | | | | | | | | | | | | | See the style.md for motivation
* | | | | Merge #9288bors[bot]2021-06-153-613/+600
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9288: internal: cleanup tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | internal: cleanup testsAleksey Kladov2021-06-153-613/+600
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ensure standard, non-indented style (should add this check to `fixture` some day) * removed a couple of ignores
* | | | | | Merge #9285bors[bot]2021-06-151-5/+13
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9285: minor: add a test variation r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | minor: add a test variationAleksey Kladov2021-06-151-5/+13
|/ / / / /
* | | | | Merge #9278bors[bot]2021-06-158-71/+86
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9278: internal: document that we don't #[ignore] tests r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | internal: document that we don't #[ignore] testsAleksey Kladov2021-06-158-71/+86
| | | | | |
* | | | | | Merge #9282bors[bot]2021-06-153-6/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9282: fix: Use objects instead of bools for markers in package.json r=lnicola a=lnicola Addresses https://github.com/rust-analyzer/rust-analyzer/issues/9174#issue-913980665. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | | Use objects instead of bools for markers in package.jsonLaurențiu Nicola2021-06-153-6/+6
| | |_|_|/ / | |/| | | |
* | | | | | Merge #9281bors[bot]2021-06-151-5/+7
|\ \ \ \ \ \ | |/ / / / / |/| | / / / | | |/ / / | |/| | | | | | | | | | | | | | | | | | 9281: fix: Code: use `Uri.toString()` for URLs r=lnicola a=wxb1ank I believe this should fix #9280. Testing is needed but I wanted to quickly push a hotfix. Co-authored-by: wxb1ank <[email protected]>
| * | | | Use `Uri.toString()` for URLswxb1ank2021-06-151-5/+7
|/ / / /
* | | | Merge #9277bors[bot]2021-06-145-12/+12
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9277: internal: more natural order of sources for TypeParam r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | internal: more natural order of sources for TypeParamAleksey Kladov2021-06-145-12/+12
| | | | | | | | | | | | | | | | | | | | We usually use first (left) variant of `Either` for "usual" case, and use right for odd things. For example, pat source is Pat | SelfParam.
* | | | Merge #9276bors[bot]2021-06-1419-341/+359
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9276: internal: refactor diagnostics more r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | internal: test diagnostic severeties and presense of fixesAleksey Kladov2021-06-1416-140/+155
| | | |
| * | | minor: make diagnostics more similarAleksey Kladov2021-06-145-201/+204
| | | |
* | | | Merge #9275bors[bot]2021-06-141-2/+60
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9275: feat: Support goto type for field expressions and patterns r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Support goto type for field expressions and patternsLukas Wirth2021-06-141-2/+60
| | | | |
* | | | | Merge #9273bors[bot]2021-06-142-51/+1
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9273: internal: don't pull tracing via chalk r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | internal: don't pull tracing via chalkAleksey Kladov2021-06-142-51/+1
|/ / / /
* | | | Merge #9272bors[bot]2021-06-1434-798/+937
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 9272: internal: move diagnostics to a dedicated crate r=matklad a=matklad bors r+ Co-authored-by: Aleksey Kladov <[email protected]>
| * | | internal: document diagnostics crateAleksey Kladov2021-06-1420-65/+87
| | | |
| * | | minor: less ambiguous nameAleksey Kladov2021-06-142-5/+7
| | | |
| * | | internal: flatten module hierarchyAleksey Kladov2021-06-143-9/+10
| | | | | | | | | | | | | | | | | | | | It seems that any crate can be made better by flattening the modules down to a single layer?
| * | | internal: document rename challengesAleksey Kladov2021-06-142-1/+42
| | | |
| * | | internal: adapt diagnostics to the new rename APIAleksey Kladov2021-06-144-455/+474
| | | |
| * | | internal: cut deps between assists and diagnosticsAleksey Kladov2021-06-1410-140/+147
| | | |
| * | | internal: prepare to move assist definitionsAleksey Kladov2021-06-144-33/+30
| | | |
| * | | internal: move diagnostics to a new crateAleksey Kladov2021-06-1428-578/+612
| | | |
| * | | internal: start ide diagnostics crateAleksey Kladov2021-06-143-0/+16
| |/ /
* | | Merge #9270bors[bot]2021-06-141-0/+18
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 9270: minor: Add assoc type in trait bound completion test r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | Add assoc type in trait bound completion testLukas Wirth2021-06-141-0/+18
| | |
* | | Merge #9265bors[bot]2021-06-141-41/+40
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9265: internal: prepare to move rename to base_db r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | internal: prepare to move rename to base_dbAleksey Kladov2021-06-141-41/+40
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | It's better to handle magical cases upper in the stack, because it allows for better re-use of the general implementation below. So, we pull the `self` case up here. The end goal is to put `Definition::rename` to the `ide_db`, because it's a generally re-usable functionality useful for different ide features, alongside with the search which is already there.