aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge #5733bors[bot]2020-08-242-119/+617
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5733: Fix expand glob import bugs r=matklad a=unexge fixes https://github.com/rust-analyzer/rust-analyzer/issues/5709 TODOs: - [x] Incorrect node replacing <details> <summary>Details</summary> ```rust use crate::{ body::scope::{ExprScopes, ScopeId}, body::Body, builtin_type::BuiltinType, db::DefDatabase, expr::{ExprId, PatId}, generics::GenericParams, item_scope::{BuiltinShadowMode, BUILTIN_SCOPE}, nameres::CrateDefMap, path::*<|>, per_ns::PerNs, visibility::{RawVisibility, Visibility}, AdtId, AssocContainerId, ConstId, ContainerId, DefWithBodyId, EnumId, EnumVariantId, FunctionId, GenericDefId, HasModule, ImplId, LocalModuleId, Lookup, ModuleDefId, ModuleId, StaticId, StructId, TraitId, TypeAliasId, TypeParamId, VariantId, }; ``` becames ```rust use crate::{PathKind, name, name, ModPath}; ``` </details> - [x] Ignoring visibility <details> <summary>Details</summary> ```rust mod foo { mod bar { pub struct Bar; } } use foo::bar::*; fn baz(bar: Bar) {} ``` becames ```rust mod foo { mod bar { pub struct Bar; } } use foo::bar::Bar; fn baz(bar: Bar) {} ``` although mod `bar` is private </details> - [x] Eating attributes Co-authored-by: unexge <[email protected]>
| * | | | | Use new `Definition::usages` API in expand glob importunexge2020-08-201-1/+1
| | | | | |
| * | | | | Fix importing private modules in expand glob importunexge2020-08-201-0/+52
| | | | | |
| * | | | | Fix importing unused traits in expand glob importunexge2020-08-201-28/+73
| | | | | |
| * | | | | Use fixme instead of todounexge2020-08-202-2/+2
| | | | | |
| * | | | | Use `Definition::find_usages` for finding used items in expand glob importunexge2020-08-202-114/+137
| | | | | |
| * | | | | Run rustfmtunexge2020-08-201-3/+5
| | | | | |
| * | | | | Handle more cases in AST replacing in expand glob importunexge2020-08-202-35/+220
| | | | | |
| * | | | | Improve AST replacing in expand glob importunexge2020-08-201-38/+229
| | | | | |
* | | | | | Merge #5855bors[bot]2020-08-241-0/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5855: Add TBD description to arena r=matklad a=pksunkara Sorry I missed this, @matklad. Please run manually again once this is merged. Co-authored-by: Pavan Kumar Sunkara <[email protected]>
| * | | | | | Add TBD description to arenaPavan Kumar Sunkara2020-08-241-0/+1
|/ / / / / /
* | | | | | Merge #4776bors[bot]2020-08-2429-98/+168
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4776: Do a weekly minor publish to crates.io r=matklad a=pksunkara This is the same system I set up on Chalk repo. Every week it creates a new minor version, pushes it to github and then deploys it to crates.io. Co-authored-by: Pavan Kumar Sunkara <[email protected]>
| * | | | | | Add description for crates that will be publishedPavan Kumar Sunkara2020-08-2425-0/+25
| | | | | | |
| * | | | | | Added weekly publish workflowPavan Kumar Sunkara2020-08-241-0/+44
| | | | | | |
| * | | | | | Add version to deps in cargo.tomlPavan Kumar Sunkara2020-08-2422-98/+99
| | |_|_|_|/ | |/| | | |
* | | | | | Merge #5845bors[bot]2020-08-243-5/+25
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5845: Omit lenses for not runnable doctests r=matklad a=SomeoneToIgnore Ideally, we should properly parse the doctest attributes before, but since I need it for the code lens only, this way should suffice for now Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | | | Omit lenses for not runnable doctestsKirill Bulatov2020-08-223-5/+25
| |/ / / / /
* | | | | | Merge #5851bors[bot]2020-08-243-2/+45
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5851: Invert if should be smart about is_some, is_none, is_ok, is_err r=matklad a=dragfire Fixes #5827 Co-authored-by: dragfire <[email protected]>
| * | | | | | Invert if should be smart about is_some, is_none, is_ok, is_errdragfire2020-08-243-2/+45
| |/ / / / /
* | | | | | Merge #5852bors[bot]2020-08-241-1/+25
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5852: Add Early Return rule to style r=matklad a=matklad bors r+ Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | Add Early Return rule to styleAleksey Kladov2020-08-241-1/+25
| |/ / / / /
* | | | | | Merge #5853bors[bot]2020-08-241-0/+35
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5853: Avoid monomorphization r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Avoid monomorphizationAleksey Kladov2020-08-241-0/+35
|/ / / / /
* | | | | Merge #5823bors[bot]2020-08-222-8/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5823: Don't underline function definition if self is &mut r=Nashenas88 a=matklad The self is right there, and is already underlined, so it makes little sense to emit even more underlines. before: ![before](https://user-images.githubusercontent.com/1711539/90672843-0d379500-e257-11ea-840f-b0caed4410f1.png) after: ![after](https://user-images.githubusercontent.com/1711539/90672840-0c9efe80-e257-11ea-9739-23af433841c6.png) Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Don't underline function definition if self is &mutAleksey Kladov2020-08-192-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The self is right there, and is already underlined, so it makes little sense to emit even more underlines.
* | | | | | Merge #5839bors[bot]2020-08-211-1/+0
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5839: Dont ask me why... r=kjeremy a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * | | | | Dont ask me why...Veetaha2020-08-211-1/+0
|/ / / / /
* | | | | Merge #5838bors[bot]2020-08-2111-19/+21
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5838: :arrow_up: autocfg r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | :arrow_up: autocfgAleksey Kladov2020-08-211-2/+2
| | | | | |
| * | | | | :arrow_up: ungrammarAleksey Kladov2020-08-2111-17/+19
|/ / / / /
* | | | | Merge #5835bors[bot]2020-08-2147-425/+54
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5835: Switch to expect_test from crates.io r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Switch to expect_test from crates.ioAleksey Kladov2020-08-2145-54/+54
| | | | |
| * | | | Remove expect crateAleksey Kladov2020-08-212-371/+0
| | | | |
* | | | | Merge #5832bors[bot]2020-08-201-10/+10
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5832: Update crates r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | Update crateskjeremy2020-08-201-10/+10
|/ / / /
* | | | Merge #5824bors[bot]2020-08-191-25/+38
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5824: Optimize reference search r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Optimize reference searchAleksey Kladov2020-08-191-25/+38
|/ / / /
* | | | Merge #5813bors[bot]2020-08-191-0/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5813: Try lld r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Use lld on winsowsAleksey Kladov2020-08-191-0/+3
| | | | |
* | | | | Merge #5822bors[bot]2020-08-191-25/+15
|\ \ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5822: Remove dead code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Remove dead codeAleksey Kladov2020-08-191-25/+15
| |/ / /
* | | | Merge #5821bors[bot]2020-08-197-7/+163
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5821: **Remove Unused Parameter** refactoring r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | **Remove Unused Parameter** refactoringAleksey Kladov2020-08-197-7/+163
|/ / /
* | | Merge #5820bors[bot]2020-08-195-17/+41
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5820: Future proof find-usages API r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Future proof find-usages APIAleksey Kladov2020-08-195-17/+41
|/ / / | | | | | | | | | | | | | | | We might want to provide more efficient impls for check if usages exist, limiting the search, filtering and cancellation, so let's violate YAGNI a bit here.
* | | Merge #5819bors[bot]2020-08-191-19/+16
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5819: Apply couple of rule of thumbs to simplify highlighting code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Apply couple of rule of thumbs to simplify highlighting codeAleksey Kladov2020-08-191-19/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Main one: instead of adding a parameter to function to handle special case, make the caller handle it. Second main one: make sure that function does a reasonable thing. `highlight_def` picks a color for def, *regardless* of the context the def is use. Feeding an info from the call-site muddies the responsibilities here. Minor smells, flagging the function as having space for improvement in the first place: * many parameters, some of which are set as constants on most call-sites (introduce severalfunction instad) * boolean param (add two functions instead)
* | | | Merge #5818bors[bot]2020-08-191-19/+11
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5818: Some trivial local simiplifications r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Inline trivial functionAleksey Kladov2020-08-191-8/+6
| | | |
| * | | SimplifyAleksey Kladov2020-08-191-9/+4
| | | |