aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
*-------. Merge #5089 #5161 #5184 #5185 #5186bors[bot]2020-07-0210-26/+242
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5089: Disable auto-complete on comments r=matklad a=BGluth Resolves #4907 by disabling any auto-completion on comments. As flodiebold [pointed out](https://github.com/rust-analyzer/rust-analyzer/issues/4907#issuecomment-648439979), in the future we may want to support some form of auto-completion within doc comments, but for now it was suggested to just disable auto-completion on them entirely. The implementation involves adding a new field `is_comment` to `CompletionContext` and checking if the immediate token we auto-completed on is a comment. I couldn't see a case where we need to check any of the ancestors, but let me know if this is not sufficient. I also wasn't sure if it was necessary to add a new field to this struct, but I decided it's probably the best option if we want to potentially do auto-completion on doc comments in the future. Finally, the three tests I added should I think ideally not filter results by `CompletionKind::Keyword`, but if I want to get unfiltered results, I need access to a non-public function [get_all_completion_items](https://github.com/rust-analyzer/rust-analyzer/blob/9a4d02faf9c47f401b8756c3f7fcab2198f5f9cd/crates/ra_ide/src/completion/test_utils.rs#L32-L39) which I don't know if I should make public just for this. 5161: SSR: Add initial support for placeholder constraints r=matklad a=davidlattimore 5184: Always install required nightly extension if current one is not nightly r=matklad a=Veetaha This is weird, but having switched back to stable by uninstalling the extension appears that vscode doesn't destroy the `PersistentState` and thus changing to `nightly` channel doesn't work because the last check for nightly extension was less than 1 hour ago. The simple solution is to skip this check if we know that the current extension version is not nightly. 5185: Force showing extension activation error pop-up notification r=matklad a=Veetaha Fixes https://github.com/rust-analyzer/rust-analyzer/issues/5091 5186: fix: correct pd/ppd/tfn/tmod completion doc r=matklad a=fannheyward https://github.com/rust-analyzer/rust-analyzer/blob/a33eefa3b26000b3018e6bb873f18dbe15ab4ab7/crates/ra_ide/src/completion/complete_snippet.rs#L23-L24 Co-authored-by: BGluth <[email protected]> Co-authored-by: David Lattimore <[email protected]> Co-authored-by: Veetaha <[email protected]> Co-authored-by: Heyward Fann <[email protected]>
| | | | | * fix: correct pd/ppd/tfn/tmod completion docHeyward Fann2020-07-021-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rust-analyzer/rust-analyzer/blob/a33eefa3b26000b3018e6bb873f18dbe15ab4ab7/crates/ra_ide/src/completion/complete_snippet.rs#L23
| | | | * | Force showing extension activation error pop-up notificationVeetaha2020-07-021-3/+11
| | | | | |
| | | * | | Always install required nightly extension if current one is not nightlyVeetaha2020-07-021-4/+8
| | | |/ /
| | * | | SSR: Use T! instead of SyntaxKind::* where possibleDavid Lattimore2020-07-021-11/+11
| | | | |
| | * | | SSR: Add initial support for placeholder constraintsDavid Lattimore2020-07-016-6/+156
| | | | |
| * | | | Auto-completion no longer occurs on commentsBGluth2020-07-011-1/+5
| | | | |
| * | | | Added tests for no auto-completion on commentsBGluth2020-07-011-0/+50
| | |_|/ | |/| |
* | | | Merge #5180bors[bot]2020-07-021-0/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5180: Disable optimizations for tracing-attributes r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | Disable optimizations for tracing-attributesLaurențiu Nicola2020-07-011-0/+2
| | | | |
* | | | | Disable npm auditAleksey Kladov2020-07-021-3/+3
| |/ / / |/| | | | | | | | | | | At the moment it fails with unfixable minor vuln in a dev-dependency
* | | | Merge #5149bors[bot]2020-07-018-71/+140
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5149: Implement Chalk variable kinds r=flodiebold a=flodiebold This means we need to keep track of the kinds (general/int/float) of variables in `Canonical`, which requires some more ceremony. (It also exposes some places where we're not really dealing with canonicalization correctly -- another thing to be cleaned up when we switch to using Chalk's types directly.) Should fix the last remaining issue of #2534. Co-authored-by: Florian Diebold <[email protected]>
| * | | Implement Chalk variable kindsFlorian Diebold2020-07-018-71/+140
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This means we need to keep track of the kinds (general/int/float) of variables in `Canonical`, which requires some more ceremony. (It also exposes some places where we're not really dealing with canonicalization correctly -- another thing to be cleaned up when we switch to using Chalk's types directly.) Should fix the last remaining issue of #2534.
* | | | Merge #5179bors[bot]2020-07-012-1/+25
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5179: ItemTree: Lower fields despite invalid type r=jonas-schievink a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/5147 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | ItemTree: Lower fields despite invalid typeJonas Schievink2020-07-012-1/+25
| | | | |
* | | | | Merge #5174bors[bot]2020-07-016-71/+71
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5174: Colorize more test fixtures r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | Colorize more test fixturesLaurențiu Nicola2020-07-016-71/+71
| | | | |
* | | | | Merge #5175bors[bot]2020-07-018-128/+148
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5175: More memory-efficient impl collection r=matklad a=jonas-schievink This saves roughly 90 MB in `ImplsFromDepsQuery`, which used to copy the list of all impls from libcore into *every* crate in the graph. It also stops collecting inherent impls from dependencies entirely, as those can only be located within the crate defining the self type. Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | Split `CrateImplDefs` in inherent and trait implsJonas Schievink2020-07-017-118/+130
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes the intention of inherent vs. trait impls somewhat more clear and also fixes (?) an issue where trait impls with an unresolved trait were added as inherent impls instead (hence the test changes).
| * | | | | Don't recursively call `impls_from_deps`Jonas Schievink2020-07-011-11/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It creates a big map and duplicates lots of impls that are then left lying around
| * | | | | Add a transitive deps iterator to `CrateGraph`Jonas Schievink2020-07-011-0/+17
| | | | | |
* | | | | | Merge #5178bors[bot]2020-07-014-318/+329
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5178: Fold multiline calls r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Fold multiline callsAleksey Kladov2020-07-013-105/+114
| | | | | |
| * | | | | Update file structure testsAleksey Kladov2020-07-011-213/+215
| | | | | |
* | | | | | Merge #5176bors[bot]2020-07-011-126/+115
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5176: Update expand macro tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Update expand macro testsAleksey Kladov2020-07-011-126/+115
|/ / / / /
* | | | | Merge #5167bors[bot]2020-07-017-39/+39
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5167: Reuse Semantics instances r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | Reuse Semantics instancesLaurențiu Nicola2020-07-017-39/+39
| | | | | |
* | | | | | Merge #5173bors[bot]2020-07-013-5/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5173: Automatically reload project on config change r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | Automatically reload project on config changeAleksey Kladov2020-07-013-5/+8
| | | | | | |
* | | | | | | Merge #5171bors[bot]2020-07-012-6/+8
|\| | | | | | | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5171: Better account for project reload r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Better account for project reloadAleksey Kladov2020-07-012-6/+8
| | | | | |
* | | | | | Merge #5169bors[bot]2020-07-017-16/+16
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5169: Add reload workspace command r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Add reload workspace commandAleksey Kladov2020-07-017-16/+16
| |/ / / /
* | | | | Merge #5168bors[bot]2020-07-011-0/+1
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5168: Log flycheck command r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Log flycheck commandAleksey Kladov2020-07-011-0/+1
|/ / / /
* | | | Merge #5110bors[bot]2020-07-012-2/+39
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5110: Use the selection range when resolving call hierarchy items r=kjeremy a=kjeremy Add a test in call_hierarchy that already passed and a corresponding heavy test to test the LSP requests which exposed the issue. Fixes #5103 Co-authored-by: Jeremy Kolb <[email protected]>
| * | | | Use the selection range when resolving call hierarchy itemsJeremy Kolb2020-07-012-2/+39
|/ / / / | | | | | | | | | | | | | | | | | | | | Add a test in call_hierarchy that already passed Fixes #5103
* | | | Merge #5162bors[bot]2020-07-012-57/+204
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5162: Try to reduce Semantics monomorphisations r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | Make less code genericLaurențiu Nicola2020-07-011-69/+47
| | | | |
| * | | | Try to reduce Semantics monomorphisationsLaurențiu Nicola2020-07-012-24/+193
| | | | |
* | | | | Merge #5164bors[bot]2020-07-011-16/+18
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5164: Dont show empty progress for empty workspaces r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Dont show empty progress for empty workspacesAleksey Kladov2020-07-011-16/+18
|/ / / / /
* | | | | Merge #5163bors[bot]2020-07-013-104/+106
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5163: Refactor parser tests a bit r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Unify magic env var nameAleksey Kladov2020-07-012-3/+3
| | | | | |
| * | | | | Move parser specific tests utils to parser testsAleksey Kladov2020-07-012-102/+104
|/ / / / /
* | | | | Merge #5159bors[bot]2020-07-019-34/+87
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5159: Don't fail expect tests in rewrite mode r=matklad a=matklad bors r+ Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Move test data to test_data directoryAleksey Kladov2020-07-018-7/+7
| | | | |
| * | | | Add file support to expectAleksey Kladov2020-07-013-21/+63
| | | | |
| * | | | CleanupAleksey Kladov2020-07-011-13/+23
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-23 10:47:15 +0000