aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| | |
| \ \
*-. \ \ Merge #9181 #9182bors[bot]2021-06-0810-59/+219
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9181: Don't complete values in type position r=jonas-schievink a=Veykril Will add some proper tests in a bit 9182: fix: don't complete derive macros as fn-like macros r=jonas-schievink a=jonas-schievink Part of https://github.com/rust-analyzer/rust-analyzer/issues/8518 bors r+ Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
| | * | | fix: don't complete derive macros as fn-like macrosJonas Schievink2021-06-084-4/+88
| | | | |
| * | | | Add tests checking no value completion in type posLukas Wirth2021-06-083-0/+55
| | | | |
| * | | | Don't complete values in type positionLukas Wirth2021-06-088-55/+76
| | |/ / | |/| |
* | | | Merge #9180bors[bot]2021-06-081-50/+56
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9180: fix: fix some IDE functionality inside attribute macros r=jonas-schievink a=jonas-schievink In `SourceToDefCtx::find_container`, we might encounter a container that has an attribute macro. We need to skip that item, instead of bailing out and creating an empty `Resolver`, otherwise all names in the macro stay unresolved. Part of https://github.com/rust-analyzer/rust-analyzer/issues/9142 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | source_to_def: skip items with no defJonas Schievink2021-06-081-50/+56
|/ / /
* | | Revert "Merge #9177"Aleksey Kladov2021-06-081-342/+335
| | | | | | | | | | | | | | | | | | | | | This reverts commit f1818cb7ba2808cba3fd9bf8f199c382060a1f19, reversing changes made to 6c9362d61b895c11b1d0cf6837ada9f2a0a30eaf. This broke things
* | | Merge #9177bors[bot]2021-06-081-335/+342
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9177: :arrow_up: npm packages r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | :arrow_up: npm packagesAleksey Kladov2021-06-081-335/+342
| | | |
* | | | Merge #9153bors[bot]2021-06-081-0/+1
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 9153: QOL: VSCode status bar icon on click now shows server status r=matklad a=Milo123459 Now, when you click the little status bar text, it will automatically reload the server. I don't think I've ever seen anyone click it randomly, and, it's there to save you a few clicks. Co-authored-by: Milo <[email protected]>
| * | | fixMilo2021-06-071-1/+1
| | | |
| * | | fixMilo2021-06-061-1/+1
| | | |
| * | | when you click status bar icon it now restarts serverMilo2021-06-061-0/+1
| | | |
* | | | Merge #9171bors[bot]2021-06-075-36/+33
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9171: internal: simplify r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | simplifyLukas Wirth2021-06-075-36/+33
| | | | |
* | | | | Merge #9170bors[bot]2021-06-077-90/+32
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9170: internal: Remove unnecessary `completion::macro_in_item_position` module r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Remove unnecessary completion::macro_in_item_positionLukas Wirth2021-06-076-72/+17
| | | | |
| * | | | Reorder CompletionContext fieldsLukas Wirth2021-06-072-18/+15
| | |/ / | |/| |
* | | | Merge #9169bors[bot]2021-06-078-30/+170
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9169: internal: steps towards attribute macro token mapping r=jonas-schievink a=jonas-schievink This doesn't work yet, but we seem to be getting a bit further along (for example, we now stop highlighting `use` items inside item with attribute macros as if they were written verbatim). bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Attempt to track attr macros during highlightingJonas Schievink2021-06-072-0/+40
| | | | |
| * | | | Make "expand macro" command work with attribute macrosJonas Schievink2021-06-072-7/+43
| | | | |
| * | | | Handle attribute macros in `descend_into_macros`Jonas Schievink2021-06-066-23/+87
| | | | |
* | | | | Merge #9144bors[bot]2021-06-071-15/+337
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9144: Extend convert_tuple_struct_to_named_struct to also apply to enum tuple variants r=matklad a=joshuawarner32 This is largely copied and adapted from the existing `convert_tuple_struct_to_named_struct` code. Not sure if maybe some of this code can/should be shared between those two assists - but the differences are significant enough to make it at least seem like a non-trivial refactor. Co-authored-by: Joshua Warner <[email protected]>
| * | | | | fmtJoshua Warner2021-06-061-3/+12
| | | | | |
| * | | | | Refactor to be just one assistJoshua Warner2021-06-053-532/+328
| | | | | |
| * | | | | Add assist for converting a tuple enum variant to a named variantJoshua Warner2021-06-052-0/+517
| | | | | |
* | | | | | Merge #9166bors[bot]2021-06-071-7/+9
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9166: Clarify label documentation r=matklad a=flodiebold Also some other cleanups while I'm there. Co-authored-by: Florian Diebold <[email protected]>
| * | | | | Further clarificationFlorian Diebold2021-06-071-1/+2
| | | | | |
| * | | | | One additional grammar fixFlorian Diebold2021-06-071-1/+1
| | | | | |
| * | | | | Clarify label documentationFlorian Diebold2021-06-071-7/+8
| | | | | | | | | | | | | | | | | | Also some other cleanups while I'm there.
* | | | | | Merge #9164bors[bot]2021-06-0712-75/+108
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9164: internal: Reduce the number of direct fields in `CompletionContext` some more r=Veykril a=Veykril Doesn't make the code much simpler yet. bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | Move more things into PathCompletionContextLukas Wirth2021-06-078-46/+62
| | | | | |
| * | | | | Simplify CompletionContext by introducing a path CallKind enumLukas Wirth2021-06-066-32/+49
| | | | | |
* | | | | | Merge #9161bors[bot]2021-06-071-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9161: Fix incorrect config usage in hover references r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | | Fix incorrect config usage in hover referencesLukas Wirth2021-06-071-1/+1
| |/ / / / /
* | | | | | Merge #9160bors[bot]2021-06-071-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9160: internal: make `Documentation::new` non-generic r=lnicola a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | | | | Make Documentation::new non-genericLaurențiu Nicola2021-06-071-2/+2
|/ / / / / /
* | | | | | Merge #9157bors[bot]2021-06-071-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9157: minor: Use HTTPS for clippy lint JSON r=lnicola a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | | | | Use HTTPS for clippy lint JSONLaurențiu Nicola2021-06-071-1/+1
|/ / / / / /
* | | | | | Merge #9106bors[bot]2021-06-072-7/+91
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9106: feat: goto definition on an impl fn goes to that fn in the trait r=lf- a=lf- e.g. if you have a trait T and `impl T for S` for some struct, if you goto definition on some function name inside the impl, it will go to the definition of that function inside the `trait T` block, rather than the current behaviour of not going anywhere at all. ![ra goto def trait the other way](https://user-images.githubusercontent.com/6652840/120403989-39aa3280-c2fa-11eb-9359-639346878acd.gif) Co-authored-by: Jade <[email protected]>
| * | | | | feat: goto def on impl items also goes to the defn in the traitJade2021-06-071-18/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was trivial to extend this to associated consts/associated types and I just didn't think of it.
| * | | | | feat: goto definition on an impl fn goes to that fn in the traitJade2021-06-072-7/+53
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e.g. if you have a trait T and `impl T for S` for some struct, if you goto definition on some function name inside the impl, it will go to the definition of that function inside the `trait T` block, rather than the current behaviour of not going anywhere at all.
* | | | | Merge #9155bors[bot]2021-06-061-2/+4
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9155: internal: replace attribute with equivalent whitespace r=jonas-schievink a=jonas-schievink This is needed to that the `TokenMap` we create contains offsets that match the source. Currently the offsets don't match because the attribute is removed, shifting all subsequent token offsets by the attribute's text length. Currently this fix has no visible effect because we don't remap tokens in attribute macros. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Replace attribute with equivalent whitespaceJonas Schievink2021-06-061-2/+4
|/ / / / | | | | | | | | | | | | | | | | This is needed to that the `TokenMap` we create contains offsets that match the source.
* | | | Merge #9149bors[bot]2021-06-051-3/+49
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9149: feat: Support goto-definition for include macros input path r=Veykril a=Veykril ![0l6l9iWPNE](https://user-images.githubusercontent.com/3757771/120891155-3fa85800-c607-11eb-9b20-7ac330dceb4b.gif) Fixes #5871 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Support goto-definition for include macro pathsLukas Wirth2021-06-051-3/+49
| | | | |
* | | | | Merge #9150bors[bot]2021-06-052-314/+731
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9150: Unescape generated clippy lints r=lnicola a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Unescape generated clippy lintsLukas Wirth2021-06-052-314/+731
| | | | |
* | | | | Merge #9140bors[bot]2021-06-054-40/+75
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9140: feat: Render documentation for derive completion r=Veykril a=Veykril ![eEzGiq2wNa](https://user-images.githubusercontent.com/3757771/120847308-9c5a3300-c573-11eb-958d-e0f22f4757ed.gif) Nothing fancy as all the std derives aren't really documented though maybe some 3rd party crates document them equally to their trait counterparts. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Complete third-party attributesLukas Wirth2021-06-041-0/+19
| | | | |