aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #4596bors[bot]2020-05-271-1/+59
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4596: Strip leading underscores of argument names in function/method r=matklad a=kuy Closes #4510 ### Goal When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names. ### Solution - Option 1: All signatures don't contain underscores - Option 2: Keep same signature, but inserted snippet doesn't contain underscores I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE. ### Other impls. rls: Complete argument names with underscores (same as actual ra) IntelliJ Rust: Doesn't complete argument names VSCode (TypeScript): Doesn't complete argument names ### Working example ![Screen Shot 2020-05-25 at 0 03 21](https://user-images.githubusercontent.com/151614/82757771-a05e5b80-9e1d-11ea-9dbc-1263c960e2ae.png) Co-authored-by: Yuki Kodama <[email protected]>
| * Trim at presentation layerYuki Kodama2020-05-252-4/+2
| |
| * Fix test to consider multiple underscoresYuki Kodama2020-05-251-7/+7
| |
| * Use built-in methodYuki Kodama2020-05-251-11/+5
| |
| * Separate assertionsYuki Kodama2020-05-251-7/+65
| |
| * Reflect test caseYuki Kodama2020-05-251-7/+7
| |
| * Strip leading underscoreYuki Kodama2020-05-251-2/+10
| |
| |
| \
*-. \ Merge #4625 #4629bors[bot]2020-05-272-7/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4625: Partially fix displaying inlay hints in Github PR diff views r=matklad a=Veetaha See the comment in https://github.com/rust-analyzer/rust-analyzer/issues/4608#issuecomment-63424257 It partially fixes the left side of diff view (the one where old code is displayed), but the diff editor with new code changes still has `file` scheme and will proceed displaying inlay hints... 4629: Fix the `should_panic` snippet r=matklad a=eminence Closes #4628 Co-authored-by: veetaha <[email protected]> Co-authored-by: Andrew Chin <[email protected]>
| | * | Fix the `should_panic` snippetAndrew Chin2020-05-261-3/+3
| | | | | | | | | | | | | | | | Closes #4628
| * | | Partially fix displaying inlay hints in Github PR diff viewsveetaha2020-05-261-4/+5
| | | |
* | | | Merge #4633bors[bot]2020-05-271-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4633: typo r=matklad a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * | | | typoVeetaha2020-05-271-1/+1
|/ / / /
* | | | Merge #4632bors[bot]2020-05-271-0/+63
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4632: Document inlay hints and runnables r=matklad a=matklad We want to change those, but let's document what we have in meantime bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Document inlay hints and runnablesAleksey Kladov2020-05-271-0/+63
| | | | | | | | | | | | | | | | | | | | We want to change those, but let's document what we have in meantime
* | | | | Merge #4622bors[bot]2020-05-274-43/+40
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4622: Pass trivially copy types as copy r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | Pass trivially copy types as copykjeremy2020-05-264-43/+40
| | |/ / | |/| |
* | | | Merge #4623bors[bot]2020-05-262-13/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4623: Update deps r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | Update lexerkjeremy2020-05-262-3/+3
| | | | |
| * | | | Update crateskjeremy2020-05-261-10/+10
|/ / / /
* | | | Merge #4621bors[bot]2020-05-261-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 4621: Highlight question mark operator r=matklad a=kuy Fixes #4597 Co-authored-by: Yuki Kodama <[email protected]>
| * | | Add question mark operatorYuki Kodama2020-05-251-1/+1
| | |/ | |/|
* | | Merge #4534bors[bot]2020-05-261-0/+59
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 4534: Add call postfix completion r=matklad a=vain0x To make it easier to wrap an expression with Ok/Some/Rc::new etc. Note I agree with conclusion of the discussion in #1431 that adding many completions is not the way to go. However, this PR still could be justified due to versatility of use. Co-authored-by: vain0x <[email protected]>
| * | Add call postfix completionvain0x2020-05-201-0/+59
| | | | | | | | | | | | To make it easier to wrap an expression with Ok/Some/Rc::new etc.
* | | Merge #4617bors[bot]2020-05-263-9/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4617: Hover tooltip module name is monospace once again r=matklad a=aloucks The line separator is also moved below the function signature to split regions between the docs. This is very similar to how IntelliJ displays tooltips. Adding an additional separator between the module name and function signature currently has rendering issues. Fixes #4594 Alternative to #4615 @kjeremy @Veetaha Note that I have semantic coloring disabled so ignore any differences due to that. ![image](https://user-images.githubusercontent.com/221559/82857507-30180e80-9edf-11ea-903a-f25c60055a93.png) ![image](https://user-images.githubusercontent.com/221559/82857407-e6c7bf00-9ede-11ea-9ae0-d348279552e7.png) Co-authored-by: Aaron Loucks <[email protected]>
| * | | Hover tooltip module name is monospace once againAaron Loucks2020-05-263-9/+12
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | The line separator is moved below the function signature to split regions between the docs. This is very similar to how IntelliJ displays tooltips. Adding an additional separator between the module name and function signature currently has rendering issues. Fixes #4594 Alternative to #4615
* | | Merge #4614bors[bot]2020-05-254-9/+8
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 4614: Fix some clippy perf warnings r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | Fix some clippy perf warningsJeremy Kolb2020-05-254-9/+8
|/ /
* | Fix conflict between nightly branch and tagAleksey Kladov2020-05-251-1/+1
| |
* | Merge pull request #4612 from matklad/fix-tagAleksey Kladov2020-05-252-1/+4
|\ \ | | | | | | Try fixing release tags
| * | Try fixing release tagsAleksey Kladov2020-05-252-1/+4
|/ / | | | | | | closes #4319
| |
| \
*-. \ Merge #4602 #4603bors[bot]2020-05-256-4/+19
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4602: Add boolean literal semantic token type to package.json r=matklad a=lnicola Closes #4583. CC @GrayJack 4603: Add self keyword semantic token type r=matklad a=lnicola Not sure if this is warranted a new token type or just a modifier. --- CC #4583, @GrayJack Co-authored-by: Laurențiu Nicola <[email protected]>
| | * | Add self keyword semantic token typeLaurențiu Nicola2020-05-256-4/+14
| | | |
| * | | Add boolean literals to package.jsonLaurențiu Nicola2020-05-251-0/+5
| |/ /
* | | Merge #4611bors[bot]2020-05-257-38/+64
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4611: Document `parentModule` experimental LSP request r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Document `parentModule` experimental LSP requestAleksey Kladov2020-05-257-38/+64
| | | |
* | | | Merge #4610bors[bot]2020-05-259-137/+93
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4610: Cleanup lsp extensions on the client side r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Cleanup lsp extensions on the client sideAleksey Kladov2020-05-259-137/+93
|/ / /
* | | Merge #4607bors[bot]2020-05-2511-55/+105
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4607: Less rust-analyzer specific onEnter r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Less rust-analyzer specific onEnterAleksey Kladov2020-05-2511-55/+105
|/ / /
* | | Merge #4605bors[bot]2020-05-2515-499/+382
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 4605: Reorganize TypeScript r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Flatten commands.tsAleksey Kladov2020-05-254-109/+103
| | |
| * | Flatten simple commandsAleksey Kladov2020-05-2510-301/+242
| | |
| * | Remove dead codeAleksey Kladov2020-05-254-106/+54
|/ /
* | Merge #4601bors[bot]2020-05-256-1/+25
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4601: Introduce `toggle inlay hints` vscode command r=matklad a=Veetaha Users now can assign a shortcut for this command via the general vscode keybindings ui or `keybindings.json` file <details> <summary>Demo</summary> ![demo](https://user-images.githubusercontent.com/36276403/82768941-b4fd1c80-9e3a-11ea-9d5b-a40fa1e4dbc6.gif) </details> <details> <summary>Howto assign a shortcut</summary> ![demo2](https://user-images.githubusercontent.com/36276403/82769350-c8a98280-9e3c-11ea-8a95-1266a539826d.gif) </details> Closes: #4599 Co-authored-by: veetaha <[email protected]>
| * | Introduce `toggle inlay hints` vscode commandveetaha2020-05-256-1/+25
|/ / | | | | | | | | | | | | | | Users now can assign a shortcut for this command via the general vscode keybindings ui or `keybinding.json file` Closes: #4599
* | Merge #4593bors[bot]2020-05-246-27/+131
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4593: Document some rust-analyzer specific protocol extensions r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fix formattingAleksey Kladov2020-05-242-4/+1
| | |
| * | Document some rust-analyzer specific protocol extensionsAleksey Kladov2020-05-242-7/+70
| | |
| * | Document matchingBrace LSP requestAleksey Kladov2020-05-246-19/+63
| | |
* | | Merge #4556bors[bot]2020-05-2410-12/+33
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 4556: More highlighting improvements r=matthewjasper a=matthewjasper * Separate `true` and `false` from keywords (this matches the Textmate grammar). * Handle more cases in `highlight_name_by_syntax`. Co-authored-by: Matthew Jasper <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 14:10:33 +0000