aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge #6964bors[bot]2020-12-228-74/+363
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6964: Add full pattern completions for Struct and Variant patterns r=matklad a=Veykril Just gonna call it full pattern completion as pattern completion is already implemented in a sense by showing idents in pattern position. What this does is basically complete struct and variant patterns where applicable(function params, let statements and refutable pattern locations). This does not replace just completing the corresponding idents of the structs and variants, instead two completions are shown for these, a completion for the ident itself and a completion for the pattern(if the pattern make sense to be used that is). I figured in some cases one would rather type out the pattern manually if it has a lot of fields but you only care about one since this completion would cause one more work in the end since you would have to delete all the extra matched fields again. These completions are tagged as `CompletionKind::Snippet`, not sure if that is the right one here. <details> <summary>some gifs</summary> ![dx2lxgzhj3](https://user-images.githubusercontent.com/3757771/102719967-6987ef80-42f1-11eb-8ae0-8aff53777860.gif) ![EP2E7sJLkB](https://user-images.githubusercontent.com/3757771/102785777-c7264580-439e-11eb-8a64-f142e19fb65b.gif) ![JMNHHWknr9](https://user-images.githubusercontent.com/3757771/102785796-d1e0da80-439e-11eb-934b-218ada31b51c.gif) </details> Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | Reduce some more code duplicationLukas Wirth2020-12-225-94/+76
| | | | | |
| * | | | | Insert snippet positions after fields names in record patternsLukas Wirth2020-12-212-6/+6
| | | | | |
| * | | | | Create non-exhaustive patterns for non_exhaustive attributed itemsLukas Wirth2020-12-201-3/+5
| | | | | |
| * | | | | Reduce code duplication in pattern completionLukas Wirth2020-12-201-34/+29
| | | | | |
| * | | | | Emit snippets for struct pattern completion if enabledLukas Wirth2020-12-202-15/+36
| | | | | |
| * | | | | Add completions for patternsLukas Wirth2020-12-206-26/+315
| | |/ / / | |/| | |
* | | | | Merge #7001bors[bot]2020-12-221-6/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7001: Add support for downloading aarch64-apple-darwin binaries r=matklad a=lnicola There's also a slight behavior change here: we no longer download our 64-binaries on 32-bit Darwin and Linux. We still do that on Windows, as I don't know how to detect 32-bit Node on 64 Windows. But some people install the 32-bit Code by mistake, I doubt 32-bit Windows is that popular in the Rust crowd. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | Add support for downloading aarch64-apple-darwin binaries, change naming ↵Laurențiu Nicola2020-12-221-6/+8
| | |_|/ / | |/| | | | | | | | | | | | | convention
* | | | | Merge #7005bors[bot]2020-12-221-103/+66
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7005: Improve extract_module_to_file assist r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Improve extract_module_to_file assistAleksey Kladov2020-12-221-103/+66
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | * simplify code * correctly handle crate roots and mod.rs files (nested inline modules are still mishandled) * make sure that new text contains a trailing newline
* | | | | Merge #7002bors[bot]2020-12-221-5/+15
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7002: Extension conflict check detects more combinations r=extremegf a=extremegf This will also detect conflicts with kalitaalexey.vscode-rust and work correctly after RA is integrated with rust-lang.rust extension. Co-authored-by: Przemyslaw Horban <[email protected]> Co-authored-by: P. Horban <[email protected]>
| * | | | | Fix grammar nitP. Horban2020-12-221-1/+1
| | | | | | | | | | | | | | | | | | Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | Extension conflict check detests more combinationsPrzemyslaw Horban2020-12-221-5/+15
| | |/ / / | |/| | |
* | | | | Merge #6993bors[bot]2020-12-223-55/+55
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6993: Clean up descriptions for settings r=matklad a=rherrmann Use two consecutive newlines (`\n\n`) to actually continue text on a new line. Use proper markup to reference related settings. Consistently format references to files, command line arguments, etc. as `code`. Format mentions of UI elements in _italic_. Fix typos, add missing full-stops, add missing default values. Co-authored-by: Rüdiger Herrmann <[email protected]>
| * | | | Clean up descriptions for settingsRüdiger Herrmann2020-12-223-55/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use two consecutive newlines (`\n\n`) to actually continue text on a new line. Use proper markup to reference related settings. Consistently format references to files, editor commands, command line arguments, files, etc. as `code`. Fix typos, add missing full-stops, add missing default values.
* | | | | Merge #6999bors[bot]2020-12-220-0/+0
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6999: Build aarch64-apple-darwin binaries on CI (take 2) r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | Build aarch64-apple-darwin binaries on CILaurențiu Nicola2020-12-222-32/+154
| | |/ / / | |/| | |
* | | | | Merge #6989bors[bot]2020-12-222-32/+154
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6989: Build aarch64-apple-darwin binaries on CI r=matklad a=lnicola This splits the `dist` matrix job into four and tries to make `xtask dist` more principled about target and artifact naming. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | Build aarch64-apple-darwin binaries on CILaurențiu Nicola2020-12-222-32/+154
| | | | |
* | | | | Merge #6746bors[bot]2020-12-2210-19/+252
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6746: Feature/add assist extract module to file r=matklad a=sasurau4 Fix #6522 ## Screenshot <img src="https://user-images.githubusercontent.com/13580199/102748269-33a44300-43a5-11eb-9e37-f5fcb8e62f73.gif" width=600 /> ## TODO - [x] Remove all TODO comment - [x] Pass the doc test Co-authored-by: Daiki Ihara <[email protected]>
| * | | | | Use workspace applyEdit instead of snippetWorkspaceEditDaiki Ihara2020-12-211-1/+1
| | | | | |
| * | | | | Fix assist test logicDaiki Ihara2020-12-211-2/+6
| | | | | |
| * | | | | Update test diagnostics in ideDaiki Ihara2020-12-211-0/+1
| | | | | |
| * | | | | Add initial_contents field for CreateFileDaiki Ihara2020-12-215-50/+47
| | | | | |
| * | | | | Add extract_module_to_file assistDaiki Ihara2020-12-213-0/+187
| | | | | |
| * | | | | Add handling file_system_edit in test assistsDaiki Ihara2020-12-212-15/+59
| | | | | |
* | | | | | Merge #6984bors[bot]2020-12-223-1146/+0
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6984: Remove TextMate grammar r=dustypomerleau a=lnicola Closes #6267 This is now included upstream in VS Code. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | Remove TextMate grammarLaurențiu Nicola2020-12-213-1146/+0
| | | | | | | | | | | | | | | | | | | | | | | | It's now included upstream in VS Code
* | | | | | Merge #6991bors[bot]2020-12-211-1/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6991: Don't download x64 binaries on non-Mac arm64 r=lnicola a=lnicola bors r+ Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | | Don't download x64 binaries on non-Mac arm64Laurențiu Nicola2020-12-211-1/+3
|/ / / / / /
* | | | | | Merge #6990bors[bot]2020-12-211-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6990: Allow code extension to download binary in apple arm r=lnicola a=phungleson Apple chip has a new `arch`. It subsequently downloads Intel version of `rust-analyzer` but it works regardless. Co-authored-by: Son <[email protected]>
| * | | | | | Allow code extension to download binary in apple armSon2020-12-211-1/+1
|/ / / / / /
* | | | | | Merge #6988bors[bot]2020-12-211-3/+2
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6988: Remove outdated FIXME r=lnicola a=lnicola bors r+ Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | Remove outdated FIXMELaurențiu Nicola2020-12-211-3/+2
|/ / / / /
* | | | | Merge #6985bors[bot]2020-12-211-1/+10
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6985: Use /etc/os-release to check for NixOS r=matklad a=lnicola Closes #5641 The motivation in #5641 isn't too strong, but /etc/os-release exists on pretty much every Linux distro, while /etc/nixos sounds like an implementation detail. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | Use /etc/os-release to check for NixOSLaurențiu Nicola2020-12-211-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The motivation in #5641 isn't too strong, but /etc/os-release exists on pretty much every Linux distro, while /etc/nixos sounds like an implementation detail.
* | | | | | Merge #6987bors[bot]2020-12-211-7/+74
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6987: Delete related whitespace when removing unused param r=matklad a=rherrmann Include adjacent whitespace in the text edits to remove the parameter declaration and its occurences in calling code. https://github.com/rust-analyzer/rust-analyzer/issues/6663 Co-authored-by: Rüdiger Herrmann <[email protected]>
| * | | | | Delete related whitespace when removing unused paramRüdiger Herrmann2020-12-211-7/+74
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Include adjacent whitespace in the text edits to remove the parameter declaration and its occurences in calling code. https://github.com/rust-analyzer/rust-analyzer/issues/6663
* | | | | Merge #6982bors[bot]2020-12-212-1/+16
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6982: Remove parentheses when inverting `!(cond)` r=matklad a=Jesse-Bakker Followup to #6894 When inverting a composite condition twice, the parentheses were left. This also removes those unnecessary parentheses when applying the invert-if assist. Co-authored-by: Jesse Bakker <[email protected]>
| * | | | Remove parentheses when inverting `!(cond)`Jesse Bakker2020-12-212-1/+16
| | |_|/ | |/| |
* | | | Merge #6981bors[bot]2020-12-211-6/+42
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6981: Acquire original text range when searching for references r=Veykril a=Veykril Fixes #6976 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Acquire original text range when searching for referencesLukas Wirth2020-12-211-6/+42
|/ / / /
* | | | Merge #6978bors[bot]2020-12-211-0/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6978: Filter out empty rustc spans r=lnicola a=jonas-schievink Hopefully, this fixes https://github.com/rust-analyzer/rust-analyzer/issues/6892 (I couldn't test it since r-a currently requires a too recent version of VS Code) Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Filter out empty rustc spansJonas Schievink2020-12-211-0/+4
| |/ / /
* | | | Merge #6977bors[bot]2020-12-211-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6977: Revert "Stop setting CompletionItem::deprecated" r=lnicola a=lnicola We should keep setting it, according to https://github.com/rust-analyzer/rust-analyzer/pull/6974#issuecomment-748983789. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | Revert "Stop setting CompletionItem::deprecated"Laurențiu Nicola2020-12-211-1/+1
|/ / / / | | | | | | | | | | | | This reverts commit 299ce609952dfaa6bef86e967c5632e8e42b8fca.
* | | | Merge #6974bors[bot]2020-12-211-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6974: Stop setting CompletionItem::deprecated r=matklad a=lnicola Closes #2042 We're now using the `CompletionItem::tags` field to mark `CompletionItem`s as deprecated, and `CompletionItem::deprecated` is gone from LSP. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Stop setting CompletionItem::deprecatedLaurențiu Nicola2020-12-211-1/+1
|/ / /
* | | Merge #6965bors[bot]2020-12-217-147/+199
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6965: Properly attach attributes to Param instead of parent ParamList r=matklad a=Veykril Fixes #2783, fixes #2781 The problem with `let _a = [0,#[cfg(feature = "L")]0];` has already been fixed some time ago it seems: <details> <summary>Syntax Tree for the const item</summary> ``` [email protected] [email protected] "let" [email protected] " " [email protected] [email protected] [email protected] "_a" [email protected] " " [email protected] "=" [email protected] " " [email protected] [email protected] "[" [email protected] [email protected] "0" [email protected] "," [email protected] [email protected] [email protected] "#" [email protected] "[" [email protected] [email protected] [email protected] [email protected] "cfg" [email protected] [email protected] "(" [email protected] "feature" [email protected] " " [email protected] "=" [email protected] " " [email protected] "\"L\"" [email protected] ")" [email protected] "]" [email protected] "0" [email protected] "]" [email protected] ";" ``` </details> Co-authored-by: Lukas Wirth <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 05:06:15 +0000