aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* vscode: fix vscode-vim keybindings conflictVeetaha2020-02-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | vscode-vim extension overrides the `type` command so that it prevents some keypresses to reach the text document editor. It conflicts with our `onEnter` keybinding that is used to support automatic doc comments extending and indentation insertion. The VSCode-native way to implement this would be to use regular expressions, but as per matklad it is considered not acceptable for the language server. Thus we implement it via a `Enter` keybinding that invokes our `onEnter` command which sends a request to rust-analyzer process and applies the appropriate source change recieved from it. At the end of the day we may only apply ad hoc workarounds for conflicting extensions. But vscode has another bug for that. You either cannot use parantheses in `when` condition of a keybinding or it just malfunctions. See an issue about that here: https://github.com/microsoft/vscode/issues/91473 To get the ultimate context, follow this zulip thread: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Enhanced.20typing
* Merge #3305bors[bot]2020-02-251-11/+13
|\ | | | | | | | | | | | | | | | | | | | | 3305: Simplify r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * SimplifyAleksey Kladov2020-02-251-11/+13
| |
* | Merge #3304bors[bot]2020-02-252-3/+3
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 3304: :arrow_up: rowan r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * :arrow_up: rowanAleksey Kladov2020-02-252-3/+3
|/
* Merge #3303bors[bot]2020-02-252-15/+7
|\ | | | | | | | | | | | | | | | | | | | | 3303: Simplify r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * SimplifyAleksey Kladov2020-02-252-15/+7
|/
* Merge #3298bors[bot]2020-02-254-65/+74
|\ | | | | | | | | | | | | | | 3298: Bump chalk and replace TypeFamily with Interner r=flodiebold a=lnicola Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * Bump chalk and replace TypeFamily with InternerLaurențiu Nicola2020-02-244-65/+74
| |
* | Merge #3302bors[bot]2020-02-252-13/+14
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3302: Replace generic with a concrete type r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Replace generic with a concrete typeAleksey Kladov2020-02-252-13/+14
| | |
* | | Merge #3295bors[bot]2020-02-253-21/+42
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3295: Refactoring fetchArtifactReleaseInfo() r=matklad a=Veetaha https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-type-assertion.md I fact this rule doesn't work when you put an unnecessary non-null assertion in an expression (as we had `(awat f())!`, but it is useful in other cases... Closes #3295, i guess... Co-authored-by: Veetaha <[email protected]>
| * | vscode: wrap non-single-line if body with curlies as per matkladVeetaha2020-02-241-3/+5
| | |
| * | vscode: remove type assertionVeetaha2020-02-242-2/+3
| | |
| * | add error handling to fetchArtifactReleaseInfo(), throw Error when no ↵Veetaha2020-02-241-19/+37
| |/ | | | | | | artifact found
* | Merge #3159bors[bot]2020-02-259-40/+247
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3159: Server-side Semantic Tokens r=matklad a=kjeremy Takes the output of `syntax_highlighting` and converts it to the proposed semantic tokens API (so far only `textDocument/semanticTokens`. There's a lot of cool stuff we could do with this and the "Inspect Editor Tokens and Scopes" vscode command (pic below) is a cool way to see what has tokens and what doesn't. Incredibly hacky and could panic due to unwraps, `panic!` etc. To use: run with `code-insiders --enable-proposed-api matklad.rust-analyzer`. If you try to run this without `--enable-proposed-api` it will crash. ![image](https://user-images.githubusercontent.com/4325700/74595603-7c66cf00-5011-11ea-9593-312663f04fc1.png) @matklad I'm mostly looking for design feedback. Co-authored-by: kjeremy <[email protected]> Co-authored-by: Jeremy Kolb <[email protected]>
| * | Add docsJeremy Kolb2020-02-251-0/+8
| | |
| * | Teach the server about Semantic Tokens proposed LSPkjeremy2020-02-259-40/+239
| | |
* | | Merge #3299bors[bot]2020-02-2515-198/+203
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3299: vscode: migrate to request type api r=matklad a=Veetaha More type-safety to the god of type-safety. Co-authored-by: Veetaha <[email protected]>
| * | vscode: migrate rust-analyzer-api to import * as lc as per matklad and kjeremyVeetaha2020-02-241-23/+23
| | |
| * | vscode: run fmtVeetaha2020-02-241-1/+1
| | |
| * | vscode: migrate inlay_hints to rust-analyzer-api.tsVeetaha2020-02-242-31/+16
| | |
| * | vscode: migrate syntax_tree to rust-analyzer-api.tsVeetaha2020-02-241-20/+7
| | |
| * | vscode: migrate ssr to rust-analyzer-api.tsVeetaha2020-02-241-11/+5
| | |
| * | vscode: migrate runnables to rust-analyzer-api.tsVeetaha2020-02-241-22/+7
| | |
| * | vscode: migrate parent_module to rust-analyzer-api.tsVeetaha2020-02-241-7/+3
| | |
| * | vscode: migrate on_enter to rust-analyzer-api.tsVeetaha2020-02-241-14/+7
| | |
| * | vscode: migrate matching_brace to rust-analyzer-api.tsVeetaha2020-02-241-12/+3
| | |
| * | vscode: migrate join_lines to rust-analyzer-api.tsVeetaha2020-02-241-13/+4
| | |
| * | vscode: migrate collectGarbage to rust-analyzer-api.tsVeetaha2020-02-241-5/+4
| | |
| * | vscode: migrate expand_macro to rust-analyzer-api.tsVeetaha2020-02-241-13/+5
| | |
| * | vscode: migrate analyzer_status to rust-analyzer-api.tsVeetaha2020-02-241-4/+2
| | |
| * | vscode: migrate highlighting to rust-analyzer-api.tsVeetaha2020-02-241-39/+21
| | |
| * | vscode: migrate source_cnage.rs to rust-analyzer-api.rsVeetaha2020-02-241-7/+2
| | |
| * | vscode: create rust-analyzer-api.tsVeetaha2020-02-241-0/+117
| |/
* | Merge #3296bors[bot]2020-02-242-4/+4
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | 3296: vscode: bump TypeScript version r=matklad a=Veetaha There is a new [`type-only` import and export feature](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#-type-only-imports-and-export), but let's keep our codebase as simple as it is now. Also, top-level await :tada:, though with a caveat )) ![image](https://user-images.githubusercontent.com/36276403/75185341-93629b00-574e-11ea-8d5c-4a4293f140f7.png) Co-authored-by: Veetaha <[email protected]>
| * vscode: bump TypeScript versionVeetaha2020-02-242-4/+4
|/
* Merge #3294bors[bot]2020-02-242-8/+53
|\ | | | | | | | | | | | | | | | | | | | | 3294: When joining lines, unwrap trivial diverging blocks r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * When joining lines, unwrap trivial diverging blocksAleksey Kladov2020-02-242-8/+53
| |
* | Merge #3293bors[bot]2020-02-241-2/+2
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 3293: Cleanp r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * CleanpAleksey Kladov2020-02-241-2/+2
|/
* Merge #3291bors[bot]2020-02-241-6/+6
|\ | | | | | | | | | | | | | | 3291: Update deps r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * Update depsJeremy Kolb2020-02-241-6/+6
|/
* Merge #3290bors[bot]2020-02-241-0/+6
|\ | | | | | | | | | | | | | | | | | | | | | | | | 3290: Don't block onEnter if request fails r=matklad a=matklad closes #3286 bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Don't block onEnter if request failsAleksey Kladov2020-02-241-0/+6
| | | | | | | | closes #3286
* | Merge #3288bors[bot]2020-02-241-2/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | 3288: Quick fix circular json error when sanity-check fails r=matklad a=Veetaha Related issue: #3280 Co-authored-by: Veetaha <[email protected]>
| * | Quick fix circular json error when sanity-check failsVeetaha2020-02-241-2/+5
| | | | | | | | | Related issue: #3280
* | | Merge #3289bors[bot]2020-02-241-0/+23
|\ \ \ | |/ / |/| / | |/ | | | | | | | | | | | | | | | | | | 3289: Don't break onEnter if rust-analyzer fails to start r=matklad a=matklad closes #3253 bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Don't break onEnter if rust-analyzer fails to startAleksey Kladov2020-02-241-0/+23
|/ | | | closes #3253
* Merge #3287bors[bot]2020-02-241-92/+125
|\ | | | | | | | | | | | | | | | | 3287: Omit type hints for enum variant bind pats r=matklad a=SomeoneToIgnore After using new hints for a while, I've started to think that hints for enum variants are an overkill. Another user also shares the same toughts: https://github.com/rust-analyzer/rust-analyzer/issues/3273#issuecomment-590172297 Co-authored-by: Kirill Bulatov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-19 18:38:31 +0100