aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge #3026bors[bot]2020-02-1856-650/+452
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3026: ra_syntax: reshape SyntaxError for the sake of removing redundancy r=matklad a=Veetaha Followup of #2911, also puts some crosses to the todo list of #223. **AHTUNG!** A big part of the diff of this PR are test data files changes. Simplified `SyntaxError` that was `SyntaxError { kind: { /* big enum */ }, location: Location }` to `SyntaxError(String, TextRange)`. I am not sure whether the tuple struct here is best fit, I am inclined to add names to the fields, because I already provide getters `SyntaxError::message()`, `SyntaxError::range()`. I also removed `Location` altogether ... This is currently WIP, because the following is not done: - [ ] ~~Add tests to `test_data` dir for unescape errors *// I don't know where to put these errors in particular, because they are out of the scope of the lexer and parser. However, I have an idea in mind that we move all validators we have right now to parsing stage, but this is up to discussion...*~~ **[UPD]** I came to a conclusion that tree validation logic, which unescape errors are a part of, should be rethought of, we currently have no tests and no place to put tests for tree validations. So I'd like to extract potential redesign (maybe move of tree validation to ra_parser) and adding tests for this into a separate task. Co-authored-by: Veetaha <[email protected]> Co-authored-by: Veetaha <[email protected]>
| * ra_syntax: fix reparsing merging errors, also now reparse_token() reports errorsVeetaha2020-02-181-7/+50
| |
| * ra_syntax: migrate test data to 0-length text-range of SyntaxError when ↵Veetaha2020-02-1746-242/+242
| | | | | | | | constructed from TextUnit
| * ra_syntax: remove message() method and use only Display trait in SyntaxError ↵Veetaha2020-02-172-4/+1
| | | | | | | | as per matklad
| * ra_syntax: change module-level documentation for syntax_error to "see X" as ↵Veetaha2020-02-171-1/+1
| | | | | | | | per matklad
| * ra_syntax: followup fix for making SyntaxError::range() to return by valueVeetaha2020-02-171-1/+1
| |
| * ra_syntax: SyntaxError::range() now returns by valueVeetaha2020-02-174-12/+6
| |
| * ra_syntax: moved reexport declaration after imports as per matkladVeetaha2020-02-171-1/+2
| |
| * ra_syntax: Apply Aleksei Kladov suggestion about TextRange of TextUnitVeetaha2020-02-171-1/+1
| | | | | | Co-Authored-By: Aleksey Kladov <[email protected]>
| * Change semmantical analyzis to tree validation as per @matkladVeetaha2020-02-171-1/+1
| | | | | | Co-Authored-By: Aleksey Kladov <[email protected]>
| * ra_syntax: reshape SyntaxError for the sake of removing redundancyVeetaha2020-02-1755-637/+404
| |
* | Merge pull request #3204 from ↵Aleksey Kladov2020-02-181-1/+0
|\ \ | | | | | | | | | | | | Veetaha/feature/vscode-remove-updates-notification-comment vscode: remove comment about updates notification
| * | vscode: remove comment about updates notificationVeetaha2020-02-171-1/+0
| |/
* | Merge pull request #3216 from matklad/rename-to-rust-analyzerAleksey Kladov2020-02-1843-111/+111
|\ \ | | | | | | rename binary to rust-analyzer
| * | Rename folderAleksey Kladov2020-02-1825-0/+0
| | |
| * | Rename config value for server PathAleksey Kladov2020-02-186-7/+7
| | |
| * | Rename the binary to rust-analyzerAleksey Kladov2020-02-1823-107/+107
| | |
* | | Merge #3214bors[bot]2020-02-1818-82/+105
|\| | | | | | | | | | | | | | | | | | | | | | | 3214: Fully document ra_lsp_server r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fully document ra_lsp_serverAleksey Kladov2020-02-188-11/+20
| | |
| * | RefactorAleksey Kladov2020-02-182-52/+52
| | |
| * | Reduce visibilityAleksey Kladov2020-02-181-6/+9
| | |
| * | RefactorAleksey Kladov2020-02-182-4/+3
| | |
| * | Some docsAleksey Kladov2020-02-187-15/+23
| | |
| * | Better folder structureAleksey Kladov2020-02-184-1/+5
|/ /
* | Merge #3211bors[bot]2020-02-181-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | 3211: Fix typo r=edwin0cheng a=atsisy Just fix typo in user/doc/readme.adoc Co-authored-by: Akihiro Takai <[email protected]>
| * | Fix typoAkihiro Takai2020-02-181-1/+1
|/ /
* | Merge pull request #3209 from matklad/eslintAleksey Kladov2020-02-187-80/+902
|\ \ | | | | | | Eslint
| * | Allow floating promisesAleksey Kladov2020-02-181-1/+0
| | | | | | | | | | | | This backfires for message-showing functions
| * | Gate stuff on CIAleksey Kladov2020-02-181-0/+2
| | |
| * | Migrate to eslintAleksey Kladov2020-02-176-80/+901
| | |
* | | Merge #3210bors[bot]2020-02-172-8/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3210: vscode-languageclient 6.1.1 r=kjeremy a=kjeremy Fixes semantic token mispellings Co-authored-by: kjeremy <[email protected]>
| * | | vscode-languageclient 6.1.1kjeremy2020-02-172-8/+8
|/ / /
* | | Merge #3206bors[bot]2020-02-172-29/+47
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 3206: Install rust-src when it is not found r=SomeoneToIgnore a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/2858 Looks like there's no RUSTUP env variable, so it adds one more thing to solve in https://github.com/rust-analyzer/rust-analyzer/issues/3154 Co-authored-by: Kirill Bulatov <[email protected]>
| * | Simplify the command executionKirill Bulatov2020-02-171-34/+28
| | |
| * | Simplify the code furtherKirill Bulatov2020-02-171-45/+35
| | |
| * | Idempotent location and installation of rust srcKirill Bulatov2020-02-171-47/+56
| | |
| * | Reword the docsKirill Bulatov2020-02-171-1/+1
| | | | | | | | | Co-Authored-By: Laurențiu Nicola <[email protected]>
| * | Install rust-src when it is not foundKirill Bulatov2020-02-172-9/+34
|/ /
* | Merge #3203bors[bot]2020-02-177-17/+17
|\ \ | |/ |/| | | | | | | | | | | 3203: vscode: press ; to respect semicolons r=matklad a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * vscode: press ; to respect semicolonsVeetaha2020-02-177-17/+17
| |
* | Merge #3202bors[bot]2020-02-174-19/+15
|\ \ | | | | | | | | | | | | | | | | | | | | | 3202: Fix RA_PROF and replace ra_cli mentions r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Replace ra_cli mentionsLaurențiu Nicola2020-02-174-17/+13
| | |
| * | Fix RA_PROFILE typo in docsLaurențiu Nicola2020-02-171-2/+2
|/ /
* | Merge #3200bors[bot]2020-02-1716-230/+201
|\ \ | |/ |/| | | | | | | | | | | 3200: Merge ra_vfs_glob and ra_lsp_server r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Merge ra_vfs_glob and ra_lsp_serverAleksey Kladov2020-02-1710-26/+12
| |
| * Merge cli and ra_lsp_serverAleksey Kladov2020-02-1711-205/+190
| |
* | Merge #3199bors[bot]2020-02-176-182/+232
|\| | | | | | | | | | | | | | | 3199: Use anyhow r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Use anyhowAleksey Kladov2020-02-175-14/+16
| |
| * CleanupAleksey Kladov2020-02-172-73/+68
| |
| * Better nameAleksey Kladov2020-02-171-2/+2
| |