aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #3432bors[bot]2020-03-042-14/+22
|\ | | | | | | | | | | | | | | | | | | | | | | 3432: Feature/snippet completions r=matklad a=iTZAvishay This PR implements #1705 and is based on #3430 to avoid future conflicts. The completions are placing default values with the names of the parameters, demo: ![call_me_demo](https://user-images.githubusercontent.com/5567310/75828341-461ca400-5db4-11ea-88d8-88e59ac1a197.gif) Co-authored-by: Avishay Matayev <[email protected]>
| * Support function's completion snippetAvishay Matayev2020-03-042-14/+22
| | | | | | | | | | | | | | Note that `detail` was replced with `function_signature` to avoid calling `from` on FunctionSignature twice. I didn't add new tests because the current ones seem enough.
* | Merge #3438bors[bot]2020-03-048-7/+37
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 3438: Remove stray FIXME r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Remove stray FIXMEAleksey Kladov2020-03-041-3/+0
| |
| * Support cross-crate marksAleksey Kladov2020-03-047-4/+37
|/
* Merge #3429bors[bot]2020-03-042-2/+39
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3429: Fix panic on eager expansion r=matklad a=edwin0cheng When lazy expanding inside an eager macro, its *parent* file of that lazy macro call must be already exists such that a panic is occurred because that parent file is the eager macro we are processing. This PR fix this bug by store the argument syntax node as another eager macro id for that purpose. Personally I don't know if it is a good answer for this bug. Co-authored-by: Edwin Cheng <[email protected]>
| * Fixed a typo in commentEdwin Cheng2020-03-031-1/+1
| |
| * Fix panic on eager expansionEdwin Cheng2020-03-032-2/+39
| |
* | Merge #3430bors[bot]2020-03-032-4/+54
|\ \ | | | | | | | | | | | | | | | | | | | | | 3430: Fix completion snippet for reexported functions r=matklad a=flodiebold Fixes #3356. Co-authored-by: Florian Diebold <[email protected]>
| * | Fix completion snippet for reexported functionsFlorian Diebold2020-03-032-4/+54
|/ / | | | | | | Fixes #3356.
* | Merge #3428bors[bot]2020-03-038-122/+90
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | 3428: Move reference classification to ra_ide_db r=matklad a=matklad Lost some marks along the way :-( bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix importsAleksey Kladov2020-03-035-19/+14
| |
| * Move reference classification to ra_ide_dbAleksey Kladov2020-03-035-104/+77
| | | | | | | | Lost some marks along the way :-(
* | Merge #3427bors[bot]2020-03-039-106/+104
|\| | | | | | | | | | | | | | | | | | | | | 3427: Rename NameDefinition -> Definition r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Actually include readme into .vsixAleksey Kladov2020-03-031-0/+1
| |
| * Rename NameDefinition -> DefinitionAleksey Kladov2020-03-038-106/+103
| |
* | Merge #3392bors[bot]2020-03-0311-82/+399
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3392: Implement concat eager macro r=matklad a=edwin0cheng This PR implements the following things: 1. Add basic eager macro infrastructure by introducing `EagerCallId` such that the new `MacroCallId` is defined as : ``` #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] pub enum MacroCallId { LazyMacro(LazyMacroId), EagerMacro(EagerMacroId), } ``` 2. Add `concat!` builtin macro. Co-authored-by: Edwin Cheng <[email protected]>
| * Fix for rebasingEdwin Cheng2020-03-031-3/+14
| |
| * Move pub function firstEdwin Cheng2020-03-031-24/+24
| |
| * Add doc about eager expansion name resolutionEdwin Cheng2020-03-031-0/+19
| |
| * Add testEdwin Cheng2020-03-031-0/+19
| |
| * Implement concat macroEdwin Cheng2020-03-0310-77/+305
| |
| * Add LazyMacroIdEdwin Cheng2020-03-035-16/+56
| |
* | Merge #3426bors[bot]2020-03-033-27/+74
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 3426: Refactor reference search a bit r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Refactor reference search a bitAleksey Kladov2020-03-033-27/+74
| |
* | Merge #3425bors[bot]2020-03-033-6/+16
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | 3425: Fix a bug for single dollar sign macro r=matklad a=edwin0cheng This PR fixed a bug to allow the following valid `macro_rules!` : ```rust macro_rules! m { ($) => ($) } ``` Co-authored-by: Edwin Cheng <[email protected]>
| * Fix a bug for single dollar sign macroEdwin Cheng2020-03-033-6/+16
| |
* | Merge #3422bors[bot]2020-03-031-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3422: Add profile call r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add profile callAleksey Kladov2020-03-031-0/+1
| | |
* | | Merge #3424bors[bot]2020-03-034-57/+85
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 3424: Highlight assist tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Highlight assist testsAleksey Kladov2020-03-033-49/+53
| | |
| * | Fix applicability of inline localAleksey Kladov2020-03-033-10/+34
| | |
* | | Merge #3423bors[bot]2020-03-031-2/+2
|\| | | |/ |/| | | | | | | | | | | | | | | | | 3423: Remove stray dbg r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Remove stray dbgAleksey Kladov2020-03-031-2/+2
|/
* Merge #3388bors[bot]2020-03-035-15/+25
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3388: Remove inlay hint in diff views r=matklad a=vbfox If the left side of a diff view that contain the old version of the file apply inlays they are misplaced and produce a weird display: ![image](https://user-images.githubusercontent.com/131878/75628802-b1ac1900-5bdc-11ea-8c26-6722d8e38371.png) After the change: ![image](https://user-images.githubusercontent.com/131878/75628831-e91ac580-5bdc-11ea-9039-c6b4ffbdb2be.png) The detection is done by blacklisting the url schemes used by git and subversion scm extensions, whitelisting `file` is also possible but neither is perfect as VSCode now support both pluggable scm extensions and pluggable remote filesystems. But I suspect that the list of scm extensions is more easily manageable. **Note**: I can rebase on #3378 if needed as it touches the same lines of code Co-authored-by: Julien Roncaglia <[email protected]>
| * Centralize the check for languageId on documentJulien Roncaglia2020-03-025-24/+25
| | | | | | | | Also move visibleRustEditors to Ctx
| * Remove inlay in diff viewsJulien Roncaglia2020-03-011-1/+10
| | | | | | | | | | | | | | | | If the left side of a diff view that contain the old version of the file apply inlays they are misplaced. The detection is done by blacklisting the url schemes used by git and subversion scm extensions.
* | Merge #3420bors[bot]2020-03-032-70/+105
|\ \ | | | | | | | | | | | | | | | | | | | | | 3420: Update code dependencies r=matklad a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | Update code dependenciesJeremy Kolb2020-03-032-70/+105
|/ /
* | Merge #3417bors[bot]2020-03-033-11/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | 3417: Drop larlpop-intern dependency r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Drop larlpop-intern depLaurențiu Nicola2020-03-033-11/+2
| | |
* | | Merge #3416bors[bot]2020-03-032-3/+6
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 3416: Clean xtask partial artifacts in `xtask pre-cache` r=matklad a=CAD97 Confirmed that these aren't getting deleted locally. This won't actually change what's cached until the cache key changes. Co-authored-by: Christopher Durham <[email protected]>
| * | Clean xtask partial artifacts in `xtask pre-cache`Christopher Durham2020-03-032-3/+6
|/ /
* | Merge #3413bors[bot]2020-03-023-31/+27
|\ \ | | | | | | | | | | | | | | | | | | | | | 3413: Update chalk for RawId removal, Ty interners r=flodiebold a=lnicola r? @flodiebold Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Update chalk for Ty internersLaurențiu Nicola2020-03-023-17/+20
| | |
| * | Update chalk for RawId removalLaurențiu Nicola2020-03-023-23/+16
|/ /
* | Merge #3410bors[bot]2020-03-021-4/+4
|\ \ | | | | | | | | | | | | | | | | | | | | | 3410: Update deps r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Update depskjeremy2020-03-021-4/+4
| | |
* | | Merge #3408bors[bot]2020-03-021-2/+2
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3408: Simplify by using to_vec r=kiljacken a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Simplify by using to_veckjeremy2020-03-021-2/+2
|/ /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 16:51:58 +0000