aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #2834bors[bot]2020-01-141-35/+26
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2834: refactor(ra_syntax.validation): removed code duplication from validate_literal() r=kiljacken a=Veetaha Hi! This is my first ever contribution to this project. I've taken some dirty job from issue #223 This is a simple atomic PR to remove code duplication according to FIXME comment in the function that is the main focus of the further development. I just didn't want to mix refactoring with the implementation of new features... I am not sure whether you prefer such atomic PRs here or you'd rather have a single PR that contains all atomic commits inside of it? So if you want me to add all that validation in one PR I'll mark this one as WIP and update it when the work is finished, otherwise, I'll go with the option of creating separate PRs per each feature of validation of strings, numbers, and comments respectively. ### Comments about refactoring Yeah, reducing the duplication is quite hard here, extracting into stateless functions could be another option but the number of their arguments would be very big and repeated across char and string implementations so that just writing their types and names would become cumbersome. I tried the option of having everything captured implicitly in the closure but failed since rust doesn't have templated (or generic) closures as C++ does, this is needed because `unescape_byte*()` and `unescape_char|str()` have different return types... Maybe I am missing something here? I may be wrong because I am not enough experienced in Rust... Well, I am awaiting any kind of feedback! Co-authored-by: Veetaha <[email protected]>
| * refactor(ra_syntax.validation): removed code duplication from ↵Veetaha2020-01-141-35/+26
| | | | | | | | validate_literal() function
* | Merge #2839bors[bot]2020-01-142-1/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | 2839: Tweak add_custom_impl r=matklad a=kjeremy Display a nicer label and categorize Co-authored-by: Jeremy Kolb <[email protected]>
| * | Tweak add_custom_implJeremy Kolb2020-01-142-1/+5
| | |
* | | Merge #2838bors[bot]2020-01-147-112/+192
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 2838: Move Type API to type r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Move Type API to typeAleksey Kladov2020-01-144-85/+102
| | |
| * | Push resolver further upAleksey Kladov2020-01-144-27/+60
| | |
| * | Push resolver upAleksey Kladov2020-01-141-21/+51
|/ /
| |
| \
*-. \ Merge #2828 #2831bors[bot]2020-01-143-19/+19
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2828: Update backtrace r=matklad a=kjeremy Has some fixes for WinXP 2831: vscode-languageclient 6.0.0-next.10 r=matklad a=kjeremy The main change is that it removes progress from the proposed section. Co-authored-by: kjeremy <[email protected]>
| | * | vscode-languageclient 6.0.0-next.10kjeremy2020-01-132-16/+16
| | | |
| * | | Update backtracekjeremy2020-01-131-3/+3
| |/ /
* | | Merge #2836bors[bot]2020-01-145-89/+82
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2836: Move utility functions down r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Move impls_future to Type, where it belongsAleksey Kladov2020-01-144-28/+21
| | | |
| * | | Use lang-items to resolve future traitAleksey Kladov2020-01-142-10/+10
| | | |
| * | | Move utility functions downAleksey Kladov2020-01-141-58/+58
| | | |
| * | | Rename fileAleksey Kladov2020-01-142-2/+2
|/ / /
* | | Merge pull request #2826 from matklad/dont-gate-on-windowsAleksey Kladov2020-01-141-1/+1
|\ \ \ | |_|/ |/| | Dont gate PRs on windows build
| * | Dont gate PRs on windows buildAleksey Kladov2020-01-131-1/+1
| | |
* | | Merge #2829bors[bot]2020-01-131-0/+4
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 2829: Log client info if present r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Log client info if presentkjeremy2020-01-131-0/+4
|/ /
* | Merge #2818bors[bot]2020-01-131-9/+35
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 2818: Don't panic if chalk panics r=matklad a=matklad r? @flodiebold Trying to paper-over panicking chalk. Not sure if this'll make situation better or worse, but I hope it'll be better, as we won't be tearing down type-inference as a whole Co-authored-by: Aleksey Kladov <[email protected]>
| * | Don't panic if chalk panicsAleksey Kladov2020-01-131-9/+35
|/ /
* | Merge #2825bors[bot]2020-01-139-45/+44
|\ \ | | | | | | | | | | | | | | | | | | | | | 2825: Some clippy lints r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Readabilitykjeremy2020-01-132-6/+6
| | |
| * | Some clippy lintskjeremy2020-01-1310-46/+45
| |/
* | Merge #2824bors[bot]2020-01-132-2/+12
|\ \ | |/ |/| | | | | | | | | | | 2824: Defer cargo check until after workspace load r=kiljacken a=kiljacken Fixes #2822 Co-authored-by: Emil Lauridsen <[email protected]>
| * Schedule check update regardless of notification settingEmil Lauridsen2020-01-131-1/+1
| |
| * Defer cargo check until after workspace loadEmil Lauridsen2020-01-132-2/+12
|/
* Merge #2823bors[bot]2020-01-131-1/+0
|\ | | | | | | | | | | | | | | 2823: Dropping a reference does nothing. r=matklad a=kjeremy Allows clippy to continue compilation Co-authored-by: kjeremy <[email protected]>
| * Dropping a reference does nothing.kjeremy2020-01-131-1/+0
|/ | | | Allows clippy to continue compilation
* build with clang?Aleksey Kladov2020-01-131-5/+11
|
* muslAleksey Kladov2020-01-131-1/+2
|
* Merge pull request #2820 from rust-analyzer/releasesAleksey Kladov2020-01-131-13/+98
|\ | | | | GitHub releases
| * 🎁 GitHub releases 🎁Aleksey Kladov2020-01-131-13/+98
|/
* Rename Emacs "extension"Aleksey Kladov2020-01-132-4/+4
|
* Merge #2815bors[bot]2020-01-131-0/+1
|\ | | | | | | | | | | | | | | 2815: Report macro calls as functions r=matklad a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * Report macro calls as functionsJeremy Kolb2020-01-121-0/+1
| |
* | Merge #2816bors[bot]2020-01-131-0/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2816: Add macro_rules item snippet r=matklad a=memoryruins An user trying out rust-analyzer mentioned to me that they missed `rls-vscode`'s [macro_rules snippet](https://github.com/rust-lang/rls-vscode/blob/c2293a63d4adc76ab714a5c6d0a2e9c7b7be77ed/snippets/rust.json#L60) ![2020-01-12_17-47-34](https://user-images.githubusercontent.com/6868531/72227227-fcf46480-3567-11ea-9e3b-2f7319d127f7.gif) Co-authored-by: memoryruins <[email protected]>
| * | Add macro_rules item snippetmemoryruins2020-01-121-0/+8
| |/
* | Merge #2768bors[bot]2020-01-136-17/+34
|\ \ | |/ |/| | | | | | | | | | | 2768: Rename VS Code extension to rust-analyzer r=matklad a=matklad I want to merge this before release on Monday, such that we can give heads up on twitter Co-authored-by: Aleksey Kladov <[email protected]>
| * Rename VS Code extension to rust-analyzerAleksey Kladov2020-01-136-17/+34
|/
* Merge #2788bors[bot]2020-01-121-8/+36
|\ | | | | | | | | | | | | | | | | | | 2788: Fix file_structure() to recognize macro_rules! r=flodiebold a=ruabmbua Fixes https://github.com/rust-analyzer/rust-analyzer/issues/2774. Not sure what to do about classifying macro definitions. Maybe make all macro invocations a function invocation? Co-authored-by: Roland Ruckerbauer <[email protected]>
| * Remove hir usage from macro_rules! detection in structure_node()Roland Ruckerbauer2020-01-122-6/+3
| |
| * Use hir .path() and .name() to differentiateRoland Ruckerbauer2020-01-122-23/+26
| | | | | | | | macro call and macro definition
| * Added test for file_structure unidentified macro definitionRoland Ruckerbauer2020-01-121-4/+18
| |
| * Fix file_structure() to recognize macro_rules!Roland Ruckerbauer2020-01-121-3/+17
|/ | | | where first token != "macro_rules"
* Merge #2814bors[bot]2020-01-121-49/+55
|\ | | | | | | | | | | | | | | 2814: Update crates r=matklad a=kjeremy Adds a new dependency on autocfg 1.0. There are pending PRs against indexmap, crossbeam and rand to bring them up. Co-authored-by: Jeremy Kolb <[email protected]>
| * Update cratesJeremy Kolb2020-01-121-49/+55
| |
* | Merge #2712bors[bot]2020-01-121-15/+153
|\ \ | | | | | | | | | | | | | | | | | | | | | 2712: Supporting extend selection inside macro calls r=edwin0cheng a=edwin0cheng Co-authored-by: Edwin Cheng <[email protected]>
| * | Fix formatEdwin Cheng2020-01-121-5/+2
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-30 16:21:50 +0000