aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #5723bors[bot]2020-08-121-14/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5723: Completely remove cargo audit My current feeling is that the build maintenance friction it creates is not proportional to the benefits it provides. We are pretty frugal with the set of Rust dependencies, and our security model is we r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Completely remove cargo auditAleksey Kladov2020-08-121-14/+0
| | | | | | | | | | | | | | | | | | My current feeling is that the build maintenance friction it creates is not proportional to the benefits it provides. We are pretty frugal with the set of Rust dependencies, and our security model is "we run build.rs and proc macros", so it doesn't seem like cargo audit could help us much.
* | Merge #5637bors[bot]2020-08-123-6/+93
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | 5637: SSR: Matching trait associated constants, types and functions r=matklad a=davidlattimore This fixes matching of things like `HashMap::default()` by resolving `HashMap` instead of `default` (which resolves to `Default::default`). Same for associated constants and types that are part of a trait implementation. However, we still don't support matching calls to trait methods. Co-authored-by: David Lattimore <[email protected]>
| * SSR: Matching trait associated constants, types and functionsDavid Lattimore2020-08-013-6/+93
| | | | | | | | | | | | | | | | | | | | This fixes matching of things like `HashMap::default()` by resolving `HashMap` instead of `default` (which resolves to `Default::default`). Same for associated constants and types that are part of a trait implementation. However, we still don't support matching calls to trait methods.
* | Merge #5553bors[bot]2020-08-1212-287/+288
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5553: Add fix ranges for diagnostics r=matklad a=SomeoneToIgnore A follow-up of https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Less.20red.20in.20the.20code Now diagnostics can apply fixes in a range that's different from the range used to highlight the diagnostics. Previous logic did not consider the fix range, having both ranges equal, which could cause a lot of red noise in the editor. Now, the fix range gets used with the fix, the diagnostics range is used for everything else which allows to improve the error highlighting. before: <img width="191" alt="image" src="https://user-images.githubusercontent.com/2690773/88590727-df9a6a00-d063-11ea-97ed-9809c1c5e6e6.png"> after: <img width="222" alt="image" src="https://user-images.githubusercontent.com/2690773/88590734-e1fcc400-d063-11ea-9b7c-25701cbd5352.png"> `MissingFields` and `MissingPatFields` diagnostics now have the fix range as `ast::RecordFieldList` of the expression with an error (as it was before this PR), and the diagnostics range as a `ast::Path` of the expression, if it's present (do you have any example of `ast::Expr::RecordLit` that has no path btw?). The rest of the diagnostics have both ranges equal, same as it was before this PR. Co-authored-by: Kirill Bulatov <[email protected]>
| * | Better naming and docsKirill Bulatov2020-08-116-28/+30
| | |
| * | Simplify fix structureKirill Bulatov2020-08-114-96/+92
| | |
| * | Add rustdocsKirill Bulatov2020-08-112-1/+4
| | |
| * | Improve the ide diagnostics trait APIKirill Bulatov2020-08-114-197/+166
| | |
| * | Move the DiagnosticsWithFix trait on the ide levelKirill Bulatov2020-08-117-63/+75
| | |
| * | Make the fix AST source OptionalKirill Bulatov2020-08-116-74/+78
| | |
| * | Refactor the diagnosticsKirill Bulatov2020-08-116-136/+106
| | |
| * | Require source implementations for DiagnosticKirill Bulatov2020-08-113-12/+15
| | |
| * | Restore accidentally removed public methodKirill Bulatov2020-08-112-10/+11
| | |
| * | Fix another missing fields diagnosticsKirill Bulatov2020-08-113-44/+19
| | |
| * | Better namingKirill Bulatov2020-08-115-48/+57
| | |
| * | Less stubsKirill Bulatov2020-08-114-31/+28
| | |
| * | Custom ranges for missing fieldsKirill Bulatov2020-08-114-8/+56
| | |
| * | Separate diagnostics and diagnostics fix rangesKirill Bulatov2020-08-113-47/+59
| | |
* | | Merge #4743bors[bot]2020-08-127-32/+284
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4743: Add tracking of packed repr, use it to highlight unsafe refs r=matklad a=Nashenas88 Taking a reference to a misaligned field on a packed struct is an unsafe operation. Highlight that behavior. Currently, the misaligned part isn't tracked, so this highlight is a bit too aggressive. Fixes #4600 Co-authored-by: Paul Daniel Faria <[email protected]> Co-authored-by: Paul Daniel Faria <[email protected]> Co-authored-by: Paul Daniel Faria <[email protected]>
| * | | Remove unused import left behind after rebasingPaul Daniel Faria2020-08-101-1/+1
| | | |
| * | | Fix type names broken by rebase, redo expected test because of rebasePaul Daniel Faria2020-08-103-14/+44
| | | |
| * | | Move unsafe semantics methods into `SemanticsImpl` and reference them in ↵Paul Daniel Faria2020-08-101-71/+83
| | | | | | | | | | | | | | | | `Semantics`
| * | | Return bool from is_unsafe_method_call and cleanup usagesPaul Daniel Faria2020-08-102-24/+25
| | | |
| * | | Move semantic logic into Semantics, fix missing tag for safe amp operator, ↵Paul Daniel Faria2020-08-106-105/+112
| | | | | | | | | | | | | | | | using functional methods rather than clunky inline closure
| * | | Remove merge backupPaul Daniel Faria2020-08-101-769/+0
| | | |
| * | | Fix rebase errorsPaul Daniel Faria2020-08-104-9/+10
| | | |
| * | | Move unsafe packed ref logic to Semantics, use `Attrs::by_key` to simplify ↵Paul Daniel Faria2020-08-104-54/+815
| | | | | | | | | | | | | | | | repr attr lookup
| * | | Revert function structs back to using bool to track self param, use first ↵Paul Daniel Faria2020-08-1010-27/+22
| | | | | | | | | | | | | | | | param for self information in syntax highlighting instead
| * | | Deduplicate unsafe method call into a single functionPaul Daniel Faria2020-08-101-41/+31
| | | |
| * | | Unsafe borrow of packed fields: account for borrow through ref binding, auto ↵Paul Daniel Faria2020-08-1010-48/+156
| | | | | | | | | | | | | | | | ref function calls
| * | | Cleanup repr check, fix packed repr check and testPaul Daniel Faria2020-08-103-14/+15
| | | |
| * | | Update FIXME comment to be more usefulPaul Daniel Faria2020-08-101-1/+2
| | | |
| * | | Limit scope of unsafe to & instead of all ref exprs, add test showing ↵Paul Daniel Faria2020-08-102-1/+20
| | | | | | | | | | | | | | | | missing support for autoref behavior
| * | | Remove token tree from ReprKind::Other variant, expose ReprKind higher, ↵Paul Daniel Faria2020-08-102-10/+4
| | | | | | | | | | | | | | | | remove debug println.
| * | | Add tracking of packed repr, use it to highlight unsafe refsPaul Daniel Faria2020-08-104-4/+105
| | | | | | | | | | | | | | | | | | | | | | | | Taking a reference to a misaligned field on a packed struct is an unsafe operation. Highlight that behavior. Currently, the misaligned part isn't tracked, so this highlight is a bit too aggressive.
* | | | Merge #5722bors[bot]2020-08-127-94/+30
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5722: Replace SepBy with Itertools r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Replace SepBy with ItertoolsAleksey Kladov2020-08-127-94/+30
| | | | |
* | | | | Merge #5721bors[bot]2020-08-1261-669/+618
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5721: Cleanup parser modifiers tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Cleanup parser modifiers testsAleksey Kladov2020-08-1241-362/+292
| | | | |
| * | | | Allow default everywhereAleksey Kladov2020-08-1221-307/+326
| | | | | | | | | | | | | | | | | | | | closes #5681
* | | | | Merge #5720bors[bot]2020-08-121-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5720: Fix docs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Fix docsAleksey Kladov2020-08-121-1/+1
| | | | |
* | | | | Merge #5699bors[bot]2020-08-126-10/+15
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5699: Fix clippy warnings r=matklad a=popzxc Currently clippy spawns a bunch of warnings on the `rust-analyzer` project. Nothing critical, but easy to fix, so I guess it won't harm. Co-authored-by: Igor Aleksanov <[email protected]>
| * | | | Revert style preference-related fixesIgor Aleksanov2020-08-125-21/+21
| | | | |
| * | | | Revert boxing for large enum variantIgor Aleksanov2020-08-101-3/+4
| | | | |
| * | | | Fix clippy warningsIgor Aleksanov2020-08-1011-34/+38
| |/ / /
* | | | Merge #5719bors[bot]2020-08-121-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5719: Minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | MinorAleksey Kladov2020-08-121-0/+1
| | | | |
* | | | | Merge #5718bors[bot]2020-08-122-1/+14
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5718: Deny clippy r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 02:33:14 +0000