aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge #7912bors[bot]2021-03-081-46/+49
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7912: Dedupe import map results r=matklad a=SomeoneToIgnore While debugging https://github.com/rust-analyzer/rust-analyzer/issues/7902, I've found that there are some duplicates are produced during the external dependencies lookup. I've spotted at least some of the `indexed_value.value` duplicated when typed `Arc` and requested the completions for that, so I've also deduped the `IndexedValue`'s to avoid unnecessary computations. This helps to show `Arc` in the completion suggestions in a zero dependency project and in `hir` module, but we loose it again in the `ide` module. Co-authored-by: Kirill Bulatov <[email protected]>
| * | Do not process indexed values more than onceKirill Bulatov2021-03-081-29/+31
| | |
| * | Deduplicate search_dependencies resultsKirill Bulatov2021-03-081-18/+19
| | |
* | | Merge #7901bors[bot]2021-03-085-15/+42
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 7901: Make extension respect http proxy settings r=matklad a=kamyuentse This patch makes vscode extension respect proxy settings when fetching release metadata and rust-analyzer binary. Co-authored-by: Kam Y. Tse <[email protected]>
| * | Make extension respect http proxy settingsKam Y. Tse2021-03-075-15/+42
| | |
* | | Merge #7889bors[bot]2021-03-0714-23/+79
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7889: Make group imports configurable r=lnicola a=asv1 Co-authored-by: asv <[email protected]>
| * | | Make group imports configurableasv2021-03-0714-23/+79
| | | |
* | | | Merge #7895bors[bot]2021-03-075-21/+23
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 7895: :arrow_up: xflags r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | :arrow_up: xflagsAleksey Kladov2021-03-075-21/+23
| | | |
* | | | Merge #7892bors[bot]2021-03-074-62/+89
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7892: Fix TokenStream::from_str for input consisting of a single group with delimiter r=edwin0cheng a=kevinmehall TokenStream holds a `tt::Subtree` but assumes its `delimiter` is always `None`. In particular, the iterator implementation iterates over the inner `token_trees` and ignores the `delimiter`. However, `TokenStream::from_str` violated this assumption when the input consists of a single group by producing a Subtree with an outer delimiter, which was ignored as seen by a procedural macro. `tt::Subtree` is just `pub delimiter: Option<Delimiter>, pub token_trees: Vec<TokenTree>`, so a Subtree that is statically guaranteed not to have a delimiter is just `Vec<TokenTree>`. Fixes #7810 Fixes #7875 Co-authored-by: Kevin Mehall <[email protected]>
| * | | | Move TokenStream::to_string helpers inside the methodKevin Mehall2021-03-061-30/+34
| | | | |
| * | | | Make a placeholder panic message explain its purposeKevin Mehall2021-03-061-1/+1
| | | | |
| * | | | Refactor TokenStream to hold Vec<TokenTree> instead of tt::SubtreeKevin Mehall2021-03-063-65/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `TokenStream` assumes that its subtree's delimeter is `None`, and this should be encoded in the type system instead of having a delimiter field that is mostly ignored. `tt::Subtree` is just `pub delimiter: Option<Delimiter>, pub token_trees: Vec<TokenTree>`, so a Subtree that is statically guaranteed not to have a delimiter is just Vec<TokenTree>.
| * | | | Fix TokenStream::from_str for input consisting of a single GroupKevin Mehall2021-03-061-2/+34
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TokenStream holds a `tt::Subtree` but assumes its `delimiter` is always `None`. In particular, the iterator implementation iterates over the inner `token_trees` and ignores the `delimiter`. However, `TokenStream::from_str` violated this assumption when the input consists of a single Group by producing a Subtree with an outer delimiter, which was ignored as seen by a procedural macro. In this case, wrap an extra level of Subtree around it. Fixes #7810 Fixes #7875
* | | | Merge #7899bors[bot]2021-03-064-19/+19
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7899: Rename a few `crate_def_map`s to `def_map` r=jonas-schievink a=jonas-schievink These could all be block `DefMap`s instead of crate-level `DefMap`s bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Rename a few `crate_def_map`s to `def_map`Jonas Schievink2021-03-064-19/+19
|/ / / / | | | | | | | | | | | | These could all be block `DefMap`s instead of crate-level `DefMap`s
* | | | Merge #7896bors[bot]2021-03-061-59/+77
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7896: Only replace quotes in replace_string_with_char assist r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Only replace quotes in replace_string_with_char assistLukas Wirth2021-03-061-59/+77
| | | | |
* | | | | Merge #7800bors[bot]2021-03-063-0/+407
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7800: [WIP] 7708: Initial implementation of generate Default assist. r=Veykril a=chetankhilosiya The Generate Default impl from new function. Co-authored-by: Chetan Khilosiya <[email protected]>
| * | | | 7708: rust ideomatic code fixes.Chetan Khilosiya2021-03-061-9/+11
| | | | |
| * | | | 7708: handle both FamousDefs fixture and plain code.Chetan Khilosiya2021-03-061-8/+18
| | | | | | | | | | | | | | | | | | | | Also fix typo in example.
| * | | | 7708: Added the updated implementation of is_default_implemented.Chetan Khilosiya2021-03-061-33/+31
| | | | | | | | | | | | | | | | | | | | The implementation uses hir create to find the implemented trait.
| * | | | 7708: Added the logic to check is default impl is already present.Chetan Khilosiya2021-03-061-18/+97
| | | | | | | | | | | | | | | | | | | | Also added test cases for code present within module.
| * | | | 7708: Updated generate default fn logic.Chetan Khilosiya2021-03-061-22/+48
| | | | |
| * | | | 7708: Added the work for review comments.Chetan Khilosiya2021-03-061-31/+60
| | | | | | | | | | | | | | | | | | | | Also added 1 test case to test multiple struct blocks are present.
| * | | | 7708: Fixed many documentaion example issues.Chetan Khilosiya2021-03-062-6/+37
| | | | |
| * | | | 7708: Format code through rust-analyzer formatter.Chetan Khilosiya2021-03-061-35/+44
| | | | |
| * | | | 7708: Initial implementation of generate Default assist.Chetan Khilosiya2021-03-062-0/+223
| | |/ / | |/| | | | | | | | | | The Generate Default impl from new function.
* | | | Merge #7865bors[bot]2021-03-061-1/+37
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 7865: preserve escape sequences when replacing string with char r=Veykril a=jDomantas Currently it replaces escape sequence with the actual value, which is very wrong for `"\n"`. Co-authored-by: Domantas Jadenkus <[email protected]>
| * | | preserve escape sequences when replacing string with charDomantas Jadenkus2021-03-031-1/+37
| | | |
* | | | Merge #7894bors[bot]2021-03-061-4/+52
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7894: generate_function assist: convert arg names to lower snake case r=Veykril a=JoshMcguigan This PR fixes one of the points listed by @TimoFreiberg in #3639. Specifically that all generated argument names should be converted to lower snake case. ```rust struct BazBaz; fn foo() { bar$0(BazBaz); // ^ when triggering the assist here, you get the output below } // BEFORE fn bar(BazBaz: BazBaz) ${0:-> ()} { todo!() } // AFTER fn bar(baz_baz: BazBaz) ${0:-> ()} { todo!() } ``` Co-authored-by: Josh Mcguigan <[email protected]>
| * | | generate function assist convert arg names to lower snake caseJosh Mcguigan2021-03-061-4/+52
|/ / /
* | | Merge #7888bors[bot]2021-03-061-0/+2
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 7888: Add a line about code action commands to the CoC section of the docs r=lnicola a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * | Add a line about code action commands to the CoC section of the docsFlorian Diebold2021-03-061-0/+2
|/ /
* | Merge #7887bors[bot]2021-03-052-2/+4
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 7887: Fix fail to parse :: for meta in mbe r=edwin0cheng a=edwin0cheng fixes #7886 bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * | Fix fail to parse :: for meta in mbeEdwin Cheng2021-03-052-2/+4
| | |
* | | Merge #7884bors[bot]2021-03-052-39/+43
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7884: Simplify TokenStream FromStr r=edwin0cheng a=edwin0cheng Make sure `FromStr` ignore all `TokenMap` in all cases. bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * | | Fix testEdwin Cheng2021-03-051-1/+1
| | | |
| * | | Simplify TokenStream FromStrEdwin Cheng2021-03-051-38/+42
| | | |
* | | | Merge #7869bors[bot]2021-03-051-0/+43
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 7869: Add support for deref assignments to "pull assignment up" assist. r=Veykril a=Jesse-Bakker Fixes #7867 Co-authored-by: Jesse Bakker <[email protected]>
| * | | Add support for deref assignments to "pull assignment up" assist.Jesse Bakker2021-03-051-0/+43
| |/ / | | | | | | | | | Fixes #7867
* | | Merge #7883bors[bot]2021-03-052-2/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7883: Make two calls virtual r=matklad a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Make two calls virtualLaurențiu Nicola2021-03-052-2/+2
| | | |
* | | | Merge #7882bors[bot]2021-03-051-8/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7882: cargo update r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | cargo updatekjeremy2021-03-051-8/+8
|/ / / /
* | | | Merge #7881bors[bot]2021-03-053-70/+37
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 7881: Underengineer `cargo xtask install --client` r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Underengineer `cargo xtask install --client`Aleksey Kladov2021-03-053-70/+37
| | | |
* | | | Merge #7880bors[bot]2021-03-051-2/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7880: Honor snippet capability when using the extract function assist r=lnicola a=Arthamys This fixes issue #7793 Co-authored-by: san <[email protected]>
| * | | | Honor snippet capability in extract function assistsan2021-03-051-2/+8
| | | | |
* | | | | Merge #7870bors[bot]2021-03-0511-73/+68
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7870: Use chalk_ir::AdtId r=Veykril a=Veykril It's a bit unfortunate that we got two AdtId's now(technically 3 with the alias in the chalk module but that one won't allow pattern matching), one from hir_def and one from chalk_ir(hir_ty). But the hir_ty/chalk one doesn't leave hir so it shouldn't be that bad I suppose. Though if I see this right this will happen for almost all IDs. I imagine most of the intermediate changes to using chalk ids will turn out not too nice until the refactor is over. Co-authored-by: Lukas Wirth <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 16:03:10 +0000