aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge #5732bors[bot]2020-08-131-8/+14
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 5732: Consider only IdentPats for param name hints r=matklad a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/4960 Avoid displaying any param name hints like <img width="590" alt="image" src="https://user-images.githubusercontent.com/2690773/90071461-47a4ad80-dcfe-11ea-9330-fb4f4e2d1b71.png"> Those hints seem to occupy plenty of space for no apparent benefit, with their destructured content not used in the code with the function hints. I'm not entirely sure if we should show something else than `IdentPat`s, since I don't understand some of the `Pat` variant meanings: https://github.com/rust-analyzer/rust-analyzer/blob/a1c187eef3ba08076aedb5154929f7eda8d1b424/crates/syntax/src/ast/generated/nodes.rs#L1336-L1352 Co-authored-by: Kirill Bulatov <[email protected]>
| * Consider only IdentPats for param name hintsKirill Bulatov2020-08-121-8/+14
| |
* | Merge #5744bors[bot]2020-08-1318-43/+40
|\ \ | | | | | | | | | | | | | | | | | | | | | 5744: Rename ra_project_model -> project_model r=matklad a=pksunkara Co-authored-by: Pavan Kumar Sunkara <[email protected]>
| * | Rename ra_project_model -> project_modelPavan Kumar Sunkara2020-08-1318-43/+40
| | |
* | | Merge #5743bors[bot]2020-08-138-71/+32
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 5743: Remove ra_fmt crate r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Remove ra_fmt crateAleksey Kladov2020-08-138-69/+29
| | |
| * | MinorAleksey Kladov2020-08-131-4/+5
| | |
* | | Merge #5741bors[bot]2020-08-135-71/+70
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5741: Minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | MinorAleksey Kladov2020-08-132-28/+25
| | |
| * | MinorAleksey Kladov2020-08-135-44/+46
| | |
* | | Merge #5740bors[bot]2020-08-134-54/+48
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5740: Remove deprecated function r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Remove deprecated functionAleksey Kladov2020-08-134-54/+48
| | |
* | | Merge #5739bors[bot]2020-08-133-117/+112
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5739: Cleanup **Move Guard** assist r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Cleanup **Move Guard** assistAleksey Kladov2020-08-133-117/+112
|/ /
* | Temporary disable MacOS builderAleksey Kladov2020-08-132-3/+2
| | | | | | | | GH Actions is not feeling great today :-(
* | Merge pull request #5738 from matklad/cfgAleksey Kladov2020-08-1336-134/+118
|\ \ | | | | | | | | | Rename ra_cfg -> cfg
| * | fmtAleksey Kladov2020-08-136-6/+6
| | |
| * | Rename ra_cfg -> cfgAleksey Kladov2020-08-1322-39/+39
| | |
| * | SimplifyAleksey Kladov2020-08-131-8/+6
| | |
| * | Minimize depsAleksey Kladov2020-08-132-2/+2
| | |
| * | Rename ra_mbe -> mbeAleksey Kladov2020-08-1319-33/+34
| | |
| * | :arrow_up: cratesAleksey Kladov2020-08-131-36/+19
| | |
| * | MinorAleksey Kladov2020-08-132-21/+23
|/ /
* | Disabe macros TypeSCript builderAleksey Kladov2020-08-131-1/+1
| | | | | | | | It hangs for some reason, and we are moving TS extension anyways...
* | Merge pull request #5734 from pksunkara/ra_proc_macro_srvAleksey Kladov2020-08-1322-11/+10
|\ \ | |/ |/| Rename ra_proc_macro_srv -> proc_macro_srv
| * Rename ra_proc_macro_srv -> proc_macro_srvPavan Kumar Sunkara2020-08-1322-11/+10
|/
* Merge #5730bors[bot]2020-08-123-3/+38
|\ | | | | | | | | | | | | | | | | | | 5730: **Merge Imports** assist handles self r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * **Merge Imports** assist handles selfAleksey Kladov2020-08-123-3/+38
|/
* Merge #5729bors[bot]2020-08-12958-363/+353
|\ | | | | | | | | | | | | | | | | | | 5729: Rename ra_syntax -> syntax r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Rename ra_syntax -> syntaxAleksey Kladov2020-08-12958-363/+353
|/
* Merge #5727bors[bot]2020-08-1247-65/+65
|\ | | | | | | | | | | | | | | | | | | 5727: Rename ra_parser -> parser r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Rename ra_parser -> parserAleksey Kladov2020-08-1247-65/+65
| |
* | Merge #5726bors[bot]2020-08-1241-94/+102
|\| | | | | | | | | | | | | | | | | | | 5726: Rename ra_text_edit -> text_edit r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Rename ra_text_edit -> text_editAleksey Kladov2020-08-1229-42/+42
| |
| * Cleanup TextEdit APIAleksey Kladov2020-08-129-24/+34
| |
| * Rename ra_toolchain -> toolchainAleksey Kladov2020-08-1214-32/+30
| |
* | Merge #5725bors[bot]2020-08-1222-77/+77
|\| | | | | | | | | | | | | | | | | | | 5725: Rename ra_tt -> tt r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Rename ra_tt -> ttAleksey Kladov2020-08-1222-77/+77
| |
* | Merge #5724bors[bot]2020-08-1279-226/+192
|\| | | | | | | | | | | | | | | | | | | 5724: Rename ra_prof -> profile r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Rename ra_prof -> profileAleksey Kladov2020-08-1261-188/+154
| |
| * Rename ra_arenaAleksey Kladov2020-08-1230-40/+40
|/
* Merge #5723bors[bot]2020-08-121-14/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5723: Completely remove cargo audit My current feeling is that the build maintenance friction it creates is not proportional to the benefits it provides. We are pretty frugal with the set of Rust dependencies, and our security model is we r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Completely remove cargo auditAleksey Kladov2020-08-121-14/+0
| | | | | | | | | | | | | | | | | | My current feeling is that the build maintenance friction it creates is not proportional to the benefits it provides. We are pretty frugal with the set of Rust dependencies, and our security model is "we run build.rs and proc macros", so it doesn't seem like cargo audit could help us much.
* | Merge #5637bors[bot]2020-08-123-6/+93
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | 5637: SSR: Matching trait associated constants, types and functions r=matklad a=davidlattimore This fixes matching of things like `HashMap::default()` by resolving `HashMap` instead of `default` (which resolves to `Default::default`). Same for associated constants and types that are part of a trait implementation. However, we still don't support matching calls to trait methods. Co-authored-by: David Lattimore <[email protected]>
| * SSR: Matching trait associated constants, types and functionsDavid Lattimore2020-08-013-6/+93
| | | | | | | | | | | | | | | | | | | | This fixes matching of things like `HashMap::default()` by resolving `HashMap` instead of `default` (which resolves to `Default::default`). Same for associated constants and types that are part of a trait implementation. However, we still don't support matching calls to trait methods.
* | Merge #5553bors[bot]2020-08-1212-287/+288
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5553: Add fix ranges for diagnostics r=matklad a=SomeoneToIgnore A follow-up of https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Less.20red.20in.20the.20code Now diagnostics can apply fixes in a range that's different from the range used to highlight the diagnostics. Previous logic did not consider the fix range, having both ranges equal, which could cause a lot of red noise in the editor. Now, the fix range gets used with the fix, the diagnostics range is used for everything else which allows to improve the error highlighting. before: <img width="191" alt="image" src="https://user-images.githubusercontent.com/2690773/88590727-df9a6a00-d063-11ea-97ed-9809c1c5e6e6.png"> after: <img width="222" alt="image" src="https://user-images.githubusercontent.com/2690773/88590734-e1fcc400-d063-11ea-9b7c-25701cbd5352.png"> `MissingFields` and `MissingPatFields` diagnostics now have the fix range as `ast::RecordFieldList` of the expression with an error (as it was before this PR), and the diagnostics range as a `ast::Path` of the expression, if it's present (do you have any example of `ast::Expr::RecordLit` that has no path btw?). The rest of the diagnostics have both ranges equal, same as it was before this PR. Co-authored-by: Kirill Bulatov <[email protected]>
| * | Better naming and docsKirill Bulatov2020-08-116-28/+30
| | |
| * | Simplify fix structureKirill Bulatov2020-08-114-96/+92
| | |
| * | Add rustdocsKirill Bulatov2020-08-112-1/+4
| | |
| * | Improve the ide diagnostics trait APIKirill Bulatov2020-08-114-197/+166
| | |