aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge #5004bors[bot]2020-06-237-4/+49
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5004: Fix panic in split/merge import assists r=matklad a=lnicola Fixes #4368 #4905 Not sure if this is the best solution here. Maybe the `make` functions should be fallible? We generally seem to be playing whack-a-mole with panics in assists, although most of them are `unwrap`s in the assist code. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Fix panic in split and merge import assistsLaurențiu Nicola2020-06-237-4/+49
| | | |
* | | | Merge #5002bors[bot]2020-06-233-5/+15
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5002: Fix underflow panic when doctests are at top of file r=Nashenas88 a=Nashenas88 While debugging a comment at the top of a test string, I discovered that the offset calculations could underflow and panic. This only seemed to occur in tests, I assume because it's running a debug mode. The wrapping is quickly fixed later on in release mode, which is why this seems to have gone unnoticed. The new checks ensure the value is always positive or zero. Co-authored-by: Paul Daniel Faria <[email protected]>
| * | | | Fix underflow panic when doctests are at top of filePaul Daniel Faria2020-06-233-5/+15
| | | | |
| | | | |
| \ \ \ \
| \ \ \ \
| \ \ \ \
| \ \ \ \
| \ \ \ \
| \ \ \ \
| \ \ \ \
*-------. \ \ \ \ Merge #4992 #4993 #4994 #4997 #4998bors[bot]2020-06-235-50/+70
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4992: Never disable error logging on the frontend r=matklad a=Veetaha 4993: Make bootstrap error message more informative and better-fitting r=matklad a=Veetaha Now this better fits standard vscode extension activation failure message and suggests enabling verbose logs. ![image](https://user-images.githubusercontent.com/36276403/85321828-ffbb9400-b4cd-11ea-8adf-4032b1f62dfd.png) 4994: Decouple http file stream logic from temp dir logic r=matklad a=Veetaha Followup for #4989 4997: Update manual.adoc r=matklad a=gwutz GNOME Builder (Nightly) supports now rust-analyzer 4998: Disrecommend trace.server: "verbose" for regular users r=matklad a=Veetaha This option has never been useful for me, I wonder if anyone finds regular users can use this for sending logs Co-authored-by: Veetaha <[email protected]> Co-authored-by: Günther Wagner <[email protected]>
| | | | | * | | | | Disrecommend trace.server: "verbose" for regular usersVeetaha2020-06-221-1/+1
| | | | | | | | | |
| | | | * | | | | | Update docs/user/manual.adocGünther Wagner2020-06-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Laurențiu Nicola <[email protected]>
| | | | * | | | | | Update manual.adocGünther Wagner2020-06-221-0/+4
| | | | |/ / / / / | | | | | | | | | | | | | | | | | | GNOME Builder (Nightly) supports now rust-analyzer
| | | * / / / / / Decouple http file stream logic from temp dir logicVeetaha2020-06-222-44/+57
| | | |/ / / / /
| | * | | | | | Make bootstrap error message more informative and better-fittingVeetaha2020-06-221-4/+8
| | | | | | | |
| * | | | | | | Never disable error logging on the frontendVeetaha2020-06-221-1/+0
| | |/ / / / / | |/| | | | |
* | | | | | | Merge #4999bors[bot]2020-06-235-13/+174
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4999: SSR: Allow matching of whole macro calls r=matklad a=davidlattimore Matching within macro calls is to come later and matching of macro calls within macro calls later still. Co-authored-by: David Lattimore <[email protected]>
| * | | | | | SSR: Allow matching of whole macro callsDavid Lattimore2020-06-225-13/+174
| | |_|/ / / | |/| | | | | | | | | | | | | | | | Matching within macro calls is to come later and matching of macro calls within macro calls later still.
* | | | | | Merge #5000bors[bot]2020-06-229-47/+47
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5000: Remove RelativePathBuf from fixture r=matklad a=matklad The paths in fixture are not really relative (the default one is `/main.rs`), so it doesn't make sense to use `RelativePathBuf` here. bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Remove RelativePathBuf from fixtureAleksey Kladov2020-06-229-47/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The paths in fixture are not really relative (the default one is `/main.rs`), so it doesn't make sense to use `RelativePathBuf` here.
* | | | | | Merge #4989bors[bot]2020-06-221-6/+7
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4989: Hotfix skipping the first chunks of the artifacts r=matklad a=Veetaha Quick hotfix. fixes: #4986, #4987 The stream starts being consumed once we put a handler for `data` event. When extracting `stream.pipeline()` under `withTempFile` in #4963 I didn't move it into the scope too, which due to preliminary awaiting for async operations with the file system allowed for the first chunks of the file to be skipped Co-authored-by: Veetaha <[email protected]>
| * | | | | Hotfix skipping the first chunks of the artifactsVeetaha2020-06-221-6/+7
|/ / / / /
* | | | | Merge #4988bors[bot]2020-06-221-0/+3
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4988: Don't offer to add missing fields of unknown types r=flodiebold a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | Don't offer to add missing fields of unknown typesLaurențiu Nicola2020-06-221-0/+3
| |/ / / /
* | | | | Merge #4900bors[bot]2020-06-222-0/+110
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4900: Self variant enum res fix r=BGluth a=BGluth Fixes #4789. This is my first PR for this project, so it's probably worth giving it an extra close look. A few things that I wasn't sure about: - Is `resolve_path` really the best place to perform this check? It seemed like a natural place, but perhaps there's a better place? - When handling the new variant `PathResolution::VariantDef`, I couldn't see an obvious variant of `TypeNs` to return in `in_type_ns` for Unions and Structs. Co-authored-by: BGluth <[email protected]>
| * | | | Enum variants with `Self::[variant]` now resolve (#4879)BGluth2020-06-221-0/+30
| | | | |
| * | | | Created goto Self enum variant testBGluth2020-06-211-0/+80
| | | | |
* | | | | Merge #4984bors[bot]2020-06-221-10/+12
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4984: Add sponsors section to changelog r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Add sponsors section to changelogAleksey Kladov2020-06-221-10/+12
| | |/ / / | |/| | |
* | | | | Merge #4983bors[bot]2020-06-221-0/+74
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4983: Add paths::RelPath[Buf] r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Add paths::RelPath[Buf]Aleksey Kladov2020-06-221-0/+74
|/ / / /
* | | | Merge #4899bors[bot]2020-06-221-72/+206
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4899: don't complete top level attrs inside nested attrs and add better labels r=matklad a=bnjjj close #4890 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | don't complete top level attrs inside nested attrs and add better labels #4899Benjamin Coenen2020-06-221-8/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | don't complete top level attrs inside nested attrs and add better labels #4899Benjamin Coenen2020-06-211-16/+105
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | don't complete top level attrs inside nested attrs and add better labels #4890Benjamin Coenen2020-06-181-16/+8
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | don't complete top level attrs inside nested attrs and add better labels #4890Benjamin Coenen2020-06-151-63/+123
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | Merge #4921bors[bot]2020-06-2210-555/+1480
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4921: Allow SSR to match type references, items, paths and patterns r=davidlattimore a=davidlattimore Part of #3186 Co-authored-by: David Lattimore <[email protected]>
| * | | | | Allow SSR to match type references, items, paths and patternsDavid Lattimore2020-06-2210-555/+1480
| | |/ / / | |/| | | | | | | | | | | | | Part of #3186
* | | | | Merge #4928bors[bot]2020-06-221-48/+139
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4928: Fix renaming mod in use tree r=matklad a=unexge Fixes #4825 Co-authored-by: unexge <[email protected]>
| * | | | Merge branch 'fix_renaming_mod_in_use_tree' of ↵unexge2020-06-170-0/+0
| |\ \ \ \ | | | | | | | | | | | | | | | | | | https://github.com/unexge/rust-analyzer into fix_renaming_mod_in_use_tree
| | * | | | Fix renaming mod in use treeunexge2020-06-111-55/+146
| | | | | |
| * | | | | Fix renaming mod in use treeunexge2020-06-171-48/+139
| | | | | |
* | | | | | Merge #4971bors[bot]2020-06-212-22/+28
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4971: cargo update r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | | | | | Update test for new serdeJeremy Kolb2020-06-211-1/+1
| | | | | | |
| * | | | | | cargo updateJeremy Kolb2020-06-211-21/+27
|/ / / / / /
* | | | | | Merge #4969bors[bot]2020-06-211-10/+24
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4969: Handle bindings after @ in patterns r=flodiebold a=jonas-schievink This is unstable, behind the `bindings_after_at` feature gate, but the semantics are fairly clear, and this is used at lot in rustc. Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | | Handle bindings after @ in patternsJonas Schievink2020-06-211-10/+24
|/ / / / / /
* | | | | | Merge #4962bors[bot]2020-06-2129-1/+222
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4962: Implement APIs for parsing expressions, types, paths, patterns and items r=davidlattimore a=davidlattimore Co-authored-by: David Lattimore <[email protected]>
| * | | | | | Implement APIs for parsing expressions, types, paths, patterns and itemsDavid Lattimore2020-06-2129-1/+222
| | | | | | |
* | | | | | | Merge #4959bors[bot]2020-06-213-2/+19
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4959: Syntax highlighting for documentation comments on macro definitions r=matklad a=ltentrup Two minor changes with regards to syntax highlighting of comments attached to macro definitions. Before <img width="290" alt="Bildschirmfoto 2020-06-20 um 00 05 19" src="https://user-images.githubusercontent.com/201808/85182705-c561b500-b289-11ea-944e-0bdf6508a44f.png"> After <img width="288" alt="Bildschirmfoto 2020-06-20 um 00 03 36" src="https://user-images.githubusercontent.com/201808/85182727-d90d1b80-b289-11ea-9d2d-234731f19302.png"> Fixes #4949 Co-authored-by: Leander Tentrup <[email protected]>
| * | | | | | | Syntax highlighting for documentation comments on macro definitionsLeander Tentrup2020-06-193-2/+19
| | | | | | | |
* | | | | | | | Merge #4963bors[bot]2020-06-212-11/+60
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4963: Download artifacts into tmp dir r=matklad a=Veetaha This should prevent partially downloaded files in cases when the user closes vsode before the download is complete. There is also a new more descriptive error message when the user has multiple vscode windows open and tries to download the server. Related: https://github.com/rust-analyzer/rust-analyzer/issues/4938#issuecomment-646738360 Co-authored-by: Veetaha <[email protected]>
| * | | | | | | | Download artifacts into tmp dirVeetaha2020-06-202-11/+60
| | | | | | | | |
* | | | | | | | | Merge #4947bors[bot]2020-06-207-59/+90
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4947: Replace `impls_in_trait` query with smarter use of `CrateImplDefs` r=matklad a=jonas-schievink `impls_in_trait` was allocating a whopping ~400 MB of RAM when running analysis-stats on r-a itself. Remove it, instead adding a query that computes a summary `CrateImplDefs` map for all transitive dependencies. This can probably still be made more efficient, but this already reduces the peak memory usage by 25% without much performance impact on analysis-stats. **Before**: ``` Total: 34.962107188s, 2083mb allocated 2141mb resident 422mb ImplsForTraitQuery (deps) 250mb CrateDefMapQueryQuery 147mb MacroArgQuery 140mb TraitSolveQuery (deps) 68mb InferQueryQuery (deps) 62mb ImplDatumQuery (deps) ``` **After**: ``` Total: 35.261100358s, 1520mb allocated 1569mb resident 250mb CrateDefMapQueryQuery 147mb MacroArgQuery 144mb TraitSolveQuery (deps) 68mb InferQueryQuery (deps) 61mb ImplDatumQuery (deps) 45mb BodyQuery 45mb ImplDatumQuery ``` Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | | | | | Recursively compute impl setsJonas Schievink2020-06-191-13/+26
| | | | | | | | | |