aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #8168bors[bot]2021-03-241-7/+70
|\ | | | | | | | | | | | | | | 8168: correct `convert to guard return` let_stmt r=Veykril a=hi-rustin close https://github.com/rust-analyzer/rust-analyzer/issues/8074 Co-authored-by: hi-rustin <[email protected]>
| * correct `convert to guard return` let_stmthi-rustin2021-03-241-7/+70
| | | | | | | | | | | | | | | | fix fix add check
* | Merge #8183bors[bot]2021-03-241-8/+38
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8183: Fix missing command error with macros r=Veykril a=brandondong **Reproduction:** 1. Define a struct through a macro (can be via `macro_rules`, proc macro, or `include!()`). 2. !!MISSING: command!! annotation appears. Clicking on it results in an error message. No matter where the macro is called/defined, the annotation is always at the start of the file. ![image](https://user-images.githubusercontent.com/13722457/112268785-bce14500-8c34-11eb-9a23-bafd63ffd6ef.png) **Cause:** - For struct `A`, a `HasImpls` annotation is added just like for struct `B`. Unlike `B`, the file id for `A` is not the file we are adding annotations to but a macro file. - The resolving step of the code lens does not succeed. **Fix:** - Check that the files match before computing offsets and adding `HasImpls`/`HasReferences` annotations. Co-authored-by: Brandon <[email protected]>
| * | Clean up implementationBrandon2021-03-242-14/+8
| | |
| * | Fix MISSING: command error with macrosBrandon2021-03-242-8/+44
| | |
* | | Merge #8177bors[bot]2021-03-243-6/+6
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8177: Limit the hints size by default r=Veykril a=SomeoneToIgnore Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8175 Fixes https://github.com/rust-analyzer/rust-analyzer/issues/3138 Co-authored-by: Kirill Bulatov <[email protected]>
| * | | Bump the default hint lengthKirill Bulatov2021-03-233-3/+3
| | | |
| * | | Limit the hints size by defaultKirill Bulatov2021-03-233-6/+6
| | | |
* | | | Merge #8182bors[bot]2021-03-241-4/+26
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8182: Trim down IPC json size r=edwin0cheng a=edwin0cheng This PR try to trim down the json of proc macro IPC by ignore token id if it equals to `TokenId::unspecifed`. Test by following commands: ```bash $ git clone https://github.com/gluon-lang/lsp-types.git $ export RA_LOG="proc_macro_api=debug" $ rust-analyzer -q analysis-stats --load-output-dirs --with-proc-macro . 2> debug.log $ cat debug.log | awk '/^\[DEBUG proc_macro_api::msg\] >/ {print substr($0,31)}' >expand.log $ stat -c "%s" expand.log ``` Before: 37576726 After: 28551718 So it trimed down 75%. bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * | | Trim down IPC json sizeEdwin Cheng2021-03-241-4/+26
|/ / /
* | | Merge #8159bors[bot]2021-03-234-15/+38
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8159: Ignore proc-macro stdout to prevent IPC crash r=edwin0cheng a=edwin0cheng fixes #7954 r? @flodiebold Co-authored-by: Edwin Cheng <[email protected]>
| * | | Improve message usage in proc-macroEdwin Cheng2021-03-233-9/+17
| | | | | | | | | | | | | | | | Reuse storage for the buffer send to child process of proc-macro.
| * | | Ignore proc-macro stdout to prevent IPC crashEdwin Cheng2021-03-232-7/+22
| | | |
* | | | Merge #8178bors[bot]2021-03-236-209/+225
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8178: Show item info when hovering intra doc links r=Veykril a=Veykril ![r4uIITP0IZ](https://user-images.githubusercontent.com/3757771/112197618-91e2fb00-8c0c-11eb-9edc-a7923214d2b6.gif) Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Cleanup intra_doc_link parsingLukas Wirth2021-03-231-82/+51
| | | | |
| * | | | Show item info when hovering intra doc linksLukas Wirth2021-03-236-128/+175
| | | | |
* | | | | Merge #8179bors[bot]2021-03-231-40/+28
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8179: cargo update r=kjeremy a=kjeremy Removes dependency on socket2 Co-authored-by: kjeremy <[email protected]>
| * | | | | cargo updatekjeremy2021-03-231-40/+28
|/ / / / / | | | | | | | | | | | | | | | Removes dependency on socket2
* | | | | Merge #8176bors[bot]2021-03-231-67/+45
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8176: Cleanup r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | CleanupAleksey Kladov2021-03-231-67/+45
| | | | | |
* | | | | | Merge #8173bors[bot]2021-03-232-40/+56
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8173: simplify r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | simplifyLukas Wirth2021-03-232-40/+56
| | |/ / / | |/| | |
* | | | | Merge #8174bors[bot]2021-03-233-39/+18
|\ \ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8174: Simplify code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Simplify codeAleksey Kladov2021-03-233-39/+18
| | | | | | | | | | | | | | | | | | | | changelog: skip
* | | | | Merge #8170bors[bot]2021-03-231-86/+79
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8170: Merge bang-macros and derives in name resolution r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Merge bang-macros and derives in name resolutionJonas Schievink2021-03-231-86/+79
|/ / / /
* | | | Merge #8169bors[bot]2021-03-232-44/+48
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8169: Make more use of the HIR in rename::rename_to_self r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Make more use of the HIR in rename::rename_to_selfLukas Wirth2021-03-232-44/+48
| | | | |
* | | | | Merge #8167bors[bot]2021-03-231-34/+36
|\ \ \ \ \ | |/ / / / |/| / / / | |/ / / | | | | | | | | | | | | | | | | | | | | 8167: Use styleguide conforming import for ast nodes r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Use styleguide conforming import for ast nodesAleksey Kladov2021-03-231-34/+36
| | | |
* | | | Merge #8166bors[bot]2021-03-231-38/+52
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8166: Unify test style r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Unify test styleAleksey Kladov2021-03-231-38/+52
| | | | | | | | | | | | | | | | changelog skip
* | | | Merge #8165bors[bot]2021-03-233-23/+53
|\| | | | |_|/ |/| | | | | | | | | | | | | | | | | | | | 8165: Tweak assits API to fit mutable syntax trees r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Tweak assits API to fit mutable syntax treesAleksey Kladov2021-03-233-23/+53
|/ / | | | | | | changelog: skip
* | Merge #8138bors[bot]2021-03-234-80/+147
|\ \ | | | | | | | | | | | | | | | | | | | | | 8138: Set up a search scope when searching for mbe macro references r=Veykril a=Veykril Closes #6184 Co-authored-by: Lukas Wirth <[email protected]>
| * | Cleanup Definition::search_scopeLukas Wirth2021-03-231-83/+94
| | |
| * | Merge hir::MacroDef::is_* into hir::MacroDef::kindLukas Wirth2021-03-233-16/+20
| | |
| * | Set up a search scope when searching for mbe macro referencesLukas Wirth2021-03-233-4/+56
|/ /
* | Merge #8162bors[bot]2021-03-233-17/+10
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8162: Compute more mathematically well-rounded notion of transitive deps r=Veykril a=matklad By including the crate itself, we make the resulting set closed with respect to `transitve_reveres_dependencies` operation, as it becomes a proper transitive closure. This just feels more proper and mathy. And, indeed, this actually allows us to simplify call sites somewhat. Co-authored-by: Aleksey Kladov <[email protected]>
| * | Improve readabilityAleksey Kladov2021-03-231-0/+1
| | |
| * | Align naming of deps and revdepsAleksey Kladov2021-03-232-9/+2
| | |
| * | Align semantics of deps and rev depsAleksey Kladov2021-03-231-2/+2
| | |
| * | Compute more mathematically well-rounded notion of transitive depsAleksey Kladov2021-03-233-6/+5
| |/ | | | | | | | | | | | | | | By including the crate itself, we make the resulting set closed with respect to `transitve_reveres_dependencies` operation, as it becomes a proper transitive closure. This just feels more proper and mathy. And, indeed, this actually allows us to simplify call sites somewhat.
* | Merge #8142bors[bot]2021-03-234-7/+75
|\ \ | |/ |/| | | | | | | | | | | | | | | 8142: temp disable broken ref match completions for struct fields/methods r=matklad a=JoshMcguigan This PR implements a temporary workaround for #8058 by disabling ref match completions for struct fields and methods. Disabling this doesn't break any existing functionality (that I am aware of) since these completions were broken. I plan to keep working on a real fix for the underlying issue here, but I think a proper fix could take some time, so I'd prefer to quickly fix the bug to buy some more time to implement a better solution (which would ultimately allow re-enabling ref matches for struct fields and methods). Co-authored-by: Josh Mcguigan <[email protected]>
| * add unit test to demonstrate struct fields/methods do not get ref match ↵Josh Mcguigan2021-03-231-0/+38
| | | | | | | | completions
| * implement a temporary workaround for #8058Josh Mcguigan2021-03-224-7/+37
| |
* | Merge #8156bors[bot]2021-03-222-8/+63
|\ \ | | | | | | | | | | | | | | | | | | | | | 8156: Correctly lower TraitRefs with default params r=flodiebold a=Veykril Fixes #5685 Co-authored-by: Lukas Wirth <[email protected]>
| * | Correctly lower TraitRefs with default paramsLukas Wirth2021-03-222-8/+63
| | |
| | |
| \ \
*-. \ \ Merge #8154 #8155bors[bot]2021-03-2211-90/+163
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8154: rewrite merge use trees assist to use muatable syntax trees r=matklad a=matklad bors r+ 🤖 8155: Fix confusion between parameters and the function r=jonas-schievink a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8152 bors r+ Co-authored-by: Aleksey Kladov <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
| | * | | resolver: manually traverse nested block scopesJonas Schievink2021-03-224-5/+45
| | |/ /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-23 08:33:54 +0000