aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #1215bors[bot]2019-04-283-10/+33
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1215: Fix hover on the beginning of a nested expression r=matklad a=flodiebold E.g. in ``` let foo = 1u32; if true { <|>foo; } ``` the hover shows `()`, the type of the whole if expression, instead of the more sensible `u32`. The reason for this was that the search for an expression was slightly left-biased: When on the edge between two tokens, it first looked at all ancestors of the left token and then of the right token. Instead merge the ancestors in ascending order, so that we get the smaller of the two possible expressions. This might seem rather inconsequential, but emacs-lsp's sideline requests hover for the beginning of each word in the current line, so it tends to hit this a lot :smile: Actually, as I think about this now, another solution might be just making hover right-biased, since if I'm hovering a certain character I really mean that character and not the one to its left... Co-authored-by: Florian Diebold <[email protected]>
| * Fix hover on the beginning of a nested expressionFlorian Diebold2019-04-283-10/+33
|/ | | | | | | | | | | | | | | | E.g. in ``` let foo = 1u32; if true { <|>foo; } ``` the hover shows `()`, the type of the whole if expression, instead of the more sensible `u32`. The reason for this was that the search for an expression was slightly left-biased: When on the edge between two tokens, it first looked at all ancestors of the left token and then of the right token. Instead merge the ancestors in ascending order, so that we get the smaller of the two possible expressions.
* Merge #1212bors[bot]2019-04-263-17/+17
|\ | | | | | | | | | | | | | | 1212: Clippy cleanups r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * Simplifykjeremy2019-04-262-13/+10
| |
| * Add is_empty to Arenakjeremy2019-04-261-0/+3
| |
| * Pass in char instead of single-char stringkjeremy2019-04-261-3/+3
| |
| * Elide lifetimekjeremy2019-04-261-1/+1
|/
* Merge #1209bors[bot]2019-04-2510-87/+543
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1209: Bugs fixes And Improvements of MBE r=matklad a=edwin0cheng This PR fixed / improve followings things: * Add `token` `$repeat` separator support: Previously $repeat only support single punct separator. * Fixed a bug which expand infinite pattern, see `test_match_group_in_group` * Correctly handle +,*,? case of $repeat patterns * Increase the limit of $repeat patterns (128 => 65536), personally i think we could remove this limit as we seem to fix all major loop bugs * **Re-enable tt matcher** * Better meta item parsing. * Add related tests and add some real world test cases. * Add more debug information. Co-authored-by: Edwin Cheng <[email protected]>
| * Use panic instead of unwrapEdwin Cheng2019-04-251-8/+6
| |
| * Fix more bugsEdwin Cheng2019-04-258-24/+203
| |
| * Add handling `token` seperator in mbeEdwin Cheng2019-04-258-226/+219
| |
| * Add more information on macro rules fail to parseEdwin Cheng2019-04-251-2/+8
| |
| * Fix incorrect repeat sep eatingEdwin Cheng2019-04-253-24/+304
|/
* Merge #1207bors[bot]2019-04-251-0/+0
|\ | | | | | | | | | | | | | | 1207: drop empty file r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * drop empty fileAleksey Kladov2019-04-251-0/+0
|/
* Merge #1203bors[bot]2019-04-241-2/+17
|\ | | | | | | | | | | | | | | 1203: Go to Type Definition: See through references r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * simplify matchkjeremy2019-04-241-4/+1
| |
| * See through referenceskjeremy2019-04-241-2/+20
|/
* Merge #1202bors[bot]2019-04-241-23/+30
|\ | | | | | | | | | | | | | | 1202: Update some deps r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * Update some depskjeremy2019-04-241-23/+30
|/
* Merge #1200bors[bot]2019-04-231-18/+70
|\ | | | | | | | | | | | | | | 1200: Allows searching for case-equivalent symbols (fixes #1151) r=matklad a=jrvidal I couldn't find a nice, functional way of calculating the ranges in one pass so I resorted to a plain old `for` loop. Co-authored-by: Roberto Vidal <[email protected]>
| * CR correctionsRoberto Vidal2019-04-231-2/+2
| |
| * Allows searching for case-equivalent symbols (fixes #1151)Roberto Vidal2019-04-231-18/+70
| |
* | Merge #1201bors[bot]2019-04-237-3/+110
|\ \ | |/ |/| | | | | | | | | | | 1201: Goto Type Definition for ADTs r=matklad a=kjeremy Very basic go to type definition Co-authored-by: kjeremy <[email protected]>
| * Add to featureskjeremy2019-04-231-0/+12
| |
| * Simplifykjeremy2019-04-231-5/+3
| |
| * Add to LSP featureskjeremy2019-04-231-1/+1
| |
| * Basic resolution for ADTkjeremy2019-04-235-2/+99
|/
* Merge #1147bors[bot]2019-04-236-15/+133
|\ | | | | | | | | | | | | | | 1147: Handle macros in type checking / HIR r=matklad a=Lapz An other attempt at #1102. I will need to flatten the nested if statements and im also not sure if the way that i get the resolver and module will always work Co-authored-by: Lenard Pratt <[email protected]>
| * Introduced resolve_macro_call on resolverLenard Pratt2019-04-236-58/+113
| | | | | | | | | | | | changed to manual expansion fix for nested macros
| * Added macro resolution and expansionLenard Pratt2019-04-228-107/+138
| |
| * Addeded resolver and dbLenard Pratt2019-04-222-60/+92
| |
* | Merge #1197bors[bot]2019-04-234-3/+47
|\ \ | |/ |/| | | | | | | | | | | 1197: Add `...` parsing for fn pointer type r=matklad a=edwin0cheng This PR should fix #1188 Co-authored-by: Edwin Cheng <[email protected]>
| * Add `...` parsing for fn pointer typeEdwin Cheng2019-04-234-3/+47
|/
* Merge #1195bors[bot]2019-04-221-4/+20
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1195: Add cached for SubtreeSource r=matklad a=edwin0cheng I just did some simple profiling, the most slowest part of the mbe related code is the tree traversal, so i add a very simple cache in here is the result: ``` target\release\ra_cli analysis-stats``` *Before ``` Database loaded, 21 roots, 1.2731481s Crates in this dir: 26 Total modules found: 282 Total declarations: 4783 Total functions: 3126 Total expressions: 59452 Expressions of unknown type: 8999 (15%) Expressions of partially unknown type: 2672 (4%) Analysis: 17.9596334s ``` ``` *After Database loaded, 21 roots, 1.7425901s Crates in this dir: 26 Total modules found: 282 Total declarations: 4783 Total functions: 3126 Total expressions: 59452 Expressions of unknown type: 8999 (15%) Expressions of partially unknown type: 2672 (4%) Analysis: 13.4007118s ``` Save 4 seconds :) Co-authored-by: Edwin Cheng <[email protected]>
| * Add cached for SubtreeSourceEdwin Cheng2019-04-221-4/+20
|/
* Merge #1194bors[bot]2019-04-227-77/+271
|\ | | | | | | | | | | | | | | | | 1194: Pr 1190 r=matklad a=matklad Co-authored-by: Andrea Pretto <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
| * unused importAleksey Kladov2019-04-221-2/+0
| |
| * remove path_ident from CompletionContextAleksey Kladov2019-04-222-39/+38
| | | | | | | | | | | | | | | | | | We really shouldn't be looking at the identifier at point. Instead, all filtering and sorting should be implemented at the layer above. This layer should probably be home for auto-import completions as well, but, since that is not yet implemented, let's just stick this into complete_scope.
| * move auto-imoprter into IDEAleksey Kladov2019-04-227-92/+68
| | | | | | | | | | auto-import is purely an IDE concern, so it should be done outside of HIR
| * complete_import: prevent panic when the anchor is the completion source rangeAndrea Pretto2019-04-213-16/+18
| | | | | | | | | | | | (fix rebase mess) Please enter the commit message for your changes. Lines starting
| * complete_import: add new import resolver infrastructure with some hardcoded ↵Andrea Pretto2019-04-216-11/+155
| | | | | | | | | | | | importable name. Changes complete_scope to support that.
| * auto_import: better no anchor managementAndrea Pretto2019-04-211-7/+48
| |
| * auto_import: make auto import working with target as a list of SmolStr ↵Andrea Pretto2019-04-212-63/+69
| | | | | | | | instead of ast::Path
| * auto_import: use TextEditBuilder instead of AssistBuilder to make it more ↵Andrea Pretto2019-04-212-8/+36
| | | | | | | | reusable
* | Merge #1193bors[bot]2019-04-221-3/+98
|\ \ | | | | | | | | | | | | | | | | | | | | | 1193: Add a test for #1178 case r=edwin0cheng a=edwin0cheng A little PR to add a test case for #1178 Co-authored-by: Edwin Cheng <[email protected]>
| * | Remove unused print outEdwin Cheng2019-04-221-67/+63
| | |
| * | Add a test for #1178 caseEdwin Cheng2019-04-221-3/+102
| | |
* | | Merge #1184bors[bot]2019-04-2213-196/+569
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1184: Start structured editing API r=matklad a=matklad I think I finally understand how to provide nice, mutable structured editing API on top of red-green trees. The problem I am trying to solve is that any modification to a particular `SyntaxNode` returns an independent new file. So, if you are editing a struct literal, and add a field, you get back a SourceFile, and you have to find the struct literal inside it yourself! This happens because our trees are immutable, but have parent pointers. The main idea here is to introduce `AstEditor<T>` type, which abstracts away that API. So, you create an `AstEditor` for node you want to edit and call various `&mut` taking methods on it. Internally, `AstEditor` stores both the original node and the current node. All edits are applied to the current node, which is replaced by the corresponding node in the new file. In the end, `AstEditor` computes a text edit between old and new nodes. Note that this also should sole a problem when you create an anchor pointing to a subnode and mutate the parent node, invalidating anchor. Because mutation needs `&mut`, all anchors must be killed before modification. Co-authored-by: Aleksey Kladov <[email protected]>
| * | drop useless testAleksey Kladov2019-04-221-28/+0
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-06 00:43:03 +0100